specrails-desktop 2.42.1 → 2.42.2

package/docs/platforms/windows-parity.md

@@ -26,7 +26,7 @@ This audit covers the `codex/multi-repo-projects` branch, including mission stee
 
 ## Automated gates
 
-`.github/workflows/windows-parity.yml` runs a `windows-parity` job on `windows-latest` (x64) for every push and pull request, and adds `windows-11-arm` on pushes to `main`. It installs dependencies, checks TypeScript, runs release/PTY helper regression tests, native filesystem/process tests (retried once, they drive real processes), the application build, native host build/tests, and four real native fixtures: WebView2 capture/selection, authentication popups, mission window handoff, and browser multiwindow transfer/parking. It is deliberately a separate workflow from `ci.yml`: `release.yml` waits for CI only, so a slow or flaky Windows run never delays the release PR, while Desktop Release still builds and installs on Windows before publication. The jsdom client suite is not repeated on Windows; it runs on Linux in CI. The bundled-core matrix in `ci.yml` exercises Windows junction/copy relocation for providers.
+`.github/workflows/windows-parity.yml` runs a `windows-parity` job on `windows-latest` (x64) for every pull request and push to `main`, adding `windows-11-arm` on the `main` pushes. It installs dependencies, checks TypeScript, runs release/PTY helper regression tests, native filesystem/process tests (retried once, they drive real processes), the application build, native host build/tests, and four real native fixtures: WebView2 capture/selection, authentication popups, mission window handoff, and browser multiwindow transfer/parking. It is deliberately a separate workflow from `ci.yml`: `release.yml` waits for CI only, so a slow or flaky Windows run never delays the release PR, while Desktop Release still builds and installs on Windows before publication. The jsdom client suite is not repeated on Windows; it runs on Linux in CI. The bundled-core matrix in `ci.yml` exercises Windows junction/copy relocation for providers.
 
 `.github/workflows/desktop-release.yml` builds the real installers and runs `scripts/smoke-windows-installers.ps1` before publishing artifacts. For each NSIS and MSI package, the script installs into a temporary path containing spaces and drives `scripts/smoke-installed-windows.mjs` with the installed Node runtime. The driver uses an isolated user profile and tests:
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "specrails-desktop",
-  "version": "2.42.1",
+  "version": "2.42.2",
   "license": "MIT",
   "repository": {
     "type": "git",

package/server/dist/code-explorer-router.js

@@ -139,7 +139,7 @@ async function gitIgnoredSet(projectPath, relPaths, maxDurationMs = Number.POSIT
             let stdout = '';
             let settled = false;
             let overflow = false;
-            const child = (0, child_process_1.spawn)('git', ['check-ignore', '--stdin', '-z'], { cwd: projectPath, stdio: ['pipe', 'pipe', 'ignore'], env: file_provenance_1.GIT_EXEC_ENV });
+            const child = (0, child_process_1.spawn)('git', ['check-ignore', '--stdin', '-z'], { cwd: projectPath, stdio: ['pipe', 'pipe', 'ignore'], env: (0, file_provenance_1.gitExecEnv)() });
             const finish = (complete) => { if (!settled) {
                 settled = true;
                 resolve({ stdout, complete: complete && !overflow });

package/server/dist/file-provenance.js

@@ -3,7 +3,8 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.STORY_EXCERPT_MAX_BYTES = exports.GIT_EXEC_ENV = void 0;
+exports.STORY_EXCERPT_MAX_BYTES = void 0;
+exports.gitExecEnv = gitExecEnv;
 exports.resolveHeadSha = resolveHeadSha;
 exports.listUntracked = listUntracked;
 exports.snapshotWorkingTree = snapshotWorkingTree;
@@ -34,9 +35,13 @@ const GIT_MAX_BUFFER = 16 * 1024 * 1024;
 // the on-demand diff patches beyond this cap are skipped (the UI shows "diff
 // unavailable" for them). Mirrors the existing large-job warn threshold (50).
 const MAX_PATCH_FILES = 50;
-// Exported: project-git.ts (the Agent-Mode git bar) runs the same cwd-scoped
-// git calls and needs the identical hostile-repo hardening.
-exports.GIT_EXEC_ENV = (() => {
+// Exported: project-git.ts (the Agent-Mode git bar), the code explorer and the
+// git diagnostics run the same cwd-scoped git calls and need the identical
+// hostile-repo hardening. Computed PER CALL, never at module load: the startup
+// path resolver prepends the bundled git directory to process.env.PATH after
+// this module was imported, and a snapshot taken earlier could not find git in
+// a packaged app without a system git — every guard then failed closed.
+function gitExecEnv() {
     // Inherit the parent env but STRIP git-location vars. If the app process (or a
     // parent) ever exports GIT_DIR / GIT_WORK_TREE / GIT_INDEX_FILE, every cwd-scoped
     // git call below would silently operate on that repo instead of the project —
@@ -61,7 +66,7 @@ exports.GIT_EXEC_ENV = (() => {
     env.GIT_CONFIG_NOSYSTEM = '1';
     env.GIT_CONFIG_PARAMETERS = "'core.fsmonitor=false' 'core.hooksPath=/dev/null' 'protocol.ext.allow=user'";
     return env;
-})();
+}
 /** Resolve the current HEAD commit SHA. Best-effort: '' on any git failure
  *  (no repo, unborn HEAD, no git, timeout). */
 function resolveHeadSha(cwd) {
@@ -72,7 +77,7 @@ function resolveHeadSha(cwd) {
             stdio: ['ignore', 'pipe', 'pipe'],
             timeout: GIT_TIMEOUT_MS,
             maxBuffer: GIT_MAX_BUFFER,
-            env: exports.GIT_EXEC_ENV,
+            env: gitExecEnv(),
         });
         return out.trim();
     }
@@ -90,7 +95,7 @@ function listUntracked(cwd) {
             stdio: ['ignore', 'pipe', 'pipe'],
             timeout: GIT_TIMEOUT_MS,
             maxBuffer: GIT_MAX_BUFFER,
-            env: exports.GIT_EXEC_ENV,
+            env: gitExecEnv(),
         });
         return out.split('\0').filter((p) => p.length > 0);
     }
@@ -107,7 +112,7 @@ function snapshotWorkingTree(cwd) {
             stdio: ['ignore', 'pipe', 'pipe'],
             timeout: GIT_TIMEOUT_MS,
             maxBuffer: GIT_MAX_BUFFER,
-            env: exports.GIT_EXEC_ENV,
+            env: gitExecEnv(),
         });
         ref = out.trim();
     }
@@ -141,7 +146,7 @@ function diffAgainstSnapshot(cwd, snapshotRef, untrackedBefore, baseSha) {
             stdio: ['ignore', 'pipe', 'pipe'],
             timeout: GIT_TIMEOUT_MS,
             maxBuffer: GIT_MAX_BUFFER,
-            env: exports.GIT_EXEC_ENV,
+            env: gitExecEnv(),
         });
     }
     catch {
@@ -309,7 +314,7 @@ function collectDiffPatches(cwd, snapshotRef, diff, baseSha) {
                 stdio: ['ignore', 'pipe', 'pipe'],
                 maxBuffer: MAX_PATCH_BYTES + 64 * 1024,
                 timeout: GIT_TIMEOUT_MS,
-                env: exports.GIT_EXEC_ENV,
+                env: gitExecEnv(),
             });
         }
         catch (err) {

package/server/dist/git-diagnostics.js

@@ -17,7 +17,7 @@ const win_spawn_1 = require("./util/win-spawn");
  * SAFETY: the command list is a FIXED ALLOWLIST — the caller only picks an
  * action name, never arguments, so no flag/ref/path can be smuggled in. Every
  * command is read-only (no push/commit/checkout/pr-create). git runs with the
- * hardened `GIT_EXEC_ENV` (hostile-repo config stripped, prompts disabled); gh
+ * hardened `gitExecEnv()` (hostile-repo config stripped, prompts disabled); gh
  * runs with the normal env so it finds the user's `~/.config/gh` auth and the
  * bundled `gh` on PATH.
  */
@@ -43,7 +43,7 @@ const OUTPUT_CAP = 8_000;
 const defaultExec = (cmd, args, cwd) => new Promise((resolve) => {
     // git: hardened, cwd-pinned env. gh: user env (needs ~/.config/gh auth) with
     // the Windows shell-critical vars guaranteed present.
-    const env = cmd === 'gh' ? (0, win_spawn_1.windowsSpawnEnv)() : file_provenance_1.GIT_EXEC_ENV;
+    const env = cmd === 'gh' ? (0, win_spawn_1.windowsSpawnEnv)() : (0, file_provenance_1.gitExecEnv)();
     (0, child_process_1.execFile)(cmd, args, { cwd, env, timeout: 15_000, maxBuffer: 8 * 1024 * 1024, windowsHide: true }, (err, stdout, stderr) => {
         const code = err && typeof err.code === 'number'
             ? err.code

package/server/dist/pr-publisher.js

@@ -35,7 +35,7 @@ function createBoundedExec(timeoutMs = exports.PR_COMMAND_TIMEOUT_MS) {
                 // `windowsSpawnEnv()` backfills SystemRoot / ComSpec / USERPROFILE, which a
                 // GUI-launched / pkg-stripped Windows sidecar can lack — without them the
                 // `git`/`gh` child (and the `sh -c` the `!gh …` credential helper runs) can
-                // fail to start. NOT `GIT_EXEC_ENV`: that hardened env disables credentials
+                // fail to start. NOT `gitExecEnv()`: that hardened env disables credentials
                 // (GIT_ASKPASS=echo / GIT_TERMINAL_PROMPT=0), which the push must keep. No-op
                 // on POSIX (returns process.env), so mac/Linux behaviour is byte-identical.
                 const env = (0, win_spawn_1.windowsSpawnEnv)();

package/server/dist/project-git.js

@@ -21,7 +21,7 @@ const GIT_MAX_BUFFER = 4 * 1024 * 1024;
 const COMMIT_SHA_RE = /^[0-9a-f]{40,64}$/i;
 function git(repoDir, args) {
     return new Promise((resolve, reject) => {
-        (0, child_process_1.execFile)('git', args, { cwd: repoDir, env: file_provenance_1.GIT_EXEC_ENV, timeout: GIT_TIMEOUT_MS, maxBuffer: GIT_MAX_BUFFER, windowsHide: true }, (err, stdout, stderr) => {
+        (0, child_process_1.execFile)('git', args, { cwd: repoDir, env: (0, file_provenance_1.gitExecEnv)(), timeout: GIT_TIMEOUT_MS, maxBuffer: GIT_MAX_BUFFER, windowsHide: true }, (err, stdout, stderr) => {
             if (err) {
                 const detail = String(stderr || err.message).trim();
                 reject(new Error(detail));

package/server/dist/setup-manager.js

@@ -772,7 +772,13 @@ class SetupManager {
             providers: list,
             continueOnError: true,
             onProviderStart: (p) => emit(p, 'running'),
-            onProviderResult: (r) => emit(r.provider, r.ok ? 'done' : 'failed', r.error),
+            onProviderResult: (r) => {
+                // The WS event carries the reason to the app; the server log must too,
+                // or a packaged-app failure (installer smoke, support bundle) is blind.
+                if (!r.ok)
+                    console.warn(`[SetupManager] silent assemble: ${r.provider} failed for ${projectId}: ${r.error ?? 'unknown error'}`);
+                emit(r.provider, r.ok ? 'done' : 'failed', r.error);
+            },
         })
             .then((results) => {
             const failed = results.filter((r) => !r.ok).map((r) => r.provider);

package/server/dist/terminal-manager.js

@@ -4,6 +4,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.TerminalManager = exports.TERMINAL_EARLY_EXIT_MS = exports.TerminalSpawnError = exports.TerminalNameInvalidError = exports.TerminalNotFoundError = exports.TerminalLimitExceededError = exports.RingBuffer = exports.TERMINAL_DEFAULT_ROWS = exports.TERMINAL_DEFAULT_COLS = exports.TERMINAL_NAME_MAX = exports.TERMINAL_MAX_PER_PROJECT = exports.TERMINAL_KILL_GRACE_MS = exports.TERMINAL_SCROLLBACK_BYTES = void 0;
+exports.killTerminalTree = killTerminalTree;
 exports.resolveShell = resolveShell;
 exports.resolveShellFor = resolveShellFor;
 exports.shellArgs = shellArgs;
@@ -20,6 +21,21 @@ const terminal_marks_store_1 = require("./terminal-marks-store");
 const terminal_shell_integration_1 = require("./terminal-shell-integration");
 exports.TERMINAL_SCROLLBACK_BYTES = 262_144;
 exports.TERMINAL_KILL_GRACE_MS = 2_000;
+/**
+ * Windows: node-pty ends a ConPTY session by enumerating the pseudo console's
+ * processes through a helper it starts with `process.execPath`. In the
+ * packaged sidecar that path is the sidecar binary itself, so the helper never
+ * runs, only the shell is terminated and whatever the shell started (a dev
+ * server, a watcher) survives the closed terminal. Kill the shell's process
+ * tree ourselves (`taskkill /T /F` through tree-kill). No-op elsewhere: the
+ * POSIX pty closes its process group.
+ */
+function killTerminalTree(pid, platform = process.platform, kill = win_spawn_1.treeKillSafe) {
+    if (platform !== 'win32' || !pid || !Number.isInteger(pid) || pid <= 0)
+        return false;
+    kill(pid, 'SIGKILL');
+    return true;
+}
 exports.TERMINAL_MAX_PER_PROJECT = 10;
 exports.TERMINAL_NAME_MAX = 64;
 exports.TERMINAL_DEFAULT_COLS = 80;
@@ -455,6 +471,7 @@ class TerminalManager {
     async shutdown() {
         const all = Array.from(this.sessions.values());
         for (const s of all) {
+            killTerminalTree(s.pty.pid);
             try {
                 s.pty.kill('SIGTERM');
             }
@@ -462,6 +479,7 @@ class TerminalManager {
         }
         await new Promise((r) => setTimeout(r, exports.TERMINAL_KILL_GRACE_MS));
         for (const s of Array.from(this.sessions.values())) {
+            killTerminalTree(s.pty.pid);
             try {
                 s.pty.kill('SIGKILL');
             }
@@ -540,12 +558,14 @@ class TerminalManager {
             return;
         this.detachFromRegistry(s);
         if (!s.exited) {
+            killTerminalTree(s.pty.pid);
             try {
                 s.pty.kill('SIGTERM');
             }
             catch { /* ignore */ }
             s.killTimer = setTimeout(() => {
                 if (!s.exited) {
+                    killTerminalTree(s.pty.pid);
                     try {
                         s.pty.kill('SIGKILL');
                     }