npm - specrails-desktop - Versions diffs - 2.30.0 → 2.30.2 - Mend

specrails-desktop 2.30.0 → 2.30.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (30) hide show

package/client/dist/index.html CHANGED Viewed

@@ -204,7 +204,7 @@
         .specrails-splash__mark .pill { opacity: 1; }
       }
     </style>
-    <script type="module" crossorigin src="/assets/index-xkzK3E5i.js"></script>
+    <script type="module" crossorigin src="/assets/index-F9r8mWP_.js"></script>
     <link rel="modulepreload" crossorigin href="/assets/rolldown-runtime-CNC7AqOf.js">
     <link rel="modulepreload" crossorigin href="/assets/jsx-runtime-zu2_FqZY.js">
     <link rel="modulepreload" crossorigin href="/assets/react-dom-DiWzBDP9.js">
@@ -276,7 +276,7 @@
     <link rel="modulepreload" crossorigin href="/assets/getTimezoneOffsetInMilliseconds-qrcBaLW1.js">
     <link rel="modulepreload" crossorigin href="/assets/formatDistanceToNow-ByKli7Q_.js">
     <link rel="modulepreload" crossorigin href="/assets/spending-DMnCXy84.js">
-    <link rel="modulepreload" crossorigin href="/assets/TicketDetailModal-7EloKP1C.js">
+    <link rel="modulepreload" crossorigin href="/assets/TicketDetailModal-CI47Dq9E.js">
     <link rel="stylesheet" crossorigin href="/assets/index-Dh9i4CnN.css">
   </head>
   <body>

package/docs/internals/interactive-jobs.md CHANGED Viewed

@@ -61,7 +61,7 @@ spawnInteractive = isInteractiveJobsEnabled()            // SPECRAILS_INTERACTIV
 | | `'finalize'` | `'auto'` |
 |---|---|---|
 | Who gets it | freestyle/Freestyle QueueManager jobs (claude) | every other interactive job + ALL loop ai-steps |
-| End of session | explicit human **Finalize** only (SIGTERM → 2s → SIGKILL) | **quiescence**: a turn `result` arrived, nothing queued, no write in flight |
+| End of session | explicit human **Finalize** only (SIGTERM → 2s → SIGKILL) | **quiescence**: a turn `result` arrived, nothing queued, no write in flight — torn down GRACEFULLY: stdin EOF (the CLI exits itself, flushing its session transcript so the next loop step can `--resume`), SIGTERM only after a grace window (`quiescentEofGraceMs`, default 5s) or when stdin is already gone |
 | Idle between turns | by design (awaiting the human) | only transiently (microtask window) |
 | Wedge detector | never armed | the queue's zombie-timeout budget, reset on any raw child output; silence for the whole budget → fold in-flight turn, settle `crashed` |
 | Composer action | **Finalize Job** | **Wrap up now** (QueueManager) / **Settle this step** (loop step) |

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "specrails-desktop",
-  "version": "2.30.0",
+  "version": "2.30.2",
   "license": "MIT",
   "repository": {
     "type": "git",

package/server/dist/core-update-manager.js CHANGED Viewed

@@ -136,9 +136,16 @@ class CoreUpdateManager {
             if (mat.errors.length > 0) {
                 throw new Error(`framework materialize failed: ${mat.errors.map((e) => `${e.provider}: ${e.message}`).join('; ')}`);
             }
-            const swapped = fm.swapCurrent(installed);
-            if (!swapped) {
-                throw new Error('framework swap-current failed');
+            // A materialize that reports no errors but ALSO no materialized providers
+            // wrote nothing — swapping `current` at a nonexistent version dir would
+            // fail downstream with a misleading "swap-current failed". Surface the
+            // real condition instead (mirrors FrameworkManager.versionCheck's guard).
+            if (mat.providers.length === 0) {
+                throw new Error(`framework materialize completed without materializing any provider (requested: ${providers.join(', ') || 'none'})`);
+            }
+            const swapped = fm.swapCurrentDetailed(installed);
+            if (!swapped.ok) {
+                throw new Error(`framework swap-current failed${swapped.detail ? `: ${swapped.detail}` : ''}`);
             }
             this.latestVersion = installed;
             this.lastCheckedAt = Date.now();

package/server/dist/framework-manager.js CHANGED Viewed

@@ -204,16 +204,30 @@ class FrameworkManager {
      * `swap-current` only moves the version pointer (provider-invariant).
      */
     swapCurrent(version, _provider = 'claude') {
+        return this.swapCurrentDetailed(version).ok;
+    }
+    /**
+     * Like `swapCurrent`, but on failure carries WHY it failed (`detail`) — the
+     * subprocess stderr/exit or the missing-CLI/verify-mismatch case — so callers
+     * (the core update channel) can surface an actionable error instead of the
+     * bare "swap-current failed".
+     */
+    swapCurrentDetailed(version) {
         const cli = this.resolveCli();
         if (!cli)
-            return false;
+            return { ok: false, detail: 'no usable core CLI to run swap-current with' };
         if (readCurrentFrameworkVersion(this.home) === version)
-            return true;
+            return { ok: true, detail: null };
         const fwDir = frameworkRoot(this.home);
         const res = (0, child_process_1.spawnSync)(nodeInterpreter(), [cli, 'swap-current', '--framework-dir', fwDir, '--version', version], { env: this.childEnv(), encoding: 'utf-8', timeout: 120_000 });
-        if (res.error || (res.status ?? 1) !== 0)
-            return false;
-        return readCurrentFrameworkVersion(this.home) === version;
+        if (res.error || (res.status ?? 1) !== 0) {
+            const detail = (res.error?.message ?? `${res.stderr || res.stdout || ''}`.trim()) || `exit ${res.status ?? 'unknown'}`;
+            return { ok: false, detail };
+        }
+        if (readCurrentFrameworkVersion(this.home) !== version) {
+            return { ok: false, detail: `swap-current exited 0 but current still resolves to ${readCurrentFrameworkVersion(this.home) ?? 'nothing'}` };
+        }
+        return { ok: true, detail: null };
     }
     /**
      * Compare the bundled core version with `framework/current`. When they differ
@@ -266,8 +280,8 @@ class FrameworkManager {
             // No errors yet nothing materialized (empty/duplicate-only provider list).
             return { swapped: false, version: current };
         }
-        const ok = this.swapCurrent(bundled);
-        if (ok) {
+        const swap = this.swapCurrentDetailed(bundled);
+        if (swap.ok) {
             try {
                 this.broadcast?.({ type: 'framework.updated', version: bundled });
             }
@@ -281,7 +295,7 @@ class FrameworkManager {
             this.broadcast?.({
                 type: 'framework.update_failed',
                 version: bundled,
-                errors: [{ provider: providers[0] ?? 'claude', message: 'swap-current failed' }],
+                errors: [{ provider: providers[0] ?? 'claude', message: `swap-current failed${swap.detail ? `: ${swap.detail}` : ''}` }],
             });
         }
         catch {

package/server/dist/interactive-job-session.js CHANGED Viewed

@@ -119,6 +119,10 @@ class InteractiveJobSession {
     _onSettle;
     _settleMode;
     _zombieTimeoutMs;
+    _quiescentEofGraceMs;
+    /** Armed by the quiescent graceful teardown: SIGTERM escalation if the child
+     *  ignores the stdin EOF. Cleared on close/settle/dispose. */
+    _eofTimer = null;
     _nextEventSeq;
     _persistTurnUsage;
     _persistTurnActivity;
@@ -194,6 +198,7 @@ class InteractiveJobSession {
         this._onSettle = deps.onSettle;
         this._settleMode = deps.settleMode ?? 'finalize';
         this._zombieTimeoutMs = deps.zombieTimeoutMs ?? 0;
+        this._quiescentEofGraceMs = deps.quiescentEofGraceMs ?? 5000;
         this._nextEventSeq = deps.nextEventSeq ?? null;
         this._persistTurnUsage = deps.persistTurnUsage ?? null;
         this._persistTurnActivity = deps.persistTurnActivity ?? null;
@@ -229,6 +234,7 @@ class InteractiveJobSession {
         child.on('close', (code) => {
             this._childClosed = true;
             this._clearKillTimer();
+            this._clearEofTimer();
             this._handleClose(code);
         });
         // A buffered write can fail asynchronously (typically EPIPE after the child
@@ -320,6 +326,39 @@ class InteractiveJobSession {
         this._clearZombieTimer();
         this._terminateChildTree('finalized');
     }
+    /** Quiescent auto-settle teardown, GRACEFUL: EOF the child's stdin so the
+     *  stream-json CLI exits by itself — it flushes its session transcript on the
+     *  way out, keeping the session `--resume`-able by the NEXT loop step. The
+     *  previous immediate SIGTERM raced that flush: the next step's resume found
+     *  no conversation, got an instant empty synthetic result, and settled
+     *  zero-work in 0.0s. SIGTERM remains as escalation after the grace window,
+     *  and as the direct fallback when stdin is already gone. */
+    _finalizeQuiescent() {
+        if (this._finalizing || this._settled)
+            return;
+        this._finalizing = true;
+        this._clearZombieTimer();
+        const child = this._child;
+        const stdin = child?.stdin;
+        if (!child || this._childClosed || !stdin || stdin.destroyed || this._stdinFailed) {
+            this._terminateChildTree('finalized');
+            return;
+        }
+        try {
+            stdin.end();
+        }
+        catch {
+            this._terminateChildTree('finalized');
+            return;
+        }
+        this._eofTimer = setTimeout(() => {
+            this._eofTimer = null;
+            if (this._childClosed || this._settled || this._disposed)
+                return;
+            this._terminateChildTree('finalized');
+        }, this._quiescentEofGraceMs);
+        this._eofTimer.unref?.();
+    }
     /** Programmatic teardown that SETTLES 'crashed' after folding any in-flight
      *  turn (loop step timeout / run cancel). Unlike dispose(), the onSettle
      *  callback fires — an owner AWAITING the settle (the loop engine) is
@@ -342,6 +381,7 @@ class InteractiveJobSession {
             return;
         this._disposed = true;
         this._clearZombieTimer();
+        this._clearEofTimer();
         this._closeReaders();
         this._terminateChildTree(null);
         this._child = null;
@@ -603,7 +643,7 @@ class InteractiveJobSession {
                     return;
                 if (this._streaming || this._pending.length > 0)
                     return;
-                this.finalize();
+                this._finalizeQuiescent();
             });
         }
     }
@@ -785,6 +825,7 @@ class InteractiveJobSession {
         this._streaming = false;
         this._awaitingResult = false;
         this._clearKillTimer();
+        this._clearEofTimer();
         this._clearZombieTimer();
         this._closeReaders();
         // The child is gone — any prompts still queued (turn died without a `result`,
@@ -888,6 +929,12 @@ class InteractiveJobSession {
             this._killTimer = null;
         }
     }
+    _clearEofTimer() {
+        if (this._eofTimer !== null) {
+            clearTimeout(this._eofTimer);
+            this._eofTimer = null;
+        }
+    }
     _closeReaders() {
         try {
             this._stdoutReader?.close();