specrails-core 1.6.0 → 1.7.0

package/templates/commands/sr/refactor-recommender.md

@@ -1,11 +1,11 @@
 ---
 name: "Refactor Recommender"
-description: "Scan the codebase for refactoring opportunities ranked by impact/effort ratio. Analyzes code for duplicates, long functions, large files, dead code, outdated patterns, and complex logic. Optionally creates GitHub Issues for tracking."
+description: "Scan the codebase for refactoring opportunities ranked by impact/effort ratio and VPC persona value. Analyzes code for duplicates, long functions, large files, dead code, outdated patterns, and complex logic. Optionally creates GitHub Issues for tracking."
 category: Workflow
-tags: [workflow, refactoring, code-quality, tech-debt]
+tags: [workflow, refactoring, code-quality, tech-debt, vpc]
 ---
 
-Scan the codebase for refactoring opportunities, score each by impact/effort ratio, and optionally create GitHub Issues for the top findings in {{BACKLOG_PROVIDER_NAME}}.
+Scan the codebase for refactoring opportunities, score each by impact/effort ratio and VPC persona value, and optionally create GitHub Issues for the top findings in {{BACKLOG_PROVIDER_NAME}}.
 
 **Input:** `$ARGUMENTS` — optional: comma-separated paths to scope the analysis. Flags: `--dry-run` (print findings without creating issues).
 
@@ -38,6 +38,27 @@ Always exclude the following from all analysis:
 
 ---
 
+## Phase 1.5: VPC Context
+
+Check whether persona files exist at `.claude/agents/personas/`. This path is present in any repo that has run `/setup`.
+
+```bash
+ls .claude/agents/personas/ 2>/dev/null
+```
+
+If the directory exists and contains persona files, set `VPC_AVAILABLE=true`. Otherwise set `VPC_AVAILABLE=false` and skip all VPC steps (they are optional enrichment, not blockers).
+
+When `VPC_AVAILABLE=true`, read each persona file and extract a compact VPC summary. For each persona record:
+
+- **name** — persona display name (e.g. "Alex — The Lead Dev")
+- **top_jobs** — up to 3 functional jobs relevant to code quality and maintainability
+- **critical_pains** — up to 3 pains marked Critical or High related to code reliability, complexity, or developer experience
+- **high_gains** — up to 3 gains marked High related to code clarity, speed, or confidence
+
+Store these as an in-memory `VPC_PROFILES` list. You will use it in Phase 3 to score persona fit.
+
+---
+
 ## Phase 2: Analysis
 
 Analyze the scoped files across six categories. For each finding record:
@@ -76,12 +97,24 @@ Find deeply nested conditionals (more than 3 levels) and functions with high cyc
 
 ## Phase 3: Score and Rank
 
-Score every finding on two dimensions (1–5 each):
+Score every finding on three dimensions (1–5 each):
 
 - **Impact** — how much the refactoring improves code quality, readability, or maintainability
 - **Effort** — how hard the refactoring is to implement (1 = trivial, 5 = major)
+- **VPC Value** — how directly this refactoring addresses persona jobs, pains, or gains (1 = no relevance, 5 = resolves a critical persona pain or delivers a high-value gain). Set to 3 when `VPC_AVAILABLE=false`.
+
+**Scoring VPC Value** (only when `VPC_AVAILABLE=true`):
+
+For each finding, reason over `VPC_PROFILES`:
 
-Compute a **composite score**: `impact * 2 + (6 - effort)`. Higher is better.
+- Does fixing this reduce a **Critical/High pain** for any persona? (e.g. complex logic → harder to trust AI output → Alex's "agents go off the rails" pain) → score 4–5
+- Does fixing this deliver a **High gain** for any persona? (e.g. extracting a function → cleaner API surface → easier onboarding → Sara's gain) → score 3–4
+- Is there indirect persona value? (e.g. dead code removal → smaller codebase → easier contributor review → Kai) → score 2–3
+- No clear persona relevance → score 1–2
+
+Assign one `vpc_value` integer per finding, and note the **primary persona** and **rationale** (one sentence).
+
+**Composite score**: `impact * 2 + (6 - effort) + vpc_value`. Higher is better.
 
 Sort all findings by composite score descending. If the same code block was flagged by multiple categories, keep only the highest-scored entry and discard the duplicates.
 
@@ -91,7 +124,7 @@ Sort all findings by composite score descending. If the same code block was flag
 
 Skip this phase if `GH_AVAILABLE=false` or `DRY_RUN=true`.
 
-First ensure the tracking label exists:
+First ensure the tracking labels exist:
 
 ```bash
 gh label create "refactor-opportunity" --color "B60205" --force
@@ -111,6 +144,7 @@ For each of the **top 5** findings (by composite score) that does not already ha
 **Category**: {category}
 **File**: {file}:{line_range}
 **Impact**: {impact}/5 | **Effort**: {effort}/5 | **Score**: {composite}
+{vpc_line}
 
 ### Current Code
 ```{lang}
@@ -129,6 +163,9 @@ For each of the **top 5** findings (by composite score) that does not already ha
 _Generated by `/sr:refactor-recommender` in {{PROJECT_NAME}}_
 ```
 
+Where `{vpc_line}` is included only when `VPC_AVAILABLE=true`:
+`**VPC Value**: {vpc_value}/5 — {vpc_persona}: {vpc_rationale}`
+
 ---
 
 ## Phase 5: Output Summary
@@ -139,10 +176,11 @@ Print the following report:
 ## Refactoring Opportunities — {{PROJECT_NAME}}
 
 {N} opportunities found | Sorted by composite score
+{vpc_header}
 
-| # | Category | File | Impact | Effort | Score | Description |
-|---|----------|------|--------|--------|-------|-------------|
-| 1 | {category} | {file}:{line_range} | {impact}/5 | {effort}/5 | {composite} | {description} |
+| # | Category | File | Impact | Effort | VPC | Score | Description |
+|---|----------|------|--------|--------|-----|-------|-------------|
+| 1 | {category} | {file}:{line_range} | {impact}/5 | {effort}/5 | {vpc_value}/5 | {composite} | {description} |
 ...
 
 ### Top 3 Detailed Recommendations
@@ -150,6 +188,7 @@ Print the following report:
 #### 1. {description}
 **File**: {file}:{line_range}
 **Category**: {category} | **Score**: {composite}
+{vpc_detail}
 
 **Current:**
 ```{lang}
@@ -167,3 +206,7 @@ Print the following report:
 
 Issues created: {N}  (or "dry-run: no issues created")
 ```
+
+Where:
+- `{vpc_header}` is `VPC personas loaded: {persona names}` when `VPC_AVAILABLE=true`, or `VPC personas: not found (run /setup to enable)` otherwise.
+- `{vpc_detail}` is `**VPC Value**: {vpc_value}/5 — {vpc_persona}: {vpc_rationale}` when `VPC_AVAILABLE=true`, omitted otherwise.

package/templates/settings/perf-thresholds.yml

@@ -0,0 +1,25 @@
+# SpecRails Performance Regression Thresholds
+# Used by sr-performance-reviewer agent and the performance CI workflow.
+# Environment variables (PERF_*) override these values.
+
+# Execution time thresholds (percentage increase = regression)
+execution_time_regression_pct: 20   # warn above this delta
+execution_time_critical_pct: 50     # block CI above this delta
+
+# Memory usage thresholds (percentage increase = regression)
+memory_regression_pct: 15
+memory_critical_pct: 40
+
+# Throughput thresholds (percentage decrease = regression)
+throughput_regression_pct: 15
+throughput_critical_pct: 40
+
+# Branch to use as baseline when .specrails/perf-baseline.json is absent
+baseline_branch: main
+
+# File patterns to always skip (in addition to agent defaults)
+skip_patterns: []
+# example:
+#   skip_patterns:
+#     - "scripts/**"
+#     - "migrations/**"