speccrew 0.7.15 → 0.7.17

package/.speccrew/skills/speccrew-pm-requirement-clarify/workflow.agentflow.xml

@@ -14,6 +14,13 @@
   <!-- ============================================================
        Global Constraints
        ============================================================ -->
+  <block type="rule" id="R-MULTIROUND" level="mandatory" desc="Multi-round clarification is MANDATORY">
+    <field name="text">MANDATORY: Clarification MUST execute multiple rounds until ALL 4 sufficiency checks pass.</field>
+    <field name="text">DO NOT terminate after a single round. Each round generates .clarification-questions-round-{N}.md</field>
+    <field name="text">After user answers, perform sufficiency check. If any check fails, generate next round questions.</field>
+    <field name="text">Maximum 5 rounds allowed. If max reached, proceed with warning.</field>
+  </block>
+
   <block type="rule" id="R1" level="mandatory" desc="Execution constraints">
     <field name="text">Always perform at least 1 clarification round</field>
     <field name="text">Use file-based for complex mode or 4+ questions</field>
@@ -69,7 +76,14 @@
       </branch>
     </block>
 
-    <!-- Step 4: Execute Clarification -->
+    <!-- Step 4: Initialize Loop Variables -->
+    <block type="task" id="B6-init" action="set-var" desc="Initialize loop control variables">
+      <field name="sufficiency_checks_passed" value="false"/>
+      <field name="round_number" value="1"/>
+      <field name="max_rounds" value="5"/>
+    </block>
+
+    <!-- Step 5: Execute Clarification -->
     <block type="gateway" id="G2" mode="exclusive" desc="Execute clarification based on mode">
       <branch test="${complexity} == 'simple'" name="Simple Mode Clarification">
         <block type="task" id="B6" action="analyze" desc="Simple mode: 1-3 key questions">
@@ -84,19 +98,28 @@
       </branch>
       <branch test="${complexity} == 'complex'" name="Complex Mode Clarification">
         <!-- Clarification Loop -->
-        <block type="loop" id="L1" condition="sufficiency_checks_passed == false" desc="Clarification rounds until sufficiency">
-          <block type="task" id="B7" action="generate" desc="Create clarification questions file">
-            <field name="output_path" value="${iteration_path}/01.product-requirement/.clarification-questions-round-{round}.md"/>
-            <field name="sections">
-              - Business Background & Goals
-              - Target Users & Scenarios
-              - System Scope & Boundaries
+        <block type="loop" id="L1" condition="sufficiency_checks_passed == false AND round_number <= max_rounds" desc="Clarification rounds until sufficiency">
+          <!-- Load Question Template -->
+          <block type="task" id="B7-load-template" action="read-file" desc="Load clarification questions template">
+            <field name="path" value="${skill_path}/templates/CLARIFICATION-QUESTIONS-TEMPLATE.md"/>
+            <field name="output" var="questions_template"/>
+          </block>
+
+          <block type="task" id="B7" action="generate" desc="Create clarification questions file from template">
+            <field name="template" value="${questions_template}"/>
+            <field name="output_path" value="${iteration_path}/01.product-requirement/.clarification-questions-round-${round_number}.md"/>
+            <field name="vars">
+              - round_number: ${round_number}
+              - iteration_name: ${iteration_name}
+              - date: ${current_date}
+              - complexity_level: ${complexity}
+              - requirement_summary: ${requirement_summary}
             </field>
             <field name="output" var="questions_file"/>
           </block>
 
-          <block type="event" id="E1" action="confirm" title="Clarification Round {round}" type="wait" desc="Wait for user to answer questions">
-            <field name="message">Round {round} questions written. Please fill answers and notify me.</field>
+          <block type="event" id="E1" action="confirm" title="Clarification Round ${round_number}" type="wait" desc="Wait for user to answer questions">
+            <field name="message">Round ${round_number} questions written. Please fill answers and notify me.</field>
           </block>
 
           <block type="task" id="B8" action="read-file" desc="Read answered questions">
@@ -106,6 +129,7 @@
 
           <!-- Sufficiency Check -->
           <block type="task" id="B9" action="analyze" desc="Perform sufficiency check">
+            <field name="input" value="${answered_questions}"/>
             <field name="checks">
               1. Scope boundaries are clear - Explicit in/out scope defined
               2. Key business rules are documented - At least 1 rule identified
@@ -114,24 +138,46 @@
             </field>
             <field name="output" var="sufficiency_result"/>
           </block>
+
+          <!-- Update sufficiency variable based on check result -->
+          <block type="task" id="B9-update" action="set-var" desc="Update sufficiency check status">
+            <field name="sufficiency_checks_passed" value="${sufficiency_result.all_passed}"/>
+            <field name="checks_passed_count" value="${sufficiency_result.passed_count}"/>
+          </block>
+
+          <!-- Increment round number for next iteration -->
+          <block type="task" id="B9-increment" action="set-var" desc="Increment round counter">
+            <field name="round_number" value="${round_number + 1}"/>
+          </block>
         </block>
       </branch>
     </block>
 
-    <!-- Step 5: Generate .clarification-summary.md -->
-    <block type="task" id="B10" action="generate" desc="Generate clarification summary">
+    <!-- Step 6: Generate .clarification-summary.md -->
+    <block type="task" id="B10-load-template" action="read-file" desc="Load summary template">
+      <field name="path" value="${skill_path}/templates/CLARIFICATION-SUMMARY-TEMPLATE.md"/>
+      <field name="output" var="summary_template"/>
+    </block>
+
+    <block type="task" id="B10" action="generate" desc="Generate clarification summary from template">
+      <field name="template" value="${summary_template}"/>
       <field name="output_path" value="${iteration_path}/01.product-requirement/.clarification-summary.md"/>
-      <field name="sections">
-        - Complexity level and rationale
-        - Key decisions table
-        - Clarification Q&A (all rounds)
-        - Sufficiency checks results
-        - Notes
+      <field name="vars">
+        - iteration_name: ${iteration_name}
+        - total_rounds: ${round_number - 1}
+        - date: ${current_date}
+        - sufficiency_result: ${sufficiency_result.all_passed ? 'PASSED' : 'PARTIAL'}
+        - checks_passed: ${sufficiency_result.passed_count}
+        - requirement_overview: ${requirement_summary}
+        - business_complexity: ${complexity}
+        - technical_complexity: ${complexity}
+        - integration_complexity: ${complexity}
+        - overall_complexity: ${complexity}
       </field>
       <field name="output" var="summary_path"/>
     </block>
 
-    <!-- Step 6: Initialize .checkpoints.json -->
+    <!-- Step 7: Initialize .checkpoints.json -->
     <block type="task" id="B11" action="run-script" desc="Initialize checkpoints via script">
       <field name="command">node "${workspace_path}/scripts/update-progress.js" write-checkpoint --file "${iteration_path}/01.product-requirement/.checkpoints.json" --checkpoint requirement_clarification --passed true</field>
       <field name="output" var="checkpoint_result"/>

package/.speccrew/skills/speccrew-product-manager-orchestration/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: speccrew-product-manager-orchestration
-version: 1.0.0
-description: Product Manager 的核心编排技能，负责需求澄清、复杂度评估、PRD 生成协调与验证。处理简单需求（单 PRD）和复杂需求（Master-Sub PRD）两种工作流路径。
+version: 2.0.0
+description: Product Manager 核心编排技能（纯路由层 v2.0），负责工作流恢复路由和各 Phase Skill 的 dispatch-to-worker 调度。所有业务逻辑由独立的 Phase Skill 执行。
 tools: Read, Write, Glob, Grep, Bash, Agent
 ---
 
@@ -23,20 +23,82 @@ tools: Read, Write, Glob, Grep, Bash, Agent
 > - `action="dispatch-to-worker"` → Create **Task** via **Task tool** for `speccrew-task-worker`
 > - `action="read-file"` → Read via **Read tool**
 > - `action="log"` → Output message directly
-> - `action="confirm"` → Present to user and wait for response
+> - `action="user-confirm"` → Present to user and wait for EXPLICIT confirmation (NON-SKIPPABLE)
 >
-> **Step 3**: Execute ALL blocks sequentially without pausing (only stop at explicit `<event action="confirm">` blocks)
+> **CRITICAL DISPATCH RULE:**
+> - PM Agent (Team Leader) MUST NOT execute Skills directly
+> - ALL Skill executions MUST go through `dispatch-to-worker` action
+> - Worker Agent (`speccrew-task-worker`) receives the Skill name and context, then executes the Skill
+>
+> **Step 3**: Execute ALL blocks sequentially without pausing (only stop at explicit `<event action="user-confirm">` blocks)
+
+# Product Manager Orchestration (v2.0)
+
+纯路由层编排技能，负责：
+
+1. **Workflow Initialization** - Phase 0 初始化并返回恢复目标
+2. **Resume Routing** - 根据 `resume_target` 跳转到正确的 Phase
+3. **Phase Dispatch** - 每个 Phase 只有一个 `dispatch-to-worker` 调用
+4. **User Confirmation Gates** - Phase 3 和 Phase 4a 的强制性用户确认门禁
+
+## Architecture: Pure Routing Layer
+
+本 Skill 是**纯路由层**，所有业务逻辑由独立的 Phase Skill 执行：
 
-# Product Manager Orchestration
+| Phase | Block ID | Skill | Purpose |
+|-------|----------|-------|---------|
+| Phase 0 | P0 | `speccrew-pm-phase0-init` | 工作流初始化、迭代目录创建/定位、恢复状态检测 |
+| Phase 1 | P1 | `speccrew-pm-phase1-knowledge-check` | 知识库状态检测、模块匹配、知识初始化 |
+| Phase 2 | P2 | `speccrew-pm-phase2-complexity-assess` | 复杂度评估、简单/复杂路径决策 |
+| Phase 3 | P3 | `speccrew-pm-requirement-clarify` | 需求澄清、问答收集 |
+| Phase 4 Simple | P4-SIMPLE | `speccrew-pm-requirement-simple` | 简单需求：单 PRD 生成 |
+| Phase 4a | P4A | `speccrew-pm-requirement-model` | 复杂需求：ISA-95 建模 |
+| Phase 4b | P4B | `speccrew-pm-requirement-analysis` | 复杂需求：Master PRD 生成 |
+| Phase 5 | P5 | `speccrew-pm-phase5-subprd-dispatch` | Sub-PRD Worker 分发 |
+| Phase 6 | P6 | `speccrew-pm-phase6-verify-confirm` | 验证清单、用户审核、最终确认 |
 
-Product Manager 的核心编排技能，负责：
+## User Confirmation Gates (MANDATORY)
 
-1. **Pipeline Progress Management** - 创建/定位迭代目录，管理工作流进度
-2. **Knowledge Base Detection** - 检测知识库状态并按需初始化
-3. **Complexity Assessment** - 评估需求复杂度，决定简单/复杂路径
-4. **Requirement Clarification** - 调用澄清技能，收集需求细节
-5. **PRD Generation Orchestration** - 协调 PRD 生成（简单路径直接调用，复杂路径分发 Worker）
-6. **Verification & Confirmation** - 验证 PRD 完整性，等待用户确认
+Phase 3 和 Phase 4a 之后有**强制性用户确认门禁**：
+
+### R-CONFIRM Rule Block
+
+```xml
+<block type="rule" id="R-CONFIRM" level="mandatory" desc="User confirmation is MANDATORY">
+  <field name="text">MANDATORY: After each phase completes, you MUST wait for EXPLICIT user confirmation.</field>
+  <field name="text">DO NOT mark checkpoint as passed by yourself. DO NOT skip user confirmation.</field>
+  <field name="text">The checkpoint write-checkpoint command MUST ONLY be executed AFTER user confirms.</field>
+</block>
+```
+
+### user-confirm Event Block
+
+```xml
+<block type="event" id="P3-CONFIRM" action="user-confirm" desc="User confirmation required">
+  <field name="prompt">📋 Phase Complete. Please review and confirm.</field>
+  <field name="skippable" value="false"/>
+</block>
+```
+
+**Key Points:**
+- `action="user-confirm"` — 必须等待用户明确确认
+- `skippable="false"` — 不可跳过
+- checkpoint 写入**必须**在用户确认后执行
+
+## Resume Router
+
+Phase 0 输出 `resume_target` 控制恢复跳转：
+
+| resume_target | Target Block | Description |
+|---------------|--------------|-------------|
+| `PHASE_1_KNOWLEDGE_CHECK` | P1 | 从知识库检查开始 |
+| `PHASE_3_USER_CONFIRMATION` | P3-CONFIRM | 恢复到 Phase 3 确认门禁 |
+| `PHASE_4_PRD_SIMPLE` | P4-SIMPLE | 简单路径 PRD 生成 |
+| `PHASE_4A_MODEL` | P4A | 复杂路径建模 |
+| `PHASE_4A_CONFIRMATION` | P4A-CONFIRM | 恢复到 Phase 4a 确认门禁 |
+| `PHASE_4B_PRD_GENERATION` | P4B | Master PRD 生成 |
+| `PHASE_5_SUBPRD_DISPATCH` | P5 | Sub-PRD 分发 |
+| `PHASE_6_VERIFICATION` | P6 | 验证确认 |
 
 ## Invocation Method
 
@@ -88,22 +150,24 @@ This skill MUST execute tasks continuously without unnecessary interruptions.
 
 ### When to Pause (ONLY these cases)
 
-1. CHECKPOINT gates defined in workflow (user confirmation required by design)
+1. **User Confirmation Gates** — `action="user-confirm"` blocks (Phase 3, Phase 4a)
 2. Ambiguous requirements that genuinely need clarification
 3. Unrecoverable errors that prevent further progress
 4. Security-sensitive operations (e.g., deleting existing files)
 
-### Orchestrator Principle
+### Orchestrator Principle (v2.0)
 
-This agent is an **orchestrator/dispatcher**. Key constraints:
+This agent is a **pure router/dispatcher**. Key constraints:
 
 | Phase | Skill | ORCHESTRATOR Rule |
 |-------|-------|-------------------|
-| Phase 3 | `speccrew-pm-requirement-clarify` | DO NOT clarify requirements yourself — Skill handles all clarification rounds |
-| Phase 4a | `speccrew-pm-requirement-model` | DO NOT perform ISA-95 analysis or module decomposition yourself |
-| Phase 4b | `speccrew-pm-requirement-analysis` | DO NOT generate Master PRD or Dispatch Plan yourself |
-| Phase 5 | `speccrew-pm-sub-prd-generate` (via workers) | DO NOT generate Sub-PRD content yourself |
-| Phase 6 | PM Agent verification | DO NOT modify PRD content — only verify and present |
+| Phase 0 | `speccrew-pm-phase0-init` | Route to correct Phase based on resume_target |
+| Phase 1-6 | All Phase Skills | DO NOT execute logic yourself — Dispatch Worker |
+
+**UNIVERSAL DISPATCH RULE:**
+- PM Agent NEVER invokes Skills directly via `action="run-skill"`
+- ALL Skill invocations use `action="dispatch-to-worker"` with `speccrew-task-worker`
+- Worker Agent receives the Skill name in context and executes it
 
 **UNIVERSAL ABORT RULE:**
 - IF ANY skill fails → STOP and report to user