speccrew 0.6.69 → 0.7.0

package/.speccrew/skills/speccrew-dev-mobile/workflow.agentflow.xml

@@ -0,0 +1,244 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<workflow id="dev-mobile" status="pending" version="1.0" desc="Mobile Development SOP - Guide System Developer Agent to implement mobile app code">
+
+  <!-- ============================================================
+       Input Parameters Definition
+       ============================================================ -->
+  <block type="input" id="I1" desc="Workflow input parameters">
+    <field name="design_doc_path" required="true" type="string" desc="Path to single module design document"/>
+    <field name="platform_id" required="true" type="string" desc="Mobile platform identifier (mobile-uniapp, mobile-flutter, mobile-react-native)"/>
+    <field name="task_id" required="true" type="string" desc="Task identifier from dispatch context"/>
+    <field name="iteration_id" required="false" type="string" desc="Current iteration identifier"/>
+    <field name="source_root" required="true" type="string" desc="Root directory of mobile source code"/>
+  </block>
+
+  <!-- ============================================================
+       Global Constraints
+       ============================================================ -->
+  <block type="rule" id="R1" level="forbidden" desc="Task Record document constraints">
+    <field name="text">NEVER use create_file to write the Task Record document</field>
+    <field name="text">MUST create Task Record by copying template then filling sections with search_replace</field>
+    <field name="text">NEVER replace the entire Task Record content in a single operation</field>
+  </block>
+
+  <block type="rule" id="R2" level="mandatory" desc="Template-first workflow">
+    <field name="text">Copy template MUST execute before fill sections</field>
+    <field name="text">Source code is NOT template-filled - write directly based on design blueprints</field>
+  </block>
+
+  <!-- ============================================================
+       Main Processing Sequence
+       ============================================================ -->
+  <sequence id="S1" name="Mobile Development" status="pending" desc="Execute mobile development workflow">
+
+    <!-- Step 1: Read Design Documents -->
+    <block type="task" id="B1" action="read-file" desc="Read Module Design Document">
+      <field name="path" value="${design_doc_path}"/>
+      <field name="output" var="module_design"/>
+    </block>
+
+    <block type="task" id="B2" action="read-file" desc="Read API Contract">
+      <field name="path">speccrew-workspace/iterations/{iteration}/02.feature-design/{feature-name}-api-contract.md</field>
+      <field name="output" var="api_contract"/>
+    </block>
+
+    <block type="task" id="B3" action="read-file" desc="Read Task Record Template">
+      <field name="path">speccrew-dev-mobile/templates/TASK-RECORD-TEMPLATE.md</field>
+      <field name="output" var="task_template"/>
+    </block>
+
+    <!-- Step 2: Read Techs Knowledge -->
+    <block type="task" id="B4" action="read-file" desc="Read Techs Knowledge - conventions-dev">
+      <field name="path">knowledges/techs/${platform_id}/conventions-dev.md</field>
+      <field name="output" var="conventions_dev"/>
+    </block>
+
+    <block type="task" id="B5" action="read-file" desc="Read Techs Knowledge - architecture">
+      <field name="path">knowledges/techs/${platform_id}/architecture.md</field>
+      <field name="output" var="architecture"/>
+    </block>
+
+    <block type="task" id="B6" action="read-file" desc="Read Techs Knowledge - tech-stack">
+      <field name="path">knowledges/techs/${platform_id}/tech-stack.md</field>
+      <field name="output" var="tech_stack"/>
+    </block>
+
+    <!-- Step 3: Extract Task List -->
+    <block type="task" id="B7" action="analyze" desc="Extract mobile-specific task list">
+      <field name="input" value="${module_design}"/>
+      <field name="extraction_rules">
+        - Screen/Page: Full screen UI implementation (LoginScreen, ProductDetailPage)
+        - Widget/Component: Reusable UI components (ProductCard, SearchBar)
+        - Navigation flow: Route configuration (GoRouter config, Stack navigator)
+        - State management: Store/provider setup (CartBloc, UserStore)
+        - API service: HTTP client integration (ProductService, AuthApi)
+        - Local storage: Persistence layer (Hive box, SQLite schema)
+        - Platform channel: Native module integration (BiometricAuth, CameraAccess)
+        - Asset management: Images, fonts, icons (pubspec.yaml, asset bundling)
+      </field>
+      <field name="output" var="extracted_items"/>
+    </block>
+
+    <block type="task" id="B8" action="analyze" desc="Generate Task Checklist Table">
+      <field name="input" value="${extracted_items}"/>
+      <field name="format">
+        | Task ID | Module | Description | Target Files | Platform Specific | Offline Support | Dependencies | Status |
+        | MB-001 | Auth | LoginScreen implementation | lib/screens/auth/ | iOS/Android | Yes | - | ⏳ Pending |
+      </field>
+      <field name="output" var="task_list"/>
+    </block>
+
+    <!-- Step 4: Create Task Record File -->
+    <block type="task" id="B9" action="create-file" desc="Copy template to Task Record path">
+      <field name="path">speccrew-workspace/iterations/{iteration}/04.development/${platform_id}/{module}-task.md</field>
+      <field name="content">${task_template} with top-level placeholders replaced</field>
+      <field name="output" var="task_record_path"/>
+    </block>
+
+    <block type="task" id="B10" action="edit-file" desc="Fill Task Record sections using search_replace">
+      <field name="path" value="${task_record_path}"/>
+      <field name="action">Fill each section with task checklist and design metadata</field>
+      <field name="output" var="task_record_filled"/>
+    </block>
+
+    <!-- Checkpoint: Task list extracted -->
+    <block type="checkpoint" id="CP1" name="task-list-extracted" desc="Verify task list extracted">
+      <field name="verify" value="${task_list.length} > 0"/>
+    </block>
+
+    <!-- Step 5: Execute Task by Task -->
+    <block type="loop" id="L1" over="${task_list}" as="task" desc="Execute tasks sequentially following dependencies">
+      <block type="task" id="B11" action="edit-file" desc="Mark task as In Progress">
+        <field name="path" value="${task_record_path}"/>
+        <field name="action">Update task status to 🔄 In Progress</field>
+      </block>
+
+      <block type="task" id="B12" action="generate" desc="Implement task following design blueprint">
+        <field name="task" value="${task}"/>
+        <field name="design" value="${module_design}"/>
+        <field name="conventions" value="${conventions_dev}"/>
+        <field name="rules">
+          - Follow design file paths, naming, structure exactly
+          - Write actual code directly (no template filling)
+          - Reuse existing code via Glob/Grep
+          - Follow techs knowledge for naming, patterns, directory structure
+          - Handle iOS/Android differences where specified
+        </field>
+        <field name="output" var="implementation_result"/>
+      </block>
+
+      <!-- Local Checks -->
+      <block type="gateway" id="G1" mode="exclusive" desc="Platform-specific checks">
+        <branch test="${platform_id} == 'mobile-flutter'" name="Flutter Checks">
+          <block type="task" id="B13" action="run-script" desc="Flutter static analysis">
+            <field name="command">flutter analyze</field>
+            <field name="output" var="analysis_result"/>
+          </block>
+          <block type="task" id="B14" action="run-script" desc="Flutter build verification">
+            <field name="command">flutter build [ios/android]</field>
+            <field name="output" var="build_result"/>
+          </block>
+          <block type="task" id="B15" action="run-script" desc="Flutter unit tests">
+            <field name="command">flutter test</field>
+            <field name="output" var="test_result"/>
+          </block>
+        </branch>
+        <branch test="${platform_id} == 'mobile-react-native'" name="React Native Checks">
+          <block type="task" id="B16" action="run-script" desc="React Native lint">
+            <field name="command">npx react-native lint</field>
+            <field name="output" var="analysis_result"/>
+          </block>
+          <block type="task" id="B17" action="run-script" desc="React Native build">
+            <field name="command">npx react-native build-ios/build-android</field>
+            <field name="output" var="build_result"/>
+          </block>
+          <block type="task" id="B18" action="run-script" desc="React Native tests">
+            <field name="command">npm test</field>
+            <field name="output" var="test_result"/>
+          </block>
+        </branch>
+      </block>
+
+      <block type="task" id="B19" action="analyze" desc="Quick verify">
+        <field name="checks">
+          - App launches on simulator/emulator without crash
+        </field>
+        <field name="output" var="verify_result"/>
+      </block>
+
+      <block type="gateway" id="G2" mode="guard" desc="Verify checks passed"
+             test="${analysis_result.status} == 'passed' AND ${build_result.status} == 'passed'"
+             fail-action="stop">
+        <field name="message">Local checks failed for task ${task.id}</field>
+      </block>
+
+      <block type="task" id="B20" action="edit-file" desc="Update status to Complete">
+        <field name="path" value="${task_record_path}"/>
+        <field name="action">Update task status to ✅ Complete</field>
+      </block>
+    </block>
+
+    <!-- Step 6: Record Deviations -->
+    <block type="gateway" id="G3" mode="exclusive" desc="Check if deviations exist">
+      <branch test="${deviations.length} > 0" name="Has Deviations">
+        <block type="task" id="B21" action="edit-file" desc="Record deviations in task file">
+          <field name="path" value="${task_record_path}"/>
+          <field name="action">Add Deviation Notes section with MB-XXX prefix</field>
+        </block>
+      </branch>
+      <branch default="true" name="No Deviations">
+        <block type="event" id="E1" action="log" level="info" desc="No deviations">
+          <field name="message">No deviations from design</field>
+        </block>
+      </branch>
+    </block>
+
+    <!-- Step 7: Record Technical Debt -->
+    <block type="gateway" id="G4" mode="exclusive" desc="Check if technical debt exists">
+      <branch test="${tech_debt.length} > 0" name="Has Tech Debt">
+        <block type="task" id="B22" action="create-file" desc="Write technical debt document">
+          <field name="path">speccrew-workspace/iterations/{iteration}/tech-debt/{feature-name}-tech-debt.md</field>
+          <field name="content">${tech_debt} with categories: Platform-specific workarounds, Offline sync, Error handling, Accessibility, Test coverage</field>
+          <field name="output" var="tech_debt_path"/>
+        </block>
+      </branch>
+      <branch default="true" name="No Tech Debt">
+        <block type="event" id="E2" action="log" level="info" desc="No tech debt">
+          <field name="message">No technical debt identified</field>
+        </block>
+      </branch>
+    </block>
+
+    <!-- Step 8: Completion Notification -->
+    <block type="task" id="B23" action="edit-file" desc="Update task record status to complete">
+      <field name="path" value="${task_record_path}"/>
+      <field name="action">Update final status</field>
+    </block>
+
+    <block type="task" id="B24" action="report" desc="Generate completion notification">
+      <field name="template">
+Mobile Development Complete:
+- Tasks implemented: [X]
+- Deviation records: [Y] (see task file)
+- Technical debt records: [Z] (see tech-debt file)
+- Task record: speccrew-workspace/iterations/{iteration}/04.development/{platform_id}/{module}-task.md
+
+Ready for QA Agent acceptance testing.
+      </field>
+      <field name="output" var="completion_report"/>
+    </block>
+
+  </sequence>
+
+  <!-- ============================================================
+       Output Results
+       ============================================================ -->
+  <block type="output" id="O1" desc="Workflow output results">
+    <field name="task_record_path" value="${task_record_path}" type="string" desc="Path to task record document"/>
+    <field name="task_count" from="${task_list.length}" type="number" desc="Number of tasks completed"/>
+    <field name="deviation_count" type="number" desc="Number of deviations recorded"/>
+    <field name="tech_debt_count" type="number" desc="Number of tech debt items"/>
+    <field name="completion_report" value="${completion_report}" type="string" desc="Completion notification text"/>
+  </block>
+
+</workflow>

package/.speccrew/skills/speccrew-dev-review-backend/SKILL.md

@@ -23,9 +23,17 @@ tools: Read, Glob, Grep
 | `task_id` | Yes | Task identifier from dispatch context |
 | `previous_review_path` | No | Path to previous review report for incremental review |
 
-# Workflow
+## AgentFlow Definition
 
-## Absolute Constraints
+<!-- @agentflow: workflow.agentflow.xml -->
+
+> **REQUIRED**: Before executing this workflow, read the XML workflow specification: `speccrew-workspace/docs/rules/agentflow-spec.md`
+
+---
+
+## Workflow
+
+### Absolute Constraints
 
 > **Violation = review failure.**
 

package/.speccrew/skills/speccrew-dev-review-backend/workflow.agentflow.xml

@@ -0,0 +1,251 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<workflow id="dev-review-backend" status="pending" version="1.0" desc="Backend Code Review - Reviews backend implementation against design documents and standards">
+
+  <!-- ============================================================
+       Input Parameters Definition
+       ============================================================ -->
+  <block type="input" id="I1" desc="Workflow input parameters">
+    <field name="design_doc_path" required="true" type="string" desc="Path to backend module design document"/>
+    <field name="implementation_report_path" required="true" type="string" desc="Path to backend development report"/>
+    <field name="source_root" required="true" type="string" desc="Root directory of backend source code"/>
+    <field name="platform_id" required="true" type="string" desc="Backend platform (backend-spring, backend-nodejs)"/>
+    <field name="task_id" required="true" type="string" desc="Task identifier from dispatch context"/>
+    <field name="api_contract_path" required="false" type="string" desc="Path to API contract file for endpoint validation"/>
+    <field name="previous_review_path" required="false" type="string" desc="Path to previous review report for incremental review"/>
+  </block>
+
+  <!-- ============================================================
+       Global Constraints
+       ============================================================ -->
+  <block type="rule" id="R1" level="forbidden" desc="Review operation constraints">
+    <field name="text">NEVER modify source code files - read-only operation</field>
+    <field name="text">Do NOT attempt to fix issues - only document them</field>
+  </block>
+
+  <block type="rule" id="R2" level="mandatory" desc="Output requirements">
+    <field name="text">PARTIAL/FAIL results MUST include specific Re-dispatch Guidance</field>
+    <field name="text">If previous_review_path provided, skip items already marked as passed</field>
+  </block>
+
+  <!-- ============================================================
+       Main Processing Sequence
+       ============================================================ -->
+  <sequence id="S1" name="Backend Code Review" status="pending" desc="Execute backend code review workflow">
+
+    <!-- Step 1: Load Documents -->
+    <block type="task" id="B1" action="validate" desc="Validate Inputs">
+      <field name="checks">Verify all required parameters provided</field>
+      <field name="on_fail">Report error and stop</field>
+      <field name="output" var="validation_result"/>
+    </block>
+
+    <block type="task" id="B2" action="read-file" desc="Read Design Document">
+      <field name="path" value="${design_doc_path}"/>
+      <field name="output" var="design_doc"/>
+    </block>
+
+    <block type="task" id="B3" action="analyze" desc="Extract from Design Document">
+      <field name="input" value="${design_doc}"/>
+      <field name="extraction">
+        - Module Overview: Module name, responsibilities
+        - File Structure: Required files (DO, VO, Mapper, Service, Controller, Convert, Enums)
+        - Class Specifications: Class names, inheritance requirements, annotations
+        - API Endpoints: Endpoint definitions, HTTP methods, paths
+        - Business Logic: Service methods, transaction requirements
+      </field>
+      <field name="output" var="design_specs"/>
+    </block>
+
+    <block type="task" id="B4" action="read-file" desc="Read Implementation Report">
+      <field name="path" value="${implementation_report_path}"/>
+      <field name="output" var="impl_report"/>
+    </block>
+
+    <block type="task" id="B5" action="analyze" desc="Extract from Implementation Report">
+      <field name="input" value="${impl_report}"/>
+      <field name="extraction">Completed Files, Implementation Status, Known Issues</field>
+      <field name="output" var="impl_status"/>
+    </block>
+
+    <!-- Conditional: Read API Contract -->
+    <block type="gateway" id="G1" mode="exclusive" desc="Check if API contract provided">
+      <branch test="${api_contract_path} != null" name="Has API Contract">
+        <block type="task" id="B6" action="read-file" desc="Read API Contract">
+          <field name="path" value="${api_contract_path}"/>
+          <field name="output" var="api_contract"/>
+        </block>
+        <block type="task" id="B7" action="analyze" desc="Extract API Contract specs">
+          <field name="input" value="${api_contract}"/>
+          <field name="extraction">Endpoint Definitions, Request/Response Schemas, HTTP Methods, Error Codes</field>
+          <field name="output" var="api_specs"/>
+        </block>
+      </branch>
+      <branch default="true" name="No API Contract">
+        <block type="event" id="E1" action="log" level="info" desc="Skip API validation">
+          <field name="message">API contract not provided - skipping API validation</field>
+        </block>
+      </branch>
+    </block>
+
+    <!-- Conditional: Read Previous Review -->
+    <block type="gateway" id="G2" mode="exclusive" desc="Check if previous review provided">
+      <branch test="${previous_review_path} != null" name="Has Previous Review">
+        <block type="task" id="B8" action="read-file" desc="Read Previous Review">
+          <field name="path" value="${previous_review_path}"/>
+          <field name="output" var="previous_review"/>
+        </block>
+      </branch>
+      <branch default="true" name="No Previous Review">
+        <block type="event" id="E2" action="log" level="info" desc="Full review">
+          <field name="message">No previous review - performing full review</field>
+        </block>
+      </branch>
+    </block>
+
+    <!-- Step 2: File Completeness Check -->
+    <block type="task" id="B9" action="analyze" desc="Build Expected File List">
+      <field name="categories">
+        - Enums: enums/*.java (e.g., enums/ErrorCodeConstants.java)
+        - DO: dal/dataobject/**/*.java (e.g., dal/dataobject/employee/EmployeeDO.java)
+        - VO: controller/admin/vo/**/*.java (e.g., controller/admin/vo/EmployeeRespVO.java)
+        - Mapper: dal/mapper/**/*.java (e.g., dal/mapper/employee/EmployeeMapper.java)
+        - Service: service/**/*.java (e.g., service/employee/EmployeeService.java)
+        - Controller: controller/admin/**/*.java (e.g., controller/admin/employee/EmployeeController.java)
+        - Convert: convert/**/*.java (e.g., convert/employee/EmployeeConvert.java)
+      </field>
+      <field name="output" var="expected_files"/>
+    </block>
+
+    <block type="task" id="B10" action="analyze" desc="Scan Actual Files">
+      <field name="source_root" value="${source_root}"/>
+      <field name="action">Use Glob to scan for implemented files</field>
+      <field name="output" var="actual_files"/>
+    </block>
+
+    <block type="task" id="B11" action="analyze" desc="Calculate Completeness">
+      <field name="formula">completeness_pct = (created / required) * 100</field>
+      <field name="output" var="completeness_result"/>
+    </block>
+
+    <!-- Step 3: Backend-Specific Compliance Check -->
+    <block type="task" id="B12" action="analyze" desc="DO/VO/DTO Compliance Check">
+      <field name="checks">
+        - Base Class: Must extend correct base class (e.g., TenantBaseDO) - Severity: ERROR
+        - @TableName: Must have @TableName with correct table name - Severity: ERROR
+        - @Schema: Must have @Schema for documentation - Severity: WARN
+        - Validation: Required fields must have @NotNull or similar - Severity: ERROR
+        - Desensitization: Sensitive fields must have desensitization - Severity: ERROR
+      </field>
+      <field name="output" var="do_vo_check"/>
+    </block>
+
+    <block type="task" id="B13" action="analyze" desc="Service Layer Check">
+      <field name="checks">
+        - Interface: Must have Service interface and implementation separation - Severity: WARN
+        - @Service: Implementation must have @Service annotation - Severity: ERROR
+        - @Transactional: DB write methods must have @Transactional - Severity: ERROR
+        - Method Coverage: All methods in design must be implemented - Severity: ERROR
+        - Data Permission: Must check data permissions where required - Severity: ERROR
+      </field>
+      <field name="output" var="service_check"/>
+    </block>
+
+    <block type="task" id="B14" action="analyze" desc="Controller Layer Check">
+      <field name="checks">
+        - @RestController: Must have @RestController annotation - Severity: ERROR
+        - @RequestMapping: Must have base @RequestMapping annotation - Severity: ERROR
+        - @Operation: Endpoints should have @Operation for documentation - Severity: WARN
+        - @PreAuthorize: Must have permission annotations where required - Severity: ERROR
+        - @Valid: Request VO parameters must have @Valid - Severity: ERROR
+      </field>
+      <field name="output" var="controller_check"/>
+    </block>
+
+    <block type="task" id="B15" action="analyze" desc="Database Mapping Validation">
+      <field name="checks">
+        - Verify Entity fields match design document
+        - Check MyBatis XML mappers exist alongside Mapper interfaces
+        - Validate Lombok @Data or similar on DO/VO classes
+      </field>
+      <field name="output" var="db_mapping_check"/>
+    </block>
+
+    <!-- Step 4: API Consistency Check -->
+    <block type="gateway" id="G3" mode="exclusive" desc="Check if API contract validation needed">
+      <branch test="${api_contract_path} != null" name="Validate API">
+        <block type="task" id="B16" action="analyze" desc="API Consistency Check">
+          <field name="checks">
+            - Endpoint Coverage: All contract endpoints exist in Controller - Severity: ERROR
+            - HTTP Method: Methods match contract - Severity: ERROR
+            - Path Match: URL paths match contract exactly - Severity: ERROR
+            - VO Fields: All contract fields present in VO - Severity: ERROR
+            - Field Types: Data types match contract - Severity: ERROR
+          </field>
+          <field name="output" var="api_check"/>
+        </block>
+      </branch>
+      <branch default="true" name="Skip API Check">
+        <block type="event" id="E3" action="log" level="info" desc="Skip API validation">
+          <field name="message">Skipping API consistency check</field>
+        </block>
+      </branch>
+    </block>
+
+    <!-- Step 5: Generate Review Report -->
+    <block type="task" id="B17" action="analyze" desc="Determine Result">
+      <field name="criteria">
+        - PASS: 100% files created, 0 ERROR-level issues
+        - PARTIAL: 70-99% files created, or non-critical ERROR issues
+        - FAIL: &lt;70% files created, or critical blockers present
+      </field>
+      <field name="output" var="review_result"/>
+    </block>
+
+    <block type="task" id="B18" action="read-file" desc="Read Review Report Template">
+      <field name="path">templates/REVIEW-REPORT-TEMPLATE.md</field>
+      <field name="output" var="report_template"/>
+    </block>
+
+    <block type="task" id="B19" action="generate" desc="Write Review Report">
+      <field name="path">speccrew-workspace/iterations/{number}-{type}-{name}/04.development/{platform_id}/[module]-review-report.md</field>
+      <field name="template" value="${report_template}"/>
+      <field name="content">
+        - Completeness: ${completeness_result}
+        - DO/VO Check: ${do_vo_check}
+        - Service Check: ${service_check}
+        - Controller Check: ${controller_check}
+        - DB Mapping Check: ${db_mapping_check}
+        - API Check: ${api_check}
+        - Final Result: ${review_result}
+      </field>
+      <field name="output" var="review_report_path"/>
+    </block>
+
+    <!-- Step 6: Task Completion Report -->
+    <block type="task" id="B20" action="report" desc="Generate Task Completion Report">
+      <field name="template">
+## Task Completion Report
+- **Status**: SUCCESS
+- **Task ID**: review-{original_task_id}
+- **Platform**: {platform_id}
+- **Module**: {module_name}
+- **Output Files**: {review_report_path}
+- **Summary**: Review {result}: {completed}/{total} files, {error_count} errors
+      </field>
+      <field name="output" var="completion_report"/>
+    </block>
+
+  </sequence>
+
+  <!-- ============================================================
+       Output Results
+       ============================================================ -->
+  <block type="output" id="O1" desc="Workflow output results">
+    <field name="review_report_path" value="${review_report_path}" type="string" desc="Path to review report"/>
+    <field name="review_result" value="${review_result}" type="string" desc="PASS/PARTIAL/FAIL verdict"/>
+    <field name="completeness_pct" from="${completeness_result.percentage}" type="number" desc="File completeness percentage"/>
+    <field name="error_count" type="number" desc="Number of ERROR-level issues"/>
+    <field name="completion_report" value="${completion_report}" type="string" desc="Task completion report"/>
+  </block>
+
+</workflow>

package/.speccrew/skills/speccrew-dev-review-desktop/SKILL.md

@@ -23,9 +23,17 @@ tools: Read, Glob, Grep
 | `task_id` | Yes | Task identifier from dispatch context |
 | `previous_review_path` | No | Path to previous review report |
 
-# Workflow
+## AgentFlow Definition
 
-## Absolute Constraints
+<!-- @agentflow: workflow.agentflow.xml -->
+
+> **REQUIRED**: Before executing this workflow, read the XML workflow specification: `speccrew-workspace/docs/rules/agentflow-spec.md`
+
+---
+
+## Workflow
+
+### Absolute Constraints
 
 > **Violation = review failure.**