spec-up-t 1.2.3 → 1.2.5

package/src/health-check/external-specs-checker.js

@@ -17,6 +17,7 @@ function isValidGitHubPagesUrl(urlStr) {
       parsedUrl.hostname.endsWith('.github.io')
     );
   } catch (error) {
+    console.error(`❌ Error validating GitHub Pages URL: ${error.message}`);
     return false;
   }
 }
@@ -34,6 +35,7 @@ function isValidGitHubRepoUrl(urlStr) {
       parsedUrl.pathname.split('/').filter(Boolean).length >= 2
     );
   } catch (error) {
+    console.error(`❌ Error validating GitHub repo URL: ${error.message}`);
     return false;
   }
 }
@@ -69,131 +71,208 @@ function urlExists(urlStr) {
 
       req.end();
     } catch (error) {
+      console.error(`❌ URL Format Error: Invalid URL format for ${urlStr} - ${error.message}`);
       resolve(false);
     }
   });
 }
 
 /**
- * Check external specs in a specs.json file
+ * Check if specs.json file exists and read it
  * @param {string} projectRoot - Root directory of the project
- * @returns {Promise<Array>} - Array of check results
+ * @returns {Object} - Object containing results and specs data if found
  */
-async function checkExternalSpecs(projectRoot) {
-  const results = [];
+function checkAndReadSpecsFile(projectRoot) {
+  const specsPath = path.join(projectRoot, 'specs.json');
   
-  try {
-    const specsPath = path.join(projectRoot, 'specs.json');
-    
-    // Check if specs.json exists
-    if (!fs.existsSync(specsPath)) {
-      return [{
+  if (!fs.existsSync(specsPath)) {
+    return {
+      results: [{
         name: 'Find specs.json file',
         success: false,
         details: 'specs.json file not found in project root'
-      }];
-    }
-    
-    results.push({
-      name: 'Find specs.json file',
-      success: true,
-      details: 'specs.json file found'
-    });
-    
-    // Read specs.json
+      }],
+      specs: null
+    };
+  }
+  
+  try {
     const specsContent = fs.readFileSync(specsPath, 'utf8');
     const specs = JSON.parse(specsContent);
     
-    // Check if external_specs key exists
-    if (!specs.specs || !Array.isArray(specs.specs) || !specs.specs.some(spec => spec.external_specs)) {
-      results.push({
+    return {
+      results: [{
+        name: 'Find specs.json file',
+        success: true,
+        details: 'specs.json file found'
+      }],
+      specs
+    };
+  } catch (error) {
+    return {
+      results: [{
+        name: 'Parse specs.json file',
+        success: false,
+        details: `❌ Error parsing specs.json: ${error.message}`
+      }],
+      specs: null
+    };
+  }
+}
+
+/**
+ * Extract external specs from specs data
+ * @param {Object} specs - Specs data
+ * @returns {Object} - Object containing results and external specs if found
+ */
+function extractExternalSpecs(specs) {
+  if (!specs.specs || !Array.isArray(specs.specs) || !specs.specs.some(spec => spec.external_specs)) {
+    return {
+      results: [{
         name: 'Find external_specs in specs.json',
         success: false,
         details: 'external_specs key not found in specs.json'
-      });
-      return results;
+      }],
+      externalSpecs: []
+    };
+  }
+  
+  const externalSpecs = [];
+  
+  specs.specs.forEach(spec => {
+    if (spec.external_specs && Array.isArray(spec.external_specs)) {
+      externalSpecs.push(...spec.external_specs);
     }
-    
-    results.push({
+  });
+  
+  return {
+    results: [{
       name: 'Find external_specs in specs.json',
       success: true,
       details: 'external_specs key found in specs.json'
+    }],
+    externalSpecs
+  };
+}
+
+/**
+ * Check GitHub Pages URL for an external spec
+ * @param {Object} spec - External spec object
+ * @returns {Promise<Array>} - Array of check results
+ */
+async function checkGitHubPagesUrl(spec) {
+  const results = [];
+  
+  if (!spec.gh_page) {
+    results.push({
+      name: `Check "${spec.external_spec}" gh_page URL`,
+      success: false,
+      details: 'gh_page URL is missing'
     });
-    
-    // Find all external specs
-    const externalSpecs = [];
-    specs.specs.forEach(spec => {
-      if (spec.external_specs && Array.isArray(spec.external_specs)) {
-        externalSpecs.push(...spec.external_specs);
-      }
+    return results;
+  }
+  
+  const isValidGhPage = isValidGitHubPagesUrl(spec.gh_page);
+  results.push({
+    name: `Check "${spec.external_spec}" gh_page URL structure`,
+    success: isValidGhPage,
+    details: isValidGhPage 
+      ? 'Valid GitHub Pages URL structure' 
+      : `Invalid GitHub Pages URL structure: ${spec.gh_page}`
+  });
+  
+  if (isValidGhPage) {
+    const ghPageExists = await urlExists(spec.gh_page);
+    results.push({
+      name: `Check "${spec.external_spec}" gh_page URL exists`,
+      success: ghPageExists,
+      details: ghPageExists 
+        ? 'GitHub Pages URL is accessible' 
+        : `GitHub Pages URL is not accessible: ${spec.gh_page}`
+    });
+  }
+  
+  return results;
+}
+
+/**
+ * Check repository URL for an external spec
+ * @param {Object} spec - External spec object
+ * @returns {Promise<Array>} - Array of check results
+ */
+async function checkRepositoryUrl(spec) {
+  const results = [];
+  
+  if (!spec.url) {
+    results.push({
+      name: `Check "${spec.external_spec}" repo URL`,
+      success: false,
+      details: 'Repository URL is missing'
     });
+    return results;
+  }
+  
+  const isValidRepoUrl = isValidGitHubRepoUrl(spec.url);
+  results.push({
+    name: `Check "${spec.external_spec}" repo URL structure`,
+    success: isValidRepoUrl,
+    details: isValidRepoUrl 
+      ? 'Valid GitHub repository URL structure' 
+      : `Invalid GitHub repository URL structure: ${spec.url}`
+  });
+  
+  if (isValidRepoUrl) {
+    const repoUrlExists = await urlExists(spec.url);
+    results.push({
+      name: `Check "${spec.external_spec}" repo URL exists`,
+      success: repoUrlExists,
+      details: repoUrlExists 
+        ? 'GitHub repository URL is accessible' 
+        : `GitHub repository URL is not accessible: ${spec.url}`
+    });
+  }
+  
+  return results;
+}
+
+/**
+ * Check external specs in a specs.json file
+ * @param {string} projectRoot - Root directory of the project
+ * @returns {Promise<Array>} - Array of check results
+ */
+async function checkExternalSpecs(projectRoot) {
+  try {
+    // Check for and read specs.json file
+    const { results, specs } = checkAndReadSpecsFile(projectRoot);
+    
+    if (!specs) {
+      return results;
+    }
+    
+    // Extract external specs from specs data
+    const { results: extractResults, externalSpecs } = extractExternalSpecs(specs);
+    
+    // Combine results
+    const allResults = [...results, ...extractResults];
+    
+    if (externalSpecs.length === 0) {
+      return allResults;
+    }
     
     // Check each external spec
     for (const spec of externalSpecs) {
-      // Check gh_page structure
-      if (spec.gh_page) {
-        const isValidGhPage = isValidGitHubPagesUrl(spec.gh_page);
-        results.push({
-          name: `Check "${spec.external_spec}" gh_page URL structure`,
-          success: isValidGhPage,
-          details: isValidGhPage 
-            ? 'Valid GitHub Pages URL structure' 
-            : `Invalid GitHub Pages URL structure: ${spec.gh_page}`
-        });
-        
-        // Check if gh_page exists
-        if (isValidGhPage) {
-          const ghPageExists = await urlExists(spec.gh_page);
-          results.push({
-            name: `Check "${spec.external_spec}" gh_page URL exists`,
-            success: ghPageExists,
-            details: ghPageExists 
-              ? 'GitHub Pages URL is accessible' 
-              : `GitHub Pages URL is not accessible: ${spec.gh_page}`
-          });
-        }
-      } else {
-        results.push({
-          name: `Check "${spec.external_spec}" gh_page URL`,
-          success: false,
-          details: 'gh_page URL is missing'
-        });
-      }
+      // Check GitHub Pages URL
+      const ghPageResults = await checkGitHubPagesUrl(spec);
+      allResults.push(...ghPageResults);
       
-      // Check url structure
-      if (spec.url) {
-        const isValidRepoUrl = isValidGitHubRepoUrl(spec.url);
-        results.push({
-          name: `Check "${spec.external_spec}" repo URL structure`,
-          success: isValidRepoUrl,
-          details: isValidRepoUrl 
-            ? 'Valid GitHub repository URL structure' 
-            : `Invalid GitHub repository URL structure: ${spec.url}`
-        });
-        
-        // Check if url exists
-        if (isValidRepoUrl) {
-          const repoUrlExists = await urlExists(spec.url);
-          results.push({
-            name: `Check "${spec.external_spec}" repo URL exists`,
-            success: repoUrlExists,
-            details: repoUrlExists 
-              ? 'GitHub repository URL is accessible' 
-              : `GitHub repository URL is not accessible: ${spec.url}`
-          });
-        }
-      } else {
-        results.push({
-          name: `Check "${spec.external_spec}" repo URL`,
-          success: false,
-          details: 'Repository URL is missing'
-        });
-      }
+      // Check repository URL
+      const repoUrlResults = await checkRepositoryUrl(spec);
+      allResults.push(...repoUrlResults);
     }
     
-    return results;
+    return allResults;
   } catch (error) {
-    console.error('Error checking external specs:', error);
+    console.error('❌ Error checking external specs:', error);
     return [{
       name: 'External specs check',
       success: false,