sparkbun 0.2.3 → 0.2.4

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "sparkbun",
-	"version": "0.2.3",
+	"version": "0.2.4",
 	"description": "Build fast, lightweight, cross-platform desktop apps with TypeScript and Bun.",
 	"license": "MIT",
 	"author": "SparkBun Contributors",

package/src/cli/index.ts

@@ -3333,7 +3333,12 @@ usageDescriptions : ""}${urlTypes ? "\n" + urlTypes : ""}${documentTypes ?
 		}
 
 		const outPath = getFlag("--out=");
-		const iconPath = getFlag("--icon=");
+		// Fall back to the platform icon from sparkbun.config.ts (build.win.icon)
+		// so the installer is branded without needing an explicit --icon flag.
+		const iconPath =
+			getFlag("--icon=") ||
+			(config.build as any)?.win?.icon ||
+			undefined;
 		const installerName = getFlag("--name=") || config.app.name;
 		const installerVersion = getFlag("--version=") || config.app.version;
 		const installerPublisher = getFlag("--publisher=") || (config.app as any).publisher || "";
@@ -3412,15 +3417,25 @@ usageDescriptions : ""}${urlTypes ? "\n" + urlTypes : ""}${documentTypes ?
 
 				console.log(`  Archiving ${spec.name}: ${spec.path}`);
 
-				// Build an uncompressed tar that preserves the source folder name as
-				// the archive root (e.g. "Dune 2000/..."), so the installer extracts
-				// into the correct subdirectory. tar -C <parent> <basename>.
+				// Build the uncompressed tar with the system `tar`. It streams to disk
+				// (bounded build memory) and preserves empty directories as real
+				// entries. The source folder name is kept as the archive root (e.g.
+				// "Dune 2000/...") via `tar -C <parent> <basename>`, so it extracts
+				// into the correct subdirectory.
+				//
+				// The on-disk format may be GNU (Windows/Linux — long paths via
+				// "././@LongLink") or pax (macOS bsdtar — long paths via extended
+				// headers). The installer's streaming extractor understands both, plus
+				// plain ustar, so the archive is portable regardless of build host.
+				//
+				// (Bun.Archive is intentionally not used here: its lazy Bun.file()
+				// inputs write empty file bodies, and eager byte inputs would require
+				// loading the entire payload into memory.)
 				const parent = dirname(spec.path);
 				const baseName = basename(spec.path);
 				createTar(tarTmpPath, parent, [baseName]);
 
-				// Measure uncompressed bytes + file count so the installer can show
-				// real per-file / byte progress without unpacking first.
+				// Measure uncompressed bytes + file count for progress denominators.
 				const { bytes: uncompressedBytes, fileCount } = measureDir(spec.path);
 
 				// Stream-compress the tar at the requested level (bounded build memory).