spacecommands 3.4.2 → 3.4.6

package/README.md

@@ -20,6 +20,16 @@ SpaceCommands is a modern, feature-rich Discord.js command handler library. Buil
 - 📊 **Poll Support** - Native Discord polls with result tracking
 - 🛡️ **AutoMod Integration** - Full AutoMod rule creation and management
 
+
+## ⚠️ Developer Notes (Common Pitfalls)
+
+**Critical information for maintainers:**
+
+1.  **SlashCommandBuilder Support**: The library MUST explicitly extract options from `configuration.data.toJSON().options`. Native `SlashCommandBuilder` objects hide the `type` field, which causes `DiscordAPIError[50035]: Invalid Form Body` if passed directly. **DO NOT** revert the `.toJSON()` extraction logic in `CommandHandler.ts`.
+2.  **Command Registration Timing**: Global commands fail silently if registered before the client is ready. The `CommandHandler` constructor now waits for `client.once('ready')`. **DO NOT** remove this check.
+3.  **Update Logic**: The `didOptionsChange` logic in `SlashCommands.ts` must use `||` (OR) operators to correctly detect changes. **DO NOT** change this back to `&&`.
+
+
 ## Installation
 
 **NPM**
@@ -569,4 +579,4 @@ If you need help or have questions, please open an issue on our [GitHub reposito
 
 ## License
 
-MIT License - see LICENSE file for details.
+MIT License - see LICENSE file for details.

package/dist/Command.js

@@ -34,7 +34,8 @@ class Command {
     _requiredChannels = new Map(); // <GuildID-Command, Channel IDs>
     _requiredEntitlements = [];
     _premiumOnly = false;
-    constructor(instance, client, names, callback, error, { category, minArgs, maxArgs, syntaxError, expectedArgs, description, requiredPermissions, permissions, cooldown, globalCooldown, ownerOnly = false, hidden = false, guildOnly = false, testOnly = false, slash = false, requireRoles = false, requiredEntitlements, premiumOnly = false, }) {
+    _delete = false;
+    constructor(instance, client, names, callback, error, { category, minArgs, maxArgs, syntaxError, expectedArgs, description, requiredPermissions, permissions, cooldown, globalCooldown, ownerOnly = false, hidden = false, guildOnly = false, testOnly = false, slash = false, requireRoles = false, requiredEntitlements, premiumOnly = false, delete: del = false, }) {
         this.instance = instance;
         this.client = client;
         this._names = typeof names === 'string' ? [names] : names;
@@ -60,6 +61,7 @@ class Command {
                 ? [requiredEntitlements]
                 : requiredEntitlements || [];
         this._premiumOnly = premiumOnly;
+        this._delete = del;
         if (this.cooldown && this.globalCooldown) {
             throw new Error(`Command "${names[0]}" has both a global and per-user cooldown. Commands can only have up to one of these properties.`);
         }
@@ -380,5 +382,8 @@ class Command {
     get premiumOnly() {
         return this._premiumOnly;
     }
+    get delete() {
+        return this._delete;
+    }
 }
 module.exports = Command;

package/dist/CommandHandler.js

@@ -44,7 +44,14 @@ class CommandHandler {
     _commandChecks = new Map();
     constructor(instance, client, dir, disabledDefaultCommands, typeScript = false) {
         this._client = client;
-        this.setUp(instance, client, dir, disabledDefaultCommands, typeScript);
+        if (client.isReady()) {
+            this.setUp(instance, client, dir, disabledDefaultCommands, typeScript);
+        }
+        else {
+            client.once('ready', () => {
+                this.setUp(instance, client, dir, disabledDefaultCommands, typeScript);
+            });
+        }
     }
     async setUp(instance, client, dir, disabledDefaultCommands, typeScript = false) {
         // Do not pass in TS here because this should always compiled to JS
@@ -158,12 +165,21 @@ class CommandHandler {
         if (configuration.default && Object.keys(configuration).length === 1) {
             configuration = configuration.default;
         }
-        const { name = fileName, category, commands, aliases, init, callback, run, execute, error, description, requiredPermissions, permissions, slash, expectedArgs, expectedArgsTypes, minArgs, options = [], autocomplete, } = configuration;
+        const { name = fileName, category, commands, aliases, init, callback, run, execute, error, description, requiredPermissions, permissions, slash, expectedArgs, expectedArgsTypes, minArgs, options = [], autocomplete, delete: del, } = configuration;
         const { testOnly } = configuration;
         // Extract options from SlashCommandBuilder if using data property
         // This allows commands to use SlashCommandBuilder pattern while still working with SpaceCommands
         let finalOptions = options;
-        if (configuration.data && configuration.data.options) {
+        if (configuration.data && typeof configuration.data.toJSON === 'function') {
+            const jsonData = configuration.data.toJSON();
+            if (jsonData.options) {
+                finalOptions = jsonData.options;
+            }
+            if (instance.debug && finalOptions && finalOptions.length) {
+                console.log(`SpaceCommands > Command "${name || fileName}" using SlashCommandBuilder with ${finalOptions.length} options`);
+            }
+        }
+        else if (configuration.data && configuration.data.options) {
             finalOptions = configuration.data.options;
             if (instance.debug) {
                 console.log(`SpaceCommands > Command "${name || fileName}" using SlashCommandBuilder with ${finalOptions.length} options`);
@@ -185,6 +201,20 @@ class CommandHandler {
         if (name && !names.includes(name.toLowerCase())) {
             names.unshift(name.toLowerCase());
         }
+        if (del) {
+            if (slash !== false) {
+                const slashCommands = instance.slashCommands;
+                if (testOnly) {
+                    for (const id of instance.testServers) {
+                        await slashCommands.deleteByName(names[0], id);
+                    }
+                }
+                else {
+                    await slashCommands.deleteByName(names[0]);
+                }
+            }
+            return;
+        }
         if (requiredPermissions || permissions) {
             for (const perm of requiredPermissions || permissions) {
                 if (!permissions_1.permissionList.includes(perm)) {

package/dist/SlashCommands.js

@@ -109,9 +109,9 @@ class SlashCommands {
     }
     didOptionsChange(command, options) {
         return (command.options?.filter((opt, index) => {
-            return (opt?.required !== options[index]?.required &&
-                opt?.name !== options[index]?.name &&
-                opt?.options?.length !== options.length);
+            return (opt?.required !== options[index]?.required ||
+                opt?.name !== options[index]?.name ||
+                (opt?.options && opt.options.length !== options[index]?.options?.length));
         }).length !== 0);
     }
     async create(name, description, options, guildId) {
@@ -164,6 +164,16 @@ class SlashCommands {
         }
         return Promise.resolve(undefined);
     }
+    async deleteByName(name, guildId) {
+        const commands = this.getCommands(guildId);
+        if (commands) {
+            await commands.fetch();
+            const cmd = commands.cache.find((c) => c.name === name);
+            if (cmd) {
+                await this.delete(cmd.id, guildId);
+            }
+        }
+    }
     async invokeCommand(interaction, commandName, options, args) {
         const command = this._instance.commandHandler.getCommand(commandName);
         if (!command || !command.callback) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "spacecommands",
-  "version": "3.4.2",
+  "version": "3.4.6",
   "main": "dist/index.js",
   "types": "./typings.d.ts",
   "typings": "./typings.d.ts",

package/typings.d.ts

@@ -193,6 +193,7 @@ export interface ICommand {
   requireRoles?: boolean
   requiredEntitlements?: string | string[]
   premiumOnly?: boolean
+  delete?: boolean
 }
 
 export interface ISlashCommand {