sourceverity 1.0.2 → 1.0.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (67) hide show
  1. package/dist/analysis/controlFlow.d.ts +5 -0
  2. package/dist/analysis/controlFlow.d.ts.map +1 -1
  3. package/dist/analysis/controlFlow.js +501 -45
  4. package/dist/analysis/controlFlow.js.map +1 -1
  5. package/dist/analysis/frameworks.d.ts.map +1 -1
  6. package/dist/analysis/frameworks.js +84 -12
  7. package/dist/analysis/frameworks.js.map +1 -1
  8. package/dist/analysis/functions.d.ts.map +1 -1
  9. package/dist/analysis/functions.js +52 -8
  10. package/dist/analysis/functions.js.map +1 -1
  11. package/dist/analysis/promiseFlow.d.ts.map +1 -1
  12. package/dist/analysis/promiseFlow.js +85 -11
  13. package/dist/analysis/promiseFlow.js.map +1 -1
  14. package/dist/baseline/manager.js +1 -1
  15. package/dist/baseline/manager.js.map +1 -1
  16. package/dist/baseline/types.d.ts +1 -1
  17. package/dist/baseline/types.d.ts.map +1 -1
  18. package/dist/cli/main.d.ts.map +1 -1
  19. package/dist/cli/main.js +2 -1
  20. package/dist/cli/main.js.map +1 -1
  21. package/dist/core/paths.d.ts +0 -4
  22. package/dist/core/paths.d.ts.map +1 -1
  23. package/dist/core/paths.js +0 -6
  24. package/dist/core/paths.js.map +1 -1
  25. package/dist/engine/runner.d.ts +6 -1
  26. package/dist/engine/runner.d.ts.map +1 -1
  27. package/dist/engine/runner.js +37 -20
  28. package/dist/engine/runner.js.map +1 -1
  29. package/dist/engine/symbols.d.ts +17 -4
  30. package/dist/engine/symbols.d.ts.map +1 -1
  31. package/dist/engine/symbols.js +267 -34
  32. package/dist/engine/symbols.js.map +1 -1
  33. package/dist/reporters/sarif.d.ts +2 -0
  34. package/dist/reporters/sarif.d.ts.map +1 -1
  35. package/dist/reporters/sarif.js +36 -7
  36. package/dist/reporters/sarif.js.map +1 -1
  37. package/dist/rules/async/floatingPromise.d.ts.map +1 -1
  38. package/dist/rules/async/floatingPromise.js +4 -2
  39. package/dist/rules/async/floatingPromise.js.map +1 -1
  40. package/dist/rules/browser/eventListenerCleanup.d.ts.map +1 -1
  41. package/dist/rules/browser/eventListenerCleanup.js +2 -9
  42. package/dist/rules/browser/eventListenerCleanup.js.map +1 -1
  43. package/dist/rules/browser/observerCleanup.d.ts.map +1 -1
  44. package/dist/rules/browser/observerCleanup.js +2 -9
  45. package/dist/rules/browser/observerCleanup.js.map +1 -1
  46. package/dist/rules/browser/timerCleanup.d.ts.map +1 -1
  47. package/dist/rules/browser/timerCleanup.js +2 -9
  48. package/dist/rules/browser/timerCleanup.js.map +1 -1
  49. package/dist/rules/network/fetchStatusUnchecked.d.ts.map +1 -1
  50. package/dist/rules/network/fetchStatusUnchecked.js +245 -46
  51. package/dist/rules/network/fetchStatusUnchecked.js.map +1 -1
  52. package/dist/rules/react/asyncEffectCallback.d.ts.map +1 -1
  53. package/dist/rules/react/asyncEffectCallback.js +2 -9
  54. package/dist/rules/react/asyncEffectCallback.js.map +1 -1
  55. package/dist/rules/react/derivedStateEffect.d.ts.map +1 -1
  56. package/dist/rules/react/derivedStateEffect.js +2 -9
  57. package/dist/rules/react/derivedStateEffect.js.map +1 -1
  58. package/dist/rules/react/missingEffectCleanup.d.ts.map +1 -1
  59. package/dist/rules/react/missingEffectCleanup.js +102 -10
  60. package/dist/rules/react/missingEffectCleanup.js.map +1 -1
  61. package/dist/rules/typescript/uncheckedIndexAccess.d.ts.map +1 -1
  62. package/dist/rules/typescript/uncheckedIndexAccess.js +55 -0
  63. package/dist/rules/typescript/uncheckedIndexAccess.js.map +1 -1
  64. package/dist/rules/typescript/unsafeUnvalidatedAssertion.d.ts.map +1 -1
  65. package/dist/rules/typescript/unsafeUnvalidatedAssertion.js +9 -4
  66. package/dist/rules/typescript/unsafeUnvalidatedAssertion.js.map +1 -1
  67. package/package.json +1 -1
@@ -1,4 +1,207 @@
1
1
  import { getNodeSourceRange, isDOMGlobal } from "../../engine/symbols.js";
2
+ import { unwrapExpression } from "../../analysis/values.js";
3
+ import { hasVariableReassignment, statementExitsControlFlow } from "../../analysis/controlFlow.js";
4
+ const BODY_CONSUMPTION_METHODS = {
5
+ json: true,
6
+ text: true,
7
+ blob: true,
8
+ arrayBuffer: true,
9
+ formData: true,
10
+ bytes: true,
11
+ };
12
+ function isMatchingTarget(expr, targetSymbol, targetName, ts, checker) {
13
+ const unwrapped = unwrapExpression(expr, ts);
14
+ if (!ts.isIdentifier(unwrapped))
15
+ return false;
16
+ if (targetSymbol) {
17
+ let sym = checker.getSymbolAtLocation(unwrapped);
18
+ if (sym && (sym.flags & ts.SymbolFlags.Alias) !== 0) {
19
+ try {
20
+ sym = checker.getAliasedSymbol(sym);
21
+ }
22
+ catch { }
23
+ }
24
+ return sym === targetSymbol;
25
+ }
26
+ return unwrapped.text === targetName;
27
+ }
28
+ function classifyStatusCheck(rawExpr, targetSymbol, targetName, ts, checker) {
29
+ const expr = unwrapExpression(rawExpr, ts);
30
+ // 1. !res.ok -> negative
31
+ if (ts.isPrefixUnaryExpression(expr) && expr.operator === ts.SyntaxKind.ExclamationToken) {
32
+ const inner = unwrapExpression(expr.operand, ts);
33
+ if (ts.isPropertyAccessExpression(inner) && inner.name.text === "ok") {
34
+ if (isMatchingTarget(inner.expression, targetSymbol, targetName, ts, checker)) {
35
+ return "negative";
36
+ }
37
+ }
38
+ }
39
+ // 2. res.ok -> positive
40
+ if (ts.isPropertyAccessExpression(expr) && expr.name.text === "ok") {
41
+ if (isMatchingTarget(expr.expression, targetSymbol, targetName, ts, checker)) {
42
+ return "positive";
43
+ }
44
+ }
45
+ // 3. Binary expressions
46
+ if (ts.isBinaryExpression(expr)) {
47
+ const op = expr.operatorToken.kind;
48
+ // Logical AND: check if positive guard (e.g. res.ok && ...)
49
+ if (op === ts.SyntaxKind.AmpersandAmpersandToken) {
50
+ const leftPol = classifyStatusCheck(expr.left, targetSymbol, targetName, ts, checker);
51
+ const rightPol = classifyStatusCheck(expr.right, targetSymbol, targetName, ts, checker);
52
+ if (leftPol === "positive" || rightPol === "positive") {
53
+ return "positive";
54
+ }
55
+ }
56
+ // Logical OR: check if negative guard (e.g. !res.ok || res.status !== 200)
57
+ if (op === ts.SyntaxKind.BarBarToken) {
58
+ const leftPol = classifyStatusCheck(expr.left, targetSymbol, targetName, ts, checker);
59
+ const rightPol = classifyStatusCheck(expr.right, targetSymbol, targetName, ts, checker);
60
+ if (leftPol === "negative" || rightPol === "negative") {
61
+ return "negative";
62
+ }
63
+ }
64
+ // Equality/inequality on res.ok or res.status
65
+ if (op === ts.SyntaxKind.EqualsEqualsToken ||
66
+ op === ts.SyntaxKind.EqualsEqualsEqualsToken ||
67
+ op === ts.SyntaxKind.ExclamationEqualsToken ||
68
+ op === ts.SyntaxKind.ExclamationEqualsEqualsToken) {
69
+ const isEq = op === ts.SyntaxKind.EqualsEqualsToken || op === ts.SyntaxKind.EqualsEqualsEqualsToken;
70
+ const left = unwrapExpression(expr.left, ts);
71
+ const right = unwrapExpression(expr.right, ts);
72
+ let propAccess;
73
+ let otherSide;
74
+ if (ts.isPropertyAccessExpression(left) && isMatchingTarget(left.expression, targetSymbol, targetName, ts, checker)) {
75
+ propAccess = left;
76
+ otherSide = right;
77
+ }
78
+ else if (ts.isPropertyAccessExpression(right) && isMatchingTarget(right.expression, targetSymbol, targetName, ts, checker)) {
79
+ propAccess = right;
80
+ otherSide = left;
81
+ }
82
+ if (propAccess) {
83
+ if (propAccess.name.text === "ok") {
84
+ if (otherSide && otherSide.kind === ts.SyntaxKind.TrueKeyword) {
85
+ return isEq ? "positive" : "negative";
86
+ }
87
+ if (otherSide && otherSide.kind === ts.SyntaxKind.FalseKeyword) {
88
+ return isEq ? "negative" : "positive";
89
+ }
90
+ }
91
+ if (propAccess.name.text === "status") {
92
+ if (otherSide && ts.isNumericLiteral(otherSide)) {
93
+ const code = parseInt(otherSide.text, 10);
94
+ if (code >= 200 && code < 300) {
95
+ return isEq ? "positive" : "negative";
96
+ }
97
+ if (code >= 400) {
98
+ return isEq ? "negative" : "positive";
99
+ }
100
+ }
101
+ }
102
+ }
103
+ }
104
+ // Range comparisons on res.status
105
+ if (op === ts.SyntaxKind.LessThanToken ||
106
+ op === ts.SyntaxKind.LessThanEqualsToken ||
107
+ op === ts.SyntaxKind.GreaterThanToken ||
108
+ op === ts.SyntaxKind.GreaterThanEqualsToken) {
109
+ const left = unwrapExpression(expr.left, ts);
110
+ const right = unwrapExpression(expr.right, ts);
111
+ if (ts.isPropertyAccessExpression(left) &&
112
+ left.name.text === "status" &&
113
+ isMatchingTarget(left.expression, targetSymbol, targetName, ts, checker)) {
114
+ if (ts.isNumericLiteral(right)) {
115
+ const num = parseInt(right.text, 10);
116
+ if (op === ts.SyntaxKind.LessThanToken || op === ts.SyntaxKind.LessThanEqualsToken) {
117
+ return num >= 300 ? "positive" : "negative";
118
+ }
119
+ if (op === ts.SyntaxKind.GreaterThanToken || op === ts.SyntaxKind.GreaterThanEqualsToken) {
120
+ return num >= 400 ? "negative" : "positive";
121
+ }
122
+ }
123
+ }
124
+ }
125
+ }
126
+ return undefined;
127
+ }
128
+ function isBodyConsumptionDominatedByCheck(consumptionNode, resDeclNode, targetSymbol, targetName, scope, ts, checker) {
129
+ const isConst = (resDeclNode.parent.flags & ts.NodeFlags.Const) !== 0;
130
+ function isReassigned(startPos, endPos) {
131
+ if (isConst)
132
+ return false;
133
+ return hasVariableReassignment(scope, targetName, targetSymbol, ts, checker, endPos, startPos);
134
+ }
135
+ // 1. Ancestor branch checks
136
+ let curr = consumptionNode;
137
+ while (curr.parent && curr !== scope) {
138
+ const parent = curr.parent;
139
+ if (ts.isIfStatement(parent)) {
140
+ const expected = parent.thenStatement === curr ? "positive" : parent.elseStatement === curr ? "negative" : undefined;
141
+ if (expected && classifyStatusCheck(parent.expression, targetSymbol, targetName, ts, checker) === expected) {
142
+ if (!isReassigned(parent.getStart(), consumptionNode.getStart())) {
143
+ return true;
144
+ }
145
+ }
146
+ }
147
+ if (ts.isConditionalExpression(parent)) {
148
+ const expected = parent.whenTrue === curr ? "positive" : parent.whenFalse === curr ? "negative" : undefined;
149
+ if (expected && classifyStatusCheck(parent.condition, targetSymbol, targetName, ts, checker) === expected) {
150
+ return true;
151
+ }
152
+ }
153
+ if (ts.isCaseClause(parent)) {
154
+ const switchStmt = parent.parent?.parent;
155
+ if (switchStmt && ts.isSwitchStatement(switchStmt)) {
156
+ const switchExpr = unwrapExpression(switchStmt.expression, ts);
157
+ if (ts.isPropertyAccessExpression(switchExpr) &&
158
+ switchExpr.name.text === "status" &&
159
+ isMatchingTarget(switchExpr.expression, targetSymbol, targetName, ts, checker)) {
160
+ if (parent.expression && ts.isNumericLiteral(parent.expression)) {
161
+ const code = parseInt(parent.expression.text, 10);
162
+ if (code >= 200 && code < 300) {
163
+ return true;
164
+ }
165
+ }
166
+ }
167
+ }
168
+ }
169
+ curr = parent;
170
+ }
171
+ // 2. Preceding early-exit guard in enclosing statement block
172
+ let nodeToFindStmt = consumptionNode;
173
+ while (nodeToFindStmt.parent && nodeToFindStmt !== scope) {
174
+ const container = nodeToFindStmt.parent;
175
+ if (ts.isBlock(container) || ts.isSourceFile(container)) {
176
+ const stmts = container.statements;
177
+ let stmtContainingConsumption;
178
+ for (const s of stmts) {
179
+ if (consumptionNode.getStart() >= s.getStart() && consumptionNode.getEnd() <= s.getEnd()) {
180
+ stmtContainingConsumption = s;
181
+ break;
182
+ }
183
+ }
184
+ if (stmtContainingConsumption) {
185
+ const idx = stmts.indexOf(stmtContainingConsumption);
186
+ for (let i = 0; i < idx; i++) {
187
+ const prevStmt = stmts[i];
188
+ if (!prevStmt || prevStmt.getStart() < resDeclNode.getStart())
189
+ continue;
190
+ if (ts.isIfStatement(prevStmt)) {
191
+ const pol = classifyStatusCheck(prevStmt.expression, targetSymbol, targetName, ts, checker);
192
+ if (pol === "negative" && statementExitsControlFlow(prevStmt.thenStatement, ts) && !prevStmt.elseStatement) {
193
+ if (!isReassigned(prevStmt.getEnd(), consumptionNode.getStart())) {
194
+ return true;
195
+ }
196
+ }
197
+ }
198
+ }
199
+ }
200
+ }
201
+ nodeToFindStmt = container;
202
+ }
203
+ return false;
204
+ }
2
205
  export const fetchStatusUncheckedRule = {
3
206
  meta: {
4
207
  id: "network/fetch-status-unchecked",
@@ -12,83 +215,79 @@ export const fetchStatusUncheckedRule = {
12
215
  const { sourceFile, checker, ts } = context;
13
216
  if (!checker || !ts)
14
217
  return;
218
+ const typeChecker = checker;
219
+ const tsLib = ts;
15
220
  context.visitNodes((node) => {
16
- // Look for VariableDeclaration: const res = await fetch(...)
17
- if (!ts.isVariableDeclaration(node))
221
+ if (!tsLib.isVariableDeclaration(node))
18
222
  return;
19
- if (!ts.isIdentifier(node.name))
223
+ if (!tsLib.isIdentifier(node.name))
20
224
  return;
21
225
  const resVarName = node.name.text;
22
226
  const init = node.initializer;
23
227
  if (!init)
24
228
  return;
25
229
  let callExpr;
26
- if (ts.isAwaitExpression(init) && ts.isCallExpression(init.expression)) {
230
+ if (tsLib.isAwaitExpression(init) && tsLib.isCallExpression(init.expression)) {
27
231
  callExpr = init.expression;
28
232
  }
29
- else if (ts.isCallExpression(init)) {
233
+ else if (tsLib.isCallExpression(init)) {
30
234
  callExpr = init;
31
235
  }
32
236
  if (!callExpr)
33
237
  return;
34
- // Check if call target is global DOM fetch
35
238
  let isFetchCall = false;
36
- if (ts.isIdentifier(callExpr.expression) && callExpr.expression.text === "fetch") {
37
- if (isDOMGlobal(callExpr.expression, checker, "fetch")) {
239
+ if (tsLib.isIdentifier(callExpr.expression) && callExpr.expression.text === "fetch") {
240
+ if (isDOMGlobal(callExpr.expression, typeChecker, "fetch")) {
38
241
  isFetchCall = true;
39
242
  }
40
243
  }
41
- else if (ts.isPropertyAccessExpression(callExpr.expression) &&
244
+ else if (tsLib.isPropertyAccessExpression(callExpr.expression) &&
42
245
  callExpr.expression.name.text === "fetch" &&
43
- ts.isIdentifier(callExpr.expression.expression) &&
246
+ tsLib.isIdentifier(callExpr.expression.expression) &&
44
247
  (callExpr.expression.expression.text === "window" || callExpr.expression.expression.text === "globalThis")) {
45
248
  isFetchCall = true;
46
249
  }
47
250
  if (!isFetchCall)
48
251
  return;
49
- // Find enclosing block or function
252
+ const targetSymbol = typeChecker.getSymbolAtLocation(node.name);
50
253
  const scope = context.findEnclosingScope(node);
51
254
  if (!scope)
52
255
  return;
53
- let hasStatusCheck = false;
54
- let bodyConsumptionNode;
55
- // Walk scope to look for usages of resVarName
56
- function inspectScope(n) {
57
- // Check for res.ok or res.status access
58
- if (ts && ts.isPropertyAccessExpression(n)) {
59
- if (ts.isIdentifier(n.expression) && n.expression.text === resVarName) {
256
+ const bodyConsumptionNodes = [];
257
+ function collectConsumptions(n) {
258
+ if (tsLib.isPropertyAccessExpression(n)) {
259
+ if (isMatchingTarget(n.expression, targetSymbol, resVarName, tsLib, typeChecker)) {
60
260
  const prop = n.name.text;
61
- if (prop === "ok" || prop === "status" || prop === "statusText") {
62
- hasStatusCheck = true;
63
- }
64
- if (prop === "json" || prop === "text" || prop === "blob" || prop === "arrayBuffer" || prop === "formData") {
65
- bodyConsumptionNode = n;
261
+ if (BODY_CONSUMPTION_METHODS[prop]) {
262
+ bodyConsumptionNodes.push({ node: n, methodName: prop });
66
263
  }
67
264
  }
68
265
  }
69
- n.forEachChild(inspectScope);
70
- }
71
- inspectScope(scope);
72
- // If body was consumed but status was never checked in scope
73
- if (bodyConsumptionNode && !hasStatusCheck) {
74
- const range = getNodeSourceRange(bodyConsumptionNode, sourceFile);
75
- context.report({
76
- ruleId: "network/fetch-status-unchecked",
77
- category: "network",
78
- severity: "warning",
79
- confidence: "high",
80
- message: `Response body consumed via .${bodyConsumptionNode.name.text}() without checking response.ok or response.status.`,
81
- file: sourceFile.fileName,
82
- range,
83
- evidence: [
84
- {
85
- message: "fetch() does not reject on HTTP 4xx or 5xx status codes.",
86
- range,
87
- },
88
- ],
89
- suggestedAction: "Check `if (response.ok)` or verify `response.status` before consuming the response body.",
90
- safeAutomaticFix: false,
91
- });
266
+ n.forEachChild(collectConsumptions);
267
+ }
268
+ collectConsumptions(scope);
269
+ for (const consumption of bodyConsumptionNodes) {
270
+ const isDominated = isBodyConsumptionDominatedByCheck(consumption.node, node, targetSymbol, resVarName, scope, tsLib, typeChecker);
271
+ if (!isDominated) {
272
+ const range = getNodeSourceRange(consumption.node, sourceFile);
273
+ context.report({
274
+ ruleId: "network/fetch-status-unchecked",
275
+ category: "network",
276
+ severity: "warning",
277
+ confidence: "high",
278
+ message: `Response body consumed via .${consumption.methodName}() without checking response.ok or response.status.`,
279
+ file: sourceFile.fileName,
280
+ range,
281
+ evidence: [
282
+ {
283
+ message: "fetch() does not reject on HTTP 4xx or 5xx status codes.",
284
+ range,
285
+ },
286
+ ],
287
+ suggestedAction: "Check `if (response.ok)` or verify `response.status` before consuming the response body.",
288
+ safeAutomaticFix: false,
289
+ });
290
+ }
92
291
  }
93
292
  });
94
293
  },
@@ -1 +1 @@
1
- {"version":3,"file":"fetchStatusUnchecked.js","sourceRoot":"","sources":["../../../src/rules/network/fetchStatusUnchecked.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,WAAW,EAAE,MAAM,yBAAyB,CAAC;AAG1E,MAAM,CAAC,MAAM,wBAAwB,GAAS;IAC5C,IAAI,EAAE;QACJ,EAAE,EAAE,gCAAgC;QACpC,QAAQ,EAAE,SAAS;QACnB,eAAe,EAAE,SAAS;QAC1B,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,wFAAwF;QACrG,uBAAuB,EAAE,IAAI;KAC9B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,OAAO,IAAI,CAAC,EAAE;YAAE,OAAO;QAE5B,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,6DAA6D;YAC7D,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAC5C,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;gBAAE,OAAO;YACxC,MAAM,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;YAElC,MAAM,IAAI,GAAG,IAAI,CAAC,WAAW,CAAC;YAC9B,IAAI,CAAC,IAAI;gBAAE,OAAO;YAElB,IAAI,QAA2C,CAAC;YAChD,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;gBACvE,QAAQ,GAAG,IAAI,CAAC,UAAU,CAAC;YAC7B,CAAC;iBAAM,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrC,QAAQ,GAAG,IAAI,CAAC;YAClB,CAAC;YAED,IAAI,CAAC,QAAQ;gBAAE,OAAO;YAEtB,2CAA2C;YAC3C,IAAI,WAAW,GAAG,KAAK,CAAC;YACxB,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,QAAQ,CAAC,UAAU,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;gBACjF,IAAI,WAAW,CAAC,QAAQ,CAAC,UAAU,EAAE,OAAO,EAAE,OAAO,CAAC,EAAE,CAAC;oBACvD,WAAW,GAAG,IAAI,CAAC;gBACrB,CAAC;YACH,CAAC;iBAAM,IACL,EAAE,CAAC,0BAA0B,CAAC,QAAQ,CAAC,UAAU,CAAC;gBAClD,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,OAAO;gBACzC,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC;gBAC/C,CAAC,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,KAAK,QAAQ,IAAI,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,KAAK,YAAY,CAAC,EAC1G,CAAC;gBACD,WAAW,GAAG,IAAI,CAAC;YACrB,CAAC;YAED,IAAI,CAAC,WAAW;gBAAE,OAAO;YAEzB,mCAAmC;YACnC,MAAM,KAAK,GAAG,OAAO,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAC;YAC/C,IAAI,CAAC,KAAK;gBAAE,OAAO;YAEnB,IAAI,cAAc,GAAG,KAAK,CAAC;YAC3B,IAAI,mBAA4C,CAAC;YAEjD,8CAA8C;YAC9C,SAAS,YAAY,CAAC,CAAc;gBAClC,wCAAwC;gBACxC,IAAI,EAAE,IAAI,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,EAAE,CAAC;oBAC3C,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,UAAU,CAAC,IAAI,KAAK,UAAU,EAAE,CAAC;wBACtE,MAAM,IAAI,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;wBACzB,IAAI,IAAI,KAAK,IAAI,IAAI,IAAI,KAAK,QAAQ,IAAI,IAAI,KAAK,YAAY,EAAE,CAAC;4BAChE,cAAc,GAAG,IAAI,CAAC;wBACxB,CAAC;wBACD,IAAI,IAAI,KAAK,MAAM,IAAI,IAAI,KAAK,MAAM,IAAI,IAAI,KAAK,MAAM,IAAI,IAAI,KAAK,aAAa,IAAI,IAAI,KAAK,UAAU,EAAE,CAAC;4BAC3G,mBAAmB,GAAG,CAAC,CAAC;wBAC1B,CAAC;oBACH,CAAC;gBACH,CAAC;gBACD,CAAC,CAAC,YAAY,CAAC,YAAY,CAAC,CAAC;YAC/B,CAAC;YAED,YAAY,CAAC,KAAK,CAAC,CAAC;YAEpB,6DAA6D;YAC7D,IAAI,mBAAmB,IAAI,CAAC,cAAc,EAAE,CAAC;gBAC3C,MAAM,KAAK,GAAG,kBAAkB,CAAC,mBAAmB,EAAE,UAAU,CAAC,CAAC;gBAClE,OAAO,CAAC,MAAM,CAAC;oBACb,MAAM,EAAE,gCAAgC;oBACxC,QAAQ,EAAE,SAAS;oBACnB,QAAQ,EAAE,SAAS;oBACnB,UAAU,EAAE,MAAM;oBAClB,OAAO,EAAE,+BAAgC,mBAAuD,CAAC,IAAI,CAAC,IAAI,qDAAqD;oBAC/J,IAAI,EAAE,UAAU,CAAC,QAAQ;oBACzB,KAAK;oBACL,QAAQ,EAAE;wBACR;4BACE,OAAO,EAAE,0DAA0D;4BACnE,KAAK;yBACN;qBACF;oBACD,eAAe,EAAE,0FAA0F;oBAC3G,gBAAgB,EAAE,KAAK;iBACxB,CAAC,CAAC;YACL,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}
1
+ {"version":3,"file":"fetchStatusUnchecked.js","sourceRoot":"","sources":["../../../src/rules/network/fetchStatusUnchecked.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,WAAW,EAAE,MAAM,yBAAyB,CAAC;AAC1E,OAAO,EAAE,gBAAgB,EAAE,MAAM,0BAA0B,CAAC;AAC5D,OAAO,EAAE,uBAAuB,EAAE,yBAAyB,EAAE,MAAM,+BAA+B,CAAC;AAKnG,MAAM,wBAAwB,GAAyB;IACrD,IAAI,EAAE,IAAI;IACV,IAAI,EAAE,IAAI;IACV,IAAI,EAAE,IAAI;IACV,WAAW,EAAE,IAAI;IACjB,QAAQ,EAAE,IAAI;IACd,KAAK,EAAE,IAAI;CACZ,CAAC;AAEF,SAAS,gBAAgB,CACvB,IAAuB,EACvB,YAAuC,EACvC,UAAkB,EAClB,EAAiB,EACjB,OAA2B;IAE3B,MAAM,SAAS,GAAG,gBAAgB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;IAC7C,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,SAAS,CAAC;QAAE,OAAO,KAAK,CAAC;IAC9C,IAAI,YAAY,EAAE,CAAC;QACjB,IAAI,GAAG,GAAG,OAAO,CAAC,mBAAmB,CAAC,SAAS,CAAC,CAAC;QACjD,IAAI,GAAG,IAAI,CAAC,GAAG,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;YACpD,IAAI,CAAC;gBACH,GAAG,GAAG,OAAO,CAAC,gBAAgB,CAAC,GAAG,CAAC,CAAC;YACtC,CAAC;YAAC,MAAM,CAAC,CAAA,CAAC;QACZ,CAAC;QACD,OAAO,GAAG,KAAK,YAAY,CAAC;IAC9B,CAAC;IACD,OAAO,SAAS,CAAC,IAAI,KAAK,UAAU,CAAC;AACvC,CAAC;AAED,SAAS,mBAAmB,CAC1B,OAA0B,EAC1B,YAAuC,EACvC,UAAkB,EAClB,EAAiB,EACjB,OAA2B;IAE3B,MAAM,IAAI,GAAG,gBAAgB,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAE3C,yBAAyB;IACzB,IAAI,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,QAAQ,KAAK,EAAE,CAAC,UAAU,CAAC,gBAAgB,EAAE,CAAC;QACzF,MAAM,KAAK,GAAG,gBAAgB,CAAC,IAAI,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;QACjD,IAAI,EAAE,CAAC,0BAA0B,CAAC,KAAK,CAAC,IAAI,KAAK,CAAC,IAAI,CAAC,IAAI,KAAK,IAAI,EAAE,CAAC;YACrE,IAAI,gBAAgB,CAAC,KAAK,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;gBAC9E,OAAO,UAAU,CAAC;YACpB,CAAC;QACH,CAAC;IACH,CAAC;IAED,wBAAwB;IACxB,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,IAAI,EAAE,CAAC;QACnE,IAAI,gBAAgB,CAAC,IAAI,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;YAC7E,OAAO,UAAU,CAAC;QACpB,CAAC;IACH,CAAC;IAED,wBAAwB;IACxB,IAAI,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC,EAAE,CAAC;QAChC,MAAM,EAAE,GAAG,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC;QAEnC,4DAA4D;QAC5D,IAAI,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,uBAAuB,EAAE,CAAC;YACjD,MAAM,OAAO,GAAG,mBAAmB,CAAC,IAAI,CAAC,IAAI,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;YACtF,MAAM,QAAQ,GAAG,mBAAmB,CAAC,IAAI,CAAC,KAAK,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;YACxF,IAAI,OAAO,KAAK,UAAU,IAAI,QAAQ,KAAK,UAAU,EAAE,CAAC;gBACtD,OAAO,UAAU,CAAC;YACpB,CAAC;QACH,CAAC;QAED,2EAA2E;QAC3E,IAAI,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;YACrC,MAAM,OAAO,GAAG,mBAAmB,CAAC,IAAI,CAAC,IAAI,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;YACtF,MAAM,QAAQ,GAAG,mBAAmB,CAAC,IAAI,CAAC,KAAK,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;YACxF,IAAI,OAAO,KAAK,UAAU,IAAI,QAAQ,KAAK,UAAU,EAAE,CAAC;gBACtD,OAAO,UAAU,CAAC;YACpB,CAAC;QACH,CAAC;QAED,8CAA8C;QAC9C,IACE,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,iBAAiB;YACtC,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,uBAAuB;YAC5C,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,sBAAsB;YAC3C,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,4BAA4B,EACjD,CAAC;YACD,MAAM,IAAI,GAAG,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,iBAAiB,IAAI,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,uBAAuB,CAAC;YAEpG,MAAM,IAAI,GAAG,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YAC7C,MAAM,KAAK,GAAG,gBAAgB,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;YAE/C,IAAI,UAAuD,CAAC;YAC5D,IAAI,SAAwC,CAAC;YAE7C,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,gBAAgB,CAAC,IAAI,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;gBACpH,UAAU,GAAG,IAAI,CAAC;gBAClB,SAAS,GAAG,KAAK,CAAC;YACpB,CAAC;iBAAM,IAAI,EAAE,CAAC,0BAA0B,CAAC,KAAK,CAAC,IAAI,gBAAgB,CAAC,KAAK,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;gBAC7H,UAAU,GAAG,KAAK,CAAC;gBACnB,SAAS,GAAG,IAAI,CAAC;YACnB,CAAC;YAED,IAAI,UAAU,EAAE,CAAC;gBACf,IAAI,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,IAAI,EAAE,CAAC;oBAClC,IAAI,SAAS,IAAI,SAAS,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;wBAC9D,OAAO,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC;oBACxC,CAAC;oBACD,IAAI,SAAS,IAAI,SAAS,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,YAAY,EAAE,CAAC;wBAC/D,OAAO,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC;oBACxC,CAAC;gBACH,CAAC;gBAED,IAAI,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oBACtC,IAAI,SAAS,IAAI,EAAE,CAAC,gBAAgB,CAAC,SAAS,CAAC,EAAE,CAAC;wBAChD,MAAM,IAAI,GAAG,QAAQ,CAAC,SAAS,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;wBAC1C,IAAI,IAAI,IAAI,GAAG,IAAI,IAAI,GAAG,GAAG,EAAE,CAAC;4BAC9B,OAAO,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC;wBACxC,CAAC;wBACD,IAAI,IAAI,IAAI,GAAG,EAAE,CAAC;4BAChB,OAAO,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC;wBACxC,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QAED,kCAAkC;QAClC,IACE,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,aAAa;YAClC,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,mBAAmB;YACxC,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,gBAAgB;YACrC,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,sBAAsB,EAC3C,CAAC;YACD,MAAM,IAAI,GAAG,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YAC7C,MAAM,KAAK,GAAG,gBAAgB,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;YAC/C,IACE,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC;gBACnC,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,QAAQ;gBAC3B,gBAAgB,CAAC,IAAI,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,EACxE,CAAC;gBACD,IAAI,EAAE,CAAC,gBAAgB,CAAC,KAAK,CAAC,EAAE,CAAC;oBAC/B,MAAM,GAAG,GAAG,QAAQ,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;oBACrC,IAAI,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,aAAa,IAAI,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,mBAAmB,EAAE,CAAC;wBACnF,OAAO,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC;oBAC9C,CAAC;oBACD,IAAI,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,gBAAgB,IAAI,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC,sBAAsB,EAAE,CAAC;wBACzF,OAAO,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC;oBAC9C,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,iCAAiC,CACxC,eAA4B,EAC5B,WAAuC,EACvC,YAAuC,EACvC,UAAkB,EAClB,KAAkB,EAClB,EAAiB,EACjB,OAA2B;IAE3B,MAAM,OAAO,GAAG,CAAC,WAAW,CAAC,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IAEtE,SAAS,YAAY,CAAC,QAAgB,EAAE,MAAc;QACpD,IAAI,OAAO;YAAE,OAAO,KAAK,CAAC;QAC1B,OAAO,uBAAuB,CAAC,KAAK,EAAE,UAAU,EAAE,YAAY,EAAE,EAAE,EAAE,OAAO,EAAE,MAAM,EAAE,QAAQ,CAAC,CAAC;IACjG,CAAC;IAED,4BAA4B;IAC5B,IAAI,IAAI,GAAgB,eAAe,CAAC;IACxC,OAAO,IAAI,CAAC,MAAM,IAAI,IAAI,KAAK,KAAK,EAAE,CAAC;QACrC,MAAM,MAAM,GAAgB,IAAI,CAAC,MAAM,CAAC;QAExC,IAAI,EAAE,CAAC,aAAa,CAAC,MAAM,CAAC,EAAE,CAAC;YAC7B,MAAM,QAAQ,GAAG,MAAM,CAAC,aAAa,KAAK,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,MAAM,CAAC,aAAa,KAAK,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;YACrH,IAAI,QAAQ,IAAI,mBAAmB,CAAC,MAAM,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,KAAK,QAAQ,EAAE,CAAC;gBAC3G,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,QAAQ,EAAE,EAAE,eAAe,CAAC,QAAQ,EAAE,CAAC,EAAE,CAAC;oBACjE,OAAO,IAAI,CAAC;gBACd,CAAC;YACH,CAAC;QACH,CAAC;QAED,IAAI,EAAE,CAAC,uBAAuB,CAAC,MAAM,CAAC,EAAE,CAAC;YACvC,MAAM,QAAQ,GAAG,MAAM,CAAC,QAAQ,KAAK,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,MAAM,CAAC,SAAS,KAAK,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;YAC5G,IAAI,QAAQ,IAAI,mBAAmB,CAAC,MAAM,CAAC,SAAS,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,KAAK,QAAQ,EAAE,CAAC;gBAC1G,OAAO,IAAI,CAAC;YACd,CAAC;QACH,CAAC;QAED,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;YAC5B,MAAM,UAAU,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC;YACzC,IAAI,UAAU,IAAI,EAAE,CAAC,iBAAiB,CAAC,UAAU,CAAC,EAAE,CAAC;gBACnD,MAAM,UAAU,GAAG,gBAAgB,CAAC,UAAU,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;gBAC/D,IACE,EAAE,CAAC,0BAA0B,CAAC,UAAU,CAAC;oBACzC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,QAAQ;oBACjC,gBAAgB,CAAC,UAAU,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,EAC9E,CAAC;oBACD,IAAI,MAAM,CAAC,UAAU,IAAI,EAAE,CAAC,gBAAgB,CAAC,MAAM,CAAC,UAAU,CAAC,EAAE,CAAC;wBAChE,MAAM,IAAI,GAAG,QAAQ,CAAC,MAAM,CAAC,UAAU,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;wBAClD,IAAI,IAAI,IAAI,GAAG,IAAI,IAAI,GAAG,GAAG,EAAE,CAAC;4BAC9B,OAAO,IAAI,CAAC;wBACd,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QAED,IAAI,GAAG,MAAM,CAAC;IAChB,CAAC;IAED,6DAA6D;IAC7D,IAAI,cAAc,GAAgB,eAAe,CAAC;IAClD,OAAO,cAAc,CAAC,MAAM,IAAI,cAAc,KAAK,KAAK,EAAE,CAAC;QACzD,MAAM,SAAS,GAAgB,cAAc,CAAC,MAAM,CAAC;QACrD,IAAI,EAAE,CAAC,OAAO,CAAC,SAAS,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,SAAS,CAAC,EAAE,CAAC;YACxD,MAAM,KAAK,GAAG,SAAS,CAAC,UAAU,CAAC;YACnC,IAAI,yBAAuD,CAAC;YAC5D,KAAK,MAAM,CAAC,IAAI,KAAK,EAAE,CAAC;gBACtB,IAAI,eAAe,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC,QAAQ,EAAE,IAAI,eAAe,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC;oBACzF,yBAAyB,GAAG,CAAC,CAAC;oBAC9B,MAAM;gBACR,CAAC;YACH,CAAC;YAED,IAAI,yBAAyB,EAAE,CAAC;gBAC9B,MAAM,GAAG,GAAG,KAAK,CAAC,OAAO,CAAC,yBAAyB,CAAC,CAAC;gBACrD,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;oBAC7B,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;oBAC1B,IAAI,CAAC,QAAQ,IAAI,QAAQ,CAAC,QAAQ,EAAE,GAAG,WAAW,CAAC,QAAQ,EAAE;wBAAE,SAAS;oBAExE,IAAI,EAAE,CAAC,aAAa,CAAC,QAAQ,CAAC,EAAE,CAAC;wBAC/B,MAAM,GAAG,GAAG,mBAAmB,CAAC,QAAQ,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;wBAC5F,IAAI,GAAG,KAAK,UAAU,IAAI,yBAAyB,CAAC,QAAQ,CAAC,aAAa,EAAE,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,aAAa,EAAE,CAAC;4BAC3G,IAAI,CAAC,YAAY,CAAC,QAAQ,CAAC,MAAM,EAAE,EAAE,eAAe,CAAC,QAAQ,EAAE,CAAC,EAAE,CAAC;gCACjE,OAAO,IAAI,CAAC;4BACd,CAAC;wBACH,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QACD,cAAc,GAAG,SAAS,CAAC;IAC7B,CAAC;IAED,OAAO,KAAK,CAAC;AACf,CAAC;AAED,MAAM,CAAC,MAAM,wBAAwB,GAAS;IAC5C,IAAI,EAAE;QACJ,EAAE,EAAE,gCAAgC;QACpC,QAAQ,EAAE,SAAS;QACnB,eAAe,EAAE,SAAS;QAC1B,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,wFAAwF;QACrG,uBAAuB,EAAE,IAAI;KAC9B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,OAAO,IAAI,CAAC,EAAE;YAAE,OAAO;QAC5B,MAAM,WAAW,GAAG,OAAO,CAAC;QAC5B,MAAM,KAAK,GAAG,EAAE,CAAC;QAEjB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,KAAK,CAAC,qBAAqB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAC/C,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;gBAAE,OAAO;YAC3C,MAAM,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;YAElC,MAAM,IAAI,GAAG,IAAI,CAAC,WAAW,CAAC;YAC9B,IAAI,CAAC,IAAI;gBAAE,OAAO;YAElB,IAAI,QAA2C,CAAC;YAChD,IAAI,KAAK,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,gBAAgB,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;gBAC7E,QAAQ,GAAG,IAAI,CAAC,UAAU,CAAC;YAC7B,CAAC;iBAAM,IAAI,KAAK,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;gBACxC,QAAQ,GAAG,IAAI,CAAC;YAClB,CAAC;YAED,IAAI,CAAC,QAAQ;gBAAE,OAAO;YAEtB,IAAI,WAAW,GAAG,KAAK,CAAC;YACxB,IAAI,KAAK,CAAC,YAAY,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,QAAQ,CAAC,UAAU,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;gBACpF,IAAI,WAAW,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,OAAO,CAAC,EAAE,CAAC;oBAC3D,WAAW,GAAG,IAAI,CAAC;gBACrB,CAAC;YACH,CAAC;iBAAM,IACL,KAAK,CAAC,0BAA0B,CAAC,QAAQ,CAAC,UAAU,CAAC;gBACrD,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,OAAO;gBACzC,KAAK,CAAC,YAAY,CAAC,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC;gBAClD,CAAC,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,KAAK,QAAQ,IAAI,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,KAAK,YAAY,CAAC,EAC1G,CAAC;gBACD,WAAW,GAAG,IAAI,CAAC;YACrB,CAAC;YAED,IAAI,CAAC,WAAW;gBAAE,OAAO;YAEzB,MAAM,YAAY,GAAG,WAAW,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAEhE,MAAM,KAAK,GAAG,OAAO,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAC;YAC/C,IAAI,CAAC,KAAK;gBAAE,OAAO;YAEnB,MAAM,oBAAoB,GAAqD,EAAE,CAAC;YAElF,SAAS,mBAAmB,CAAC,CAAc;gBACzC,IAAI,KAAK,CAAC,0BAA0B,CAAC,CAAC,CAAC,EAAE,CAAC;oBACxC,IAAI,gBAAgB,CAAC,CAAC,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,EAAE,KAAK,EAAE,WAAW,CAAC,EAAE,CAAC;wBACjF,MAAM,IAAI,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;wBACzB,IAAI,wBAAwB,CAAC,IAAI,CAAC,EAAE,CAAC;4BACnC,oBAAoB,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC,CAAC;wBAC3D,CAAC;oBACH,CAAC;gBACH,CAAC;gBACD,CAAC,CAAC,YAAY,CAAC,mBAAmB,CAAC,CAAC;YACtC,CAAC;YAED,mBAAmB,CAAC,KAAK,CAAC,CAAC;YAE3B,KAAK,MAAM,WAAW,IAAI,oBAAoB,EAAE,CAAC;gBAC/C,MAAM,WAAW,GAAG,iCAAiC,CACnD,WAAW,CAAC,IAAI,EAChB,IAAI,EACJ,YAAY,EACZ,UAAU,EACV,KAAK,EACL,KAAK,EACL,WAAW,CACZ,CAAC;gBAEF,IAAI,CAAC,WAAW,EAAE,CAAC;oBACjB,MAAM,KAAK,GAAG,kBAAkB,CAAC,WAAW,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;oBAC/D,OAAO,CAAC,MAAM,CAAC;wBACb,MAAM,EAAE,gCAAgC;wBACxC,QAAQ,EAAE,SAAS;wBACnB,QAAQ,EAAE,SAAS;wBACnB,UAAU,EAAE,MAAM;wBAClB,OAAO,EAAE,+BAA+B,WAAW,CAAC,UAAU,qDAAqD;wBACnH,IAAI,EAAE,UAAU,CAAC,QAAQ;wBACzB,KAAK;wBACL,QAAQ,EAAE;4BACR;gCACE,OAAO,EAAE,0DAA0D;gCACnE,KAAK;6BACN;yBACF;wBACD,eAAe,EAAE,0FAA0F;wBAC3G,gBAAgB,EAAE,KAAK;qBACxB,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"asyncEffectCallback.d.ts","sourceRoot":"","sources":["../../../src/rules/react/asyncEffectCallback.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,uBAAuB,EAAE,IA8DrC,CAAC"}
1
+ {"version":3,"file":"asyncEffectCallback.d.ts","sourceRoot":"","sources":["../../../src/rules/react/asyncEffectCallback.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,uBAAuB,EAAE,IAuDrC,CAAC"}
@@ -1,4 +1,4 @@
1
- import { getNodeSourceRange, resolveReactHook } from "../../engine/symbols.js";
1
+ import { getNodeSourceRange, isReactLifecycleHookCall } from "../../engine/symbols.js";
2
2
  export const asyncEffectCallbackRule = {
3
3
  meta: {
4
4
  id: "react/async-effect-callback",
@@ -15,14 +15,7 @@ export const asyncEffectCallbackRule = {
15
15
  context.visitNodes((node) => {
16
16
  if (!ts.isCallExpression(node))
17
17
  return;
18
- let isEffectHook = false;
19
- if (checker && (resolveReactHook(node, checker, "useEffect") || resolveReactHook(node, checker, "useLayoutEffect"))) {
20
- isEffectHook = true;
21
- }
22
- else if (ts.isIdentifier(node.expression) && (node.expression.text === "useEffect" || node.expression.text === "useLayoutEffect")) {
23
- isEffectHook = true;
24
- }
25
- if (!isEffectHook)
18
+ if (!isReactLifecycleHookCall(node, ts, checker))
26
19
  return;
27
20
  const args = node.arguments;
28
21
  if (!args || args.length === 0)
@@ -1 +1 @@
1
- {"version":3,"file":"asyncEffectCallback.js","sourceRoot":"","sources":["../../../src/rules/react/asyncEffectCallback.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAG/E,MAAM,CAAC,MAAM,uBAAuB,GAAS;IAC3C,IAAI,EAAE;QACJ,EAAE,EAAE,6BAA6B;QACjC,QAAQ,EAAE,OAAO;QACjB,eAAe,EAAE,OAAO;QACxB,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,uEAAuE;QACpF,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,YAAY,GAAG,KAAK,CAAC;YACzB,IAAI,OAAO,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,IAAI,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC,EAAE,CAAC;gBACpH,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;iBAAM,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,WAAW,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,iBAAiB,CAAC,EAAE,CAAC;gBACpI,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;YAED,IAAI,CAAC,YAAY;gBAAE,OAAO;YAE1B,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;YAC5B,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,IAAI,CAAC,QAAQ;gBAAE,OAAO;YACtB,IAAI,OAAO,GAAG,KAAK,CAAC;YAEpB,IAAI,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACtE,IAAI,QAAQ,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,YAAY,CAAC,EAAE,CAAC;oBAC3E,OAAO,GAAG,IAAI,CAAC;gBACjB,CAAC;YACH,CAAC;YAED,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,KAAK,GAAG,kBAAkB,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;gBACvD,OAAO,CAAC,MAAM,CAAC;oBACb,MAAM,EAAE,6BAA6B;oBACrC,QAAQ,EAAE,OAAO;oBACjB,QAAQ,EAAE,OAAO;oBACjB,UAAU,EAAE,MAAM;oBAClB,OAAO,EAAE,sDAAsD;oBAC/D,IAAI,EAAE,UAAU,CAAC,QAAQ;oBACzB,KAAK;oBACL,QAAQ,EAAE;wBACR;4BACE,OAAO,EAAE,kIAAkI;4BAC3I,KAAK;yBACN;qBACF;oBACD,eAAe,EACb,uIAAuI;oBACzI,gBAAgB,EAAE,KAAK;iBACxB,CAAC,CAAC;YACL,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}
1
+ {"version":3,"file":"asyncEffectCallback.js","sourceRoot":"","sources":["../../../src/rules/react/asyncEffectCallback.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,wBAAwB,EAAE,MAAM,yBAAyB,CAAC;AAGvF,MAAM,CAAC,MAAM,uBAAuB,GAAS;IAC3C,IAAI,EAAE;QACJ,EAAE,EAAE,6BAA6B;QACjC,QAAQ,EAAE,OAAO;QACjB,eAAe,EAAE,OAAO;QACxB,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,uEAAuE;QACpF,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,CAAC,wBAAwB,CAAC,IAAI,EAAE,EAAE,EAAE,OAAO,CAAC;gBAAE,OAAO;YAEzD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;YAC5B,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,IAAI,CAAC,QAAQ;gBAAE,OAAO;YACtB,IAAI,OAAO,GAAG,KAAK,CAAC;YAEpB,IAAI,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACtE,IAAI,QAAQ,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,YAAY,CAAC,EAAE,CAAC;oBAC3E,OAAO,GAAG,IAAI,CAAC;gBACjB,CAAC;YACH,CAAC;YAED,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,KAAK,GAAG,kBAAkB,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;gBACvD,OAAO,CAAC,MAAM,CAAC;oBACb,MAAM,EAAE,6BAA6B;oBACrC,QAAQ,EAAE,OAAO;oBACjB,QAAQ,EAAE,OAAO;oBACjB,UAAU,EAAE,MAAM;oBAClB,OAAO,EAAE,sDAAsD;oBAC/D,IAAI,EAAE,UAAU,CAAC,QAAQ;oBACzB,KAAK;oBACL,QAAQ,EAAE;wBACR;4BACE,OAAO,EAAE,kIAAkI;4BAC3I,KAAK;yBACN;qBACF;oBACD,eAAe,EACb,uIAAuI;oBACzI,gBAAgB,EAAE,KAAK;iBACxB,CAAC,CAAC;YACL,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"derivedStateEffect.d.ts","sourceRoot":"","sources":["../../../src/rules/react/derivedStateEffect.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AA0D7D,eAAO,MAAM,sBAAsB,EAAE,IAkIpC,CAAC"}
1
+ {"version":3,"file":"derivedStateEffect.d.ts","sourceRoot":"","sources":["../../../src/rules/react/derivedStateEffect.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AA0D7D,eAAO,MAAM,sBAAsB,EAAE,IA2HpC,CAAC"}
@@ -1,4 +1,4 @@
1
- import { getNodeSourceRange, resolveReactHook } from "../../engine/symbols.js";
1
+ import { getNodeSourceRange, isReactLifecycleHookCall } from "../../engine/symbols.js";
2
2
  import { isResetValue, resolveConstantValue, unwrapExpression } from "../../analysis/values.js";
3
3
  /**
4
4
  * Collects all identifier names referenced within an AST node, following local const variable initializers.
@@ -64,14 +64,7 @@ export const derivedStateEffectRule = {
64
64
  context.visitNodes((node) => {
65
65
  if (!ts.isCallExpression(node))
66
66
  return;
67
- let isEffectHook = false;
68
- if (checker && (resolveReactHook(node, checker, "useEffect") || resolveReactHook(node, checker, "useLayoutEffect"))) {
69
- isEffectHook = true;
70
- }
71
- else if (ts.isIdentifier(node.expression) && (node.expression.text === "useEffect" || node.expression.text === "useLayoutEffect")) {
72
- isEffectHook = true;
73
- }
74
- if (!isEffectHook)
67
+ if (!isReactLifecycleHookCall(node, ts, checker))
75
68
  return;
76
69
  const args = node.arguments;
77
70
  if (!args || args.length === 0)
@@ -1 +1 @@
1
- {"version":3,"file":"derivedStateEffect.js","sourceRoot":"","sources":["../../../src/rules/react/derivedStateEffect.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC/E,OAAO,EAAE,YAAY,EAAE,oBAAoB,EAAE,gBAAgB,EAAE,MAAM,0BAA0B,CAAC;AAGhG;;GAEG;AACH,SAAS,4BAA4B,CACnC,IAAiB,EACjB,EAAiB,EACjB,OAAwC;IAExC,MAAM,KAAK,GAAG,IAAI,GAAG,EAAU,CAAC;IAChC,MAAM,cAAc,GAAG,IAAI,GAAG,EAAiB,CAAC;IAEhD,SAAS,IAAI,CAAC,CAAc;QAC1B,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YACvB,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;YAClB,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,GAAG,GAAG,OAAO,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAC;gBAC3C,IAAI,GAAG,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;oBACpC,cAAc,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;oBACxB,MAAM,IAAI,GAAG,GAAG,CAAC,gBAAgB,IAAI,GAAG,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC;oBAC3D,IAAI,IAAI,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;wBAC/D,IAAI,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;oBACzB,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QACD,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC;IACvB,CAAC;IACD,IAAI,CAAC,IAAI,CAAC,CAAC;IACX,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;GAEG;AACH,SAAS,sBAAsB,CAAC,OAA0B,EAAE,EAAiB;IAC3E,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;IACnC,MAAM,SAAS,GAAG,gBAAgB,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAEhD,IAAI,EAAE,CAAC,wBAAwB,CAAC,SAAS,CAAC,EAAE,CAAC;QAC3C,KAAK,MAAM,IAAI,IAAI,SAAS,CAAC,QAAQ,EAAE,CAAC;YACtC,MAAM,CAAC,GAAG,gBAAgB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YACrC,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC;gBACvB,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;YACvB,CAAC;iBAAM,IAAI,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,EAAE,CAAC;gBAC5C,kDAAkD;gBAClD,MAAM,IAAI,GAAG,gBAAgB,CAAC,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;gBAChD,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC1B,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBAC1B,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,MAAM,CAAC,MAAM,sBAAsB,GAAS;IAC1C,IAAI,EAAE;QACJ,EAAE,EAAE,4BAA4B;QAChC,QAAQ,EAAE,OAAO;QACjB,eAAe,EAAE,SAAS;QAC1B,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,sEAAsE;QACnF,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,YAAY,GAAG,KAAK,CAAC;YACzB,IAAI,OAAO,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,IAAI,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC,EAAE,CAAC;gBACpH,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;iBAAM,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,WAAW,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,iBAAiB,CAAC,EAAE,CAAC;gBACpI,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;YAED,IAAI,CAAC,YAAY;gBAAE,OAAO;YAE1B,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;YAC5B,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,IAAI,CAAC,QAAQ,IAAI,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;gBACvF,OAAO;YACT,CAAC;YAED,oCAAoC;YACpC,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,CAAC;YAC3B,IAAI,cAAiD,CAAC;YACtD,IAAI,UAAU,GAAG,EAAE,CAAC;YAEpB,IAAI,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrB,MAAM,KAAK,GAAG,IAAI,CAAC,UAAU,CAAC;gBAC9B,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;oBACzE,MAAM,IAAI,GAAG,gBAAgB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;oBACvD,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;wBAClE,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC;wBACpC,IAAI,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;4BAC7B,cAAc,GAAG,IAAI,CAAC;4BACtB,UAAU,GAAG,MAAM,CAAC;wBACtB,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;iBAAM,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrC,MAAM,aAAa,GAAG,gBAAgB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;gBACjD,IAAI,EAAE,CAAC,gBAAgB,CAAC,aAAa,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,aAAa,CAAC,UAAU,CAAC,EAAE,CAAC;oBACpF,MAAM,MAAM,GAAG,aAAa,CAAC,UAAU,CAAC,IAAI,CAAC;oBAC7C,IAAI,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;wBAC7B,cAAc,GAAG,aAAa,CAAC;wBAC/B,UAAU,GAAG,MAAM,CAAC;oBACtB,CAAC;gBACH,CAAC;YACH,CAAC;YAED,IAAI,CAAC,cAAc;gBAAE,OAAO;YAE5B,MAAM,UAAU,GAAG,cAAc,CAAC,SAAS,CAAC;YAC5C,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEpC,MAAM,SAAS,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC;YAChC,IAAI,CAAC,SAAS;gBAAE,OAAO;YAEvB,kEAAkE;YAClE,MAAM,YAAY,GAAG,gBAAgB,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC;YACrD,IAAI,EAAE,CAAC,eAAe,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,YAAY,CAAC,EAAE,CAAC;gBAC9E,OAAO;YACT,CAAC;YAED,4HAA4H;YAC5H,IAAI,YAAY,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;gBAC5C,OAAO;YACT,CAAC;YAED,iFAAiF;YACjF,MAAM,WAAW,GAAG,oBAAoB,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;YACpE,IAAI,WAAW,CAAC,QAAQ,EAAE,CAAC;gBACzB,OAAO;YACT,CAAC;YAED,oIAAoI;YACpI,MAAM,OAAO,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACxB,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,IAAI,GAAG,sBAAsB,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;gBACjD,MAAM,eAAe,GAAG,4BAA4B,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;gBAEhF,wFAAwF;gBACxF,IAAI,qBAAqB,GAAG,KAAK,CAAC;gBAClC,KAAK,MAAM,GAAG,IAAI,eAAe,EAAE,CAAC;oBAClC,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;wBAClB,qBAAqB,GAAG,IAAI,CAAC;wBAC7B,MAAM;oBACR,CAAC;gBACH,CAAC;gBAED,+FAA+F;gBAC/F,uCAAuC;gBACvC,IAAI,CAAC,qBAAqB,IAAI,IAAI,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;oBAC5C,OAAO;gBACT,CAAC;YACH,CAAC;YAED,MAAM,KAAK,GAAG,kBAAkB,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;YACnD,OAAO,CAAC,MAAM,CAAC;gBACb,MAAM,EAAE,4BAA4B;gBACpC,QAAQ,EAAE,OAAO;gBACjB,QAAQ,EAAE,SAAS;gBACnB,UAAU,EAAE,MAAM;gBAClB,OAAO,EAAE,iBAAiB,UAAU,+DAA+D;gBACnG,IAAI,EAAE,UAAU,CAAC,QAAQ;gBACzB,KAAK;gBACL,QAAQ,EAAE;oBACR;wBACE,OAAO,EAAE,iGAAiG;wBAC1G,KAAK;qBACN;iBACF;gBACD,eAAe,EACb,gHAAgH;gBAClH,gBAAgB,EAAE,KAAK;aACxB,CAAC,CAAC;QACL,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}
1
+ {"version":3,"file":"derivedStateEffect.js","sourceRoot":"","sources":["../../../src/rules/react/derivedStateEffect.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,wBAAwB,EAAE,MAAM,yBAAyB,CAAC;AACvF,OAAO,EAAE,YAAY,EAAE,oBAAoB,EAAE,gBAAgB,EAAE,MAAM,0BAA0B,CAAC;AAGhG;;GAEG;AACH,SAAS,4BAA4B,CACnC,IAAiB,EACjB,EAAiB,EACjB,OAAwC;IAExC,MAAM,KAAK,GAAG,IAAI,GAAG,EAAU,CAAC;IAChC,MAAM,cAAc,GAAG,IAAI,GAAG,EAAiB,CAAC;IAEhD,SAAS,IAAI,CAAC,CAAc;QAC1B,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YACvB,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;YAClB,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,GAAG,GAAG,OAAO,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAC;gBAC3C,IAAI,GAAG,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;oBACpC,cAAc,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;oBACxB,MAAM,IAAI,GAAG,GAAG,CAAC,gBAAgB,IAAI,GAAG,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC;oBAC3D,IAAI,IAAI,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;wBAC/D,IAAI,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;oBACzB,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QACD,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC;IACvB,CAAC;IACD,IAAI,CAAC,IAAI,CAAC,CAAC;IACX,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;GAEG;AACH,SAAS,sBAAsB,CAAC,OAA0B,EAAE,EAAiB;IAC3E,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;IACnC,MAAM,SAAS,GAAG,gBAAgB,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAEhD,IAAI,EAAE,CAAC,wBAAwB,CAAC,SAAS,CAAC,EAAE,CAAC;QAC3C,KAAK,MAAM,IAAI,IAAI,SAAS,CAAC,QAAQ,EAAE,CAAC;YACtC,MAAM,CAAC,GAAG,gBAAgB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YACrC,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC;gBACvB,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;YACvB,CAAC;iBAAM,IAAI,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,EAAE,CAAC;gBAC5C,kDAAkD;gBAClD,MAAM,IAAI,GAAG,gBAAgB,CAAC,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;gBAChD,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC1B,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBAC1B,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,MAAM,CAAC,MAAM,sBAAsB,GAAS;IAC1C,IAAI,EAAE;QACJ,EAAE,EAAE,4BAA4B;QAChC,QAAQ,EAAE,OAAO;QACjB,eAAe,EAAE,SAAS;QAC1B,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,sEAAsE;QACnF,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,CAAC,wBAAwB,CAAC,IAAI,EAAE,EAAE,EAAE,OAAO,CAAC;gBAAE,OAAO;YAEzD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;YAC5B,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,IAAI,CAAC,QAAQ,IAAI,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;gBACvF,OAAO;YACT,CAAC;YAED,oCAAoC;YACpC,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,CAAC;YAC3B,IAAI,cAAiD,CAAC;YACtD,IAAI,UAAU,GAAG,EAAE,CAAC;YAEpB,IAAI,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrB,MAAM,KAAK,GAAG,IAAI,CAAC,UAAU,CAAC;gBAC9B,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;oBACzE,MAAM,IAAI,GAAG,gBAAgB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;oBACvD,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;wBAClE,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC;wBACpC,IAAI,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;4BAC7B,cAAc,GAAG,IAAI,CAAC;4BACtB,UAAU,GAAG,MAAM,CAAC;wBACtB,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;iBAAM,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrC,MAAM,aAAa,GAAG,gBAAgB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;gBACjD,IAAI,EAAE,CAAC,gBAAgB,CAAC,aAAa,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,aAAa,CAAC,UAAU,CAAC,EAAE,CAAC;oBACpF,MAAM,MAAM,GAAG,aAAa,CAAC,UAAU,CAAC,IAAI,CAAC;oBAC7C,IAAI,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;wBAC7B,cAAc,GAAG,aAAa,CAAC;wBAC/B,UAAU,GAAG,MAAM,CAAC;oBACtB,CAAC;gBACH,CAAC;YACH,CAAC;YAED,IAAI,CAAC,cAAc;gBAAE,OAAO;YAE5B,MAAM,UAAU,GAAG,cAAc,CAAC,SAAS,CAAC;YAC5C,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEpC,MAAM,SAAS,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC;YAChC,IAAI,CAAC,SAAS;gBAAE,OAAO;YAEvB,kEAAkE;YAClE,MAAM,YAAY,GAAG,gBAAgB,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC;YACrD,IAAI,EAAE,CAAC,eAAe,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,YAAY,CAAC,EAAE,CAAC;gBAC9E,OAAO;YACT,CAAC;YAED,4HAA4H;YAC5H,IAAI,YAAY,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;gBAC5C,OAAO;YACT,CAAC;YAED,iFAAiF;YACjF,MAAM,WAAW,GAAG,oBAAoB,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;YACpE,IAAI,WAAW,CAAC,QAAQ,EAAE,CAAC;gBACzB,OAAO;YACT,CAAC;YAED,oIAAoI;YACpI,MAAM,OAAO,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACxB,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,IAAI,GAAG,sBAAsB,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;gBACjD,MAAM,eAAe,GAAG,4BAA4B,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;gBAEhF,wFAAwF;gBACxF,IAAI,qBAAqB,GAAG,KAAK,CAAC;gBAClC,KAAK,MAAM,GAAG,IAAI,eAAe,EAAE,CAAC;oBAClC,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;wBAClB,qBAAqB,GAAG,IAAI,CAAC;wBAC7B,MAAM;oBACR,CAAC;gBACH,CAAC;gBAED,+FAA+F;gBAC/F,uCAAuC;gBACvC,IAAI,CAAC,qBAAqB,IAAI,IAAI,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;oBAC5C,OAAO;gBACT,CAAC;YACH,CAAC;YAED,MAAM,KAAK,GAAG,kBAAkB,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;YACnD,OAAO,CAAC,MAAM,CAAC;gBACb,MAAM,EAAE,4BAA4B;gBACpC,QAAQ,EAAE,OAAO;gBACjB,QAAQ,EAAE,SAAS;gBACnB,UAAU,EAAE,MAAM;gBAClB,OAAO,EAAE,iBAAiB,UAAU,+DAA+D;gBACnG,IAAI,EAAE,UAAU,CAAC,QAAQ;gBACzB,KAAK;gBACL,QAAQ,EAAE;oBACR;wBACE,OAAO,EAAE,iGAAiG;wBAC1G,KAAK;qBACN;iBACF;gBACD,eAAe,EACb,gHAAgH;gBAClH,gBAAgB,EAAE,KAAK;aACxB,CAAC,CAAC;QACL,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"missingEffectCleanup.d.ts","sourceRoot":"","sources":["../../../src/rules/react/missingEffectCleanup.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,wBAAwB,EAAE,IA8FtC,CAAC"}
1
+ {"version":3,"file":"missingEffectCleanup.d.ts","sourceRoot":"","sources":["../../../src/rules/react/missingEffectCleanup.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AA4G7D,eAAO,MAAM,wBAAwB,EAAE,IAiGtC,CAAC"}
@@ -1,4 +1,94 @@
1
- import { getNodeSourceRange, resolveReactHook } from "../../engine/symbols.js";
1
+ import { getNodeSourceRange, isReactLifecycleHookCall } from "../../engine/symbols.js";
2
+ function unwrapParentheses(expr, ts) {
3
+ let cur = expr;
4
+ while (ts.isParenthesizedExpression(cur)) {
5
+ cur = cur.expression;
6
+ }
7
+ return cur;
8
+ }
9
+ /**
10
+ * Determines whether a returned expression is a valid, callable cleanup callback.
11
+ * Arbitrary primitives, objects, or non-callable values do not satisfy cleanup.
12
+ */
13
+ function isCallableCleanupExpression(rawExpr, ts, checker, scopeNode) {
14
+ const expr = unwrapParentheses(rawExpr, ts);
15
+ if (ts.isArrowFunction(expr) || ts.isFunctionExpression(expr)) {
16
+ return true;
17
+ }
18
+ if (ts.isConditionalExpression(expr)) {
19
+ return (isCallableCleanupExpression(expr.whenTrue, ts, checker, scopeNode) ||
20
+ isCallableCleanupExpression(expr.whenFalse, ts, checker, scopeNode));
21
+ }
22
+ if (checker) {
23
+ const type = checker.getTypeAtLocation(expr);
24
+ if (type) {
25
+ if (type.getCallSignatures().length > 0) {
26
+ return true;
27
+ }
28
+ if (type.isUnion() && type.types.some((t) => t.getCallSignatures().length > 0)) {
29
+ return true;
30
+ }
31
+ }
32
+ const symbol = checker.getSymbolAtLocation(expr);
33
+ if (symbol) {
34
+ let resolvedSym = symbol;
35
+ if ((resolvedSym.flags & ts.SymbolFlags.Alias) !== 0) {
36
+ try {
37
+ resolvedSym = checker.getAliasedSymbol(resolvedSym);
38
+ }
39
+ catch {
40
+ // ignore
41
+ }
42
+ }
43
+ const decls = resolvedSym.getDeclarations();
44
+ if (decls) {
45
+ for (const decl of decls) {
46
+ if (ts.isFunctionDeclaration(decl) || ts.isFunctionExpression(decl) || ts.isArrowFunction(decl)) {
47
+ return true;
48
+ }
49
+ if (ts.isVariableDeclaration(decl) && decl.initializer) {
50
+ const init = unwrapParentheses(decl.initializer, ts);
51
+ if (ts.isArrowFunction(init) || ts.isFunctionExpression(init)) {
52
+ return true;
53
+ }
54
+ const initType = checker.getTypeAtLocation(init);
55
+ if (initType && initType.getCallSignatures().length > 0) {
56
+ return true;
57
+ }
58
+ }
59
+ }
60
+ }
61
+ }
62
+ }
63
+ // AST-based fallback within the effect scope when checker is unavailable or symbol is local
64
+ if (ts.isIdentifier(expr) && scopeNode) {
65
+ const targetName = expr.text;
66
+ let foundCallable = false;
67
+ function checkScope(node) {
68
+ if (foundCallable)
69
+ return;
70
+ if (ts.isFunctionDeclaration(node) && node.name && node.name.text === targetName) {
71
+ foundCallable = true;
72
+ return;
73
+ }
74
+ if (ts.isVariableDeclaration(node) &&
75
+ ts.isIdentifier(node.name) &&
76
+ node.name.text === targetName &&
77
+ node.initializer) {
78
+ const init = unwrapParentheses(node.initializer, ts);
79
+ if (ts.isArrowFunction(init) || ts.isFunctionExpression(init)) {
80
+ foundCallable = true;
81
+ return;
82
+ }
83
+ }
84
+ node.forEachChild(checkScope);
85
+ }
86
+ checkScope(scopeNode);
87
+ if (foundCallable)
88
+ return true;
89
+ }
90
+ return false;
91
+ }
2
92
  export const missingEffectCleanupRule = {
3
93
  meta: {
4
94
  id: "react/missing-effect-cleanup",
@@ -15,14 +105,7 @@ export const missingEffectCleanupRule = {
15
105
  context.visitNodes((node) => {
16
106
  if (!ts.isCallExpression(node))
17
107
  return;
18
- let isEffectHook = false;
19
- if (checker && (resolveReactHook(node, checker, "useEffect") || resolveReactHook(node, checker, "useLayoutEffect"))) {
20
- isEffectHook = true;
21
- }
22
- else if (ts.isIdentifier(node.expression) && (node.expression.text === "useEffect" || node.expression.text === "useLayoutEffect")) {
23
- isEffectHook = true;
24
- }
25
- if (!isEffectHook)
108
+ if (!isReactLifecycleHookCall(node, ts, checker))
26
109
  return;
27
110
  const args = node.arguments;
28
111
  if (!args || args.length === 0)
@@ -31,8 +114,15 @@ export const missingEffectCleanupRule = {
31
114
  if (!callback || (!ts.isArrowFunction(callback) && !ts.isFunctionExpression(callback))) {
32
115
  return;
33
116
  }
117
+ const callbackBody = callback.body;
34
118
  const subscriptions = [];
35
119
  let hasCleanupReturn = false;
120
+ // Check concise arrow body: useEffect(() => () => socket.close(), [])
121
+ if (!ts.isBlock(callbackBody)) {
122
+ if (isCallableCleanupExpression(callbackBody, ts, checker, callbackBody)) {
123
+ hasCleanupReturn = true;
124
+ }
125
+ }
36
126
  function inspectEffectBody(n) {
37
127
  // Look for: new WebSocket(...), new EventSource(...), new BroadcastChannel(...)
38
128
  if (ts && ts.isNewExpression(n) && ts.isIdentifier(n.expression)) {
@@ -50,7 +140,9 @@ export const missingEffectCleanupRule = {
50
140
  }
51
141
  // Check for return statement
52
142
  if (ts && ts.isReturnStatement(n) && n.expression) {
53
- hasCleanupReturn = true;
143
+ if (isCallableCleanupExpression(n.expression, ts, checker, callbackBody)) {
144
+ hasCleanupReturn = true;
145
+ }
54
146
  }
55
147
  if (ts && n !== callback && (ts.isFunctionDeclaration(n) || ts.isArrowFunction(n) || ts.isFunctionExpression(n))) {
56
148
  return;
@@ -1 +1 @@
1
- {"version":3,"file":"missingEffectCleanup.js","sourceRoot":"","sources":["../../../src/rules/react/missingEffectCleanup.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAG/E,MAAM,CAAC,MAAM,wBAAwB,GAAS;IAC5C,IAAI,EAAE;QACJ,EAAE,EAAE,8BAA8B;QAClC,QAAQ,EAAE,OAAO;QACjB,eAAe,EAAE,SAAS;QAC1B,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,+EAA+E;QAC5F,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,YAAY,GAAG,KAAK,CAAC;YACzB,IAAI,OAAO,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,IAAI,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC,EAAE,CAAC;gBACpH,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;iBAAM,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,WAAW,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,iBAAiB,CAAC,EAAE,CAAC;gBACpI,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;YAED,IAAI,CAAC,YAAY;gBAAE,OAAO;YAE1B,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;YAC5B,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,IAAI,CAAC,QAAQ,IAAI,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;gBACvF,OAAO;YACT,CAAC;YAED,MAAM,aAAa,GAA+C,EAAE,CAAC;YACrE,IAAI,gBAAgB,GAAG,KAAK,CAAC;YAE7B,SAAS,iBAAiB,CAAC,CAAc;gBACvC,gFAAgF;gBAChF,IAAI,EAAE,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC;oBACjE,MAAM,SAAS,GAAG,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC;oBACpC,IAAI,SAAS,KAAK,WAAW,IAAI,SAAS,KAAK,aAAa,IAAI,SAAS,KAAK,kBAAkB,EAAE,CAAC;wBACjG,aAAa,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,CAAC;oBACnD,CAAC;gBACH,CAAC;gBAED,kCAAkC;gBAClC,IACE,EAAE;oBACF,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC;oBACtB,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,UAAU,CAAC;oBAC3C,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,WAAW,EACtC,CAAC;oBACD,aAAa,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,IAAI,EAAE,cAAc,EAAE,CAAC,CAAC;gBACxD,CAAC;gBAED,6BAA6B;gBAC7B,IAAI,EAAE,IAAI,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,CAAC;oBAClD,gBAAgB,GAAG,IAAI,CAAC;gBAC1B,CAAC;gBAED,IAAI,EAAE,IAAI,CAAC,KAAK,QAAQ,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;oBACjH,OAAO;gBACT,CAAC;gBAED,CAAC,CAAC,YAAY,CAAC,iBAAiB,CAAC,CAAC;YACpC,CAAC;YAED,iBAAiB,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;YAEjC,IAAI,aAAa,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,gBAAgB,EAAE,CAAC;gBAClD,KAAK,MAAM,GAAG,IAAI,aAAa,EAAE,CAAC;oBAChC,MAAM,KAAK,GAAG,kBAAkB,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;oBACvD,OAAO,CAAC,MAAM,CAAC;wBACb,MAAM,EAAE,8BAA8B;wBACtC,QAAQ,EAAE,OAAO;wBACjB,QAAQ,EAAE,SAAS;wBACnB,UAAU,EAAE,MAAM;wBAClB,OAAO,EAAE,0BAA0B,GAAG,CAAC,IAAI,8DAA8D;wBACzG,IAAI,EAAE,UAAU,CAAC,QAAQ;wBACzB,KAAK;wBACL,QAAQ,EAAE;4BACR;gCACE,OAAO,EAAE,wFAAwF;gCACjG,KAAK;6BACN;yBACF;wBACD,eAAe,EAAE,oFAAoF;wBACrG,gBAAgB,EAAE,KAAK;qBACxB,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}
1
+ {"version":3,"file":"missingEffectCleanup.js","sourceRoot":"","sources":["../../../src/rules/react/missingEffectCleanup.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,wBAAwB,EAAE,MAAM,yBAAyB,CAAC;AAGvF,SAAS,iBAAiB,CAAC,IAAuB,EAAE,EAAiB;IACnE,IAAI,GAAG,GAAG,IAAI,CAAC;IACf,OAAO,EAAE,CAAC,yBAAyB,CAAC,GAAG,CAAC,EAAE,CAAC;QACzC,GAAG,GAAG,GAAG,CAAC,UAAU,CAAC;IACvB,CAAC;IACD,OAAO,GAAG,CAAC;AACb,CAAC;AAED;;;GAGG;AACH,SAAS,2BAA2B,CAClC,OAA0B,EAC1B,EAAiB,EACjB,OAAwC,EACxC,SAAmC;IAEnC,MAAM,IAAI,GAAG,iBAAiB,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAE5C,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,CAAC;QAC9D,OAAO,IAAI,CAAC;IACd,CAAC;IAED,IAAI,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,EAAE,CAAC;QACrC,OAAO,CACL,2BAA2B,CAAC,IAAI,CAAC,QAAQ,EAAE,EAAE,EAAE,OAAO,EAAE,SAAS,CAAC;YAClE,2BAA2B,CAAC,IAAI,CAAC,SAAS,EAAE,EAAE,EAAE,OAAO,EAAE,SAAS,CAAC,CACpE,CAAC;IACJ,CAAC;IAED,IAAI,OAAO,EAAE,CAAC;QACZ,MAAM,IAAI,GAAG,OAAO,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAC7C,IAAI,IAAI,EAAE,CAAC;YACT,IAAI,IAAI,CAAC,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBACxC,OAAO,IAAI,CAAC;YACd,CAAC;YACD,IAAI,IAAI,CAAC,OAAO,EAAE,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,CAAC,EAAE,CAAC;gBAC/E,OAAO,IAAI,CAAC;YACd,CAAC;QACH,CAAC;QAED,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QACjD,IAAI,MAAM,EAAE,CAAC;YACX,IAAI,WAAW,GAAG,MAAM,CAAC;YACzB,IAAI,CAAC,WAAW,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;gBACrD,IAAI,CAAC;oBACH,WAAW,GAAG,OAAO,CAAC,gBAAgB,CAAC,WAAW,CAAC,CAAC;gBACtD,CAAC;gBAAC,MAAM,CAAC;oBACP,SAAS;gBACX,CAAC;YACH,CAAC;YACD,MAAM,KAAK,GAAG,WAAW,CAAC,eAAe,EAAE,CAAC;YAC5C,IAAI,KAAK,EAAE,CAAC;gBACV,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;oBACzB,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;wBAChG,OAAO,IAAI,CAAC;oBACd,CAAC;oBACD,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;wBACvD,MAAM,IAAI,GAAG,iBAAiB,CAAC,IAAI,CAAC,WAAW,EAAE,EAAE,CAAC,CAAC;wBACrD,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,CAAC;4BAC9D,OAAO,IAAI,CAAC;wBACd,CAAC;wBACD,MAAM,QAAQ,GAAG,OAAO,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;wBACjD,IAAI,QAAQ,IAAI,QAAQ,CAAC,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;4BACxD,OAAO,IAAI,CAAC;wBACd,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,4FAA4F;IAC5F,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,SAAS,EAAE,CAAC;QACvC,MAAM,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC;QAC7B,IAAI,aAAa,GAAG,KAAK,CAAC;QAE1B,SAAS,UAAU,CAAC,IAAiB;YACnC,IAAI,aAAa;gBAAE,OAAO;YAC1B,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,UAAU,EAAE,CAAC;gBACjF,aAAa,GAAG,IAAI,CAAC;gBACrB,OAAO;YACT,CAAC;YACD,IACE,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC;gBAC9B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;gBAC1B,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,UAAU;gBAC7B,IAAI,CAAC,WAAW,EAChB,CAAC;gBACD,MAAM,IAAI,GAAG,iBAAiB,CAAC,IAAI,CAAC,WAAW,EAAE,EAAE,CAAC,CAAC;gBACrD,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC9D,aAAa,GAAG,IAAI,CAAC;oBACrB,OAAO;gBACT,CAAC;YACH,CAAC;YACD,IAAI,CAAC,YAAY,CAAC,UAAU,CAAC,CAAC;QAChC,CAAC;QAED,UAAU,CAAC,SAAS,CAAC,CAAC;QACtB,IAAI,aAAa;YAAE,OAAO,IAAI,CAAC;IACjC,CAAC;IAED,OAAO,KAAK,CAAC;AACf,CAAC;AAED,MAAM,CAAC,MAAM,wBAAwB,GAAS;IAC5C,IAAI,EAAE;QACJ,EAAE,EAAE,8BAA8B;QAClC,QAAQ,EAAE,OAAO;QACjB,eAAe,EAAE,SAAS;QAC1B,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,+EAA+E;QAC5F,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,CAAC,wBAAwB,CAAC,IAAI,EAAE,EAAE,EAAE,OAAO,CAAC;gBAAE,OAAO;YAEzD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;YAC5B,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,IAAI,CAAC,QAAQ,IAAI,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;gBACvF,OAAO;YACT,CAAC;YAED,MAAM,YAAY,GAAG,QAAQ,CAAC,IAAI,CAAC;YACnC,MAAM,aAAa,GAA+C,EAAE,CAAC;YACrE,IAAI,gBAAgB,GAAG,KAAK,CAAC;YAE7B,sEAAsE;YACtE,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,YAAY,CAAC,EAAE,CAAC;gBAC9B,IAAI,2BAA2B,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,EAAE,YAAY,CAAC,EAAE,CAAC;oBACzE,gBAAgB,GAAG,IAAI,CAAC;gBAC1B,CAAC;YACH,CAAC;YAED,SAAS,iBAAiB,CAAC,CAAc;gBACvC,gFAAgF;gBAChF,IAAI,EAAE,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC;oBACjE,MAAM,SAAS,GAAG,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC;oBACpC,IAAI,SAAS,KAAK,WAAW,IAAI,SAAS,KAAK,aAAa,IAAI,SAAS,KAAK,kBAAkB,EAAE,CAAC;wBACjG,aAAa,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,CAAC;oBACnD,CAAC;gBACH,CAAC;gBAED,kCAAkC;gBAClC,IACE,EAAE;oBACF,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC;oBACtB,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,UAAU,CAAC;oBAC3C,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,WAAW,EACtC,CAAC;oBACD,aAAa,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,IAAI,EAAE,cAAc,EAAE,CAAC,CAAC;gBACxD,CAAC;gBAED,6BAA6B;gBAC7B,IAAI,EAAE,IAAI,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,CAAC;oBAClD,IAAI,2BAA2B,CAAC,CAAC,CAAC,UAAU,EAAE,EAAE,EAAE,OAAO,EAAE,YAAY,CAAC,EAAE,CAAC;wBACzE,gBAAgB,GAAG,IAAI,CAAC;oBAC1B,CAAC;gBACH,CAAC;gBAED,IAAI,EAAE,IAAI,CAAC,KAAK,QAAQ,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;oBACjH,OAAO;gBACT,CAAC;gBAED,CAAC,CAAC,YAAY,CAAC,iBAAiB,CAAC,CAAC;YACpC,CAAC;YAED,iBAAiB,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;YAEjC,IAAI,aAAa,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,gBAAgB,EAAE,CAAC;gBAClD,KAAK,MAAM,GAAG,IAAI,aAAa,EAAE,CAAC;oBAChC,MAAM,KAAK,GAAG,kBAAkB,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;oBACvD,OAAO,CAAC,MAAM,CAAC;wBACb,MAAM,EAAE,8BAA8B;wBACtC,QAAQ,EAAE,OAAO;wBACjB,QAAQ,EAAE,SAAS;wBACnB,UAAU,EAAE,MAAM;wBAClB,OAAO,EAAE,0BAA0B,GAAG,CAAC,IAAI,8DAA8D;wBACzG,IAAI,EAAE,UAAU,CAAC,QAAQ;wBACzB,KAAK;wBACL,QAAQ,EAAE;4BACR;gCACE,OAAO,EAAE,wFAAwF;gCACjG,KAAK;6BACN;yBACF;wBACD,eAAe,EAAE,oFAAoF;wBACrG,gBAAgB,EAAE,KAAK;qBACxB,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"uncheckedIndexAccess.d.ts","sourceRoot":"","sources":["../../../src/rules/typescript/uncheckedIndexAccess.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,wBAAwB,EAAE,IAkFtC,CAAC"}
1
+ {"version":3,"file":"uncheckedIndexAccess.d.ts","sourceRoot":"","sources":["../../../src/rules/typescript/uncheckedIndexAccess.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAuE7D,eAAO,MAAM,wBAAwB,EAAE,IAwFtC,CAAC"}