soundbip 2.1.1 → 2.2.0

package/index.js

@@ -1,10 +1,10 @@
 #!/usr/bin/env node
 const readline = require('readline');
 const https = require('https');
-const { exec } = require('child_process');
+// child_process used in openBrowser()
 
 const API_URL = 'api.dltpays.com';
-const VERSION = '2.1.1';
+const VERSION = '2.2.0';
 
 // Colors
 const c = {
@@ -112,19 +112,25 @@ function apiCall(method, path, data = null) {
       port: 443,
       path: `/api/v1${path}`,
       method,
-      headers: { 'Content-Type': 'application/json' }
+      headers: { 'Content-Type': 'application/json' },
+      timeout: 30000
     };
     const req = https.request(options, res => {
       let body = '';
       res.on('data', chunk => body += chunk);
       res.on('end', () => {
         try {
-          resolve(JSON.parse(body));
+          const parsed = JSON.parse(body);
+          resolve(parsed);
         } catch {
-          resolve(body);
+          reject(new Error(`Server returned invalid response (HTTP ${res.statusCode})`));
         }
       });
     });
+    req.on('timeout', () => {
+      req.destroy();
+      reject(new Error('Request timed out — check your internet connection'));
+    });
     req.on('error', reject);
     if (data) req.write(JSON.stringify(data));
     req.end();
@@ -132,18 +138,22 @@ function apiCall(method, path, data = null) {
 }
 
 function openBrowser(url) {
+  const { execFile } = require('child_process');
   const platform = process.platform;
-  let command;
 
+  let cmd, args;
   if (platform === 'darwin') {
-    command = `open "${url}"`;
+    cmd = 'open';
+    args = [url];
   } else if (platform === 'win32') {
-    command = `start "" "${url}"`;
+    cmd = 'cmd';
+    args = ['/c', 'start', '', url];
   } else {
-    command = `xdg-open "${url}"`;
+    cmd = 'xdg-open';
+    args = [url];
   }
 
-  exec(command, (err) => {
+  execFile(cmd, args, (err) => {
     if (err) {
       console.log(`${c.dim}  Could not open browser automatically.${c.reset}`);
     }
@@ -198,6 +208,10 @@ function info(label, value, indent = '  ') {
 }
 
 function spinner(text) {
+  if (!process.stdout.isTTY) {
+    console.log(`  ${text}`);
+    return null;
+  }
   const frames = ['⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏'];
   let i = 0;
   process.stdout.write(`\n${c.yellow}  ${frames[0]} ${text}${c.reset}`);
@@ -210,9 +224,12 @@ function spinner(text) {
 }
 
 function stopSpinner(interval) {
+  if (!interval) return;
   clearInterval(interval);
-  process.stdout.clearLine(0);
-  process.stdout.cursorTo(0);
+  if (process.stdout.isTTY) {
+    process.stdout.clearLine(0);
+    process.stdout.cursorTo(0);
+  }
 }
 
 const PLATFORMS = {
@@ -382,7 +399,30 @@ async function main() {
   console.log(`${c.dim}  Takes about 2 minutes for WooCommerce, 5-10 for custom integrations${c.reset}`);
   console.log('');
 
+  // Terms of Service
+  section('📋', 'Vendor Terms of Service');
+  console.log('');
+  console.log(`${c.dim}  By registering, you agree to the following:${c.reset}`);
+  console.log('');
+  console.log(`  ${c.white}1.${c.reset} SoundBip is a ${c.bold}non-custodial${c.reset} POS platform — we never hold your funds`);
+  console.log(`  ${c.white}2.${c.reset} Blockchain transactions on XRPL are ${c.bold}irreversible${c.reset} once confirmed`);
+  console.log(`  ${c.white}3.${c.reset} You are responsible for your wallet security and tax compliance`);
+  console.log(`  ${c.white}4.${c.reset} Platform fee: ${c.bold}0.5%${c.reset} on eligible transactions`);
+  console.log(`  ${c.white}5.${c.reset} Governed by the laws of ${c.bold}Guernsey${c.reset}`);
+  console.log('');
+  console.log(`  ${c.dim}Full terms: ${c.cyan}https://soundbip.com/terms${c.reset}`);
+  console.log('');
+
+  const termsAccepted = await ask(`${c.cyan}  Do you accept the Vendor Terms of Service? [y/n]: ${c.reset}`);
+  if (termsAccepted.trim().toLowerCase() !== 'y' && termsAccepted.trim().toLowerCase() !== 'yes') {
+    console.log(`\n${c.yellow}  Registration cancelled. You must accept the terms to continue.${c.reset}\n`);
+    rl.close();
+    return;
+  }
+  success('Terms accepted');
+
   // Store details with validation
+  section('🏪', 'Business Details');
   const storeName = await askWithValidation(
     `${c.cyan}  Store name: ${c.reset}`,
     (name) => name.length >= 2,
@@ -425,10 +465,12 @@ async function main() {
   );
 
   // Auto-extract postcode from address if present
-  const postcodeMatch = addressStreet.match(/GY\d{1,2}\s?\d[A-Z]{2}/i);
+  const postcodeMatch = addressStreet.match(/,?\s*GY\d{1,2}\s?\d[A-Z]{2}\s*$/i);
   let addressPostcode;
+  let cleanStreet = addressStreet;
   if (postcodeMatch) {
-    addressPostcode = postcodeMatch[0].trim().toUpperCase();
+    addressPostcode = postcodeMatch[0].replace(/^,?\s*/, '').trim().toUpperCase();
+    cleanStreet = addressStreet.replace(postcodeMatch[0], '').trim().replace(/,\s*$/, '');
     success(`Postcode detected: ${addressPostcode}`);
   } else {
     addressPostcode = await askWithValidation(
@@ -446,8 +488,16 @@ async function main() {
     console.log(`${c.dim}    ${c.reset}${c.cyan}[${num.padStart(2)}]${c.reset} ${name}`);
   });
   console.log('');
-  const parishChoice = await ask(`${c.cyan}  Select parish [1-10]: ${c.reset}`);
-  const addressCity = PARISHES[parishChoice.trim()] || parishChoice.trim();
+  let addressCity;
+  while (true) {
+    const parishChoice = await ask(`${c.cyan}  Select parish [1-10]: ${c.reset}`);
+    const picked = PARISHES[parishChoice.trim()];
+    if (picked) {
+      addressCity = picked;
+      break;
+    }
+    console.log(`${c.red}  ✗ Please enter a number between 1 and 10${c.reset}`);
+  }
 
   // Optional fields
   section('📝', 'Additional Details');
@@ -455,8 +505,8 @@ async function main() {
 
   const registrationNumber = await askWithValidation(
     `${c.cyan}  Guernsey registration number: ${c.reset}`,
-    (n) => n.length >= 3,
-    'Registration number is required'
+    (n) => /^\d{4,10}$/.test(n.trim()),
+    'Must be a valid numeric registration number (4-10 digits)'
   );
 
   const description = await ask(`${c.cyan}  Describe your business (optional, max 250 chars): ${c.reset}`);
@@ -466,19 +516,51 @@ async function main() {
 
   let referred_by_store = null;
   if (referralCode.trim()) {
-    const lookupResult = await apiCall('GET', `/store/lookup-referral/${referralCode.trim()}`);
-    if (lookupResult.success) {
-      referred_by_store = lookupResult.store_id;
-      console.log(`${c.green}  ✓ Referred by: ${lookupResult.store_name}${c.reset}`);
-    } else {
-      console.log(`${c.yellow}  ⚠ Referral code not found - continuing without referral${c.reset}`);
+    try {
+      const lookupResult = await apiCall('GET', `/store/lookup-referral/${encodeURIComponent(referralCode.trim())}`);
+      if (lookupResult.success) {
+        referred_by_store = lookupResult.store_id;
+        console.log(`${c.green}  ✓ Referred by: ${lookupResult.store_name}${c.reset}`);
+      } else {
+        console.log(`${c.yellow}  ⚠ Referral code not found - continuing without referral${c.reset}`);
+      }
+    } catch {
+      console.log(`${c.yellow}  ⚠ Could not verify referral code - continuing without referral${c.reset}`);
     }
   }
 
   // Platform selection
   showPlatformMenu();
-  const platformChoice = await ask(`${c.cyan}  Select platform [1-7]: ${c.reset}`);
-  const platform = PLATFORMS[platformChoice] || PLATFORMS['3'];
+  let platform;
+  while (true) {
+    const platformChoice = await ask(`${c.cyan}  Select platform [1-7]: ${c.reset}`);
+    platform = PLATFORMS[platformChoice.trim()];
+    if (platform) break;
+    console.log(`${c.red}  ✗ Please enter a number between 1 and 7${c.reset}`);
+  }
+
+  // Review before submitting
+  section('✅', 'Review Your Details');
+  console.log('');
+  info('Business', storeName);
+  info('Website', storeUrl);
+  info('Email', email);
+  info('Owner', ownerName);
+  info('Address', cleanStreet);
+  info('Parish', addressCity);
+  info('Postcode', addressPostcode);
+  info('Reg Number', registrationNumber.trim());
+  if (description.trim()) info('Description', description.trim());
+  info('Platform', platform.name);
+  if (referred_by_store) info('Referral', '✓ Applied');
+  console.log('');
+
+  const confirmReg = await ask(`${c.cyan}  Everything correct? [y/n]: ${c.reset}`);
+  if (confirmReg.trim().toLowerCase() !== 'y' && confirmReg.trim().toLowerCase() !== 'yes') {
+    console.log(`\n${c.yellow}  Registration cancelled. Run npx soundbip again to start over.${c.reset}\n`);
+    rl.close();
+    return;
+  }
 
   const spin = spinner('Registering your store...');
 
@@ -488,7 +570,7 @@ async function main() {
     email: email,
     owner_name: ownerName,
     business_address: {
-      street: addressStreet,
+      street: cleanStreet,
       city: addressCity,
       postcode: addressPostcode
     },
@@ -503,12 +585,20 @@ async function main() {
     registerBody.description = description.trim();
   }
 
-  const result = await apiCall('POST', '/store/register', registerBody);
+  let result;
+  try {
+    result = await apiCall('POST', '/store/register', registerBody);
+  } catch (err) {
+    stopSpinner(spin);
+    console.log(`\n${c.red}  ✗ ${err.message}${c.reset}\n`);
+    rl.close();
+    return;
+  }
 
   stopSpinner(spin);
 
-  if (result.error) {
-    console.log(`\n${c.red}  ✗ Error: ${result.error}${c.reset}\n`);
+  if (!result || !result.store_id) {
+    console.log(`\n${c.red}  ✗ Error: ${result?.error || 'Registration failed — unexpected server response'}${c.reset}\n`);
     rl.close();
     return;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "soundbip",
-  "version": "2.1.1",
+  "version": "2.2.0",
   "description": "CLI for SoundBip POS - instant affiliate commissions on XRPL",
   "bin": {
     "soundbip": "./index.js"