sophhub 0.4.71 → 0.4.72

package/skills/hotel-booking/src/scripts/test_hotel_booking.py

@@ -0,0 +1,349 @@
+#!/usr/bin/env python3
+"""hotel_booking 纯函数单测（不触网、不需要 requests、不需要密钥）。
+
+覆盖三类容易出错的口径：
+1. **比价口径**：逐晚价条数必须等于入住晚数、逐晚价解析不出来就不能按剩下的凑；
+2. **房型 + 价格计划成对**：实测同一个 ratePlanId 会落在不同房型下且价格不同，
+   只按 ratePlanId 索引会拿到别的房型的价；
+3. **退订响应形态**：整单退订 `data` 是对象、部分退订 `data` 是**数组**，
+   两种都要能取到退单号；取不到必须返回 None（调用方据此报错，绝不能按整单取消处理）。
+
+用法::
+
+    python3 skills/hotel-booking/src/scripts/test_hotel_booking.py
+"""
+from __future__ import annotations
+
+import contextlib
+import io
+import os
+import sys
+import tempfile
+import types
+from pathlib import Path
+
+# 先隔离运行环境，再导入被测模块：模块导入时要求 SOPH_API_KEY 且会创建数据目录，
+# 单测不应依赖密钥、也不该写真实用户目录。
+_TMP_HOME = tempfile.mkdtemp(prefix="hotel-booking-test-")
+os.environ["HOME"] = _TMP_HOME
+os.environ["USERPROFILE"] = _TMP_HOME
+os.environ.setdefault("SOPH_API_KEY", "unit-test-key-not-used")
+
+# 业务脚本导入时即引入 requests；单测不触网，用桩模块顶上，
+# 这样在没有安装 requests 的环境里也能跑这套测试。
+if "requests" not in sys.modules:
+    _stub = types.ModuleType("requests")
+
+    def _no_network(*_args, **_kwargs):
+        raise AssertionError("单测不应发起网络请求")
+
+    _stub.post = _no_network
+    _stub.get = _no_network
+    sys.modules["requests"] = _stub
+
+HERE = Path(__file__).resolve().parent
+if str(HERE) not in sys.path:
+    sys.path.insert(0, str(HERE))
+
+import hotel_booking as hb  # noqa: E402
+
+
+# ---------- 造数据（字段取自 dev8 实测响应） ----------
+
+def _night_rates(prices: list[float], start: str = "2026-10-22") -> list[dict]:
+    from datetime import date, timedelta
+    y, m, d = (int(x) for x in start.split("-"))
+    first = date(y, m, d)
+    return [{
+        "checkInDate": (first + timedelta(days=i)).isoformat(),
+        "price": price,
+        "breakfastCount": 0,
+        "stock": None,
+        "breakFastDes": "无早",
+    } for i, price in enumerate(prices)]
+
+
+def _plan(rate_plan_id: str, price: float, nights: int, shopping_code: str) -> dict:
+    return {
+        "bedInfo": "1张1.8米大床",
+        "bedType": "大床",
+        "currencyCode": "CNY",
+        "invoiceMode": "SUPPLIER_GENERAL_INVOICE",
+        "productType": "ORDINARY",
+        "nightRates": _night_rates([price] * nights),
+        "cancelRule": {"ruleType": "NeedOneTime", "showDescription": "10-21 18:00前|免费|10-21 18:00后|不可取消"},
+        "ratePlanId": rate_plan_id,
+        "price": price,
+        "stock": 10,
+        "shoppingCode": shopping_code,
+        "subProductCode": "5",
+    }
+
+
+def _detail() -> dict:
+    return {
+        "originHotelId": "11357228",
+        "originType": "80",
+        "name": "上海浦东川沙诺富特酒店",
+        "lowestPrice": 458,
+        "rooms": [
+            {
+                "name": "高级大床房",
+                "roomId": "259735835",
+                "originRoomId": "259735835",
+                "area": "28",
+                "capcity": "2",
+                "ratePlans": [_plan("1655121775", 458, 1, "e16802672e290de2e54d2c5c106cf30d")],
+            },
+            {
+                "name": "行政大床房",
+                "roomId": "438117870",
+                "originRoomId": "438117870",
+                "area": "35",
+                "capcity": "2",
+                # 同一个 ratePlanId 出现在另一个房型下（实测形如 562680496 落在两个房型）
+                "ratePlans": [_plan("1655121775", 837, 1, "b0d2b1c0f0a94f1e9d7c3b2a5e6f7a8b")],
+            },
+        ],
+    }
+
+
+def _guests() -> list[dict]:
+    return [{"name": "张三", "mobile": "13800138000", "credentialType": "IDENTITY",
+             "credentialNo": "310101199001011234", "roomNo": 1}]
+
+
+# ---------- 比价口径 ----------
+
+def test_nights_between() -> None:
+    assert hb.nights_between("2026-10-22", "2026-10-23") == 1
+    assert hb.nights_between("2026-10-22", "2026-10-25") == 3
+    assert hb.nights_between("2026-10-22", "2026-10-22") is None, "同日入住离店不合法"
+    assert hb.nights_between("2026-10-25", "2026-10-22") is None, "离店早于入住不合法"
+    assert hb.nights_between("2026/10/22", "2026-10-23") is None, "日期格式必须 yyyy-MM-dd"
+    assert hb.nights_between("", "2026-10-23") is None
+
+
+def test_plan_total_multiplies_rooms() -> None:
+    rates = _night_rates([429, 429, 429])
+    assert hb.plan_total(rates, rooms=1, expected_nights=3) == 1287.0
+    assert hb.plan_total(rates, rooms=2, expected_nights=3) == 2574.0
+
+
+def test_plan_total_rejects_incomplete_night_rates() -> None:
+    """缺一晚不能按剩下的凑：条数与晚数对不上必须拒绝。"""
+    assert hb.plan_total(_night_rates([429, 429]), rooms=1, expected_nights=3) is None
+    assert hb.plan_total([], rooms=1, expected_nights=1) is None
+    assert hb.plan_total(None, rooms=1, expected_nights=1) is None
+    broken = _night_rates([429])
+    broken[0]["price"] = None
+    assert hb.plan_total(broken, rooms=1, expected_nights=1) is None, "价格缺失不得当成 0"
+
+
+def test_to_number_does_not_guess() -> None:
+    assert hb.to_number("458") == 458.0
+    assert hb.to_number(458) == 458.0
+    assert hb.to_number("458.50") == 458.5
+    assert hb.to_number("") is None
+    assert hb.to_number(None) is None
+    assert hb.to_number(True) is None, "布尔值不是价格"
+    assert hb.to_number("abc") is None
+    assert hb.to_number({"price": 1}) is None
+
+
+# ---------- 房型 + 价格计划成对 ----------
+
+def test_flatten_plans_pairs_room_with_plan() -> None:
+    rows = hb.flatten_plans(_detail(), expected_nights=1)
+    assert len(rows) == 2, "两个房型各有一个价格计划"
+
+    grand = next(r for r in rows if r["originRoomId"] == "259735835")
+    exec_room = next(r for r in rows if r["originRoomId"] == "438117870")
+    assert grand["price"] == 458.0 and exec_room["price"] == 837.0, "同名 ratePlanId 必须按房型分别取价"
+    assert grand["nightTotal"] == 458.0 and exec_room["nightTotal"] == 837.0
+    assert grand["cancelRule"] == "10-21 18:00前|免费|10-21 18:00后|不可取消"
+    assert grand["breakfast"] == "无早"
+    assert grand["productType"] == "ORDINARY"
+    assert grand["stock"] == 10.0
+
+
+def test_flatten_plans_falls_back_to_room_id_and_marks_unknown_type() -> None:
+    detail = _detail()
+    detail["rooms"][0].pop("originRoomId")          # 只给 roomId 的形态
+    detail["rooms"][0]["ratePlans"][0].pop("productType")
+    detail["rooms"][0]["ratePlans"][0]["stock"] = None
+    rows = hb.flatten_plans(detail, expected_nights=1)
+    first = next(r for r in rows if r["roomName"] == "高级大床房")
+    assert first["originRoomId"] == "259735835", "缺少 originRoomId 时回退 roomId"
+    assert first["productType"] == "UNKNOWN", "未识别取值标 UNKNOWN，不猜协议价"
+    assert first["stock"] is None
+    assert first["nightTotal"] == 458.0
+
+
+def test_flatten_plans_marks_incomplete_night_total_as_none() -> None:
+    detail = _detail()
+    detail["rooms"][0]["ratePlans"][0]["nightRates"] = _night_rates([458, 458])
+    rows = hb.flatten_plans(detail, expected_nights=3)
+    first = next(r for r in rows if r["roomName"] == "高级大床房")
+    assert first["nightTotal"] is None, "晚数对不上时不下发可疑总价"
+
+
+# ---------- 退订响应形态 ----------
+
+def test_first_refund_order_no_accepts_object_and_array() -> None:
+    # 整单退订：data 是对象；未确认订单等价取消时 refundOrderNo 是字符串 "null"
+    assert hb.first_refund_order_no({"refundOrderNo": "1124465634433153"}) == "1124465634433153"
+    assert hb.first_refund_order_no({"refundOrderNo": "null"}) is None, '"null" 视为没有退单号'
+    assert hb.first_refund_order_no({"refundOrderNo": None}) is None
+    # 部分退订：data 是数组（dev8 实测形态）
+    assert hb.first_refund_order_no([
+        {"orderNo": "1124465480226944", "roomNos": [1],
+         "checkInDate": "2026-10-17", "checkOutDate": "2026-10-18",
+         "refundOrderNo": "1124465634433153"},
+    ]) == "1124465634433153"
+    assert hb.first_refund_order_no([{"refundOrderNo": None}, {"refundOrderNo": "R-2"}]) == "R-2"
+    assert hb.first_refund_order_no([]) is None
+    assert hb.first_refund_order_no("null") is None
+
+
+# ---------- 请求报文组装 ----------
+
+def test_build_create_payload_uses_inhouse_origin_type() -> None:
+    payload = hb.build_create_payload(
+        city_id="10801",
+        origin_hotel_id="11357228",
+        origin_room_id="259735835",
+        rate_plan_id="1655121775",
+        shopping_code="e16802672e290de2e54d2c5c106cf30d",
+        check_in="2026-10-22",
+        check_out="2026-10-23",
+        rooms=1,
+        total_amount=458.0,
+        earliest_arrival_time="2026-10-22 14:00:00",
+        latest_arrival_time="2026-10-22 23:59:00",
+        guests=_guests(),
+        contacter_name="张三",
+        contacter_mobile="13800138000",
+    )
+    assert payload["originType"] == 80, "本期统一在途渠道 80"
+    assert payload["totalAmount"] == 458.0
+    assert payload["checkInDate"] == "2026-10-22"
+    assert payload["customers"][0]["roomNo"] == 1
+    assert "cityId" in payload
+
+
+def test_build_create_payload_omits_empty_fields() -> None:
+    """无值字段直接不下发，让网关点名字段报 40105，而不是下发空串。"""
+    payload = hb.build_create_payload(
+        city_id=None,
+        origin_hotel_id="11357228",
+        origin_room_id="259735835",
+        rate_plan_id="1655121775",
+        shopping_code="sc",
+        check_in="2026-10-22",
+        check_out="2026-10-23",
+        rooms=1,
+        total_amount=458.0,
+        earliest_arrival_time="2026-10-22 14:00:00",
+        latest_arrival_time="2026-10-22 23:59:00",
+        guests=_guests(),
+        contacter_name="张三",
+        contacter_mobile="13800138000",
+    )
+    assert "cityId" not in payload
+
+
+def test_build_partial_refund_shape() -> None:
+    payload = hb.build_partial_refund(1, "2026-10-17", "2026-10-18", None)
+    assert payload["partialRefunds"][0]["roomNos"] == [1]
+    assert payload["partialRefunds"][0]["checkInDate"] == "2026-10-17"
+    assert "reason" not in payload, "没填原因就不要下发空原因"
+    with_reason = hb.build_partial_refund(2, "2026-10-17", "2026-10-18", "行程变更")
+    assert with_reason["reason"] == "行程变更"
+
+
+def test_show_status_zh_and_expire_time() -> None:
+    assert hb.show_status_zh("CANCELED") == "已取消"
+    assert hb.show_status_zh("part_refund_change") == "部分退订", "大小写不敏感"
+    assert hb.show_status_zh("SOMETHING_NEW") == "SOMETHING_NEW", "未知状态原样展示，不吞掉"
+    assert hb.show_status_zh(None) == "-"
+    assert hb._expire_time_text(1790738675618).startswith("2026-")
+    assert hb._expire_time_text(None) == "None"
+
+
+# ---------- cityId 透传（下单全程必须带，断了就查不到酒店/下不了单） ----------
+
+def _run_hotel_detail(**kwargs):
+    """跑一次 cmd_hotel_detail，返回 (返回码, 实际下发的 detail 报文)。"""
+    seen: dict = {}
+
+    def fake_post(path, payload):
+        seen["path"] = path
+        seen["payload"] = payload
+        return {"code": "0", "msg": "成功", "data": _detail()}
+
+    original = hb._post
+    hb._post = fake_post
+    try:
+        args = types.SimpleNamespace(origin_hotel_id="11357228",
+                                     check_in="2026-10-22", check_out="2026-10-23", **kwargs)
+        with contextlib.redirect_stdout(io.StringIO()):
+            rc = hb.cmd_hotel_detail(args)
+    finally:
+        hb._post = original
+    return rc, seen
+
+
+def test_hotel_detail_city_id_falls_back_to_search_cache() -> None:
+    """首次详情没有详情缓存时，cityId 必须从关键词检索缓存里取，否则创单会缺 cityId。"""
+    hb._write_json(hb.LAST_DETAIL_FILE, {})
+    hb._write_json(hb.LAST_SEARCH_FILE, {"keyword": "外滩", "cityId": "10801", "hotels": []})
+
+    rc, seen = _run_hotel_detail(city_id=None)
+
+    assert rc == 0
+    assert seen["path"] == "/search/detail"
+    assert seen["payload"].get("cityId") == "10801", "首次详情必须从检索缓存带上 cityId"
+    assert seen["payload"].get("originType") == 80
+    assert hb._read_json(hb.LAST_DETAIL_FILE, {}).get("cityId") == "10801", "详情缓存要写 cityId 供创单复用"
+
+
+def test_hotel_detail_city_id_prefers_explicit_arg() -> None:
+    """显式 --city-id 优先，且两个缓存都为空时不能因缺 cityId 而崩。"""
+    hb._write_json(hb.LAST_DETAIL_FILE, {})
+    hb._write_json(hb.LAST_SEARCH_FILE, {"cityId": "10801", "createdAt": "2026-09-30 10:00:00"})
+
+    _, seen = _run_hotel_detail(city_id="2")
+    assert seen["payload"].get("cityId") == "2", "显式入参优先于缓存"
+
+    hb._write_json(hb.LAST_DETAIL_FILE, {})
+    hb._write_json(hb.LAST_SEARCH_FILE, {})
+    _, seen2 = _run_hotel_detail(city_id=None)
+    assert "cityId" not in seen2["payload"], "没有任何来源时不下发空 cityId"
+
+
+def test_hotel_detail_city_id_uses_newer_cache() -> None:
+    """换城市后检索缓存比上次详情新，必须用新 cityId（沿用旧值会查不到酒店）。"""
+    hb._write_json(hb.LAST_DETAIL_FILE, {"cityId": "10801", "createdAt": "2026-09-30 09:00:00"})
+    hb._write_json(hb.LAST_SEARCH_FILE, {"cityId": "1", "createdAt": "2026-09-30 10:00:00"})
+    _, seen = _run_hotel_detail(city_id=None)
+    assert seen["payload"].get("cityId") == "1", "更新的检索缓存应覆盖旧详情缓存"
+
+    hb._write_json(hb.LAST_DETAIL_FILE, {"cityId": "10801", "createdAt": "2026-09-30 11:00:00"})
+    _, seen2 = _run_hotel_detail(city_id=None)
+    assert seen2["payload"].get("cityId") == "10801", "详情比检索新时用详情缓存"
+
+
+if __name__ == "__main__":
+    tests = [(name, fn) for name, fn in sorted(globals().items())
+             if name.startswith("test_") and callable(fn)]
+    failed = 0
+    for name, fn in tests:
+        try:
+            fn()
+            print(f"PASS  {name}")
+        except AssertionError as exc:
+            failed += 1
+            print(f"FAIL  {name}: {exc}")
+    print(f"\n{len(tests) - failed}/{len(tests)} passed")
+    sys.exit(1 if failed else 0)