sonamu 0.5.7 → 0.7.0

package/src/database/_batch_update.ts

@@ -3,11 +3,12 @@
   https://github.com/knex/knex/issues/5716
 */
 
-import { Knex } from "knex";
+import type { Knex } from "knex";
 
+type ColumnValue = string | number | boolean | null;
 export type RowWithId<Id extends string> = {
-  [key in Id]: any;
-} & Record<string, any>;
+  [key in Id]: ColumnValue;
+} & Record<string, ColumnValue>;
 
 /**
  * Batch update rows in a table. Technically its a patch since it only updates the specified columns. Any omitted columns will not be affected
@@ -24,17 +25,14 @@ export async function batchUpdate<Id extends string>(
   ids: Id[],
   rows: RowWithId<Id>[],
   chunkSize = 50,
-  trx: Knex.Transaction | null = null
+  trx: Knex.Transaction | null = null,
 ) {
   const chunks: RowWithId<Id>[][] = [];
   for (let i = 0; i < rows.length; i += chunkSize) {
     chunks.push(rows.slice(i, i + chunkSize));
   }
 
-  const executeUpdate = async (
-    chunk: RowWithId<Id>[],
-    transaction: Knex.Transaction
-  ) => {
+  const executeUpdate = async (chunk: RowWithId<Id>[], transaction: Knex.Transaction) => {
     const sql = generateBatchUpdateSQL(knex, tableName, chunk, ids);
     return knex.raw(sql).transacting(transaction);
   };
@@ -59,7 +57,7 @@ export async function batchUpdate<Id extends string>(
  * [ { a: 1, b: 2 }, { a: 3, c: 4 } ] => Set([ "a", "b", "c" ])
  * @param data
  */
-function generateKeySetFromData(data: Record<string, any>[]) {
+function generateKeySetFromData(data: Record<string, ColumnValue>[]) {
   const keySet: Set<string> = new Set();
   for (const row of data) {
     for (const key of Object.keys(row)) {
@@ -72,50 +70,67 @@ function generateKeySetFromData(data: Record<string, any>[]) {
 function generateBatchUpdateSQL<Id extends string>(
   db: Knex,
   tableName: string,
-  data: Record<string, any>[],
-  identifiers: Id[]
+  data: Record<string, ColumnValue>[],
+  identifiers: Id[],
 ) {
   const keySet = generateKeySetFromData(data);
-  const bindings = [];
+  const allBindings: (string | number | boolean | null)[] = [];
 
   const invalidIdentifiers = identifiers.filter((id) => !keySet.has(id));
   if (invalidIdentifiers.length > 0) {
     throw new Error(
-      `Invalid identifiers: ${invalidIdentifiers.join(", ")}. Identifiers must exist in the data`
+      `Invalid identifiers: ${invalidIdentifiers.join(", ")}. Identifiers must exist in the data`,
     );
   }
 
-  const cases = [];
+  const cases: string[] = [];
+
   for (const key of keySet) {
     if (identifiers.includes(key as Id)) continue;
 
-    const rows = [];
+    const caseBindings: (string | number | boolean | null)[] = [];
+    const whenClauses: string[] = [];
+
     for (const row of data) {
-      if (Object.hasOwnProperty.call(row, key)) {
-        const whereClause = identifiers
-          .map((id) => `\`${id}\` = ?`)
-          .join(" AND ");
-        rows.push(`WHEN (${whereClause}) THEN ?`);
-        bindings.push(...identifiers.map((i) => row[i]), row[key]);
+      if (Object.hasOwn(row, key)) {
+        const whereParts = identifiers.map(() => `?? = ?`).join(" AND ");
+        whenClauses.push(`WHEN (${whereParts}) THEN ?`);
+
+        // identifier 이름과 값들을 추가
+        for (const id of identifiers) {
+          caseBindings.push(id, row[id]);
+        }
+        // THEN 값 추가
+        caseBindings.push(row[key]);
       }
     }
 
-    const whenThen = rows.join(" ");
-    cases.push(`\`${key}\` = CASE ${whenThen} ELSE \`${key}\` END`);
+    const whenThen = whenClauses.join(" ");
+    cases.push(`?? = CASE ${whenThen} ELSE ?? END`);
+
+    // 컬럼명 2개 추가 (SET의 컬럼명, ELSE의 컬럼명)
+    allBindings.push(key);
+    allBindings.push(...caseBindings);
+    allBindings.push(key);
   }
 
   const whereInClauses = identifiers
-    .map((col) => `${col} IN (${data.map(() => "?").join(", ")})`)
+    .map((_col) => `?? IN (${data.map(() => "?").join(", ")})`)
     .join(" AND ");
 
-  const whereInBindings = identifiers.flatMap((col) =>
-    data.map((row) => row[col])
-  );
+  const whereInBindings: (string | number | boolean | null)[] = [];
+  for (const col of identifiers) {
+    whereInBindings.push(col);
+    for (const row of data) {
+      whereInBindings.push(row[col]);
+    }
+  }
 
-  const sql = db.raw(
-    `UPDATE \`${tableName}\` SET ${cases.join(", ")} WHERE ${whereInClauses}`,
-    [...bindings, ...whereInBindings]
-  );
+  const sql = db.raw(`UPDATE ?? SET ${cases.join(", ")} WHERE ${whereInClauses}`, [
+    tableName,
+    ...allBindings,
+    ...whereInBindings,
+  ]);
 
   return sql.toQuery();
 }