soloforge 1.4.16 → 1.5.0

package/dist/adapters/claude_code/tools.js

@@ -1,7 +1,7 @@
 import { debug, internalWarn } from "../../engine/logger.js";
 import { z } from "zod";
 import path from "node:path";
-import fss from "node:fs";
+import { promises as fsp } from "node:fs";
 import crypto from "node:crypto";
 import { normalizePathCandidate } from "../../engine/input_material_extractor.js";
 import { archiveStaleCurrentPointer, detectStaleCurrentTask } from "../../engine/stale_current_task_detector.js";
@@ -362,7 +362,7 @@ export async function checkInstructionContractGate(params) {
     // 消费 enforceInstructionBeforeImplementation（链式消费 checkInstructionCompleteness + validateInstructionContract）
     const result = await instrModule.enforceInstructionBeforeImplementation(instruction, params.toolName);
     // Draft 状态不阻断 — 仅在 confirmed/executing/blocked 状态时强制
-    if (instruction.status === "draft") {
+    if (instruction?.status === "draft") {
         return { allowed: true, findings: result.allowed ? [] : [result.reason_zh] };
     }
     if (!result.allowed) {
@@ -1067,8 +1067,10 @@ export async function registerTools(server, deps) {
             const bypass = effectiveCategory === "read_only_bypass"
                 ? { allowed: true, reason: "read_only" } : undefined;
             // 计划前置门: 在合同验证之前检查 — 写工具必须有 plan_proposal_gate
+            // sf_classify 创建任务、sf_expand 创建 plan_proposal_gate — 两者豁免
             const hasWriteEffect = hasWriteSideEffect(effectiveSideEffects);
-            if (hasWriteEffect && taskId) {
+            const planGateExempt = name === "sf_classify" || name === "sf_expand";
+            if (hasWriteEffect && taskId && !planGateExempt) {
                 const pgResult = checkWriteToolPlanGate({ ctx, toolName: name, sideEffects: effectiveSideEffects });
                 if (!pgResult.allowed) {
                     const planViolation = {
@@ -1401,7 +1403,7 @@ export async function registerTools(server, deps) {
         try {
             for (const anchor of mapData.anchors) {
                 for (const ref of anchor.source_refs) {
-                    if (ref.type === "file" && fss.existsSync(path.join(projectPath, ref.ref))) {
+                    if (ref.type === "file" && await fsp.access(path.join(projectPath, ref.ref)).then(() => true, () => false)) {
                         existingFiles.add(ref.ref);
                     }
                 }
@@ -1489,7 +1491,7 @@ export async function registerTools(server, deps) {
         const classification = (await lazyClassifier()).classify(input);
         // 存储分类结果
         await taskContext.setClassification(ctx.task_id, classification);
-        if (!(await lazyIntentRouter()).shouldEnterSoloForge(classification.route_decision)) {
+        if (!(await lazyIntentRouter()).shouldEnterSoloForge(classification?.route_decision)) {
             await taskContext.updateStatus(ctx.task_id, "done");
         }
         return {
@@ -1605,24 +1607,27 @@ export async function registerTools(server, deps) {
             gateway.endTask();
         }
         expansion.task_id = args.task_id;
-        const projectRoot = fss.realpathSync(projectPath);
+        const projectRoot = await fsp.realpath(projectPath);
         const referencedMaterialPaths = new Set((expansion.input_materials ?? [])
             .map((material) => material.path_or_ref)
             .filter((materialPath) => typeof materialPath === "string" && materialPath.length > 0)
             .map((materialPath) => path.resolve(projectRoot, normalizePathCandidate(materialPath))));
-        const confirmedProjectSourcePaths = (args.input_material_confirmations ?? [])
+        const _confirmedCandidates = (args.input_material_confirmations ?? [])
             .map((materialPath) => path.resolve(projectRoot, normalizePathCandidate(materialPath)))
             .filter((absolutePath) => isSameOrDescendantPath(absolutePath, projectRoot, { caseSensitive: false }))
-            .filter((absolutePath) => referencedMaterialPaths.has(absolutePath))
-            .filter((absolutePath) => {
+            .filter((absolutePath) => referencedMaterialPaths.has(absolutePath));
+        const confirmedProjectSourcePaths = [];
+        for (const absolutePath of _confirmedCandidates) {
             try {
-                return fss.statSync(absolutePath).isFile()
-                    && fss.realpathSync(absolutePath).startsWith(`${projectRoot}${path.sep}`);
+                if ((await fsp.stat(absolutePath)).isFile()
+                    && (await fsp.realpath(absolutePath)).startsWith(`${projectRoot}${path.sep}`)) {
+                    confirmedProjectSourcePaths.push(absolutePath);
+                }
             }
             catch {
-                return false;
+                // 跳过无效路径
             }
-        });
+        }
         const registerConfirmedProjectSources = (registry) => {
             for (const absolutePath of confirmedProjectSourcePaths) {
                 const sourceRef = path.relative(projectRoot, absolutePath);
@@ -1740,8 +1745,20 @@ export async function registerTools(server, deps) {
             }
         }
         // 问题六十一: 架构设计前的六域研讨门独立执行，不得被施工指令契约有无绕过。
-        const existingSourceRoot = ["src", "backend", "frontend", "apps", "services"].some((candidate) => fss.existsSync(path.join(projectPath, candidate)));
-        const existingManifest = ["package.json", "pom.xml", "build.gradle", "settings.gradle"].some((candidate) => fss.existsSync(path.join(projectPath, candidate)));
+        let existingSourceRoot = false;
+        for (const candidate of ["src", "backend", "frontend", "apps", "services"]) {
+            if (await fsp.access(path.join(projectPath, candidate)).then(() => true, () => false)) {
+                existingSourceRoot = true;
+                break;
+            }
+        }
+        let existingManifest = false;
+        for (const candidate of ["package.json", "pom.xml", "build.gradle", "settings.gradle"]) {
+            if (await fsp.access(path.join(projectPath, candidate)).then(() => true, () => false)) {
+                existingManifest = true;
+                break;
+            }
+        }
         const detectedArchitectureContext = existingSourceRoot && existingManifest
             ? "existing_system"
             : (!existingSourceRoot && !existingManifest ? "empty_project" : "new_system");
@@ -1801,8 +1818,8 @@ export async function registerTools(server, deps) {
             }
         }
         // 问题四十九/五十: 已有架构合同或现有系统证据的进一步审查。
-        const expansionRoute = expansion.workflow_trace
-            ? expansion.workflow_trace?.route
+        const expansionRoute = expansion?.workflow_trace
+            ? expansion?.workflow_trace?.route
             : undefined;
         const hasInstructionContract = !!ctx?.instruction_contract;
         if (hasInstructionContract) {
@@ -1908,7 +1925,7 @@ export async function registerTools(server, deps) {
                 const preImplementationBlocks = [];
                 const preImplementationPayload = {};
                 const artifactDesignIntent = expansionRoute === "artifact_generation"
-                    || ["architecture_design", "database_design", "api_design", "detailed_design"].includes(String(workflowIntent))
+                    || ["architecture_design", "detailed_design", "database_design", "api_design"].includes(String(workflowIntent))
                     || /(?:架构|数据库|API|接口|OpenAPI).{0,12}(?:设计|规格|文档)|(?:设计|规格|文档).{0,12}(?:API|接口|OpenAPI)/i.test(ctx.intent);
                 const isImplementationRoute = !artifactDesignIntent && (expansionRoute === "code_change"
                     || String(workflowIntent) === "backend_api_implementation"
@@ -2233,7 +2250,7 @@ export async function registerTools(server, deps) {
                 // 4. 设置 plan_proposal_gate（共享 ctx，最后一次 save）
                 {
                     const { evaluatePlanProposalGate, inferPlanGateTaskType } = await import("../../engine/plan_proposal_gate.js");
-                    const routeForGate = expansion.workflow_trace?.route ?? expansionRoute ?? "code_change";
+                    const routeForGate = expansion?.workflow_trace?.route ?? expansionRoute ?? "code_change";
                     const taskTypeForGate = inferPlanGateTaskType(ctx.intent);
                     const isLightweight = routeForGate === "acceptance" || routeForGate === "review"
                         || routeForGate === "direct_answer" || routeForGate === "analysis"
@@ -2297,8 +2314,8 @@ export async function registerTools(server, deps) {
             for (const changedFile of implementationFiles) {
                 const absoluteFile = path.resolve(projectPath, changedFile);
                 try {
-                    if (isSameOrDescendantPath(absoluteFile, path.resolve(projectPath), { caseSensitive: false }) && fss.statSync(absoluteFile).isFile()) {
-                        implementationContents[changedFile] = fss.readFileSync(absoluteFile, "utf-8");
+                    if (isSameOrDescendantPath(absoluteFile, path.resolve(projectPath), { caseSensitive: false }) && (await fsp.stat(absoluteFile)).isFile()) {
+                        implementationContents[changedFile] = await fsp.readFile(absoluteFile, "utf-8");
                     }
                 }
                 catch {
@@ -2374,12 +2391,14 @@ export async function registerTools(server, deps) {
                 const openApiPath = path.join(projectPath, "docs", "api", "openapi.yaml");
                 const apiMarkdownPath = path.join(projectPath, "docs", "architecture", "03-API接口规格文档.md");
                 const migrationDirectory = path.join(projectPath, "db", "migrations");
-                const openapiText = fss.existsSync(openApiPath) ? fss.readFileSync(openApiPath, "utf-8") : undefined;
-                const apiDocumentText = fss.existsSync(apiMarkdownPath) ? fss.readFileSync(apiMarkdownPath, "utf-8") : undefined;
-                const migrationText = fss.existsSync(migrationDirectory)
-                    ? fss.readdirSync(migrationDirectory).filter((name) => /\.sql$/i.test(name))
-                        .map((name) => fss.readFileSync(path.join(migrationDirectory, name), "utf-8")).join("\n")
-                    : undefined;
+                const openapiText = await fsp.access(openApiPath).then(() => true, () => false) ? await fsp.readFile(openApiPath, "utf-8") : undefined;
+                const apiDocumentText = await fsp.access(apiMarkdownPath).then(() => true, () => false) ? await fsp.readFile(apiMarkdownPath, "utf-8") : undefined;
+                let migrationText;
+                if (await fsp.access(migrationDirectory).then(() => true, () => false)) {
+                    const migrationFiles = (await fsp.readdir(migrationDirectory)).filter((name) => /\.sql$/i.test(name));
+                    const migrationContents = await Promise.all(migrationFiles.map((name) => fsp.readFile(path.join(migrationDirectory, name), "utf-8")));
+                    migrationText = migrationContents.join("\n");
+                }
                 backendFindings.push(...backendModule.verifyBackendArtifactAlignment({
                     openapiText,
                     apiDocumentText,
@@ -2472,7 +2491,7 @@ export async function registerTools(server, deps) {
         })) {
             for (const changedFile of args.changed_files) {
                 const absFile = path.join(projectPath, changedFile);
-                if (!fss.existsSync(absFile) || !/\.md$/.test(changedFile))
+                if (!await fsp.access(absFile).then(() => true, () => false) || !/\.md$/.test(changedFile))
                     continue;
                 // 按实际文件路径匹配契约（不再使用 changed_files[0] 的契约校验全部文件）
                 const perFileContract = sacModule.matchTemplateContract({
@@ -2483,7 +2502,7 @@ export async function registerTools(server, deps) {
                 });
                 if (!perFileContract)
                     continue;
-                const content = fss.readFileSync(absFile, "utf-8");
+                const content = await fsp.readFile(absFile, "utf-8");
                 // 草稿阻断下游消费 — 不再静默跳过
                 if (sacModule.isDraftDocument(content)) {
                     ctx.repair_reverify_directive = {
@@ -2596,8 +2615,8 @@ export async function registerTools(server, deps) {
             // 验证前解析产物文件并计算 hash
             const artifact = ctx.artifact_output;
             const fullPath = path.join(projectPath, artifact.path);
-            if (fss.existsSync(fullPath)) {
-                const fileContent = fss.readFileSync(fullPath);
+            if (await fsp.access(fullPath).then(() => true, () => false)) {
+                const fileContent = await fsp.readFile(fullPath);
                 const hash = crypto.createHash("sha256").update(fileContent).digest("hex");
                 artifact.hash = `sha256:${hash}`;
                 if (!artifact.evidence_refs.some(r => r.startsWith("file:artifact:"))) {
@@ -2802,7 +2821,7 @@ export async function registerTools(server, deps) {
             return { result: { error: "任务不存在" } };
         }
         // 必须有 VerificationPlan
-        const currentPlan = ctx.verification_plan ?? ctx.batch2_verification_plan;
+        const currentPlan = ctx.verification_plan;
         if (!currentPlan) {
             return { result: { error: "任务无 VerificationPlan，先执行 sf_verify 生成计划" } };
         }
@@ -3240,8 +3259,8 @@ export async function registerTools(server, deps) {
                 continue;
             const absoluteFile = path.resolve(projectPath, changedFile);
             try {
-                if (isSameOrDescendantPath(absoluteFile, path.resolve(projectPath), { caseSensitive: false }) && fss.statSync(absoluteFile).isFile()) {
-                    contractContents[changedFile] = fss.readFileSync(absoluteFile, "utf-8");
+                if (isSameOrDescendantPath(absoluteFile, path.resolve(projectPath), { caseSensitive: false }) && (await fsp.stat(absoluteFile)).isFile()) {
+                    contractContents[changedFile] = await fsp.readFile(absoluteFile, "utf-8");
                 }
             }
             catch {
@@ -3338,18 +3357,18 @@ export async function registerTools(server, deps) {
                     error: "验收必须包含显式确认、确认者、可审计确认引用和验收说明",
                     diagnostic_code: "SF-ACCEPT-CONFIRMATION-REQUIRED",
                     recovery_next_tools: ["sf_accept", "sf_status"],
-                    recovery_forbidden_tools: ["sf_deliver", "sf_scaffold", "sf_classify", "sf_expand"],
+                    recovery_forbidden_tools: ["sf_verify", "sf_scaffold", "sf_classify", "sf_expand"],
                 },
             };
         }
-        const currentVerification = ctx.verification_result ?? ctx.batch2_verification_result;
+        const currentVerification = ctx.verification_result;
         if (currentVerification?.status !== "passed") {
             return {
                 result: {
                     error: "验收前必须已有真实执行并通过的 verification_result",
                     diagnostic_code: "SF-ACCEPT-VERIFICATION-REQUIRED",
                     recovery_next_tools: ["sf_verify", "sf_record_verification_execution", "sf_status"],
-                    recovery_forbidden_tools: ["sf_deliver", "sf_scaffold", "sf_classify", "sf_expand"],
+                    recovery_forbidden_tools: ["sf_verify", "sf_scaffold", "sf_classify", "sf_expand"],
                 },
             };
         }
@@ -3362,7 +3381,7 @@ export async function registerTools(server, deps) {
                         error: "manual_review 验收缺少 final_access 真实访问证据",
                         diagnostic_code: "SF-ACCEPT-FINAL-ACCESS-REQUIRED",
                         recovery_next_tools: ["sf_accept", "sf_status"],
-                        recovery_forbidden_tools: ["sf_deliver", "sf_scaffold", "sf_classify", "sf_expand"],
+                        recovery_forbidden_tools: ["sf_verify", "sf_scaffold", "sf_classify", "sf_expand"],
                     },
                 };
             }
@@ -3373,7 +3392,7 @@ export async function registerTools(server, deps) {
                         error: `manual_review 验收证据不完整: ${finalAccessResult.blocking_reasons.join("; ")}`,
                         diagnostic_code: "SF-ACCEPT-FINAL-ACCESS-INVALID",
                         recovery_next_tools: ["sf_accept", "sf_status"],
-                        recovery_forbidden_tools: ["sf_deliver", "sf_scaffold", "sf_classify", "sf_expand"],
+                        recovery_forbidden_tools: ["sf_verify", "sf_scaffold", "sf_classify", "sf_expand"],
                     },
                 };
             }
@@ -3439,8 +3458,8 @@ export async function registerTools(server, deps) {
                     diagnostic_code: TOOL_DIAGNOSTIC_CODES.contractDraft,
                     repair_directive: ctx.repair_reverify_directive,
                     recovery: "修复文档缺口后重新执行 sf_verify，验证通过后 repair_reverify_directive 自动清零",
-                    recovery_next_tools: ["sf_learn", "sf_verify", "sf_status"],
-                    recovery_forbidden_tools: ["sf_deliver", "sf_scaffold", "sf_classify", "sf_expand"],
+                    recovery_next_tools: ["sf_learn", "sf_deliver", "sf_status"],
+                    recovery_forbidden_tools: ["sf_verify", "sf_scaffold", "sf_classify", "sf_expand"],
                 },
             };
         }
@@ -3550,8 +3569,8 @@ export async function registerTools(server, deps) {
         // 交付就绪评估 — delivery_allowed=false 必须阻断交付
         const drModule = await lazyDeliveryReadiness();
         const guardModule = await lazyEnforcementGuard();
-        const currentVResult = ctx.verification_result ?? ctx.batch2_verification_result;
-        const currentVPlan = ctx.verification_plan ?? ctx.batch2_verification_plan;
+        const currentVResult = ctx.verification_result;
+        const currentVPlan = ctx.verification_plan;
         const guardFindings = guardModule.evaluateDeliveryReadinessGuard(currentVResult, currentVPlan);
         // 问题五十一: 编码就绪门 — 交付前检查 coding readiness
         const codingGate = await checkCodingReadinessGate({ ctx });
@@ -3689,9 +3708,9 @@ export async function registerTools(server, deps) {
             browser_acceptance_passed: ctx.artifact_output?.status === "accepted" || ctx.artifact_output === undefined,
             guard_passed: guardFindings.length === 0 || guardFindings.every((f) => f.severity !== "hard_fail"),
             evidence_sufficient: (currentVResult?.evidence_ids?.length ?? 0) > 0,
-            current_status: ctx.status === "done" ? "completed" : ctx.status,
+            current_status: ctx.status === "done" ? "完成" : ctx.status,
         });
-        if (cepNfcResult.decision === "blocked" || cepNfcResult.decision === "repair_reverify") {
+        if (cepNfcResult.decision === "blocked" || cepNfcResult.decision === "回退") {
             if (deliverLease.lease) {
                 leaseModule.releaseLease(deliverLease.lease.lease_id);
             }
@@ -3706,7 +3725,7 @@ export async function registerTools(server, deps) {
                             severity: "blocking",
                             reason_zh: cepNfcResult.reason_zh,
                             evidence_refs: [],
-                            required_action: cepNfcResult.decision === "blocked" ? "block_delivery" : "repair_reverify",
+                            required_action: cepNfcResult.decision === "blocked" ? "block_delivery" : "回退",
                         }],
                     user_facing_summary_zh: `CEP 检查未通过: ${cepNfcResult.reason_zh}`,
                     internal_trace_refs: [],