solid-recharts 0.1.0 → 0.2.0

package/test/shape/Cross.spec.tsx

@@ -3,7 +3,7 @@
 // import; the invalid-input cast uses `unknown` instead of `any`. Assertions
 // are byte-identical (snapshots self-record our output; the `.recharts-cross`
 // counts are the parity signal).
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 
 import { Surface, Cross } from "../../src";
 

package/test/shape/Curve.spec.tsx

@@ -4,7 +4,7 @@
 // render takes a thunk. All assertions are byte-identical.
 import { describe, expect, it, test } from "vitest";
 import { createSignal } from "solid-js";
-import { render, fireEvent } from "../helper/render";
+import { render, fireEvent } from "@solidjs/testing-library";
 import { curveLinear } from "victory-vendor/d3-shape";
 import { Surface, Curve } from "../../src";
 import { getPath, type CurveType } from "../../src/shape/Curve";

package/test/shape/Curve.typed.spec.tsx

@@ -19,7 +19,7 @@
  *   `(_curveProps, e)` React signature is reported in blocked.)
  */
 import { describe, it } from "vitest";
-import { render } from "@solid-recharts/testing-library";
+import { render } from "@solidjs/testing-library";
 import { Curve, getRelativeCoordinate } from "../../src";
 
 describe("Curve types", () => {

package/test/shape/Dot.spec.tsx

@@ -2,7 +2,7 @@
 // Harness changes only: render from local Solid shim, no React import, render takes a thunk.
 // All assertions are byte-identical to recharts.
 import { describe, test, expect } from "vitest";
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 
 import { Surface, Dot } from "../../src";
 import { assertNotNull } from "../helper/assertNotNull";

package/test/shape/Polygon.spec.tsx

@@ -2,7 +2,7 @@
 // Harness changes only: render/fireEvent from the local Solid shim (thunk), no
 // React import; `className` → `class` (the sanctioned prop rename). Path `d`
 // assertions are byte-identical (the parity signal); snapshots self-record.
-import { render, fireEvent } from "../helper/render";
+import { render, fireEvent } from "@solidjs/testing-library";
 import { Surface, Polygon } from "../../src";
 import { Coordinate } from "../../src/util/types";
 import { assertNotNull } from "../helper/assertNotNull";

package/test/shape/Rectangle.animation.spec.tsx

@@ -37,7 +37,7 @@
 //     is preserved.
 import { beforeAll, afterAll, describe, expect, it } from "vitest";
 import { createSignal, flush } from "solid-js";
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 import { trim } from "../helper/trim";
 import { assertNotNull } from "../helper/assertNotNull";
 import { Rectangle, Surface } from "../../src";

package/test/shape/Rectangle.spec.tsx

@@ -2,7 +2,7 @@
 // Harness changes only: render from the local Solid shim (thunk), no React
 // import; invalid-input casts use `unknown`. These all exercise the static
 // (non-update-animation) path. Path `d`/arc assertions are byte-identical.
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 import { Surface, Rectangle } from "../../src";
 import { RectRadius } from "../../src/shape/Rectangle";
 

package/test/shape/Sector.spec.tsx

@@ -2,7 +2,7 @@
 // Harness changes only: render from the local Solid shim (thunk), no React
 // import. Assertions are byte-identical (snapshots self-record; the
 // `.recharts-sector` presence/count + arc-count are the parity signal).
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 
 import { Surface, Sector } from "../../src";
 

package/test/shape/Symbols.spec.tsx

@@ -4,7 +4,7 @@
 // tests are ported; the 4th ('Expect no points attribute on path') renders a
 // full LineChart with XAxis/YAxis/Line and is DEFERRED until the chart vertical
 // is ported.
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 import { Surface, Symbols } from "../../src";
 
 describe("<Symbols />", () => {

package/test/shape/Trapezoid.spec.tsx

@@ -2,7 +2,7 @@
 // Harness changes only: render from the local Solid shim (thunk), no React
 // import. The 'with animation' case snapshot matches the reference byte-for-byte
 // (the update-animation path renders the t=0 frame with the "0px 1px" dash).
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 import { Surface, Trapezoid } from "../../src";
 
 describe("<Trapezoid />", () => {

package/test/state/hooks.spec.tsx

@@ -14,7 +14,7 @@
 // asserted after `flush()` (Solid batches writes on microtasks).
 import { describe, expect, it } from "vitest";
 import { flush } from "solid-js";
-import { renderHook } from "../helper/render";
+import { renderHook } from "@solidjs/testing-library";
 import { useAppSelector, useAppStore } from "../../src/state/hooks";
 import { RechartsStoreProvider } from "../../src/state/RechartsStoreProvider";
 

package/test/state/selectors/axisSelectors.spec.tsx

@@ -40,7 +40,7 @@ import { PageData, misbehavedData } from "../../_data";
 import { createSelectorTestCase } from "../../helper/createSelectorTestCase";
 import { expectXAxisTicks } from "../../helper/expectAxisTicks";
 import { expectLastCalledWithScale } from "../../helper/expectScale";
-import { render } from "../../helper/render";
+import { render } from "@solidjs/testing-library";
 import { useAppStore } from "../../../src/state/hooks";
 import {
   shouldReturnFromInitialState,

package/test/state/selectors/dataSelectors.spec.tsx

@@ -10,7 +10,7 @@ import {
   useAppSelectorWithStableTest,
 } from "../../helper/selectorTestHelpers";
 import { expectLastCalledWith } from "../../helper/expectLastCalledWith";
-import { render } from "../../helper/render";
+import { render } from "@solidjs/testing-library";
 
 // Ported from recharts 3.8.1 test/state/selectors/dataSelectors.spec.tsx.
 

package/test/state/selectors/legendSelectors.spec.tsx

@@ -14,7 +14,7 @@ import {
   useAppSelectorWithStableTest,
 } from "../../helper/selectorTestHelpers";
 import { mockGetBoundingClientRect } from "../../helper/mockGetBoundingClientRect";
-import { render } from "../../helper/render";
+import { render } from "@solidjs/testing-library";
 
 // Ported from recharts 3.8.1 test/state/selectors/legendSelectors.spec.tsx.
 

package/test/state/selectors/radarSelectors.spec.tsx

@@ -7,7 +7,7 @@
 // asserts the selector VALUE before/after the click (render-count assertions dropped).
 import { createEffect, createSignal, flush } from "solid-js";
 import { describe, expect, it, vi } from "vitest";
-import { fireEvent, render } from "../../helper/render";
+import { fireEvent, render } from "@solidjs/testing-library";
 import { useAppSelectorWithStableTest } from "../../helper/selectorTestHelpers";
 import { RechartsRootState } from "../../../src/state/store";
 import {

package/test/state/selectors/selectActiveTooltipIndex.spec.tsx

@@ -1,6 +1,6 @@
 import { beforeEach, describe, it } from "vitest";
 import { flush } from "solid-js";
-import { fireEvent } from "../../helper/render";
+import { fireEvent } from "@solidjs/testing-library";
 import { createSelectorTestCase } from "../../helper/createSelectorTestCase";
 import { RadialBar, RadialBarChart, Tooltip } from "../../../src";
 import { PageData } from "../../_data";

package/test/state/selectors/selectDisplayedData.spec.tsx

@@ -16,7 +16,7 @@ import {
   useAppSelectorWithStableTest,
 } from "../../helper/selectorTestHelpers";
 import { expectLastCalledWith } from "../../helper/expectLastCalledWith";
-import { render } from "../../helper/render";
+import { render } from "@solidjs/testing-library";
 
 const data1 = [
   { label: "Iter: 0", x: 211, y: 481, z: 1798 },

package/test/state/selectors/selectStackGroups.spec.tsx

@@ -12,7 +12,7 @@
 import { createSignal, flush } from "solid-js";
 import type { JSX } from "@solidjs/web";
 import { describe, expect, it } from "vitest";
-import { fireEvent } from "../../helper/render";
+import { fireEvent } from "@solidjs/testing-library";
 import type { RechartsRootState } from "../../../src/state/store";
 import { selectStackGroups } from "../../../src/state/selectors/axisSelectors";
 import {

package/test/state/selectors/selectors.spec.tsx

@@ -3,7 +3,7 @@
 // Solid-native store actions; tooltip selector exports live in tooltipSelectors.
 import { createEffect, flush } from "solid-js";
 import { describe, expect, it, test, vi } from "vitest";
-import { render } from "../../helper/render";
+import { render } from "@solidjs/testing-library";
 import { RechartsStoreProvider } from "../../../src/state/RechartsStoreProvider";
 import { createRechartsStore, type RechartsRootState } from "../../../src/state/store";
 import { arrayTooltipSearcher } from "../../../src/state/optionsSlice";

package/test/util/DomUtils.spec.tsx

@@ -1,7 +1,7 @@
 // Ported from recharts 3.8.1 test/util/DomUtils.spec.tsx.
 // Harness changes only: render from the local Solid shim (thunk), no React
 // import. Assertions are byte-identical to recharts.
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 import {
   getStringSize,
   clearStringCache,

package/test/util/FunnelUtils.spec.tsx

@@ -6,7 +6,7 @@
 // <Shape>/<Layer> emits `<g class="recharts-layer recharts-active-shape">`, so
 // `toHaveClass('recharts-active-shape')` (substring-class match) still holds.
 import { describe, expect, it } from "vitest";
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 import { FunnelTrapezoid, type FunnelTrapezoidProps } from "../../src/util/FunnelUtils";
 import type { Coordinate, TrapezoidViewBox } from "../../src/util/types";
 

package/test/util/useElementOffset.spec.tsx

@@ -7,7 +7,7 @@
 // values are byte-identical to recharts.
 import { describe, it, expect, vi, beforeEach } from "vitest";
 import { flush } from "solid-js";
-import { renderHook } from "../helper/render";
+import { renderHook } from "@solidjs/testing-library";
 import { useElementOffset } from "../../src/util/useElementOffset";
 import { getMockDomRect } from "../helper/mockGetBoundingClientRect";
 

package/test/util/usePrefersReducedMotion.spec.ts

@@ -3,7 +3,7 @@
 // an Accessor, so the value is read via `result()` where React wrote
 // `result.current`. Assertions/mocks are otherwise byte-identical.
 import { test } from "vitest";
-import { renderHook } from "../helper/render";
+import { renderHook } from "@solidjs/testing-library";
 
 import { usePrefersReducedMotion } from "../../src/util/usePrefersReducedMotion";
 import { Global } from "../../src/util/Global";

package/test/util/useUniqueId.spec.ts

@@ -5,7 +5,7 @@
 // spec's structure; the stability assertions hold by construction. Assertions
 // are otherwise byte-identical.
 import { describe, it, expect } from "vitest";
-import { renderHook } from "../helper/render";
+import { renderHook } from "@solidjs/testing-library";
 import { useUniqueId } from "../../src/util/useUniqueId";
 import { useIdFallback } from "../../src/util/useId";
 

package/test/zIndex/AllZIndexPortals.spec.tsx

@@ -10,7 +10,7 @@
 // `store.actions.zIndex.registerZIndexPortal(…)` + `flush()`.
 import { beforeEach, describe, expect, it } from "vitest";
 import { flush } from "solid-js";
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 import { RechartsStoreContext } from "../../src/state/RechartsStoreContext";
 import { AllZIndexPortals } from "../../src/zIndex/ZIndexPortal";
 import { createRechartsStore, type RechartsStore } from "../../src/state/store";

package/test/zIndex/DynamicZIndex.spec.tsx

@@ -13,7 +13,7 @@
 import { describe, it, expect } from "vitest";
 import { createSignal, flush } from "solid-js";
 import { LineChart, Line, XAxis, YAxis } from "../../src";
-import { fireEvent, render, screen } from "../helper/render";
+import { fireEvent, render, screen } from "@solidjs/testing-library";
 
 describe("Dynamic zIndex updates", () => {
   it("should keep the line in the DOM when zIndex changes dynamically", () => {

package/test/zIndex/ZIndexLayer.portalOwner.spec.tsx

@@ -9,7 +9,7 @@
 import { describe, expect, it } from "vitest";
 import { createSignal, flush } from "solid-js";
 import type { JSX } from "@solidjs/web";
-import { render, fireEvent } from "../helper/render";
+import { render, fireEvent } from "@solidjs/testing-library";
 import { BarChart, Bar } from "../../src";
 import type { AnimationController } from "../../src";
 import { AnimationControllerProvider } from "../../src/animation/useAnimationController";

package/test/zIndex/componentZIndex.spec.tsx

@@ -25,7 +25,7 @@ import {
   XAxis,
   YAxis,
 } from "../../src";
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 
 const data = [
   { name: "a", uv: 100 },

package/test/zIndex/multiChartZIndexIsolation.spec.tsx

@@ -10,7 +10,7 @@ import { describe, expect, it } from "vitest";
 import { createSignal, flush, Show } from "solid-js";
 import { Bar, BarChart, Pie, PieChart } from "../../src";
 import { assertNotNull } from "../helper/assertNotNull";
-import { render } from "../helper/render";
+import { render } from "@solidjs/testing-library";
 
 const barData = [
   { name: "a", uv: 100 },

package/NEXT_SESSION_PROMPT.md

@@ -1,114 +0,0 @@
-# Session goal: grow the test suite (and fix what it surfaces)
-
-You are continuing a faithful port of **recharts 3.8.1 → SolidJS 2.0** living at
-`/Users/thomas/Downloads/solid-recharts/packages/solid-recharts`. The feature port is ~80%
-complete; **test coverage is the gap** — ~1217 cases vs recharts' ~3658 (~33%). Your job this
-session is to **port reference specs into the Solid suite**, and **fix any real port bugs the
-new tests surface**. Quality over volume: every test must be faithful and must pass for the
-right reason.
-
-## The reference
-
-recharts 3.8.1 source + tests are checked out at:
-
-- `/Users/thomas/Documents/Github/recharts-reference/src`
-- `/Users/thomas/Documents/Github/recharts-reference/test`
-
-Port the reference spec's _intent and exact assertions_ (golden numbers, geometry, counts),
-adapting only the React→Solid mechanics.
-
-## Non-negotiable conventions (these OVERRIDE defaults)
-
-1. **Gate after EVERY change**: `vp check --fix` (lint/format/type — must end at _0 errors_;
-   10 warnings is the known steady-state baseline) AND `vp test run` (must stay fully green).
-   Do NOT use `npx vitest` — use `vp test run <pattern>`.
-2. **No `any`, no `as`, no non-null `!` in src, no `@ts-expect-error`.** The lint is
-   type-aware and WILL catch these (it already caught a bad test this project). Use typed
-   coercion / helpers instead.
-3. **Faithful porting.** If a feature is genuinely deferred in the port (check the file's
-   header comment), don't assert it — write a _subset_ spec mirroring the existing ported
-   specs' style, and note in the spec header which reference assertions you omitted and why.
-   If the spec fails because the **port has a real bug or missing-but-claimed feature, FIX the
-   port** (faithfully to recharts), don't weaken the test.
-4. **Document deviations** in spec/source header comments (the codebase does this consistently
-   — match the surrounding style, comment density, and naming).
-
-## Solid 2.0 gotchas that WILL bite (all learned the hard way — see memory)
-
-- A global guard in `test/setup.ts` **fails any test on a non-allowlisted Solid diagnostic**
-  (STRICT_READ_UNTRACKED etc). Common fixes:
-  - Don't read a reactive/accessor value directly in `<Show when={...}>` static children —
-    use the accessor-child form `<Show when={obj()}>{(v) => ...}</Show>` with a TRUTHY object
-    `when`, OR a plain **ternary** in JSX for a captured non-reactive const (a
-    `<Show when={capturedConst}>` still trips STRICT_READ).
-  - Bake values into `<For>`-item descriptors; don't render recursive hierarchies via
-    components that read reactive `props.*`.
-- **`mouseenter`/`mouseleave` do NOT bubble.** Item handlers live on the wrapping node
-  `<Layer>` — `fireEvent.mouseEnter` the Layer `g`, not the inner shape.
-- **Bar item-hover tooltip needs `<Tooltip shared={false}>`** (shared tooltips use the
-  axis/mouse path, not item-enter).
-- Solid 2.0 **defers propagation to a flush boundary**: after a sync signal set, a memo read
-  in the same tick is stale until `flush()`. Tests call `flush()` after render and after
-  `fireEvent`. Use local values (not re-read memos) inside event handlers.
-- Test wrappers: use `props.children`, never destructure `{children}` (breaks the store).
-
-## Exact commands
-
-```
-cd /Users/thomas/Downloads/solid-recharts/packages/solid-recharts
-vp test run <Name>      # run one spec (substring match), e.g. vp test run ChartUtils
-vp test run             # full suite (currently 1217 passing / 115 files)
-vp check --fix          # the gate (0 errors / 10 warnings = clean)
-```
-
-## Prioritized worklist (port in this order — fastest/safest first)
-
-**Tier 1 — pure-function specs (no DOM, no flake, highest value).** These pin exact numeric
-behavior of code we already ship but barely test. Reference paths under `…/recharts-reference/test/`:
-
-- `util/ChartUtils.spec.tsx`, `util/BarUtils.spec.tsx`, `util/DataUtils.spec.ts` (extend ours)
-- `util/round.spec.ts`, `util/isWellBehavedNumber.spec.ts`, `util/getRelativeCoordinate.spec.ts`
-- `util/ChartUtils/{truncateByDomain,getStackedData,getCateCoordinateOfLine}.spec.*`
-- `util/scale/{getNiceTickValues,arithmetic,createCategoricalInverse}.spec.ts`
-- `util/cursor/{getCursorRectangle,getCursorPoints,getRadialCursorPoints}.spec.ts`
-- `util/payload/getUniqPayload.spec.ts`, `util/tooltip/translate.spec.ts`
-- `util/CartesianUtils/{CartesianUtils,rectWithPoints}.spec.ts`, `util/PolarUtils.spec.ts`
-- `util/resolveDefaultProps.spec.tsx` (NB: our port uses Solid `merge`, not resolveDefaultProps
-  — adapt or skip with a note), `util/isDomainSpecifiedByUser.spec.ts`, `util/TickUtils.spec.ts`
-- Also untested port units with NO ref-named spec but clearly testable: `src/util/getSliced.ts`,
-  `getEveryNth.ts`, `getActiveCoordinate.ts`, `YAxisUtils.ts`, `getRadiusAndStrokeWidthFromDot.ts`,
-  `ReduceCSSCalc.ts` — write fresh unit specs from the port's behavior + reference src.
-
-**Tier 2 — state selectors (test through the store; medium effort).**
-`state/selectors/*.spec.tsx` — `dataSelectors`, `axisSelectors`, `legendSelectors`,
-`lineSelectors`, `pieSelectors`, `scatterSelectors`, `radialBarSelectors`, `selectChartOffset`,
-`combiners/combineActiveTooltipIndex`. Use the existing `test/helper/render` + store patterns.
-
-**Tier 3 — component/integration specs (deepen behavior).**
-`component/{Text,Label,LabelList,Legend,DefaultTooltipContent,Cursor,ResponsiveContainer}.spec.tsx`,
-`cartesian/{Area,Line,Bar/Bar,Scatter,CartesianAxis,CartesianGrid,ErrorBar,Brush}.spec.tsx`,
-`polar/{Pie/Pie,Radar,RadialBar/RadialBar,PolarGrid,PolarAngleAxis,PolarRadiusAxis}.spec.tsx`,
-`chart/{ComposedChart,RadarChart,ScatterChart,CategoricalChart}.spec.tsx`. These are big in the
-reference — port the parity-critical subset and document omissions (the existing `*.spec.tsx`
-headers show the house style).
-
-## Working rhythm
-
-1. Pick the next worklist item. Read the reference spec + the port's source.
-2. Port the spec into the mirrored path under `test/` (match existing naming/structure).
-3. `vp test run <Name>`. If it fails: decide — port bug (fix src faithfully) vs deferred feature
-   (subset the spec + document). Never weaken a test to hide a real gap.
-4. `vp check --fix`. Confirm 0 errors.
-5. Periodically run the full `vp test run` to catch cross-file regressions.
-6. Update `MEMORY.md` + a memory file when you learn something non-obvious or finish a cluster.
-
-## Context to load first
-
-Read the memory index at
-`/Users/thomas/.claude/projects/-Users-thomas-Downloads-solid-recharts/memory/MEMORY.md` and the
-files it points to (especially `expectclean-or-diagnostics-silent.md`,
-`solid2-reactivity-timing.md`, `root-config-and-lint.md`, `custom-shape-render-props.md`) — they
-encode the gate, the diagnostic guard, and the reactivity rules above.
-
-Start with **Tier 1** and report progress in batches (files ported, tests added, any port bugs
-fixed). Keep the suite green the whole way.

package/test/helper/render.ts

@@ -1,7 +0,0 @@
-// Test render helper, backed by the @solid-recharts/testing-library workspace
-// package (a vendored Solid 2.0 port of @solidjs/testing-library — the official
-// 0.8.x still targets Solid 1.x via the removed `solid-js/web` path). Specs
-// import `render`, `cleanup`, and the @testing-library/dom query/event helpers
-// (screen, fireEvent, waitFor, …) from here so there's a single swap point for
-// when the package is published to npm.
-export * from "@solid-recharts/testing-library";