solid-js 1.3.0-beta.0 → 1.3.0-beta.4

package/README.md

@@ -1,4 +1,6 @@
-## <img src="https://raw.githubusercontent.com/solidjs/solid/main/assets/logo.png" alt="Solid" width="350"/><br>
+<p>
+  <img width="100%" src="https://raw.githubusercontent.com/solidjs/solid/master/banner.png" alt="SolidJS">
+</p>
 
 [![Build Status](https://github.com/solidjs/solid/workflows/Solid%20CI/badge.svg)](https://github.com/solidjs/solid/actions/workflows/main-ci.yml)
 [![Coverage Status](https://img.shields.io/coveralls/github/solidjs/solid.svg?style=flat)](https://coveralls.io/github/solidjs/solid?branch=main)

package/dist/dev.cjs

@@ -149,6 +149,7 @@ const [transPending, setTransPending] = /*@__PURE__*/createSignal(false);
 var Owner = null;
 let Transition = null;
 let Scheduler = null;
+let ExternalSourceFactory = null;
 let Listener = null;
 let Pending = null;
 let Updates = null;
@@ -354,7 +355,7 @@ function createSelector(source, fn = equalFn, options) {
   const subs = new Map();
   const node = createComputation(p => {
     const v = source();
-    for (const key of subs.keys()) if (fn(key, v) || p !== undefined && fn(key, p)) {
+    for (const key of subs.keys()) if (fn(key, v) !== (p !== undefined && fn(key, p))) {
       const l = subs.get(key);
       for (const c of l.values()) {
         c.state = STALE;
@@ -554,6 +555,24 @@ let SuspenseContext;
 function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
+function enableExternalSource(factory) {
+  if (ExternalSourceFactory) {
+    const oldFactory = ExternalSourceFactory;
+    ExternalSourceFactory = (fn, trigger) => {
+      const oldSource = oldFactory(fn, trigger);
+      const source = factory(x => oldSource.track(x), trigger);
+      return {
+        track: x => source.track(x),
+        dispose() {
+          source.dispose();
+          oldSource.dispose();
+        }
+      };
+    };
+  } else {
+    ExternalSourceFactory = factory;
+  }
+}
 function readSignal() {
   const runningTransition = Transition && Transition.running;
   if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
@@ -682,6 +701,19 @@ function createComputation(fn, init, pure, state = STALE, options) {
     }
     c.name = options && options.name || `${Owner.name || "c"}-${(Owner.owned || Owner.tOwned).length}`;
   }
+  if (ExternalSourceFactory) {
+    const [track, trigger] = createSignal(undefined, {
+      equals: false
+    });
+    const ordinary = ExternalSourceFactory(c.fn, trigger);
+    onCleanup(() => ordinary.dispose());
+    const triggerInTransition = () => startTransition(trigger, () => inTransition.dispose());
+    const inTransition = ExternalSourceFactory(c.fn, triggerInTransition);
+    c.fn = x => {
+      track();
+      return Transition && Transition.running ? inTransition.track(x) : ordinary.track(x);
+    };
+  }
   return c;
 }
 function runTop(node) {
@@ -708,7 +740,7 @@ function runTop(node) {
     } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
-      lookDownstream(node);
+      lookDownstream(node, ancestors[0]);
       Updates = updates;
     }
   }
@@ -807,13 +839,15 @@ function runUserEffects(queue) {
   for (i = 0; i < userLength; i++) runTop(queue[i]);
   for (i = resume; i < queue.length; i++) runTop(queue[i]);
 }
-function lookDownstream(node) {
+function lookDownstream(node, ignore) {
   node.state = 0;
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) {
+        if (source !== ignore) runTop(source);
+      } else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source, ignore);
     }
   }
 }
@@ -1137,13 +1171,19 @@ function indexArray(list, mapFn, options = {}) {
   };
 }
 
+let hydrationEnabled = false;
+function enableHydration() {
+  hydrationEnabled = true;
+}
 function createComponent(Comp, props) {
-  if (sharedConfig.context) {
-    const c = sharedConfig.context;
-    setHydrateContext(nextHydrateContext());
-    const r = devComponent(Comp, props) ;
-    setHydrateContext(c);
-    return r;
+  if (hydrationEnabled) {
+    if (sharedConfig.context) {
+      const c = sharedConfig.context;
+      setHydrateContext(nextHydrateContext());
+      const r = devComponent(Comp, props) ;
+      setHydrateContext(c);
+      return r;
+    }
   }
   return devComponent(Comp, props);
 }
@@ -1232,19 +1272,20 @@ function splitProps(props, ...keys) {
 }
 function lazy(fn) {
   let comp;
+  let p;
   const wrap = props => {
     const ctx = sharedConfig.context;
     if (ctx) {
       ctx.count++;
       const [s, set] = createSignal();
-      fn().then(mod => {
+      (p || (p = fn())).then(mod => {
         setHydrateContext(ctx);
         set(() => mod.default);
         setHydrateContext(undefined);
       });
       comp = s;
     } else if (!comp) {
-      const [s] = createResource(() => fn().then(mod => mod.default));
+      const [s] = createResource(() => (p || (p = fn())).then(mod => mod.default));
       comp = s;
     } else {
       const c = comp();
@@ -1260,7 +1301,7 @@ function lazy(fn) {
       return r;
     }));
   };
-  wrap.preload = () => comp || fn().then(mod => comp = () => mod.default);
+  wrap.preload = () => p || ((p = fn()).then(mod => comp = () => mod.default), p);
   return wrap;
 }
 let counter = 0;
@@ -1320,7 +1361,11 @@ function Match(props) {
   return props;
 }
 function ErrorBoundary(props) {
-  const [errored, setErrored] = createSignal();
+  let err = undefined;
+  if (sharedConfig.context && sharedConfig.load) {
+    err = sharedConfig.load(sharedConfig.context.id + sharedConfig.context.count);
+  }
+  const [errored, setErrored] = createSignal(err);
   let e;
   return createMemo(() => {
     if ((e = errored()) != null) {
@@ -1404,7 +1449,8 @@ function Suspense(props) {
       showFallback,
       ctx,
       waitingHydration,
-      flicker;
+      flicker,
+      error;
   const [inFallback, setFallback] = createSignal(false),
         SuspenseContext = getSuspenseContext(),
         store = {
@@ -1419,7 +1465,7 @@ function Suspense(props) {
     resolved: false
   },
         owner = getOwner();
-  if (sharedConfig.context && sharedConfig.load) {
+  if (sharedConfig.context) {
     const key = sharedConfig.context.id + sharedConfig.context.count;
     const p = sharedConfig.load(key);
     if (p) {
@@ -1427,7 +1473,8 @@ function Suspense(props) {
         equals: false
       });
       flicker = s;
-      p.then(() => {
+      p.then(err => {
+        if (error = err) return set();
         sharedConfig.gather(key);
         waitingHydration = true;
         setHydrateContext(ctx);
@@ -1445,6 +1492,7 @@ function Suspense(props) {
     value: store,
     get children() {
       return createMemo(() => {
+        if (error) throw error;
         if (flicker) {
           ctx = sharedConfig.context;
           flicker();
@@ -1510,6 +1558,8 @@ exports.createRoot = createRoot;
 exports.createSelector = createSelector;
 exports.createSignal = createSignal;
 exports.createUniqueId = createUniqueId;
+exports.enableExternalSource = enableExternalSource;
+exports.enableHydration = enableHydration;
 exports.enableScheduling = enableScheduling;
 exports.equalFn = equalFn;
 exports.from = from;

package/dist/dev.js

@@ -145,6 +145,7 @@ const [transPending, setTransPending] = /*@__PURE__*/createSignal(false);
 var Owner = null;
 let Transition = null;
 let Scheduler = null;
+let ExternalSourceFactory = null;
 let Listener = null;
 let Pending = null;
 let Updates = null;
@@ -350,7 +351,7 @@ function createSelector(source, fn = equalFn, options) {
   const subs = new Map();
   const node = createComputation(p => {
     const v = source();
-    for (const key of subs.keys()) if (fn(key, v) || p !== undefined && fn(key, p)) {
+    for (const key of subs.keys()) if (fn(key, v) !== (p !== undefined && fn(key, p))) {
       const l = subs.get(key);
       for (const c of l.values()) {
         c.state = STALE;
@@ -550,6 +551,24 @@ let SuspenseContext;
 function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
+function enableExternalSource(factory) {
+  if (ExternalSourceFactory) {
+    const oldFactory = ExternalSourceFactory;
+    ExternalSourceFactory = (fn, trigger) => {
+      const oldSource = oldFactory(fn, trigger);
+      const source = factory(x => oldSource.track(x), trigger);
+      return {
+        track: x => source.track(x),
+        dispose() {
+          source.dispose();
+          oldSource.dispose();
+        }
+      };
+    };
+  } else {
+    ExternalSourceFactory = factory;
+  }
+}
 function readSignal() {
   const runningTransition = Transition && Transition.running;
   if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
@@ -678,6 +697,19 @@ function createComputation(fn, init, pure, state = STALE, options) {
     }
     c.name = options && options.name || `${Owner.name || "c"}-${(Owner.owned || Owner.tOwned).length}`;
   }
+  if (ExternalSourceFactory) {
+    const [track, trigger] = createSignal(undefined, {
+      equals: false
+    });
+    const ordinary = ExternalSourceFactory(c.fn, trigger);
+    onCleanup(() => ordinary.dispose());
+    const triggerInTransition = () => startTransition(trigger, () => inTransition.dispose());
+    const inTransition = ExternalSourceFactory(c.fn, triggerInTransition);
+    c.fn = x => {
+      track();
+      return Transition && Transition.running ? inTransition.track(x) : ordinary.track(x);
+    };
+  }
   return c;
 }
 function runTop(node) {
@@ -704,7 +736,7 @@ function runTop(node) {
     } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
-      lookDownstream(node);
+      lookDownstream(node, ancestors[0]);
       Updates = updates;
     }
   }
@@ -803,13 +835,15 @@ function runUserEffects(queue) {
   for (i = 0; i < userLength; i++) runTop(queue[i]);
   for (i = resume; i < queue.length; i++) runTop(queue[i]);
 }
-function lookDownstream(node) {
+function lookDownstream(node, ignore) {
   node.state = 0;
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) {
+        if (source !== ignore) runTop(source);
+      } else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source, ignore);
     }
   }
 }
@@ -1133,13 +1167,19 @@ function indexArray(list, mapFn, options = {}) {
   };
 }
 
+let hydrationEnabled = false;
+function enableHydration() {
+  hydrationEnabled = true;
+}
 function createComponent(Comp, props) {
-  if (sharedConfig.context) {
-    const c = sharedConfig.context;
-    setHydrateContext(nextHydrateContext());
-    const r = devComponent(Comp, props) ;
-    setHydrateContext(c);
-    return r;
+  if (hydrationEnabled) {
+    if (sharedConfig.context) {
+      const c = sharedConfig.context;
+      setHydrateContext(nextHydrateContext());
+      const r = devComponent(Comp, props) ;
+      setHydrateContext(c);
+      return r;
+    }
   }
   return devComponent(Comp, props);
 }
@@ -1228,19 +1268,20 @@ function splitProps(props, ...keys) {
 }
 function lazy(fn) {
   let comp;
+  let p;
   const wrap = props => {
     const ctx = sharedConfig.context;
     if (ctx) {
       ctx.count++;
       const [s, set] = createSignal();
-      fn().then(mod => {
+      (p || (p = fn())).then(mod => {
         setHydrateContext(ctx);
         set(() => mod.default);
         setHydrateContext(undefined);
       });
       comp = s;
     } else if (!comp) {
-      const [s] = createResource(() => fn().then(mod => mod.default));
+      const [s] = createResource(() => (p || (p = fn())).then(mod => mod.default));
       comp = s;
     } else {
       const c = comp();
@@ -1256,7 +1297,7 @@ function lazy(fn) {
       return r;
     }));
   };
-  wrap.preload = () => comp || fn().then(mod => comp = () => mod.default);
+  wrap.preload = () => p || ((p = fn()).then(mod => comp = () => mod.default), p);
   return wrap;
 }
 let counter = 0;
@@ -1316,7 +1357,11 @@ function Match(props) {
   return props;
 }
 function ErrorBoundary(props) {
-  const [errored, setErrored] = createSignal();
+  let err = undefined;
+  if (sharedConfig.context && sharedConfig.load) {
+    err = sharedConfig.load(sharedConfig.context.id + sharedConfig.context.count);
+  }
+  const [errored, setErrored] = createSignal(err);
   let e;
   return createMemo(() => {
     if ((e = errored()) != null) {
@@ -1400,7 +1445,8 @@ function Suspense(props) {
       showFallback,
       ctx,
       waitingHydration,
-      flicker;
+      flicker,
+      error;
   const [inFallback, setFallback] = createSignal(false),
         SuspenseContext = getSuspenseContext(),
         store = {
@@ -1415,7 +1461,7 @@ function Suspense(props) {
     resolved: false
   },
         owner = getOwner();
-  if (sharedConfig.context && sharedConfig.load) {
+  if (sharedConfig.context) {
     const key = sharedConfig.context.id + sharedConfig.context.count;
     const p = sharedConfig.load(key);
     if (p) {
@@ -1423,7 +1469,8 @@ function Suspense(props) {
         equals: false
       });
       flicker = s;
-      p.then(() => {
+      p.then(err => {
+        if (error = err) return set();
         sharedConfig.gather(key);
         waitingHydration = true;
         setHydrateContext(ctx);
@@ -1441,6 +1488,7 @@ function Suspense(props) {
     value: store,
     get children() {
       return createMemo(() => {
+        if (error) throw error;
         if (flicker) {
           ctx = sharedConfig.context;
           flicker();
@@ -1482,4 +1530,4 @@ if (globalThis) {
   if (!globalThis.Solid$$) globalThis.Solid$$ = true;else console.warn("You appear to have multiple instances of Solid. This can lead to unexpected behavior.");
 }
 
-export { $PROXY, DEV, ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, batch, cancelCallback, children, createComponent, createComputed, createContext, createDeferred, createEffect, createMemo, createRenderEffect, createResource, createRoot, createSelector, createSignal, createUniqueId, enableScheduling, equalFn, from, getListener, getOwner, indexArray, lazy, mapArray, mergeProps, observable, on, onCleanup, onError, onMount, requestCallback, runWithOwner, sharedConfig, splitProps, startTransition, untrack, useContext, useTransition };
+export { $PROXY, DEV, ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, batch, cancelCallback, children, createComponent, createComputed, createContext, createDeferred, createEffect, createMemo, createRenderEffect, createResource, createRoot, createSelector, createSignal, createUniqueId, enableExternalSource, enableHydration, enableScheduling, equalFn, from, getListener, getOwner, indexArray, lazy, mapArray, mergeProps, observable, on, onCleanup, onError, onMount, requestCallback, runWithOwner, sharedConfig, splitProps, startTransition, untrack, useContext, useTransition };

package/dist/server.cjs

@@ -41,8 +41,15 @@ function createComputed(fn, value) {
     owner: Owner,
     context: null
   };
-  fn(value);
-  Owner = Owner.owner;
+  try {
+    fn(value);
+  } catch (err) {
+    const fns = lookup(Owner, ERROR);
+    if (!fns) throw err;
+    fns.forEach(f => f(err));
+  } finally {
+    Owner = Owner.owner;
+  }
 }
 const createRenderEffect = createComputed;
 function createEffect(fn, value) {}
@@ -51,8 +58,16 @@ function createMemo(fn, value) {
     owner: Owner,
     context: null
   };
-  const v = fn(value);
-  Owner = Owner.owner;
+  let v;
+  try {
+    v = fn(value);
+  } catch (err) {
+    const fns = lookup(Owner, ERROR);
+    if (!fns) throw err;
+    fns.forEach(f => f(err));
+  } finally {
+    Owner = Owner.owner;
+  }
   return () => v;
 }
 function createDeferred(source) {
@@ -193,6 +208,7 @@ function from(producer) {
   }
   return s;
 }
+function enableExternalSource(factory) {}
 
 function resolveSSRNode(node) {
   const t = typeof node;
@@ -290,7 +306,20 @@ function Match(props) {
   return props;
 }
 function ErrorBoundary(props) {
-  return props.children;
+  let error, res;
+  const ctx = sharedConfig.context;
+  const id = ctx.id + ctx.count;
+  onError(err => error = err);
+  createMemo(() => res = props.children);
+  if (error) {
+    ctx.writeResource(id, error, true);
+    setHydrateContext({ ...ctx,
+      count: 0
+    });
+    const f = props.fallback;
+    return typeof f === "function" && f.length ? f(error, () => {}) : f;
+  }
+  return res;
 }
 const SuspenseContext = createContext();
 let resourceContext = null;
@@ -310,6 +339,7 @@ function createResource(fn, fetcher, options = {}) {
   let resource = {};
   let value = options.initialValue;
   let p;
+  let error;
   if (sharedConfig.context.async) {
     resource = sharedConfig.context.resources[id] || (sharedConfig.context.resources[id] = {});
     if (resource.ref) {
@@ -318,6 +348,7 @@ function createResource(fn, fetcher, options = {}) {
     }
   }
   const read = () => {
+    if (error) throw error;
     if (resourceContext && p) resourceContext.push(p);
     const resolved = sharedConfig.context.async && sharedConfig.context.resources[id].data;
     if (!resolved) {
@@ -356,6 +387,11 @@ function createResource(fn, fetcher, options = {}) {
         p = null;
         notifySuspense(contexts);
         return res;
+      }).catch(err => {
+        read.loading = false;
+        error = err;
+        p = null;
+        notifySuspense(contexts);
       });
       return;
     }
@@ -390,7 +426,7 @@ function lazy(fn) {
     });
     return "";
   };
-  wrap.preload = () => {};
+  wrap.preload = () => p;
   return wrap;
 }
 function suspenseComplete(c) {
@@ -418,13 +454,14 @@ function SuspenseList(props) {
   return props.children;
 }
 function Suspense(props) {
+  let done;
   const ctx = sharedConfig.context;
   const id = ctx.id + ctx.count;
-  const done = ctx.async ? ctx.registerFragment(id) : () => {};
   const o = Owner;
   const value = ctx.suspense[id] || (ctx.suspense[id] = {
     resources: new Map(),
     completed: () => {
+      if (ctx.dataOnly) return done();
       const res = runSuspense();
       if (suspenseComplete(value)) {
         done(resolveSSRNode(res));
@@ -445,12 +482,13 @@ function Suspense(props) {
     });
   }
   const res = runSuspense();
-  if (suspenseComplete(value)) {
-    done();
-    return res;
-  }
-  if (sharedConfig.context.async) {
-    if (sharedConfig.context.streaming) {
+  if (suspenseComplete(value)) return res;
+  onError(err => {
+    if (!done || !done(undefined, err)) throw err;
+  });
+  done = ctx.async ? ctx.registerFragment(id) : undefined;
+  if (ctx.streaming) {
+    if (!ctx.dataOnly) {
       setHydrateContext(undefined);
       const res = {
         t: `<span id="pl${id}">${resolveSSRNode(props.fallback)}</span>`
@@ -458,6 +496,7 @@ function Suspense(props) {
       setHydrateContext(ctx);
       return res;
     }
+  } else if (ctx.async) {
     return {
       t: `<![${id}]>`
     };
@@ -492,6 +531,7 @@ exports.createRoot = createRoot;
 exports.createSelector = createSelector;
 exports.createSignal = createSignal;
 exports.createUniqueId = createUniqueId;
+exports.enableExternalSource = enableExternalSource;
 exports.enableScheduling = enableScheduling;
 exports.equalFn = equalFn;
 exports.from = from;