solid-js 1.2.6 → 1.3.0-beta.3

package/README.md

@@ -1,4 +1,6 @@
-## <img src="https://raw.githubusercontent.com/solidjs/solid/main/assets/logo.png" alt="Solid" width="350"/><br>
+<p>
+  <img width="100%" src="https://raw.githubusercontent.com/solidjs/solid/master/banner.png" alt="SolidJS">
+</p>
 
 [![Build Status](https://github.com/solidjs/solid/workflows/Solid%20CI/badge.svg)](https://github.com/solidjs/solid/actions/workflows/main-ci.yml)
 [![Coverage Status](https://img.shields.io/coveralls/github/solidjs/solid.svg?style=flat)](https://coveralls.io/github/solidjs/solid?branch=main)

package/dist/dev.cjs

@@ -187,12 +187,13 @@ function createSignal(value, options) {
     comparator: options.equals || undefined
   };
   if (!options.internal) s.name = registerGraph(options.name || hashValue(value), s);
-  return [readSignal.bind(s), value => {
+  const setter = value => {
     if (typeof value === "function") {
       if (Transition && Transition.running && Transition.sources.has(s)) value = value(s.pending !== NOTPENDING ? s.pending : s.tValue);else value = value(s.pending !== NOTPENDING ? s.pending : s.value);
     }
     return writeSignal(s, value);
-  }];
+  };
+  return [readSignal.bind(s), setter];
 }
 function createComputed(fn, value, options) {
   const c = createComputation(fn, value, true, STALE, options );
@@ -249,12 +250,7 @@ function createResource(source, fetcher, options) {
       dynamic = typeof source === "function";
   if (sharedConfig.context) {
     id = `${sharedConfig.context.id}${sharedConfig.context.count++}`;
-    if (sharedConfig.context.loadResource) {
-      initP = sharedConfig.context.loadResource(id);
-    } else if (sharedConfig.resources && id && id in sharedConfig.resources) {
-      initP = sharedConfig.resources[id];
-      delete sharedConfig.resources[id];
-    }
+    if (sharedConfig.load) initP = sharedConfig.load(id);
   }
   function loadEnd(p, v, e) {
     if (pr === p) {
@@ -358,7 +354,7 @@ function createSelector(source, fn = equalFn, options) {
   const subs = new Map();
   const node = createComputation(p => {
     const v = source();
-    for (const key of subs.keys()) if (fn(key, v) || p !== undefined && fn(key, p)) {
+    for (const key of subs.keys()) if (fn(key, v) !== (p !== undefined && fn(key, p))) {
       const l = subs.get(key);
       for (const c of l.values()) {
         c.state = STALE;
@@ -409,7 +405,8 @@ function untrack(fn) {
   Listener = listener;
   return result;
 }
-function on(deps, fn, options) {
+function on(deps, fn,
+options) {
   const isArray = Array.isArray(deps);
   let prevInput;
   let defer = options && options.defer;
@@ -711,7 +708,7 @@ function runTop(node) {
     } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
-      lookDownstream(node);
+      lookDownstream(node, ancestors[0]);
       Updates = updates;
     }
   }
@@ -810,13 +807,15 @@ function runUserEffects(queue) {
   for (i = 0; i < userLength; i++) runTop(queue[i]);
   for (i = resume; i < queue.length; i++) runTop(queue[i]);
 }
-function lookDownstream(node) {
+function lookDownstream(node, ignore) {
   node.state = 0;
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) {
+        if (source !== ignore) runTop(source);
+      } else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source, ignore);
     }
   }
 }
@@ -1237,7 +1236,7 @@ function lazy(fn) {
   let comp;
   const wrap = props => {
     const ctx = sharedConfig.context;
-    if (ctx && sharedConfig.resources) {
+    if (ctx) {
       ctx.count++;
       const [s, set] = createSignal();
       fn().then(mod => {
@@ -1310,7 +1309,7 @@ function Switch(props) {
     }
     return [-1];
   }, undefined, {
-    equals: (a, b) => a && a[0] === b[0] && (strictEqual ? a[1] === b[1] : !a[1] === !b[1]) && a[2] === b[2]
+    equals: (a, b) => a[0] === b[0] && (strictEqual ? a[1] === b[1] : !a[1] === !b[1]) && a[2] === b[2]
   });
   return createMemo(() => {
     const [index, when, cond] = evalConditions();
@@ -1323,7 +1322,11 @@ function Match(props) {
   return props;
 }
 function ErrorBoundary(props) {
-  const [errored, setErrored] = createSignal();
+  let err = undefined;
+  if (sharedConfig.context && sharedConfig.load) {
+    err = sharedConfig.load(sharedConfig.context.id + sharedConfig.context.count);
+  }
+  const [errored, setErrored] = createSignal(err);
   let e;
   return createMemo(() => {
     if ((e = errored()) != null) {
@@ -1404,7 +1407,11 @@ function SuspenseList(props) {
 function Suspense(props) {
   let counter = 0,
       showContent,
-      showFallback;
+      showFallback,
+      ctx,
+      waitingHydration,
+      flicker,
+      error;
   const [inFallback, setFallback] = createSignal(false),
         SuspenseContext = getSuspenseContext(),
         store = {
@@ -1419,6 +1426,25 @@ function Suspense(props) {
     resolved: false
   },
         owner = getOwner();
+  if (sharedConfig.context) {
+    const key = sharedConfig.context.id + sharedConfig.context.count;
+    const p = sharedConfig.load(key);
+    if (p) {
+      const [s, set] = createSignal(undefined, {
+        equals: false
+      });
+      flicker = s;
+      p.then(err => {
+        if (error = err) return set();
+        sharedConfig.gather(key);
+        waitingHydration = true;
+        setHydrateContext(ctx);
+        set();
+        setHydrateContext(undefined);
+        waitingHydration = false;
+      });
+    }
+  }
   const listContext = useContext(SuspenseListContext);
   if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
   let dispose;
@@ -1426,28 +1452,36 @@ function Suspense(props) {
   return createComponent(SuspenseContext.Provider, {
     value: store,
     get children() {
-      const rendered = untrack(() => props.children);
       return createMemo(() => {
-        const inFallback = store.inFallback(),
-              visibleContent = showContent ? showContent() : true,
-              visibleFallback = showFallback ? showFallback() : true;
-        dispose && dispose();
-        if (!inFallback && visibleContent) {
-          store.resolved = true;
-          resumeEffects(store.effects);
-          return rendered;
+        if (error) throw error;
+        if (flicker) {
+          ctx = sharedConfig.context;
+          flicker();
+          return flicker = undefined;
         }
-        if (!visibleFallback) return;
-        return createRoot(disposer => {
-          dispose = disposer;
-          return props.fallback;
-        }, owner);
+        const rendered = untrack(() => props.children);
+        return createMemo(() => {
+          const inFallback = store.inFallback(),
+                visibleContent = showContent ? showContent() : true,
+                visibleFallback = showFallback ? showFallback() : true;
+          dispose && dispose();
+          if ((!inFallback || waitingHydration) && visibleContent) {
+            store.resolved = true;
+            resumeEffects(store.effects);
+            return rendered;
+          }
+          if (!visibleFallback) return;
+          return createRoot(disposer => {
+            dispose = disposer;
+            if (sharedConfig.context) sharedConfig.context.count = 0;
+            return props.fallback;
+          }, owner);
+        });
       });
     }
   });
 }
 
-function awaitSuspense() {}
 exports.DEV = void 0;
 {
   exports.DEV = {
@@ -1470,7 +1504,6 @@ exports.Show = Show;
 exports.Suspense = Suspense;
 exports.SuspenseList = SuspenseList;
 exports.Switch = Switch;
-exports.awaitSuspense = awaitSuspense;
 exports.batch = batch;
 exports.cancelCallback = cancelCallback;
 exports.children = children;

package/dist/dev.js

@@ -183,12 +183,13 @@ function createSignal(value, options) {
     comparator: options.equals || undefined
   };
   if (!options.internal) s.name = registerGraph(options.name || hashValue(value), s);
-  return [readSignal.bind(s), value => {
+  const setter = value => {
     if (typeof value === "function") {
       if (Transition && Transition.running && Transition.sources.has(s)) value = value(s.pending !== NOTPENDING ? s.pending : s.tValue);else value = value(s.pending !== NOTPENDING ? s.pending : s.value);
     }
     return writeSignal(s, value);
-  }];
+  };
+  return [readSignal.bind(s), setter];
 }
 function createComputed(fn, value, options) {
   const c = createComputation(fn, value, true, STALE, options );
@@ -245,12 +246,7 @@ function createResource(source, fetcher, options) {
       dynamic = typeof source === "function";
   if (sharedConfig.context) {
     id = `${sharedConfig.context.id}${sharedConfig.context.count++}`;
-    if (sharedConfig.context.loadResource) {
-      initP = sharedConfig.context.loadResource(id);
-    } else if (sharedConfig.resources && id && id in sharedConfig.resources) {
-      initP = sharedConfig.resources[id];
-      delete sharedConfig.resources[id];
-    }
+    if (sharedConfig.load) initP = sharedConfig.load(id);
   }
   function loadEnd(p, v, e) {
     if (pr === p) {
@@ -354,7 +350,7 @@ function createSelector(source, fn = equalFn, options) {
   const subs = new Map();
   const node = createComputation(p => {
     const v = source();
-    for (const key of subs.keys()) if (fn(key, v) || p !== undefined && fn(key, p)) {
+    for (const key of subs.keys()) if (fn(key, v) !== (p !== undefined && fn(key, p))) {
       const l = subs.get(key);
       for (const c of l.values()) {
         c.state = STALE;
@@ -405,7 +401,8 @@ function untrack(fn) {
   Listener = listener;
   return result;
 }
-function on(deps, fn, options) {
+function on(deps, fn,
+options) {
   const isArray = Array.isArray(deps);
   let prevInput;
   let defer = options && options.defer;
@@ -707,7 +704,7 @@ function runTop(node) {
     } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
-      lookDownstream(node);
+      lookDownstream(node, ancestors[0]);
       Updates = updates;
     }
   }
@@ -806,13 +803,15 @@ function runUserEffects(queue) {
   for (i = 0; i < userLength; i++) runTop(queue[i]);
   for (i = resume; i < queue.length; i++) runTop(queue[i]);
 }
-function lookDownstream(node) {
+function lookDownstream(node, ignore) {
   node.state = 0;
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) {
+        if (source !== ignore) runTop(source);
+      } else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source, ignore);
     }
   }
 }
@@ -1233,7 +1232,7 @@ function lazy(fn) {
   let comp;
   const wrap = props => {
     const ctx = sharedConfig.context;
-    if (ctx && sharedConfig.resources) {
+    if (ctx) {
       ctx.count++;
       const [s, set] = createSignal();
       fn().then(mod => {
@@ -1306,7 +1305,7 @@ function Switch(props) {
     }
     return [-1];
   }, undefined, {
-    equals: (a, b) => a && a[0] === b[0] && (strictEqual ? a[1] === b[1] : !a[1] === !b[1]) && a[2] === b[2]
+    equals: (a, b) => a[0] === b[0] && (strictEqual ? a[1] === b[1] : !a[1] === !b[1]) && a[2] === b[2]
   });
   return createMemo(() => {
     const [index, when, cond] = evalConditions();
@@ -1319,7 +1318,11 @@ function Match(props) {
   return props;
 }
 function ErrorBoundary(props) {
-  const [errored, setErrored] = createSignal();
+  let err = undefined;
+  if (sharedConfig.context && sharedConfig.load) {
+    err = sharedConfig.load(sharedConfig.context.id + sharedConfig.context.count);
+  }
+  const [errored, setErrored] = createSignal(err);
   let e;
   return createMemo(() => {
     if ((e = errored()) != null) {
@@ -1400,7 +1403,11 @@ function SuspenseList(props) {
 function Suspense(props) {
   let counter = 0,
       showContent,
-      showFallback;
+      showFallback,
+      ctx,
+      waitingHydration,
+      flicker,
+      error;
   const [inFallback, setFallback] = createSignal(false),
         SuspenseContext = getSuspenseContext(),
         store = {
@@ -1415,6 +1422,25 @@ function Suspense(props) {
     resolved: false
   },
         owner = getOwner();
+  if (sharedConfig.context) {
+    const key = sharedConfig.context.id + sharedConfig.context.count;
+    const p = sharedConfig.load(key);
+    if (p) {
+      const [s, set] = createSignal(undefined, {
+        equals: false
+      });
+      flicker = s;
+      p.then(err => {
+        if (error = err) return set();
+        sharedConfig.gather(key);
+        waitingHydration = true;
+        setHydrateContext(ctx);
+        set();
+        setHydrateContext(undefined);
+        waitingHydration = false;
+      });
+    }
+  }
   const listContext = useContext(SuspenseListContext);
   if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
   let dispose;
@@ -1422,28 +1448,36 @@ function Suspense(props) {
   return createComponent(SuspenseContext.Provider, {
     value: store,
     get children() {
-      const rendered = untrack(() => props.children);
       return createMemo(() => {
-        const inFallback = store.inFallback(),
-              visibleContent = showContent ? showContent() : true,
-              visibleFallback = showFallback ? showFallback() : true;
-        dispose && dispose();
-        if (!inFallback && visibleContent) {
-          store.resolved = true;
-          resumeEffects(store.effects);
-          return rendered;
+        if (error) throw error;
+        if (flicker) {
+          ctx = sharedConfig.context;
+          flicker();
+          return flicker = undefined;
         }
-        if (!visibleFallback) return;
-        return createRoot(disposer => {
-          dispose = disposer;
-          return props.fallback;
-        }, owner);
+        const rendered = untrack(() => props.children);
+        return createMemo(() => {
+          const inFallback = store.inFallback(),
+                visibleContent = showContent ? showContent() : true,
+                visibleFallback = showFallback ? showFallback() : true;
+          dispose && dispose();
+          if ((!inFallback || waitingHydration) && visibleContent) {
+            store.resolved = true;
+            resumeEffects(store.effects);
+            return rendered;
+          }
+          if (!visibleFallback) return;
+          return createRoot(disposer => {
+            dispose = disposer;
+            if (sharedConfig.context) sharedConfig.context.count = 0;
+            return props.fallback;
+          }, owner);
+        });
       });
     }
   });
 }
 
-function awaitSuspense() {}
 let DEV;
 {
   DEV = {
@@ -1457,4 +1491,4 @@ if (globalThis) {
   if (!globalThis.Solid$$) globalThis.Solid$$ = true;else console.warn("You appear to have multiple instances of Solid. This can lead to unexpected behavior.");
 }
 
-export { $PROXY, DEV, ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, awaitSuspense, batch, cancelCallback, children, createComponent, createComputed, createContext, createDeferred, createEffect, createMemo, createRenderEffect, createResource, createRoot, createSelector, createSignal, createUniqueId, enableScheduling, equalFn, from, getListener, getOwner, indexArray, lazy, mapArray, mergeProps, observable, on, onCleanup, onError, onMount, requestCallback, runWithOwner, sharedConfig, splitProps, startTransition, untrack, useContext, useTransition };
+export { $PROXY, DEV, ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, batch, cancelCallback, children, createComponent, createComputed, createContext, createDeferred, createEffect, createMemo, createRenderEffect, createResource, createRoot, createSelector, createSignal, createUniqueId, enableScheduling, equalFn, from, getListener, getOwner, indexArray, lazy, mapArray, mergeProps, observable, on, onCleanup, onError, onMount, requestCallback, runWithOwner, sharedConfig, splitProps, startTransition, untrack, useContext, useTransition };

package/dist/server.cjs

@@ -41,8 +41,15 @@ function createComputed(fn, value) {
     owner: Owner,
     context: null
   };
-  fn(value);
-  Owner = Owner.owner;
+  try {
+    fn(value);
+  } catch (err) {
+    const fns = lookup(Owner, ERROR);
+    if (!fns) throw err;
+    fns.forEach(f => f(err));
+  } finally {
+    Owner = Owner.owner;
+  }
 }
 const createRenderEffect = createComputed;
 function createEffect(fn, value) {}
@@ -51,8 +58,16 @@ function createMemo(fn, value) {
     owner: Owner,
     context: null
   };
-  const v = fn(value);
-  Owner = Owner.owner;
+  let v;
+  try {
+    v = fn(value);
+  } catch (err) {
+    const fns = lookup(Owner, ERROR);
+    if (!fns) throw err;
+    fns.forEach(f => f(err));
+  } finally {
+    Owner = Owner.owner;
+  }
   return () => v;
 }
 function createDeferred(source) {
@@ -219,7 +234,7 @@ function createUniqueId() {
   return `${ctx.id}${ctx.count++}`;
 }
 function createComponent(Comp, props) {
-  if (sharedConfig.context) {
+  if (sharedConfig.context && !sharedConfig.context.noHydrate) {
     const c = sharedConfig.context;
     setHydrateContext(nextHydrateContext());
     const r = Comp(props);
@@ -290,7 +305,20 @@ function Match(props) {
   return props;
 }
 function ErrorBoundary(props) {
-  return props.children;
+  let error, res;
+  const ctx = sharedConfig.context;
+  const id = ctx.id + ctx.count;
+  onError(err => error = err);
+  createMemo(() => res = props.children);
+  if (error) {
+    ctx.writeResource(id, error, true);
+    setHydrateContext({ ...ctx,
+      count: 0
+    });
+    const f = props.fallback;
+    return typeof f === "function" && f.length ? f(error, () => {}) : f;
+  }
+  return res;
 }
 const SuspenseContext = createContext();
 let resourceContext = null;
@@ -310,6 +338,7 @@ function createResource(fn, fetcher, options = {}) {
   let resource = {};
   let value = options.initialValue;
   let p;
+  let error;
   if (sharedConfig.context.async) {
     resource = sharedConfig.context.resources[id] || (sharedConfig.context.resources[id] = {});
     if (resource.ref) {
@@ -318,9 +347,10 @@ function createResource(fn, fetcher, options = {}) {
     }
   }
   const read = () => {
+    if (error) throw error;
     if (resourceContext && p) resourceContext.push(p);
     const resolved = sharedConfig.context.async && sharedConfig.context.resources[id].data;
-    if (sharedConfig.context.async && !resolved) {
+    if (!resolved) {
       const ctx = useContext(SuspenseContext);
       if (ctx) {
         ctx.resources.set(id, read);
@@ -332,7 +362,7 @@ function createResource(fn, fetcher, options = {}) {
   read.loading = false;
   function load() {
     const ctx = sharedConfig.context;
-    if (!ctx.async && !ctx.streaming) return;
+    if (!ctx.async) return read.loading = true;
     if (ctx.resources && id in ctx.resources && ctx.resources[id].data) {
       value = ctx.resources[id].data;
       return;
@@ -349,21 +379,18 @@ function createResource(fn, fetcher, options = {}) {
     }
     read.loading = true;
     if ("then" in p) {
-      if (ctx.writeResource) {
-        ctx.writeResource(id, p);
-        p.then(v => {
-          value = v;
-          read.loading = false;
-          p = null;
-        });
-        return;
-      }
+      if (ctx.writeResource) ctx.writeResource(id, p);
       p.then(res => {
         read.loading = false;
         ctx.resources[id].data = res;
         p = null;
         notifySuspense(contexts);
         return res;
+      }).catch(err => {
+        read.loading = false;
+        error = err;
+        p = null;
+        notifySuspense(contexts);
       });
       return;
     }
@@ -392,7 +419,7 @@ function lazy(fn) {
       ctx.resources.set(id, track);
       contexts.add(ctx);
     }
-    p.then(() => {
+    if (sharedConfig.context.async) p.then(() => {
       track.loading = false;
       notifySuspense(contexts);
     });
@@ -425,19 +452,15 @@ function useTransition() {
 function SuspenseList(props) {
   return props.children;
 }
-const SUSPENSE_GLOBAL = Symbol("suspense-global");
 function Suspense(props) {
+  let done;
   const ctx = sharedConfig.context;
-  if (!ctx.async) return createComponent(() => {
-    props.children;
-    return props.fallback;
-  }, {});
   const id = ctx.id + ctx.count;
-  const done = ctx.async ? lookup(Owner, SUSPENSE_GLOBAL)(id) : () => {};
   const o = Owner;
   const value = ctx.suspense[id] || (ctx.suspense[id] = {
     resources: new Map(),
     completed: () => {
+      if (ctx.dataOnly) return done();
       const res = runSuspense();
       if (suspenseComplete(value)) {
         done(resolveSSRNode(res));
@@ -458,44 +481,29 @@ function Suspense(props) {
     });
   }
   const res = runSuspense();
-  if (suspenseComplete(value)) {
-    done();
-    return res;
-  }
-  return sharedConfig.context.async ? {
-    t: `<#${id}#>`
-  } : props.fallback;
-}
-const SUSPENSE_REPLACE = /<#([\d.]+)#>/;
-function awaitSuspense(fn) {
-  return new Promise(resolve => {
-    const registry = new Set();
-    const cache = Object.create(null);
-    const res = createMemo(() => {
-      Owner.context = {
-        [SUSPENSE_GLOBAL]: getCallback
-      };
-      return fn();
-    });
-    if (!registry.size) resolve(res());
-    function getCallback(key) {
-      registry.add(key);
-      return value => {
-        if (value) cache[key] = value;
-        registry.delete(key);
-        if (!registry.size) Promise.resolve().then(() => {
-          let source = resolveSSRNode(res());
-          let final = "";
-          let match;
-          while (match = source.match(SUSPENSE_REPLACE)) {
-            final += source.substring(0, match.index);
-            source = cache[match[1]] + source.substring(match.index + match[0].length);
-          }
-          resolve(final + source);
-        });
+  if (suspenseComplete(value)) return res;
+  onError(err => {
+    if (!done || !done(undefined, err)) throw err;
+  });
+  done = ctx.async ? ctx.registerFragment(id) : undefined;
+  if (ctx.streaming) {
+    if (!ctx.dataOnly) {
+      setHydrateContext(undefined);
+      const res = {
+        t: `<span id="pl${id}">${resolveSSRNode(props.fallback)}</span>`
       };
+      setHydrateContext(ctx);
+      return res;
     }
+  } else if (ctx.async) {
+    return {
+      t: `<![${id}]>`
+    };
+  }
+  setHydrateContext({ ...ctx,
+    count: 0
   });
+  return createComponent(() => props.fallback, {});
 }
 
 exports.$PROXY = $PROXY;
@@ -508,7 +516,6 @@ exports.Show = Show;
 exports.Suspense = Suspense;
 exports.SuspenseList = SuspenseList;
 exports.Switch = Switch;
-exports.awaitSuspense = awaitSuspense;
 exports.batch = batch;
 exports.children = children;
 exports.createComponent = createComponent;