solid-js 1.2.2 → 1.2.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/dist/dev.cjs CHANGED
@@ -1409,9 +1409,12 @@ function Suspense(props) {
1409
1409
  inFallback,
1410
1410
  effects: [],
1411
1411
  resolved: false
1412
- };
1412
+ },
1413
+ owner = getOwner();
1413
1414
  const listContext = useContext(SuspenseListContext);
1414
1415
  if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
1416
+ let dispose;
1417
+ onCleanup(() => dispose && dispose());
1415
1418
  return createComponent(SuspenseContext.Provider, {
1416
1419
  value: store,
1417
1420
  get children() {
@@ -1420,13 +1423,17 @@ function Suspense(props) {
1420
1423
  const inFallback = store.inFallback(),
1421
1424
  visibleContent = showContent ? showContent() : true,
1422
1425
  visibleFallback = showFallback ? showFallback() : true;
1426
+ dispose && dispose();
1423
1427
  if (!inFallback && visibleContent) {
1424
1428
  store.resolved = true;
1425
1429
  resumeEffects(store.effects);
1426
1430
  return rendered;
1427
1431
  }
1428
1432
  if (!visibleFallback) return;
1429
- return props.fallback;
1433
+ return createRoot(disposer => {
1434
+ dispose = disposer;
1435
+ return props.fallback;
1436
+ }, owner);
1430
1437
  });
1431
1438
  }
1432
1439
  });
package/dist/dev.js CHANGED
@@ -1405,9 +1405,12 @@ function Suspense(props) {
1405
1405
  inFallback,
1406
1406
  effects: [],
1407
1407
  resolved: false
1408
- };
1408
+ },
1409
+ owner = getOwner();
1409
1410
  const listContext = useContext(SuspenseListContext);
1410
1411
  if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
1412
+ let dispose;
1413
+ onCleanup(() => dispose && dispose());
1411
1414
  return createComponent(SuspenseContext.Provider, {
1412
1415
  value: store,
1413
1416
  get children() {
@@ -1416,13 +1419,17 @@ function Suspense(props) {
1416
1419
  const inFallback = store.inFallback(),
1417
1420
  visibleContent = showContent ? showContent() : true,
1418
1421
  visibleFallback = showFallback ? showFallback() : true;
1422
+ dispose && dispose();
1419
1423
  if (!inFallback && visibleContent) {
1420
1424
  store.resolved = true;
1421
1425
  resumeEffects(store.effects);
1422
1426
  return rendered;
1423
1427
  }
1424
1428
  if (!visibleFallback) return;
1425
- return props.fallback;
1429
+ return createRoot(disposer => {
1430
+ dispose = disposer;
1431
+ return props.fallback;
1432
+ }, owner);
1426
1433
  });
1427
1434
  }
1428
1435
  });
package/dist/solid.cjs CHANGED
@@ -1333,9 +1333,12 @@ function Suspense(props) {
1333
1333
  inFallback,
1334
1334
  effects: [],
1335
1335
  resolved: false
1336
- };
1336
+ },
1337
+ owner = getOwner();
1337
1338
  const listContext = useContext(SuspenseListContext);
1338
1339
  if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
1340
+ let dispose;
1341
+ onCleanup(() => dispose && dispose());
1339
1342
  return createComponent(SuspenseContext.Provider, {
1340
1343
  value: store,
1341
1344
  get children() {
@@ -1344,13 +1347,17 @@ function Suspense(props) {
1344
1347
  const inFallback = store.inFallback(),
1345
1348
  visibleContent = showContent ? showContent() : true,
1346
1349
  visibleFallback = showFallback ? showFallback() : true;
1350
+ dispose && dispose();
1347
1351
  if (!inFallback && visibleContent) {
1348
1352
  store.resolved = true;
1349
1353
  resumeEffects(store.effects);
1350
1354
  return rendered;
1351
1355
  }
1352
1356
  if (!visibleFallback) return;
1353
- return props.fallback;
1357
+ return createRoot(disposer => {
1358
+ dispose = disposer;
1359
+ return props.fallback;
1360
+ }, owner);
1354
1361
  });
1355
1362
  }
1356
1363
  });
package/dist/solid.js CHANGED
@@ -1329,9 +1329,12 @@ function Suspense(props) {
1329
1329
  inFallback,
1330
1330
  effects: [],
1331
1331
  resolved: false
1332
- };
1332
+ },
1333
+ owner = getOwner();
1333
1334
  const listContext = useContext(SuspenseListContext);
1334
1335
  if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
1336
+ let dispose;
1337
+ onCleanup(() => dispose && dispose());
1335
1338
  return createComponent(SuspenseContext.Provider, {
1336
1339
  value: store,
1337
1340
  get children() {
@@ -1340,13 +1343,17 @@ function Suspense(props) {
1340
1343
  const inFallback = store.inFallback(),
1341
1344
  visibleContent = showContent ? showContent() : true,
1342
1345
  visibleFallback = showFallback ? showFallback() : true;
1346
+ dispose && dispose();
1343
1347
  if (!inFallback && visibleContent) {
1344
1348
  store.resolved = true;
1345
1349
  resumeEffects(store.effects);
1346
1350
  return rendered;
1347
1351
  }
1348
1352
  if (!visibleFallback) return;
1349
- return props.fallback;
1353
+ return createRoot(disposer => {
1354
+ dispose = disposer;
1355
+ return props.fallback;
1356
+ }, owner);
1350
1357
  });
1351
1358
  }
1352
1359
  });
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "name": "solid-js",
3
3
  "description": "A declarative JavaScript library for building user interfaces.",
4
- "version": "1.2.2",
4
+ "version": "1.2.3",
5
5
  "author": "Ryan Carniato",
6
6
  "license": "MIT",
7
7
  "homepage": "https://github.com/solidjs/solid#readme",
@@ -132,5 +132,5 @@
132
132
  "compiler",
133
133
  "performance"
134
134
  ],
135
- "gitHead": "116e636553b34a7bf9fc5d87402d0077d7f16e59"
135
+ "gitHead": "151eee8891045ff05229d6e38a71742c597102ba"
136
136
  }
@@ -65,7 +65,7 @@ function getDataNodes(target) {
65
65
  }
66
66
  function proxyDescriptor(target, property) {
67
67
  const desc = Reflect.getOwnPropertyDescriptor(target, property);
68
- if (!desc || desc.get || property === solidJs.$PROXY || property === $NODE || property === $NAME) return desc;
68
+ if (!desc || desc.get || !desc.configurable || property === solidJs.$PROXY || property === $NODE || property === $NAME) return desc;
69
69
  delete desc.value;
70
70
  delete desc.writable;
71
71
  desc.get = () => target[solidJs.$PROXY][property];
package/store/dist/dev.js CHANGED
@@ -61,7 +61,7 @@ function getDataNodes(target) {
61
61
  }
62
62
  function proxyDescriptor(target, property) {
63
63
  const desc = Reflect.getOwnPropertyDescriptor(target, property);
64
- if (!desc || desc.get || property === $PROXY || property === $NODE || property === $NAME) return desc;
64
+ if (!desc || desc.get || !desc.configurable || property === $PROXY || property === $NODE || property === $NAME) return desc;
65
65
  delete desc.value;
66
66
  delete desc.writable;
67
67
  desc.get = () => target[$PROXY][property];
@@ -62,7 +62,7 @@ function getDataNodes(target) {
62
62
  }
63
63
  function proxyDescriptor(target, property) {
64
64
  const desc = Reflect.getOwnPropertyDescriptor(target, property);
65
- if (!desc || desc.get || property === solidJs.$PROXY || property === $NODE || property === $NAME) return desc;
65
+ if (!desc || desc.get || !desc.configurable || property === solidJs.$PROXY || property === $NODE || property === $NAME) return desc;
66
66
  delete desc.value;
67
67
  delete desc.writable;
68
68
  desc.get = () => target[solidJs.$PROXY][property];
@@ -58,7 +58,7 @@ function getDataNodes(target) {
58
58
  }
59
59
  function proxyDescriptor(target, property) {
60
60
  const desc = Reflect.getOwnPropertyDescriptor(target, property);
61
- if (!desc || desc.get || property === $PROXY || property === $NODE || property === $NAME) return desc;
61
+ if (!desc || desc.get || !desc.configurable || property === $PROXY || property === $NODE || property === $NAME) return desc;
62
62
  delete desc.value;
63
63
  delete desc.writable;
64
64
  desc.get = () => target[$PROXY][property];