solid-js 1.2.0 → 1.2.1

package/dist/dev.cjs

@@ -553,10 +553,11 @@ function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
 function readSignal() {
-  if (this.state && this.sources) {
+  const runningTransition = Transition && Transition.running;
+  if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
     const updates = Updates;
     Updates = null;
-    this.state === STALE || Transition && Transition.running && this.tState ? updateComputation(this) : lookDownstream(this);
+    !runningTransition && this.state === STALE || runningTransition && this.tState === STALE ? updateComputation(this) : lookDownstream(this);
     Updates = updates;
   }
   if (Listener) {
@@ -576,7 +577,7 @@ function readSignal() {
       this.observerSlots.push(Listener.sources.length - 1);
     }
   }
-  if (Transition && Transition.running && Transition.sources.has(this)) return this.tValue;
+  if (runningTransition && Transition.sources.has(this)) return this.tValue;
   return this.value;
 }
 function writeSignal(node, value, isComp) {
@@ -624,7 +625,7 @@ function updateComputation(node) {
         listener = Listener,
         time = ExecCount;
   Listener = Owner = node;
-  runComputation(node, node.value, time);
+  runComputation(node, Transition && Transition.running && Transition.sources.has(node) ? node.tValue : node.value, time);
   if (Transition && !Transition.running && Transition.sources.has(node)) {
     queueMicrotask(() => {
       runUpdates(() => {
@@ -689,7 +690,7 @@ function runTop(node) {
   const ancestors = [node];
   while ((node = node.owner) && (!node.updatedAt || node.updatedAt < ExecCount)) {
     if (runningTransition && Transition.disposed.has(node)) return;
-    if (node.state || runningTransition && node.tState) ancestors.push(node);
+    if (!runningTransition && node.state || runningTransition && node.tState) ancestors.push(node);
   }
   for (let i = ancestors.length - 1; i >= 0; i--) {
     node = ancestors[i];
@@ -700,9 +701,9 @@ function runTop(node) {
         if (Transition.disposed.has(top)) return;
       }
     }
-    if (node.state === STALE || runningTransition && node.tState === STALE) {
+    if (!runningTransition && node.state === STALE || runningTransition && node.tState === STALE) {
       updateComputation(node);
-    } else if (node.state === PENDING || runningTransition && node.tState === PENDING) {
+    } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
       lookDownstream(node);
@@ -806,10 +807,11 @@ function runUserEffects(queue) {
 }
 function lookDownstream(node) {
   node.state = 0;
+  const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (source.state === STALE || Transition && Transition.running && source.tState) runTop(source);else if (source.state === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
     }
   }
 }
@@ -817,7 +819,7 @@ function markUpstream(node) {
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.observers.length; i += 1) {
     const o = node.observers[i];
-    if (!o.state || runningTransition && !o.tState) {
+    if (!runningTransition && !o.state || runningTransition && !o.tState) {
       if (runningTransition) o.tState = PENDING;else o.state = PENDING;
       if (o.pure) Updates.push(o);else Effects.push(o);
       o.observers && markUpstream(o);

package/dist/dev.js

@@ -549,10 +549,11 @@ function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
 function readSignal() {
-  if (this.state && this.sources) {
+  const runningTransition = Transition && Transition.running;
+  if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
     const updates = Updates;
     Updates = null;
-    this.state === STALE || Transition && Transition.running && this.tState ? updateComputation(this) : lookDownstream(this);
+    !runningTransition && this.state === STALE || runningTransition && this.tState === STALE ? updateComputation(this) : lookDownstream(this);
     Updates = updates;
   }
   if (Listener) {
@@ -572,7 +573,7 @@ function readSignal() {
       this.observerSlots.push(Listener.sources.length - 1);
     }
   }
-  if (Transition && Transition.running && Transition.sources.has(this)) return this.tValue;
+  if (runningTransition && Transition.sources.has(this)) return this.tValue;
   return this.value;
 }
 function writeSignal(node, value, isComp) {
@@ -620,7 +621,7 @@ function updateComputation(node) {
         listener = Listener,
         time = ExecCount;
   Listener = Owner = node;
-  runComputation(node, node.value, time);
+  runComputation(node, Transition && Transition.running && Transition.sources.has(node) ? node.tValue : node.value, time);
   if (Transition && !Transition.running && Transition.sources.has(node)) {
     queueMicrotask(() => {
       runUpdates(() => {
@@ -685,7 +686,7 @@ function runTop(node) {
   const ancestors = [node];
   while ((node = node.owner) && (!node.updatedAt || node.updatedAt < ExecCount)) {
     if (runningTransition && Transition.disposed.has(node)) return;
-    if (node.state || runningTransition && node.tState) ancestors.push(node);
+    if (!runningTransition && node.state || runningTransition && node.tState) ancestors.push(node);
   }
   for (let i = ancestors.length - 1; i >= 0; i--) {
     node = ancestors[i];
@@ -696,9 +697,9 @@ function runTop(node) {
         if (Transition.disposed.has(top)) return;
       }
     }
-    if (node.state === STALE || runningTransition && node.tState === STALE) {
+    if (!runningTransition && node.state === STALE || runningTransition && node.tState === STALE) {
       updateComputation(node);
-    } else if (node.state === PENDING || runningTransition && node.tState === PENDING) {
+    } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
       lookDownstream(node);
@@ -802,10 +803,11 @@ function runUserEffects(queue) {
 }
 function lookDownstream(node) {
   node.state = 0;
+  const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (source.state === STALE || Transition && Transition.running && source.tState) runTop(source);else if (source.state === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
     }
   }
 }
@@ -813,7 +815,7 @@ function markUpstream(node) {
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.observers.length; i += 1) {
     const o = node.observers[i];
-    if (!o.state || runningTransition && !o.tState) {
+    if (!runningTransition && !o.state || runningTransition && !o.tState) {
       if (runningTransition) o.tState = PENDING;else o.state = PENDING;
       if (o.pure) Updates.push(o);else Effects.push(o);
       o.observers && markUpstream(o);

package/dist/solid.cjs

@@ -502,10 +502,11 @@ function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
 function readSignal() {
-  if (this.state && this.sources) {
+  const runningTransition = Transition && Transition.running;
+  if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
     const updates = Updates;
     Updates = null;
-    this.state === STALE || Transition && Transition.running && this.tState ? updateComputation(this) : lookDownstream(this);
+    !runningTransition && this.state === STALE || runningTransition && this.tState === STALE ? updateComputation(this) : lookDownstream(this);
     Updates = updates;
   }
   if (Listener) {
@@ -525,7 +526,7 @@ function readSignal() {
       this.observerSlots.push(Listener.sources.length - 1);
     }
   }
-  if (Transition && Transition.running && Transition.sources.has(this)) return this.tValue;
+  if (runningTransition && Transition.sources.has(this)) return this.tValue;
   return this.value;
 }
 function writeSignal(node, value, isComp) {
@@ -573,7 +574,7 @@ function updateComputation(node) {
         listener = Listener,
         time = ExecCount;
   Listener = Owner = node;
-  runComputation(node, node.value, time);
+  runComputation(node, Transition && Transition.running && Transition.sources.has(node) ? node.tValue : node.value, time);
   if (Transition && !Transition.running && Transition.sources.has(node)) {
     queueMicrotask(() => {
       runUpdates(() => {
@@ -637,7 +638,7 @@ function runTop(node) {
   const ancestors = [node];
   while ((node = node.owner) && (!node.updatedAt || node.updatedAt < ExecCount)) {
     if (runningTransition && Transition.disposed.has(node)) return;
-    if (node.state || runningTransition && node.tState) ancestors.push(node);
+    if (!runningTransition && node.state || runningTransition && node.tState) ancestors.push(node);
   }
   for (let i = ancestors.length - 1; i >= 0; i--) {
     node = ancestors[i];
@@ -648,9 +649,9 @@ function runTop(node) {
         if (Transition.disposed.has(top)) return;
       }
     }
-    if (node.state === STALE || runningTransition && node.tState === STALE) {
+    if (!runningTransition && node.state === STALE || runningTransition && node.tState === STALE) {
       updateComputation(node);
-    } else if (node.state === PENDING || runningTransition && node.tState === PENDING) {
+    } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
       lookDownstream(node);
@@ -753,10 +754,11 @@ function runUserEffects(queue) {
 }
 function lookDownstream(node) {
   node.state = 0;
+  const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (source.state === STALE || Transition && Transition.running && source.tState) runTop(source);else if (source.state === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
     }
   }
 }
@@ -764,7 +766,7 @@ function markUpstream(node) {
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.observers.length; i += 1) {
     const o = node.observers[i];
-    if (!o.state || runningTransition && !o.tState) {
+    if (!runningTransition && !o.state || runningTransition && !o.tState) {
       if (runningTransition) o.tState = PENDING;else o.state = PENDING;
       if (o.pure) Updates.push(o);else Effects.push(o);
       o.observers && markUpstream(o);

package/dist/solid.js

@@ -498,10 +498,11 @@ function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
 function readSignal() {
-  if (this.state && this.sources) {
+  const runningTransition = Transition && Transition.running;
+  if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
     const updates = Updates;
     Updates = null;
-    this.state === STALE || Transition && Transition.running && this.tState ? updateComputation(this) : lookDownstream(this);
+    !runningTransition && this.state === STALE || runningTransition && this.tState === STALE ? updateComputation(this) : lookDownstream(this);
     Updates = updates;
   }
   if (Listener) {
@@ -521,7 +522,7 @@ function readSignal() {
       this.observerSlots.push(Listener.sources.length - 1);
     }
   }
-  if (Transition && Transition.running && Transition.sources.has(this)) return this.tValue;
+  if (runningTransition && Transition.sources.has(this)) return this.tValue;
   return this.value;
 }
 function writeSignal(node, value, isComp) {
@@ -569,7 +570,7 @@ function updateComputation(node) {
         listener = Listener,
         time = ExecCount;
   Listener = Owner = node;
-  runComputation(node, node.value, time);
+  runComputation(node, Transition && Transition.running && Transition.sources.has(node) ? node.tValue : node.value, time);
   if (Transition && !Transition.running && Transition.sources.has(node)) {
     queueMicrotask(() => {
       runUpdates(() => {
@@ -633,7 +634,7 @@ function runTop(node) {
   const ancestors = [node];
   while ((node = node.owner) && (!node.updatedAt || node.updatedAt < ExecCount)) {
     if (runningTransition && Transition.disposed.has(node)) return;
-    if (node.state || runningTransition && node.tState) ancestors.push(node);
+    if (!runningTransition && node.state || runningTransition && node.tState) ancestors.push(node);
   }
   for (let i = ancestors.length - 1; i >= 0; i--) {
     node = ancestors[i];
@@ -644,9 +645,9 @@ function runTop(node) {
         if (Transition.disposed.has(top)) return;
       }
     }
-    if (node.state === STALE || runningTransition && node.tState === STALE) {
+    if (!runningTransition && node.state === STALE || runningTransition && node.tState === STALE) {
       updateComputation(node);
-    } else if (node.state === PENDING || runningTransition && node.tState === PENDING) {
+    } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
       lookDownstream(node);
@@ -749,10 +750,11 @@ function runUserEffects(queue) {
 }
 function lookDownstream(node) {
   node.state = 0;
+  const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (source.state === STALE || Transition && Transition.running && source.tState) runTop(source);else if (source.state === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
     }
   }
 }
@@ -760,7 +762,7 @@ function markUpstream(node) {
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.observers.length; i += 1) {
     const o = node.observers[i];
-    if (!o.state || runningTransition && !o.tState) {
+    if (!runningTransition && !o.state || runningTransition && !o.tState) {
       if (runningTransition) o.tState = PENDING;else o.state = PENDING;
       if (o.pure) Updates.push(o);else Effects.push(o);
       o.observers && markUpstream(o);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "solid-js",
   "description": "A declarative JavaScript library for building user interfaces.",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "author": "Ryan Carniato",
   "license": "MIT",
   "homepage": "https://github.com/solidjs/solid#readme",
@@ -132,5 +132,5 @@
     "compiler",
     "performance"
   ],
-  "gitHead": "e6bbfa693db53cffd3372ee8bf1c61e3f1d47064"
+  "gitHead": "8bca8fa83837ac7406bc76813fedbc72bbe11a01"
 }

package/types/jsx.d.ts

@@ -2874,7 +2874,8 @@ export namespace JSX {
     extends FilterPrimitiveElementSVGAttributes<T>,
       ExternalResourceSVGAttributes,
       StylableSVGAttributes {
-    preserveAspectRatio: SVGPreserveAspectRatio;
+    preserveAspectRatio?: SVGPreserveAspectRatio;
+    href?: string;
   }
   interface FeMergeSVGAttributes<T>
     extends FilterPrimitiveElementSVGAttributes<T>,
@@ -2977,6 +2978,7 @@ export namespace JSX {
     width?: number | string;
     height?: number | string;
     preserveAspectRatio?: ImagePreserveAspectRatio;
+    href?: string;
   }
   interface LineSVGAttributes<T>
     extends GraphicsElementSVGAttributes<T>,