solid-js 1.2.0-beta.0 → 1.2.3

package/dist/dev.cjs

@@ -553,10 +553,11 @@ function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
 function readSignal() {
-  if (this.state && this.sources) {
+  const runningTransition = Transition && Transition.running;
+  if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
     const updates = Updates;
     Updates = null;
-    this.state === STALE || Transition && Transition.running && this.tState ? updateComputation(this) : lookDownstream(this);
+    !runningTransition && this.state === STALE || runningTransition && this.tState === STALE ? updateComputation(this) : lookDownstream(this);
     Updates = updates;
   }
   if (Listener) {
@@ -576,7 +577,7 @@ function readSignal() {
       this.observerSlots.push(Listener.sources.length - 1);
     }
   }
-  if (Transition && Transition.running && Transition.sources.has(this)) return this.tValue;
+  if (runningTransition && Transition.sources.has(this)) return this.tValue;
   return this.value;
 }
 function writeSignal(node, value, isComp) {
@@ -624,7 +625,7 @@ function updateComputation(node) {
         listener = Listener,
         time = ExecCount;
   Listener = Owner = node;
-  runComputation(node, node.value, time);
+  runComputation(node, Transition && Transition.running && Transition.sources.has(node) ? node.tValue : node.value, time);
   if (Transition && !Transition.running && Transition.sources.has(node)) {
     queueMicrotask(() => {
       runUpdates(() => {
@@ -689,7 +690,7 @@ function runTop(node) {
   const ancestors = [node];
   while ((node = node.owner) && (!node.updatedAt || node.updatedAt < ExecCount)) {
     if (runningTransition && Transition.disposed.has(node)) return;
-    if (node.state || runningTransition && node.tState) ancestors.push(node);
+    if (!runningTransition && node.state || runningTransition && node.tState) ancestors.push(node);
   }
   for (let i = ancestors.length - 1; i >= 0; i--) {
     node = ancestors[i];
@@ -700,9 +701,9 @@ function runTop(node) {
         if (Transition.disposed.has(top)) return;
       }
     }
-    if (node.state === STALE || runningTransition && node.tState === STALE) {
+    if (!runningTransition && node.state === STALE || runningTransition && node.tState === STALE) {
       updateComputation(node);
-    } else if (node.state === PENDING || runningTransition && node.tState === PENDING) {
+    } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
       lookDownstream(node);
@@ -806,10 +807,11 @@ function runUserEffects(queue) {
 }
 function lookDownstream(node) {
   node.state = 0;
+  const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (source.state === STALE || Transition && Transition.running && source.tState) runTop(source);else if (source.state === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
     }
   }
 }
@@ -817,7 +819,7 @@ function markUpstream(node) {
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.observers.length; i += 1) {
     const o = node.observers[i];
-    if (!o.state || runningTransition && !o.tState) {
+    if (!runningTransition && !o.state || runningTransition && !o.tState) {
       if (runningTransition) o.tState = PENDING;else o.state = PENDING;
       if (o.pure) Updates.push(o);else Effects.push(o);
       o.observers && markUpstream(o);
@@ -1407,9 +1409,12 @@ function Suspense(props) {
     inFallback,
     effects: [],
     resolved: false
-  };
+  },
+        owner = getOwner();
   const listContext = useContext(SuspenseListContext);
   if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
+  let dispose;
+  onCleanup(() => dispose && dispose());
   return createComponent(SuspenseContext.Provider, {
     value: store,
     get children() {
@@ -1418,13 +1423,17 @@ function Suspense(props) {
         const inFallback = store.inFallback(),
               visibleContent = showContent ? showContent() : true,
               visibleFallback = showFallback ? showFallback() : true;
+        dispose && dispose();
         if (!inFallback && visibleContent) {
           store.resolved = true;
           resumeEffects(store.effects);
           return rendered;
         }
         if (!visibleFallback) return;
-        return props.fallback;
+        return createRoot(disposer => {
+          dispose = disposer;
+          return props.fallback;
+        }, owner);
       });
     }
   });

package/dist/dev.js

@@ -549,10 +549,11 @@ function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
 function readSignal() {
-  if (this.state && this.sources) {
+  const runningTransition = Transition && Transition.running;
+  if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
     const updates = Updates;
     Updates = null;
-    this.state === STALE || Transition && Transition.running && this.tState ? updateComputation(this) : lookDownstream(this);
+    !runningTransition && this.state === STALE || runningTransition && this.tState === STALE ? updateComputation(this) : lookDownstream(this);
     Updates = updates;
   }
   if (Listener) {
@@ -572,7 +573,7 @@ function readSignal() {
       this.observerSlots.push(Listener.sources.length - 1);
     }
   }
-  if (Transition && Transition.running && Transition.sources.has(this)) return this.tValue;
+  if (runningTransition && Transition.sources.has(this)) return this.tValue;
   return this.value;
 }
 function writeSignal(node, value, isComp) {
@@ -620,7 +621,7 @@ function updateComputation(node) {
         listener = Listener,
         time = ExecCount;
   Listener = Owner = node;
-  runComputation(node, node.value, time);
+  runComputation(node, Transition && Transition.running && Transition.sources.has(node) ? node.tValue : node.value, time);
   if (Transition && !Transition.running && Transition.sources.has(node)) {
     queueMicrotask(() => {
       runUpdates(() => {
@@ -685,7 +686,7 @@ function runTop(node) {
   const ancestors = [node];
   while ((node = node.owner) && (!node.updatedAt || node.updatedAt < ExecCount)) {
     if (runningTransition && Transition.disposed.has(node)) return;
-    if (node.state || runningTransition && node.tState) ancestors.push(node);
+    if (!runningTransition && node.state || runningTransition && node.tState) ancestors.push(node);
   }
   for (let i = ancestors.length - 1; i >= 0; i--) {
     node = ancestors[i];
@@ -696,9 +697,9 @@ function runTop(node) {
         if (Transition.disposed.has(top)) return;
       }
     }
-    if (node.state === STALE || runningTransition && node.tState === STALE) {
+    if (!runningTransition && node.state === STALE || runningTransition && node.tState === STALE) {
       updateComputation(node);
-    } else if (node.state === PENDING || runningTransition && node.tState === PENDING) {
+    } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
       lookDownstream(node);
@@ -802,10 +803,11 @@ function runUserEffects(queue) {
 }
 function lookDownstream(node) {
   node.state = 0;
+  const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (source.state === STALE || Transition && Transition.running && source.tState) runTop(source);else if (source.state === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
     }
   }
 }
@@ -813,7 +815,7 @@ function markUpstream(node) {
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.observers.length; i += 1) {
     const o = node.observers[i];
-    if (!o.state || runningTransition && !o.tState) {
+    if (!runningTransition && !o.state || runningTransition && !o.tState) {
       if (runningTransition) o.tState = PENDING;else o.state = PENDING;
       if (o.pure) Updates.push(o);else Effects.push(o);
       o.observers && markUpstream(o);
@@ -1403,9 +1405,12 @@ function Suspense(props) {
     inFallback,
     effects: [],
     resolved: false
-  };
+  },
+        owner = getOwner();
   const listContext = useContext(SuspenseListContext);
   if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
+  let dispose;
+  onCleanup(() => dispose && dispose());
   return createComponent(SuspenseContext.Provider, {
     value: store,
     get children() {
@@ -1414,13 +1419,17 @@ function Suspense(props) {
         const inFallback = store.inFallback(),
               visibleContent = showContent ? showContent() : true,
               visibleFallback = showFallback ? showFallback() : true;
+        dispose && dispose();
         if (!inFallback && visibleContent) {
           store.resolved = true;
           resumeEffects(store.effects);
           return rendered;
         }
         if (!visibleFallback) return;
-        return props.fallback;
+        return createRoot(disposer => {
+          dispose = disposer;
+          return props.fallback;
+        }, owner);
       });
     }
   });

package/dist/server.cjs

@@ -510,6 +510,7 @@ exports.SuspenseList = SuspenseList;
 exports.Switch = Switch;
 exports.awaitSuspense = awaitSuspense;
 exports.batch = batch;
+exports.children = children;
 exports.createComponent = createComponent;
 exports.createComputed = createComputed;
 exports.createContext = createContext;

package/dist/server.js

@@ -494,4 +494,4 @@ function awaitSuspense(fn) {
   });
 }
 
-export { $PROXY, DEV, ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, awaitSuspense, batch, createComponent, createComputed, createContext, createDeferred, createEffect, createMemo, createRenderEffect, createResource, createRoot, createSelector, createSignal, createUniqueId, enableScheduling, equalFn, from, getListener, getOwner, lazy, mapArray, mergeProps, observable, on, onCleanup, onError, onMount, requestCallback, runWithOwner, sharedConfig, splitProps, startTransition, untrack, useContext, useTransition };
+export { $PROXY, DEV, ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, awaitSuspense, batch, children, createComponent, createComputed, createContext, createDeferred, createEffect, createMemo, createRenderEffect, createResource, createRoot, createSelector, createSignal, createUniqueId, enableScheduling, equalFn, from, getListener, getOwner, lazy, mapArray, mergeProps, observable, on, onCleanup, onError, onMount, requestCallback, runWithOwner, sharedConfig, splitProps, startTransition, untrack, useContext, useTransition };

package/dist/solid.cjs

@@ -502,10 +502,11 @@ function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
 function readSignal() {
-  if (this.state && this.sources) {
+  const runningTransition = Transition && Transition.running;
+  if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
     const updates = Updates;
     Updates = null;
-    this.state === STALE || Transition && Transition.running && this.tState ? updateComputation(this) : lookDownstream(this);
+    !runningTransition && this.state === STALE || runningTransition && this.tState === STALE ? updateComputation(this) : lookDownstream(this);
     Updates = updates;
   }
   if (Listener) {
@@ -525,7 +526,7 @@ function readSignal() {
       this.observerSlots.push(Listener.sources.length - 1);
     }
   }
-  if (Transition && Transition.running && Transition.sources.has(this)) return this.tValue;
+  if (runningTransition && Transition.sources.has(this)) return this.tValue;
   return this.value;
 }
 function writeSignal(node, value, isComp) {
@@ -573,7 +574,7 @@ function updateComputation(node) {
         listener = Listener,
         time = ExecCount;
   Listener = Owner = node;
-  runComputation(node, node.value, time);
+  runComputation(node, Transition && Transition.running && Transition.sources.has(node) ? node.tValue : node.value, time);
   if (Transition && !Transition.running && Transition.sources.has(node)) {
     queueMicrotask(() => {
       runUpdates(() => {
@@ -637,7 +638,7 @@ function runTop(node) {
   const ancestors = [node];
   while ((node = node.owner) && (!node.updatedAt || node.updatedAt < ExecCount)) {
     if (runningTransition && Transition.disposed.has(node)) return;
-    if (node.state || runningTransition && node.tState) ancestors.push(node);
+    if (!runningTransition && node.state || runningTransition && node.tState) ancestors.push(node);
   }
   for (let i = ancestors.length - 1; i >= 0; i--) {
     node = ancestors[i];
@@ -648,9 +649,9 @@ function runTop(node) {
         if (Transition.disposed.has(top)) return;
       }
     }
-    if (node.state === STALE || runningTransition && node.tState === STALE) {
+    if (!runningTransition && node.state === STALE || runningTransition && node.tState === STALE) {
       updateComputation(node);
-    } else if (node.state === PENDING || runningTransition && node.tState === PENDING) {
+    } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
       lookDownstream(node);
@@ -753,10 +754,11 @@ function runUserEffects(queue) {
 }
 function lookDownstream(node) {
   node.state = 0;
+  const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (source.state === STALE || Transition && Transition.running && source.tState) runTop(source);else if (source.state === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
     }
   }
 }
@@ -764,7 +766,7 @@ function markUpstream(node) {
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.observers.length; i += 1) {
     const o = node.observers[i];
-    if (!o.state || runningTransition && !o.tState) {
+    if (!runningTransition && !o.state || runningTransition && !o.tState) {
       if (runningTransition) o.tState = PENDING;else o.state = PENDING;
       if (o.pure) Updates.push(o);else Effects.push(o);
       o.observers && markUpstream(o);
@@ -1331,9 +1333,12 @@ function Suspense(props) {
     inFallback,
     effects: [],
     resolved: false
-  };
+  },
+        owner = getOwner();
   const listContext = useContext(SuspenseListContext);
   if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
+  let dispose;
+  onCleanup(() => dispose && dispose());
   return createComponent(SuspenseContext.Provider, {
     value: store,
     get children() {
@@ -1342,13 +1347,17 @@ function Suspense(props) {
         const inFallback = store.inFallback(),
               visibleContent = showContent ? showContent() : true,
               visibleFallback = showFallback ? showFallback() : true;
+        dispose && dispose();
         if (!inFallback && visibleContent) {
           store.resolved = true;
           resumeEffects(store.effects);
           return rendered;
         }
         if (!visibleFallback) return;
-        return props.fallback;
+        return createRoot(disposer => {
+          dispose = disposer;
+          return props.fallback;
+        }, owner);
       });
     }
   });

package/dist/solid.js

@@ -498,10 +498,11 @@ function getSuspenseContext() {
   return SuspenseContext || (SuspenseContext = createContext({}));
 }
 function readSignal() {
-  if (this.state && this.sources) {
+  const runningTransition = Transition && Transition.running;
+  if (this.sources && (!runningTransition && this.state || runningTransition && this.tState)) {
     const updates = Updates;
     Updates = null;
-    this.state === STALE || Transition && Transition.running && this.tState ? updateComputation(this) : lookDownstream(this);
+    !runningTransition && this.state === STALE || runningTransition && this.tState === STALE ? updateComputation(this) : lookDownstream(this);
     Updates = updates;
   }
   if (Listener) {
@@ -521,7 +522,7 @@ function readSignal() {
       this.observerSlots.push(Listener.sources.length - 1);
     }
   }
-  if (Transition && Transition.running && Transition.sources.has(this)) return this.tValue;
+  if (runningTransition && Transition.sources.has(this)) return this.tValue;
   return this.value;
 }
 function writeSignal(node, value, isComp) {
@@ -569,7 +570,7 @@ function updateComputation(node) {
         listener = Listener,
         time = ExecCount;
   Listener = Owner = node;
-  runComputation(node, node.value, time);
+  runComputation(node, Transition && Transition.running && Transition.sources.has(node) ? node.tValue : node.value, time);
   if (Transition && !Transition.running && Transition.sources.has(node)) {
     queueMicrotask(() => {
       runUpdates(() => {
@@ -633,7 +634,7 @@ function runTop(node) {
   const ancestors = [node];
   while ((node = node.owner) && (!node.updatedAt || node.updatedAt < ExecCount)) {
     if (runningTransition && Transition.disposed.has(node)) return;
-    if (node.state || runningTransition && node.tState) ancestors.push(node);
+    if (!runningTransition && node.state || runningTransition && node.tState) ancestors.push(node);
   }
   for (let i = ancestors.length - 1; i >= 0; i--) {
     node = ancestors[i];
@@ -644,9 +645,9 @@ function runTop(node) {
         if (Transition.disposed.has(top)) return;
       }
     }
-    if (node.state === STALE || runningTransition && node.tState === STALE) {
+    if (!runningTransition && node.state === STALE || runningTransition && node.tState === STALE) {
       updateComputation(node);
-    } else if (node.state === PENDING || runningTransition && node.tState === PENDING) {
+    } else if (!runningTransition && node.state === PENDING || runningTransition && node.tState === PENDING) {
       const updates = Updates;
       Updates = null;
       lookDownstream(node);
@@ -749,10 +750,11 @@ function runUserEffects(queue) {
 }
 function lookDownstream(node) {
   node.state = 0;
+  const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.sources.length; i += 1) {
     const source = node.sources[i];
     if (source.sources) {
-      if (source.state === STALE || Transition && Transition.running && source.tState) runTop(source);else if (source.state === PENDING) lookDownstream(source);
+      if (!runningTransition && source.state === STALE || runningTransition && source.tState === STALE) runTop(source);else if (!runningTransition && source.state === PENDING || runningTransition && source.tState === PENDING) lookDownstream(source);
     }
   }
 }
@@ -760,7 +762,7 @@ function markUpstream(node) {
   const runningTransition = Transition && Transition.running;
   for (let i = 0; i < node.observers.length; i += 1) {
     const o = node.observers[i];
-    if (!o.state || runningTransition && !o.tState) {
+    if (!runningTransition && !o.state || runningTransition && !o.tState) {
       if (runningTransition) o.tState = PENDING;else o.state = PENDING;
       if (o.pure) Updates.push(o);else Effects.push(o);
       o.observers && markUpstream(o);
@@ -1327,9 +1329,12 @@ function Suspense(props) {
     inFallback,
     effects: [],
     resolved: false
-  };
+  },
+        owner = getOwner();
   const listContext = useContext(SuspenseListContext);
   if (listContext) [showContent, showFallback] = listContext.register(store.inFallback);
+  let dispose;
+  onCleanup(() => dispose && dispose());
   return createComponent(SuspenseContext.Provider, {
     value: store,
     get children() {
@@ -1338,13 +1343,17 @@ function Suspense(props) {
         const inFallback = store.inFallback(),
               visibleContent = showContent ? showContent() : true,
               visibleFallback = showFallback ? showFallback() : true;
+        dispose && dispose();
         if (!inFallback && visibleContent) {
           store.resolved = true;
           resumeEffects(store.effects);
           return rendered;
         }
         if (!visibleFallback) return;
-        return props.fallback;
+        return createRoot(disposer => {
+          dispose = disposer;
+          return props.fallback;
+        }, owner);
       });
     }
   });

package/h/README.md

@@ -0,0 +1,99 @@
+# Solid HyperScript
+
+This sub module provides a HyperScript method for Solid. This is useful to use Solid in non-compiled environments or in some environments where you can only use a standard JSX transform. This method can be used as the JSX factory function.
+
+HyperScript function takes a few forms. The 2nd props argument is optional. Children may be passed as either an array to the 2nd/3rd argument or as every argument past the 2nd.
+
+```js
+// create an element with a title attribute
+h("button", { title: "My button" }, "Click Me")
+
+// create a component with a title prop
+h(Button, { title: "My button" }, "Click Me")
+
+// create an element with many children
+h("div", { title: "My button" }, h("span", "1"), h("span", "2"), h("span", "3"))
+```
+
+This is the least efficient way to use Solid as it requires a slightly larger runtime that isn't treeshakebable, and cannot leverage anything in the way of analysis, so it requires manual wrapping of expressions and has a few other caveats (see below).
+
+## Example
+
+```js
+import { render } from "solid-js/web";
+import h from "solid-js/h";
+import { createSignal } from "solid-js";
+
+function Button(props) {
+  return h("button.btn-primary", props)
+}
+
+function Counter() {
+  const [count, setCount] = createSignal(0);
+  const increment = (e) => setCount(c => c + 1);
+
+  return h(Button, { type: "button", onClick: increment }, count);
+}
+
+render(Counter, document.getElementById("app"));
+```
+
+## Differences from JSX
+
+There are a few differences from Solid's JSX that are important to note. And also apply when attempting use any transformation that would compile to HyperScript.
+
+1. Reactive expression must be manually wrapped in functions to be reactive.
+
+```js
+// jsx
+<div id={props.id}>{firstName() + lastName()}</div>
+
+// hyperscript
+h("div", { id: () => props.id }, () => firstName() + lastName())
+```
+
+2. Merging spreads requires using the merge props helper to keep reactivity
+
+```js
+// jsx
+<div class={selectedClass()} {...props} />
+
+// hyperscript
+import { mergeProps } from "solid-js"
+
+h("div", mergeProps({ class: selectedClass }, props))
+```
+
+3. Events on components require explicit event in the arguments
+
+Solid's HyperScript automatically wraps functions passed to props of components with no arguments in getters so you need to provide one to prevent this. The same applies to render props like in the `<For>` component.
+
+```js
+// good
+h(Button, { onClick: (e) => console.log("Hi")});
+
+// bad
+h(Button, { onClick: () => console.log("Hi")})
+```
+
+4. All refs are callback form
+
+We can't do the compiled assigment trick so only the callback form is supported.
+
+```js
+let myEl;
+
+h(div, { ref: (el) => myEl = el });
+```
+
+5. There is a shorthand for static id and classes
+
+```js
+h("div#some-id.my-class")
+```
+
+6. Fragments are just arrays
+
+```js
+[h("span", "1"), h("span", "2")]
+```

package/html/README.md

@@ -0,0 +1,84 @@
+# Solid Tagged Template Literals
+
+This sub module provides a Tagged Template Literal `html` method for Solid. This is useful to use Solid in non-compiled environments. This method can be used as replacement for JSX.
+
+`html` uses `${}` to escape into JavaScript expressions. Components are closed with `<//>`
+
+```js
+// create an element with a title attribute
+html`<button title="My button">Click Me</button>`
+
+// create a component with a title prop
+html`<${Button} title="My button">Click me<//>`
+
+// create an element with dynamic attribute and spread
+html`<div title=${() => selectedClass()} ...${props} />`
+```
+
+Using `html` is slightly less efficient than JSX(but more than HyperScript), requires a larger runtime that isn't treeshakebable, and cannot leverage expression analysis, so it requires manual wrapping of expressions and has a few other caveats (see below).
+
+## Example
+
+```js
+import { render } from "solid-js/web";
+import html from "solid-js/html";
+import { createSignal } from "solid-js";
+
+function Button(props) {
+  return html`<button class="btn-primary" ...${props} />`;
+}
+
+function Counter() {
+  const [count, setCount] = createSignal(0);
+  const increment = (e) => setCount((c) => c + 1);
+
+  return html`<${Button} type="button" onClick=${increment}>${count}<//>`;
+}
+
+render(Counter, document.getElementById("app"));
+```
+
+## Differences from JSX
+
+There are a few differences from Solid's JSX that are important to note.
+
+1. Reactive expression must be manually wrapped in functions to be reactive.
+
+```js
+// jsx
+<div id={props.id}>{firstName() + lastName()}</div>
+
+// hyperscript
+html`<div id=${() => props.id}>${() => firstName() + lastName()}</div>`
+```
+
+2. Events on components require explicit event in the arguments
+
+Solid's Tagged Template Literals automatically wraps functions passed to props of components with no arguments in getters so you need to provide one to prevent this. The same applies to render props like in the `<For>` component.
+
+```js
+// good
+html`<${Button} onClick=${(e) => console.log("Hi")} />`;
+
+// bad
+html`<${Button} onClick=${() => console.log("Hi")} />`;
+```
+
+4. All refs are callback form
+
+We can't do the compiled assigment trick so only the callback form is supported.
+
+```js
+let myEl;
+html`<div ref=${(el) => myEl = el} />`;
+```
+
+5. There can be multiple top level elements
+
+No need for fragments just:
+```js
+html`
+  <div>1</div>
+  <div>2</div>
+`
+```

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "solid-js",
   "description": "A declarative JavaScript library for building user interfaces.",
-  "version": "1.2.0-beta.0",
+  "version": "1.2.3",
   "author": "Ryan Carniato",
   "license": "MIT",
   "homepage": "https://github.com/solidjs/solid#readme",
@@ -132,5 +132,5 @@
     "compiler",
     "performance"
   ],
-  "gitHead": "ec5bfa3adc09c0efd9210be6ff5096ec18c06d02"
+  "gitHead": "151eee8891045ff05229d6e38a71742c597102ba"
 }

package/store/README.md

@@ -0,0 +1,23 @@
+# Solid Store
+
+This submodules contains the means for handling deeps nested reactivity. It provides 2 main primitives `createStore` and `createMutable` which leverage proxies to create dynamic nested reactive structures.
+
+This also contains helper methods `produce` and `reconcile` which augment the behavior of the store setter method to allow for localized mutationa and data diffing.
+
+For full documentation, check out the [website](https://www.solidjs.com/docs/latest/api).
+
+## Example
+
+```js
+import { createStore } from "solid-js/store";
+
+const [store, setStore] = createStore({
+  user: {
+    firstName: "John",
+    lastName: "Smith"
+  }
+});
+
+// update store.user.firstName
+setStore("user", "firstName", "Will");
+```

package/store/dist/dev.cjs

@@ -65,7 +65,7 @@ function getDataNodes(target) {
 }
 function proxyDescriptor(target, property) {
   const desc = Reflect.getOwnPropertyDescriptor(target, property);
-  if (!desc || desc.get || property === solidJs.$PROXY || property === $NODE || property === $NAME) return desc;
+  if (!desc || desc.get || !desc.configurable || property === solidJs.$PROXY || property === $NODE || property === $NAME) return desc;
   delete desc.value;
   delete desc.writable;
   desc.get = () => target[solidJs.$PROXY][property];

package/store/dist/dev.js

@@ -61,7 +61,7 @@ function getDataNodes(target) {
 }
 function proxyDescriptor(target, property) {
   const desc = Reflect.getOwnPropertyDescriptor(target, property);
-  if (!desc || desc.get || property === $PROXY || property === $NODE || property === $NAME) return desc;
+  if (!desc || desc.get || !desc.configurable || property === $PROXY || property === $NODE || property === $NAME) return desc;
   delete desc.value;
   delete desc.writable;
   desc.get = () => target[$PROXY][property];

package/store/dist/store.cjs

@@ -62,7 +62,7 @@ function getDataNodes(target) {
 }
 function proxyDescriptor(target, property) {
   const desc = Reflect.getOwnPropertyDescriptor(target, property);
-  if (!desc || desc.get || property === solidJs.$PROXY || property === $NODE || property === $NAME) return desc;
+  if (!desc || desc.get || !desc.configurable || property === solidJs.$PROXY || property === $NODE || property === $NAME) return desc;
   delete desc.value;
   delete desc.writable;
   desc.get = () => target[solidJs.$PROXY][property];

package/store/dist/store.js

@@ -58,7 +58,7 @@ function getDataNodes(target) {
 }
 function proxyDescriptor(target, property) {
   const desc = Reflect.getOwnPropertyDescriptor(target, property);
-  if (!desc || desc.get || property === $PROXY || property === $NODE || property === $NAME) return desc;
+  if (!desc || desc.get || !desc.configurable || property === $PROXY || property === $NODE || property === $NAME) return desc;
   delete desc.value;
   delete desc.writable;
   desc.get = () => target[$PROXY][property];

package/types/jsx.d.ts

@@ -11,7 +11,7 @@ export namespace JSX {
     | Node
     | ArrayElement
     | FunctionElement
-    | string
+    | (string & {})
     | number
     | boolean
     | null
@@ -2874,7 +2874,8 @@ export namespace JSX {
     extends FilterPrimitiveElementSVGAttributes<T>,
       ExternalResourceSVGAttributes,
       StylableSVGAttributes {
-    preserveAspectRatio: SVGPreserveAspectRatio;
+    preserveAspectRatio?: SVGPreserveAspectRatio;
+    href?: string;
   }
   interface FeMergeSVGAttributes<T>
     extends FilterPrimitiveElementSVGAttributes<T>,
@@ -2977,6 +2978,7 @@ export namespace JSX {
     width?: number | string;
     height?: number | string;
     preserveAspectRatio?: ImagePreserveAspectRatio;
+    href?: string;
   }
   interface LineSVGAttributes<T>
     extends GraphicsElementSVGAttributes<T>,

package/types/server/index.d.ts

@@ -1,3 +1,3 @@
-export { createRoot, createSignal, createComputed, createRenderEffect, createEffect, createDeferred, createSelector, createMemo, getListener, onMount, onCleanup, onError, untrack, batch, on, createContext, useContext, getOwner, runWithOwner, equalFn, requestCallback, mapArray, observable, from, $PROXY, DEV } from "./reactive";
+export { createRoot, createSignal, createComputed, createRenderEffect, createEffect, createDeferred, createSelector, createMemo, getListener, onMount, onCleanup, onError, untrack, batch, on, children, createContext, useContext, getOwner, runWithOwner, equalFn, requestCallback, mapArray, observable, from, $PROXY, DEV } from "./reactive";
 export { awaitSuspense, mergeProps, splitProps, createComponent, For, Index, Show, Switch, Match, ErrorBoundary, Suspense, SuspenseList, createResource, enableScheduling, startTransition, useTransition, createUniqueId, lazy, sharedConfig } from "./rendering";
 export type { Component, Resource } from "./rendering";

package/universal/README.md

@@ -0,0 +1,102 @@
+# Solid Universal
+
+This contains the means to create the runtime for a custom renderer for Solid. This can enable using Solid to render to different platforms like native mobile and desktop, canvas or WebGL, or even the terminal. It relies on custom compilation from `babel-preset-solid` and exporting the result of `createRenderer` at a referenceable location.
+
+## Example
+
+To use a custom renderer available in the (fictional) `solid-custom-dom` package you'd configure your babelrc as:
+```json
+{
+  "presets": [
+    [
+      "babel-preset-solid",
+      {
+        "moduleName": "solid-custom-dom",
+        "generate": "universal"
+      }
+    ]
+  ]
+}
+```
+
+To create a custom renderer you must implement certain methods and export (as named exports) the results. You may also want to forward `solid-js` control flow to allow them to be auto imported as well.
+
+```js
+// example custom dom renderer
+import { createRenderer } from "solid-js/universal";
+
+const PROPERTIES = new Set(["className", "textContent"]);
+
+export const {
+  render,
+  effect,
+  memo,
+  createComponent,
+  createElement,
+  createTextNode,
+  insertNode,
+  insert,
+  spread,
+  setProp,
+  mergeProps
+} = createRenderer({
+  createElement(string) {
+    return document.createElement(string);
+  },
+  createTextNode(value) {
+    return document.createTextNode(value);
+  },
+  replaceText(textNode, value) {
+    textNode.data = value;
+  },
+  setProperty(node, name, value) {
+    if (name === "style") Object.assign(node.style, value);
+    else if (name.startsWith("on")) node[name.toLowerCase()] = value;
+    else if (PROPERTIES.has(name)) node[name] = value;
+    else node.setAttribute(name, value);
+  },
+  insertNode(parent, node, anchor) {
+    parent.insertBefore(node, anchor);
+  },
+  isTextNode(node) {
+    return node.type === 3;
+  },
+  removeNode(parent, node) {
+    parent.removeChild(node);
+  },
+  getParentNode(node) {
+    return node.parentNode;
+  },
+  getFirstChild(node) {
+    return node.firstChild;
+  },
+  getNextSibling(node) {
+    return node.nextSibling;
+  }
+});
+
+// Forward Solid control flow
+export {
+  For,
+  Show,
+  Suspense,
+  SuspenseList,
+  Switch,
+  Match,
+  Index,
+  ErrorBoundary
+} from "solid-js";
+```
+
+Then to consume:
+```js
+import { render } from "solid-custom-dom";
+
+function App() {
+  // the skies the limits
+}
+
+render(() => <App />, mountNode)
+```
+
+> Note: For TypeScript support of non-standard JSX you will need to provide your own types at a jsx-runtime entry on your package so that it can be set as the `jsxImportSource`. If mixing and matching different JSX implementations you will need use the per file pragmas.

package/web/README.md

@@ -0,0 +1,7 @@
+# Solid Web
+
+This submodule contains the web specific APIs for Solid that are mostly internal methods imported during compilation. It has all the code to render for the web on the server and the browser.
+
+In addition this modules provides the primary entry point methods `render`, `hydrate`, `renderToString`, `renderToStringAsync`, `pipeToNodeWritable`, and `pipeToWritable`. As well as a few web specific control flow components `<Portal>` and `<Dynamic>`.
+
+Refer to the [website](https://www.solidjs.com/docs/latest/api) for documentation.