solid-deps 0.0.1 → 0.0.2

package/README.md

@@ -7,7 +7,13 @@ Attach additional reactive dependencies to an existing **Solid 2 effect**—even
 ## Installation
 
 ```sh
-npm install solid-deps@0.0.1 solid-js@2.0.0-rc.17 @solidjs/signals@2.0.0-rc.17
+npm install solid-deps@0.0.2 solid-js@2.0.0-rc.17 @solidjs/signals@2.0.0-rc.17
+```
+
+With Bun:
+
+```sh
+bun add solid-deps@0.0.2 solid-js@2.0.0-rc.17 @solidjs/signals@2.0.0-rc.17
 ```
 
 **Compatibility:** This release targets **Solid 2.0.0-rc.17** (`solid-js` and `@solidjs/signals`). Both the app and `solid-deps` must resolve to the **same instance** of `@solidjs/signals`. Server-side rendering is not supported. See [Limitations](#limitations).
@@ -184,9 +190,13 @@ createEffect(async () => {
 
 `solid-deps` is experimental and restricted to Solid **2.0.0-rc.17** in browser-oriented applications. Dependency registration requires an existing **tracked computation**, not simply any owner.
 
-Keep `read()` synchronous and limited to settled reactive reads, such as signals, memos, or store properties. Do not use it to create computations, install cleanups, write signals, or perform side effects. It does not run in the target's original reactive context.
+Keep `read()` synchronous and limited to settled reactive reads, such as signals, memos, or store properties. Do not use it to create computations, install cleanups, write signals, or perform side effects. It does not run in the target's original reactive context. The library rejects reader callbacks that create owned children or register cleanups, and rejects sources owned by its temporary observer, to prevent subscriptions to disposed computations.
+
+Pending async memo reads can throw `NotReadyError`; a failed read does not attach dependencies. A memo with a `loadingValue` can return that fallback while pending, but `attachRead` does not restore the target observer's original suspension or transition context. Treat resources, loading boundaries, held transactions, and optimistic state as **unsupported beyond ordinary settled reads**.
+
+An `attachRead()` subscription is prospective: signal updates that happen before attachment are not replayed. Grafted dependencies can be removed by the target's next normal recomputation. For async effects, reattach on each pass using `captureObserverPass()`.
 
-Pending resources, transitions, reentrant reactive updates, server rendering, and independently bundled copies of the signals runtime are not supported. Do not assume compatibility with other Solid versions.
+Reads that create computations/cleanups, write signals, or depend on `getOwner()`/`getObserver()` seeing the original effect are unsupported, because the callback executes under a temporary observer. Server rendering and independently bundled copies of the signals runtime are not supported. Do not assume compatibility with other Solid versions.
 
 ## License
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "solid-deps",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "Experimental direct dependency attachment for Solid 2 reactive observers after async boundaries",
   "type": "module",
   "license": "MIT",
@@ -36,10 +36,14 @@
   ],
   "scripts": {
     "setup": "node scripts/setup.mjs",
-    "test": "node --conditions=browser --test test/test.mjs test/test-async.mjs test/test-tuple.mjs",
-    "test:dev": "node --conditions=browser --conditions=development --test test/test.mjs test/test-async.mjs test/test-tuple.mjs",
-    "test:observe": "node --conditions=browser --conditions=observe --test test/test.mjs test/test-async.mjs test/test-tuple.mjs",
+    "test": "node --conditions=browser --test test/test.mjs test/test-async.mjs test/test-tuple.mjs test/test-manifest.mjs test/test-graph-hardening.mjs test/test-async-transitions.mjs test/test-transaction-integrity.mjs test/test-scheduler-lifecycle.mjs test/test-release-hardening.mjs",
+    "test:dev": "node --conditions=browser --conditions=development --test test/test.mjs test/test-async.mjs test/test-tuple.mjs test/test-manifest.mjs test/test-graph-hardening.mjs test/test-async-transitions.mjs test/test-transaction-integrity.mjs test/test-scheduler-lifecycle.mjs test/test-release-hardening.mjs",
+    "test:observe": "node --conditions=browser --conditions=observe --test test/test.mjs test/test-async.mjs test/test-tuple.mjs test/test-manifest.mjs test/test-graph-hardening.mjs test/test-async-transitions.mjs test/test-transaction-integrity.mjs test/test-scheduler-lifecycle.mjs test/test-release-hardening.mjs",
     "test:all": "node scripts/run-tests.mjs",
     "test:package": "node scripts/smoke-package.mjs"
+  },
+  "devDependencies": {
+    "@solidjs/signals": "2.0.0-rc.17",
+    "solid-js": "2.0.0-rc.17"
   }
 }

package/src/attach-read.mjs

@@ -8,15 +8,27 @@
 import { createRoot, createReaction, getObserver, isDisposed } from '@solidjs/signals';
 
 const layouts = {
-  dev: { deps: '_deps', tail: '_depsTail', gen: '_depGen', flags: '_flags', dep: '_dep', sub: '_sub', next: '_nextDep', linkGen: '_gen' },
-  prod: { deps: 'C', tail: '_', gen: 'Ne', flags: 'R', dep: 'S', sub: 'u', next: 'G', linkGen: 'Te' }
+  dev: { deps: '_deps', tail: '_depsTail', gen: '_depGen', flags: '_flags', dep: '_dep', sub: '_sub', next: '_nextDep', linkGen: '_gen', child: '_firstChild', disposal: '_disposal' },
+  prod: { deps: 'C', tail: '_', gen: 'Ne', flags: 'R', dep: 'S', sub: 'u', next: 'G', linkGen: 'Te', child: 'De', disposal: 'He' },
+  observe: { deps: 'C', tail: '_', gen: 'Ne', flags: 'R', dep: 'S', sub: 'u', next: 'G', linkGen: 'Te', child: 'ze', disposal: 'rt' }
 };
 function layoutOf(node) {
-  const shape = node && (('_deps' in node) ? layouts.dev : ('C' in node) ? layouts.prod : null);
+  const shape = node && (('_deps' in node) ? layouts.dev : ('C' in node) ? ('ze' in node ? layouts.observe : layouts.prod) : null);
   if (!shape || typeof node[shape.gen] !== 'number' || !(shape.tail in node))
     throw new TypeError('Expected a tracking Computed from @solidjs/signals rc.17, not a plain Owner');
   return shape;
 }
+// Probe-owned sources disappear when the temporary tracking root is disposed.
+// Their dependency edges must never be transferred to a longer-lived target.
+function ownedBy(node, ancestor) {
+  const seen = new Set();
+  for (let owner = node; owner != null; owner = owner._parent) {
+    if (owner === ancestor) return true;
+    if (seen.has(owner)) throw new Error('Cyclic owner ancestry');
+    seen.add(owner);
+  }
+  return false;
+}
 function links(owner, layout) {
   const out = [];
   let cur = owner[layout.deps];
@@ -91,6 +103,19 @@ export function attachRead(observerOrPass, read) {
       throw new Error('Target dependency chain changed during capture');
 
     const captured = links(probe, s);
+    // `read()` must not allocate owned children or register cleanups. A child
+    // can disappear when the probe is disposed, and a cleanup can throw AFTER
+    // a successful graft, leaving the target changed despite a failed call.
+    if (probe[s.child] != null || probe[s.disposal] != null)
+      throw new Error('attachRead read() cannot create owned children or register cleanups');
+    // Guard before touching either graph. A memo or signal created inside
+    // `read()` may be owned by the disposable probe, and disposing that probe
+    // would otherwise leave the target subscribed to a disposed source.
+    for (const edge of captured) {
+      const source = edge[s.dep];
+      if (isDisposed(source) || ownedBy(source, probe))
+        throw new Error('Cannot attach a disposed or temporary-observer-owned source');
+    }
     const seen = new Set(valid.map(edge => edge[s.dep]));
     const staleBySource = new Map(stale.map(edge => [edge[s.dep], edge]));
     const moved = [];