solana-traderclaw 1.0.23 → 1.0.25

package/README.md

@@ -554,8 +554,8 @@ I'll monitor this position and review after exit.
 - Run `traderclaw setup` to create or select a wallet
 - Verify the wallet ID: `traderclaw config show`
 
-**Wizard (`traderclaw install --wizard`) fails on `install_plugin_package` with `ENOENT` / `/root/solana-traderclaw/package.json` / `file:solana-traderclaw`:**
-- npm is picking up a **local folder** named `solana-traderclaw` in your shell cwd (often `/root`) instead of the registry. Remove or rename an empty/broken `~/solana-traderclaw` directory, then run `npm install -g solana-traderclaw@latest` and start the wizard again. Current installers use `solana-traderclaw@latest` for the registry fallback to avoid this ambiguity.
+**Wizard (`traderclaw install --wizard`) fails on `install_plugin_package` with `ENOENT` / `…/solana-traderclaw/package.json` / `file:solana-traderclaw`:**
+- Older installers used `spawn` with `shell: true`, which on Linux could drop npm’s argv so npm treated the package as a **local folder** under cwd (`/root` or `/tmp`). Current installers use **`shell: false`**, explicit **`--registry https://registry.npmjs.org/`** for registry installs, **`solana-traderclaw@latest`**, and a temp **`cwd`**. Upgrade `solana-traderclaw` and retry. If a stray directory `./solana-traderclaw` exists under that cwd, remove it: `rm -rf /tmp/solana-traderclaw` (and under `/root` if present).
 
 **Heartbeat not sending messages to Telegram:**
 - **Fresh `traderclaw setup`:** the installer runs `configureGatewayScheduling`, which sets a custom `heartbeat.prompt` on the `main` agent (no `HEARTBEAT_OK` escape). You only need the manual `openclaw config set` command below if you are on an older install or overwrote `agents.list`.

package/bin/installer-step-engine.mjs

@@ -231,6 +231,27 @@ function isNpmGlobalBinConflict(err, cliName) {
   );
 }
 
+/** True when spec is an on-disk package directory (global npm path or git checkout), not a registry name. */
+function isNpmFilesystemPackageSpec(spec) {
+  if (typeof spec !== "string" || !spec.length) return false;
+  if (spec.startsWith("/")) return true;
+  return process.platform === "win32" && /^[A-Za-z]:[\\/]/.test(spec);
+}
+
+/**
+ * Args for `npm install -g …`. Use explicit registry for registry specs so npm never treats cwd/temp as `file:solana-traderclaw`.
+ * IMPORTANT: run with `{ shell: false }` — `spawn(..., { shell: true })` can drop argv on Unix and npm then mis-resolves the package name.
+ */
+function npmGlobalInstallArgs(spec, { force = false } = {}) {
+  const args = ["install", "-g"];
+  if (force) args.push("--force");
+  if (!isNpmFilesystemPackageSpec(spec)) {
+    args.push("--registry", "https://registry.npmjs.org/");
+  }
+  args.push(spec);
+  return args;
+}
+
 async function installPlugin(modeConfig, onEvent) {
   const spec = resolvePluginInstallSpec(modeConfig);
   const isLocalPluginRoot =
@@ -244,17 +265,17 @@ async function installPlugin(modeConfig, onEvent) {
       urls: [],
     });
   }
-  // npm resolves bare package names against process cwd; a folder named solana-traderclaw under /root becomes file:solana-traderclaw and breaks global install.
   const npmCwd = tmpdir();
   if (typeof onEvent === "function") {
     onEvent({
       type: "stdout",
-      text: `Running npm global install with cwd=${npmCwd} (avoids shadowing by ./solana-traderclaw in the wizard shell).\n`,
+      text: `Running npm global install with cwd=${npmCwd}, shell=false, args=${JSON.stringify(npmGlobalInstallArgs(spec))}\n`,
       urls: [],
     });
   }
+  const npmOpts = { onEvent, cwd: npmCwd, shell: false };
   try {
-    await runCommandWithEvents("npm", ["install", "-g", spec], { onEvent, cwd: npmCwd });
+    await runCommandWithEvents("npm", npmGlobalInstallArgs(spec), npmOpts);
     return { installed: true, available: commandExists(modeConfig.cliName), forced: false };
   } catch (err) {
     if (!isNpmGlobalBinConflict(err, modeConfig.cliName)) throw err;
@@ -265,7 +286,7 @@ async function installPlugin(modeConfig, onEvent) {
         urls: [],
       });
     }
-    await runCommandWithEvents("npm", ["install", "-g", "--force", spec], { onEvent, cwd: npmCwd });
+    await runCommandWithEvents("npm", npmGlobalInstallArgs(spec, { force: true }), npmOpts);
     return { installed: true, available: commandExists(modeConfig.cliName), forced: true };
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "solana-traderclaw",
-  "version": "1.0.23",
+  "version": "1.0.25",
   "description": "TraderClaw V1 — autonomous Solana memecoin trading for OpenClaw (team edition: X/Twitter journal and engagement tools)",
   "type": "module",
   "main": "./dist/index.js",