softseti-sale-calculator-library 4.0.1 → 4.1.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "softseti-sale-calculator-library",
-  "version": "4.0.1",
+  "version": "4.1.1",
   "description": "Sales calculation engine by Softseti",
   "main": "src/index.js",
   "types": "src/index.d.ts",

package/src/core/rule-engine.js

@@ -1,9 +1,7 @@
 // src/rules/RuleEngine.js
-const { ZenEngine } = require('@gorules/zen-engine');
-
 class RuleEngine {
-  constructor() {
-    this.engine = new ZenEngine();
+  constructor(zenEngine) {
+    this.engine = zenEngine ? new zenEngine() : null;
     this.ruleCache = new Map();
   }
 
@@ -15,6 +13,10 @@ class RuleEngine {
    */
   async evaluateRule(ruleContent, context) {
     try {
+      // Verificar si el motor está disponible
+      if (!this.engine) {
+        throw new Error('Rule engine not initialized. ZenEngine dependency not provided.');
+      }
 
       const decision = this.engine.createDecision(ruleContent);
       const result = await decision.safeEvaluate(context);
@@ -34,16 +36,17 @@ class RuleEngine {
    * @returns {Promise<Array>} Array of rule execution results
    */
   async executeRules(rules, context) {
+    if (!this.engine || !rules || rules.length === 0) {
+      return [];
+    }
+
     const results = [];
 
     for (const rule of rules) {
       try {
         const result = await this.evaluateRule(rule.rule_content, context);
-        results.push(
-          result
-        );
+        results.push(result);
       } catch (error) {
-
         results.push({
           ruleId: rule.id,
           success: false,

package/src/core/sale-calculator.js

@@ -19,6 +19,8 @@ let useRounding = false;
 
 let preprocessedSale = {};
 
+let zenEngineDependency = null;
+
 /**
  * Sales Calculation Engine (V1)
  * @author softseti
@@ -39,13 +41,13 @@ let preprocessedSale = {};
  *   - settings: GlobalSettings
  */
 
-function init(params) {
+function init(params, dependencies = {}) {
   products = params.products || {};
   productTaxes = params.product_taxes || {};
   taxes = params.taxes || {};
   wholesaleLevels = params.wholesale_levels || {};
   settings = params.settings || {};
-  // Set currencies convertion
+  // Set currencies conversion
   exchangeRates = params.exchange_rates || {};
   currencyConverterRates = params.currency_converter_rates || {};
   currencies = params.currencies || {};
@@ -56,6 +58,11 @@ function init(params) {
 
   useRounding = params.use_rounding !== undefined ? params.use_rounding : false;
 
+  // Store dependencies
+  if (dependencies.zenEngine) {
+    zenEngineDependency = dependencies.zenEngine;
+  }
+
   // Start engine
   initializeRuleSystem(businessRules);
 
@@ -67,20 +74,19 @@ function init(params) {
 
 function initializeRuleSystem(businessRules) {
   try {
-    ruleEngine = new RuleEngine();
+    ruleEngine = new RuleEngine(zenEngineDependency);
     ruleManager = new RuleManager();
 
-    if (businessRules && Object.keys(businessRules).length > 0) {
-
+    if (businessRules && Object.keys(businessRules).length > 0) { 
       ruleManager.loadRules(businessRules);
-      console.log('Sistema de reglas inicializado correctamente');
+      console.log('Rule system initialized successfully');
 
     } else {
-      console.warn('No se encontraron reglas de negocio para cargar');
+      console.warn('No business rules found to load');
     }
   } catch (error) {
-    console.error('Error al inicializar el sistema de reglas:', error);
-    // Fallback: continuar sin reglas
+    console.error('Error initializing rule system:', error);
+    // Fallback: without rules
     ruleEngine = null;
     ruleManager = null;
   }
@@ -94,10 +100,10 @@ function initializeRuleSystem(businessRules) {
 function validateSaleStructure(sale) {
   const required = ['receipt_type_key', 'company_id', 'branch_id', 'dwSaleProducts'];
   if (required.some(field => !sale[field])) {
-    throw new Error("Estructura de venta inválida");
+    throw new Error("Invalid sale structure");
   }
   if (Object.keys(products).length === 0) {
-    throw new Error("Productos no cargados");
+    throw new Error("Products not loaded");
   }
 }
 
@@ -279,7 +285,7 @@ function calcDwSaleProductPrice(saleProduct, sale) {
 
   const saleCurrency = sale.currency_iso;
 
-  // Convertion currency
+  // Currency conversion
   if (productCurrency && saleCurrency && productCurrency !== saleCurrency) {
     return exchange(
       basePrice,
@@ -287,7 +293,7 @@ function calcDwSaleProductPrice(saleProduct, sale) {
       saleCurrency
     );
   }
-  // If not exist exchange and convert rate return the basePrice.
+  // If no exchange or conversion rate exists, return the basePrice.
   return basePrice;
 }
 
@@ -319,7 +325,7 @@ async function getApplicableProductTaxes(saleProduct, productSum, sale) {
   // GET General Taxes
   const generalTaxes = getGeneralTaxes(sale);
 
-  // Combination for taxes
+  // Combine all applicable taxes
   const taxes = [...specificTaxes, ...generalTaxes];
 
   // Get rules for taxes
@@ -472,14 +478,14 @@ function getTaxReceiptTypeKey(receiptType) {
 function exchange(amount, fromCurrency, toCurrency) {
   if (fromCurrency === toCurrency) return roundCurrency(amount);
 
-  // GET EXANGE RATE
+  // GET EXCHANGE RATE
   const exchangeRateModel = findExchangeRate(fromCurrency, toCurrency);
 
   if (exchangeRateModel) {
     return roundCurrency(applyExchangeStrategy(amount, exchangeRateModel));
   }
 
-  // GET CURRENCY CONVERTER RATE WHEN NOT EXIST THE EXANGE RATE
+  // GET CURRENCY CONVERTER RATE WHEN NO EXCHANGE RATE EXISTS
   const currencyConverterRateModel = findCurrencyConverterRate(fromCurrency, toCurrency);
 
   if (!currencyConverterRateModel) {
@@ -706,7 +712,7 @@ function appliedWholesaleLevels(sale) {
   }
 
   const result = [];
-  let levelCounter = 1; // Para generar IDs secuenciales como en el ejemplo
+  let levelCounter = 1; // For generating sequential IDs as in the example
 
   sale.dwSaleProducts.forEach(product => {
     const productData = products[product.product_id];
@@ -995,30 +1001,6 @@ function getConsolidatedTaxes(sale) {
     .sort((a, b) => b.amount - a.amount);
 }
 
-/**
- * Rounds or truncates currency values based on configuration
- * @param {number} value - Value to process
- * @param {boolean} overrideRounding - Optional override for rounding behavior
- * @returns {number} Processed value
- *
-function roundCurrency(value, overrideRounding) {
-  if (typeof value !== 'number' || isNaN(value)) {
-    return 0;
-  }
-  
-  // Determine rounding behavior (parameter override > global setting > default false)
-  const shouldRound = overrideRounding !== undefined ? overrideRounding : useRounding;
-  
-  if (shouldRound) {
-    // Use rounding (comportamiento original)
-    return Math.round(value * roundingFactor) / roundingFactor;
-  } else {
-    // Use truncation (comportamiento por defecto - sin redondeo)
-    return Math.trunc(value * roundingFactor) / roundingFactor;
-  }
-}
-*/
-
 /**
  * Rounds or truncates currency values based on configuration
  * @param {number} value - Value to process
@@ -1073,4 +1055,4 @@ module.exports = {
     getApplicableProductTaxes, // Async
     exchange
   }
-};
+};