soft-skills 2.1.19 → 2.1.20

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "soft-skills",
3
- "version": "2.1.19",
3
+ "version": "2.1.20",
4
4
  "description": "Communication toolkit for burnt-out humans and collaborative AI's",
5
5
  "author": "Gilad Barnea (https://github.com/giladbarnea)",
6
6
  "homepage": "https://github.com/giladbarnea/soft-skills",
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "soft-skills",
3
- "version": "2.1.19",
3
+ "version": "2.1.20",
4
4
  "description": "Communication toolkit for burnt-out humans and collaborative AI's",
5
5
  "author": {
6
6
  "name": "Gilad Barnea",
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "soft-skills",
3
- "version": "2.1.19",
3
+ "version": "2.1.20",
4
4
  "description": "Communication toolkit for burnt-out humans and collaborative AI's",
5
5
  "author": {
6
6
  "name": "Gilad Barnea",
@@ -8,16 +8,15 @@ Think again whether you truly grok <research_targets>. Unless you have no missin
8
8
 
9
9
  Finally, review <work_to_review>.
10
10
 
11
- Review for major overlooks/blindspots and critically incomplete understanding of the source or requirements; significant missed opportunities to leverage elegant design and avoid implementation slop; obviously unnecessary over-engineering that could be collapsed into something simpler yet cleaner; scope creep; mismatch, misuse or underuse of the project’s patterns; Regressions and contradictions; etc.
11
+ Review for major overlooks/blindspots and critically incomplete understanding of the source or requirements; significant missed opportunities to leverage elegant design and avoid slop; obviously unnecessary over-engineering that could be collapsed into something simpler yet cleaner; scope creep; mismatch, misuse or underuse of the project’s pre-existing reality; regressions and contradictions; etc.
12
12
 
13
13
  Recall the project’s core development and engineering rules.
14
14
 
15
- Verify implicit and explicit assumptions: “Is this really the case that ...?”, “Might there have been a simpler pattern used elsewhere?”, etc.
15
+ Verify implicit and explicit assumptions: “Is this really the case that ...?”, “Might there have been a simpler way to get the same end result?”, “Is there any element, pattern, or system in the project that the work under review would have benefited from considering or using, but seemingly overlooked due to a bad judgment call or plain lack of awareness?”, etc.
16
16
 
17
17
  The threshold for what constitutes an issue is high — don’t surface noise.
18
18
 
19
- { if the reviewed work involved writing tests }
20
- Also review the tests for substantiality (test real, product spec-derived behavior) vs. hollowness (don’t really test anything and create false confidence) and general test design.
21
- { end if }
19
+ If the reviewed work involved writing tests:
20
+ Also review the tests for substantiality (test real, product spec-derived behavior) vs. hollowness (don’t really hold any bar, test the implementation, or create false confidence) and general test design.
22
21
 
23
22
  You are a reviewer, not an executioner. The work to review might not have any issues, might have multiple, or anything in between. Respond succinctly, directly, with code snippets, without weasel words, and without fluff. If you are unsure of an observation, communicate that (“It looks to me like it might [...] — please verify.”). If you are certain, communicate as usual.
@@ -5,21 +5,25 @@ arguments: work_to_review
5
5
  loads: references/peer-review-instructions.md
6
6
  ---
7
7
 
8
- First, commit your work to have a commit reference. Then dispatch a large subagent (thinking=xhigh if project is medium-sized, thinking=max if large) with the following prompt:
9
-
10
- ---
8
+ First, commit your work to have a commit reference. Then dispatch a fresh, flagship subagent (thinking=xhigh if project is medium-sized, thinking=max if large) with the following prompt:
11
9
 
10
+ ```
12
11
  The user has given me this task:
13
12
  <original-user-task> # Quote verbatim.
14
13
  { original user task that resulted in work_to_review }
15
14
  </original-user-task>
16
15
 
17
- I have attempted to complete it. It’s committed to { commit_sha }.
16
+ I have attempted to complete it. My work for your review is committed to { commit_sha }.
18
17
 
19
- @peer-review-instructions.md <work_to_review> <research_targets="Blast radius of {commit_sha}".>
18
+ It touches the systems `A`, `B`, `C` and `D`: `A` publishes an event to `B`, `B` attempts to write to `C` then reports back to `A`, and depending on the report, `A` might talk to `D`. {# Keep it ultra high-level and brief, like I wrote here. "`A` publishes an event to `B`" is literally enough if that's what `A` does. Do not mention how the systems work. Definitely do not say why they work the way they do. Do not try to be comprehensive. #}
20
19
 
21
- { if original user task references skills }
22
- Load the referenced skills yourself for complete understanding:
20
+ Load the `peer-review` skill and follow its `peer-review-instructions.md` reference.
21
+
22
+ { if original user task includes instructions to load skills, documents and context-gathering resources: }
23
+ Load the following skills, docs and resources to gain deep understanding of the review space:
23
24
  - `skill-1`: `path/to/skill-1/`
25
+ - `doc.md`: ...
24
26
  - ...
25
- { end if }
27
+ ```
28
+
29
+ When the review findings are back, note whether a review item is out of scope, or implicitly makes new design decisions behind the words that might be true, but following them would be scope creep. The reviewer is instructed to surface only real issues, not noise, but there is still place for you to exercise judgment.