sofia-cli 0.1.1

package/tests/unit/phases/contextSummarizer.spec.ts

@@ -0,0 +1,158 @@
+/**
+ * Context summarizer tests.
+ *
+ * Tests for buildSummarizedContext() and renderSummarizedContext()
+ * that project structured session fields into compact markdown
+ * for injection into phase system prompts.
+ */
+import { describe, it, expect } from 'vitest';
+
+import {
+  buildSummarizedContext,
+  renderSummarizedContext,
+} from '../../../src/phases/contextSummarizer.js';
+import type { WorkshopSession } from '../../../src/shared/schemas/session.js';
+
+function emptySession(overrides?: Partial<WorkshopSession>): WorkshopSession {
+  return {
+    sessionId: 'test-1',
+    schemaVersion: '1.0.0',
+    createdAt: '2025-01-01T00:00:00Z',
+    updatedAt: '2025-01-01T00:00:00Z',
+    phase: 'Discover',
+    status: 'Active',
+    participants: [],
+    artifacts: { generatedFiles: [] },
+    turns: [],
+    ...overrides,
+  };
+}
+
+describe('buildSummarizedContext', () => {
+  it('returns empty context for empty session', () => {
+    const ctx = buildSummarizedContext(emptySession());
+    expect(ctx.businessSummary).toBeUndefined();
+    expect(ctx.challenges).toBeUndefined();
+    expect(ctx.ideaSummaries).toBeUndefined();
+    expect(ctx.evaluationSummary).toBeUndefined();
+    expect(ctx.selectionSummary).toBeUndefined();
+    expect(ctx.planMilestones).toBeUndefined();
+  });
+
+  it('projects all fields from a full session', () => {
+    const session = emptySession({
+      businessContext: {
+        businessDescription: 'Zava Industries',
+        challenges: ['Scaling', 'Automation'],
+      },
+      topic: { topicArea: 'Customer Support' },
+      workflow: {
+        activities: [
+          { id: 's1', name: 'Intake' },
+          { id: 's2', name: 'Processing' },
+        ],
+        edges: [],
+      },
+      ideas: [
+        { id: 'idea-1', title: 'AI Bot', description: 'Automate support', workflowStepIds: ['s1'] },
+      ],
+      evaluation: {
+        method: 'feasibility-value-matrix',
+        ideas: [{ ideaId: 'idea-1', feasibility: 8, value: 9 }],
+      },
+      selection: {
+        ideaId: 'idea-1',
+        selectionRationale: 'Best fit',
+        confirmedByUser: true,
+      },
+      plan: {
+        milestones: [
+          { id: 'm1', title: 'Phase 1', items: ['Task 1'] },
+        ],
+        architectureNotes: 'Node.js + TypeScript',
+      },
+    });
+
+    const ctx = buildSummarizedContext(session);
+    expect(ctx.businessSummary).toBe('Zava Industries');
+    expect(ctx.challenges).toEqual(['Scaling', 'Automation']);
+    expect(ctx.topicArea).toBe('Customer Support');
+    expect(ctx.workflowSteps).toEqual(['Intake', 'Processing']);
+    expect(ctx.ideaSummaries).toHaveLength(1);
+    expect(ctx.ideaSummaries![0].title).toBe('AI Bot');
+    expect(ctx.evaluationSummary).toContain('feasibility-value-matrix');
+    expect(ctx.selectionSummary).toContain('idea-1');
+    expect(ctx.planMilestones).toEqual(['Phase 1']);
+    expect(ctx.architectureNotes).toBe('Node.js + TypeScript');
+  });
+
+  it('gracefully handles null fields', () => {
+    const session = emptySession({
+      businessContext: {
+        businessDescription: 'Test Inc',
+        challenges: [],
+      },
+      // Everything else is null/undefined
+    });
+
+    const ctx = buildSummarizedContext(session);
+    expect(ctx.businessSummary).toBe('Test Inc');
+    expect(ctx.ideaSummaries).toBeUndefined();
+    expect(ctx.evaluationSummary).toBeUndefined();
+  });
+
+  it('includes discovery enrichment highlights', () => {
+    const session = emptySession({
+      discovery: {
+        enrichment: {
+          industryTrends: ['AI adoption growing', 'Cloud migration'],
+          companyNews: ['Raised Series B'],
+        },
+      },
+    });
+
+    const ctx = buildSummarizedContext(session);
+    expect(ctx.enrichmentHighlights).toBeDefined();
+    expect(ctx.enrichmentHighlights).toContain('AI adoption growing');
+    expect(ctx.enrichmentHighlights).toContain('Raised Series B');
+  });
+});
+
+describe('renderSummarizedContext', () => {
+  it('returns empty string for empty context', () => {
+    expect(renderSummarizedContext({})).toBe('');
+  });
+
+  it('renders markdown with all sections', () => {
+    const markdown = renderSummarizedContext({
+      businessSummary: 'Zava Industries',
+      challenges: ['Scaling'],
+      topicArea: 'Support',
+      workflowSteps: ['Intake', 'Processing'],
+      ideaSummaries: [{ id: 'idea-1', title: 'AI Bot', description: 'Automate' }],
+      evaluationSummary: 'Method: feasibility-value-matrix, 1 ideas evaluated',
+      selectionSummary: 'Selected: idea-1',
+      planMilestones: ['Phase 1'],
+      architectureNotes: 'Node.js',
+    });
+
+    expect(markdown).toContain('## Prior Phase Context');
+    expect(markdown).toContain('### Business Context');
+    expect(markdown).toContain('Zava Industries');
+    expect(markdown).toContain('### Workflow');
+    expect(markdown).toContain('### Ideas');
+    expect(markdown).toContain('### Evaluation');
+    expect(markdown).toContain('### Selection');
+    expect(markdown).toContain('### Plan');
+  });
+
+  it('omits sections when data is absent', () => {
+    const markdown = renderSummarizedContext({
+      businessSummary: 'Test Inc',
+    });
+
+    expect(markdown).toContain('Test Inc');
+    expect(markdown).not.toContain('### Ideas');
+    expect(markdown).not.toContain('### Plan');
+  });
+});

package/tests/unit/phases/discoveryEnricher.repeatCalls.spec.ts

@@ -0,0 +1,125 @@
+/**
+ * T041 focused: Discovery enricher repeated calls (simplified live test).
+ *
+ * Reproduces the exact scenario from T041 but with detailed logging
+ * to isolate web search behavior across repeated enrichFromWebSearch() calls.
+ *
+ * Gated behind SOFIA_LIVE_MCP_TESTS=true to skip in CI.
+ *
+ * Run with:
+ *   SOFIA_LIVE_MCP_TESTS=true \
+ *   FOUNDRY_PROJECT_ENDPOINT=... \
+ *   FOUNDRY_MODEL_DEPLOYMENT_NAME=... \
+ *   npm test -- tests/unit/phases/discoveryEnricher.repeatCalls.spec.ts
+ */
+import { describe, it, expect } from 'vitest';
+
+const LIVE = process.env.SOFIA_LIVE_MCP_TESTS === 'true';
+
+const TEST_COMPANIES = [
+  {
+    summary: '"Nestlé" is a global food and beverage company headquartered in Switzerland.',
+    keywords: ['food', 'beverage', 'switzerland'],
+  },
+  {
+    summary: '"Zara" is a global retail company headquartered in Spain.',
+    keywords: ['retail', 'fashion', 'spain'],
+  },
+  {
+    summary:
+      '"Microsoft Corporation" is a global technology company headquartered in Redmond, Washington.',
+    keywords: ['technology', 'software', 'cloud'],
+  },
+];
+
+describe.skipIf(!LIVE)('DiscoveryEnricher repeated web search calls (T041 focused)', () => {
+  it('enrichFromWebSearch returns results for each company when called sequentially', async () => {
+    const { DiscoveryEnricher } = await import('../../../src/phases/discoveryEnricher.js');
+    const { createWebSearchTool } = await import('../../../src/mcp/webSearch.js');
+
+    const webSearchFn = createWebSearchTool({
+      projectEndpoint: process.env.FOUNDRY_PROJECT_ENDPOINT!,
+      modelDeploymentName: process.env.FOUNDRY_MODEL_DEPLOYMENT_NAME!,
+    });
+
+    const webSearchClient = {
+      search: async (query: string) => {
+        console.log(`  [WebSearch] Query: "${query}"`);
+        const result = await webSearchFn(query);
+        console.log(
+          `  [WebSearch] Results: ${result.results.length} items, degraded=${result.degraded}`,
+        );
+        if (result.error) {
+          console.log(`  [WebSearch] Error: ${result.error}`);
+        }
+        return result;
+      },
+    };
+
+    const enricher = new DiscoveryEnricher();
+
+    console.log('\n=== T041 Focused: Sequential enrichFromWebSearch Calls ===\n');
+
+    const allResults: Array<{
+      company: string;
+      snippetCount: number;
+      hasRelevantKeyword: boolean;
+      rawContent: string[];
+    }> = [];
+
+    for (let idx = 0; idx < TEST_COMPANIES.length; idx++) {
+      const company = TEST_COMPANIES[idx];
+      console.log(
+        `\n[${idx + 1}/${TEST_COMPANIES.length}] Processing: ${company.summary.split('"')[1]}`,
+      );
+
+      const enrichment = await enricher.enrichFromWebSearch(company.summary, webSearchClient);
+
+      const content = [
+        ...(enrichment.companyNews ?? []),
+        ...(enrichment.competitorInfo ?? []),
+        ...(enrichment.industryTrends ?? []),
+      ];
+
+      const allText = content.join(' ').toLowerCase();
+      const hasRelevant = company.keywords.some((kw) => allText.includes(kw.toLowerCase()));
+
+      console.log(`  [Enrichment] companyNews: ${enrichment.companyNews?.length ?? 0}`);
+      console.log(`  [Enrichment] competitorInfo: ${enrichment.competitorInfo?.length ?? 0}`);
+      console.log(`  [Enrichment] industryTrends: ${enrichment.industryTrends?.length ?? 0}`);
+      console.log(`  [Enrichment] Total snippets: ${content.length}`);
+      console.log(`  [Enrichment] Has relevant keyword: ${hasRelevant}`);
+
+      if (content.length > 0) {
+        console.log(`  [Enrichment] First snippet: ${content[0].slice(0, 80)}...`);
+      }
+
+      allResults.push({
+        company: company.summary.split('"')[1],
+        snippetCount: content.length,
+        hasRelevantKeyword: hasRelevant,
+        rawContent: content,
+      });
+    }
+
+    console.log('\n=== Summary ===\n');
+    let relevantCount = 0;
+    for (const r of allResults) {
+      const status = r.hasRelevantKeyword && r.snippetCount > 0 ? '✓' : '✗';
+      console.log(
+        `${status} ${r.company}: ${r.snippetCount} snippets, relevant=${r.hasRelevantKeyword}`,
+      );
+      if (r.hasRelevantKeyword && r.snippetCount > 0) {
+        relevantCount++;
+      }
+    }
+
+    console.log(
+      `\nResult: ${relevantCount}/${TEST_COMPANIES.length} companies have relevant results`,
+    );
+    console.log(`Expected: >= 2 for pass (simplified from T041's 3/5 threshold)\n`);
+
+    // Simplified threshold: at least 2/3
+    expect(relevantCount).toBeGreaterThanOrEqual(2);
+  }, 180_000); // 3 minute timeout for live queries
+});