sofia-cli 0.1.1 → 0.1.4

package/tests/e2e/developE2e.spec.ts

@@ -9,19 +9,18 @@
  * It validates the CLI plumbing, argument parsing, and file creation.
  */
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import { mkdtemp, rm, readFile, writeFile, mkdir } from 'node:fs/promises';
+import { mkdtemp, rm, writeFile, mkdir } from 'node:fs/promises';
 import { join } from 'node:path';
 import { tmpdir } from 'node:os';
 import { createRequire } from 'node:module';
 
 import { buildCli } from '../../src/cli/index.js';
 import { validateSessionForDevelop } from '../../src/cli/developCommand.js';
-import { PocScaffolder } from '../../src/develop/pocScaffolder.js';
-import { validatePocOutput } from '../../src/develop/pocScaffolder.js';
 import type { WorkshopSession } from '../../src/shared/schemas/session.js';
 
 const require = createRequire(import.meta.url);
-const fixtureSession: WorkshopSession = require('../fixtures/completedSession.json') as WorkshopSession;
+const fixtureSession: WorkshopSession =
+  require('../fixtures/completedSession.json') as WorkshopSession;
 
 describe('E2E: sofia dev command', () => {
   let workDir: string;
@@ -92,61 +91,4 @@ describe('E2E: sofia dev command', () => {
       expect(fixtureSession.plan!.milestones.length).toBeGreaterThan(0);
     });
   });
-
-  describe('PocScaffolder with fixture session', () => {
-    let outputDir: string;
-
-    beforeEach(async () => {
-      outputDir = await mkdtemp(join(tmpdir(), 'sofia-e2e-poc-'));
-    });
-
-    afterEach(async () => {
-      await rm(outputDir, { recursive: true, force: true });
-    });
-
-    it('scaffolds valid PoC output from fixture session', async () => {
-      const scaffolder = new PocScaffolder();
-      const ctx = PocScaffolder.buildContext(fixtureSession, outputDir);
-      await scaffolder.scaffold(ctx);
-
-      const validation = await validatePocOutput(outputDir);
-      expect(validation.valid).toBe(true);
-    });
-
-    it('generated package.json has correct project name from fixture', async () => {
-      const scaffolder = new PocScaffolder();
-      const ctx = PocScaffolder.buildContext(fixtureSession, outputDir);
-      await scaffolder.scaffold(ctx);
-
-      const pkgContent = await readFile(join(outputDir, 'package.json'), 'utf-8');
-      const pkg = JSON.parse(pkgContent) as { name: string };
-      expect(pkg.name).toBe('ai-powered-route-optimizer');
-    });
-
-    it('session JSON would be updated with poc state after loop', () => {
-      // Verify the shape of poc state that RalphLoop would produce
-      const expectedPocShape = {
-        repoSource: 'local',
-        iterations: expect.arrayContaining([
-          expect.objectContaining({
-            outcome: 'scaffold',
-          }),
-        ]),
-      };
-      // This test verifies the schema is correct
-      const poc = {
-        repoSource: 'local' as const,
-        repoPath: outputDir,
-        iterations: [
-          {
-            iteration: 1,
-            startedAt: new Date().toISOString(),
-            outcome: 'scaffold' as const,
-            filesChanged: ['package.json', 'src/index.ts'],
-          },
-        ],
-      };
-      expect(poc).toMatchObject(expectedPocShape);
-    });
-  });
 });

package/tests/e2e/developFailureE2e.spec.ts

@@ -12,7 +12,7 @@ import { tmpdir } from 'node:os';
 import { createRequire } from 'node:module';
 
 import { RalphLoop } from '../../src/develop/ralphLoop.js';
-import { PocScaffolder } from '../../src/develop/pocScaffolder.js';
+import { generateDynamicScaffold } from '../../src/develop/dynamicScaffolder.js';
 import { TestRunner } from '../../src/develop/testRunner.js';
 import type { WorkshopSession } from '../../src/shared/schemas/session.js';
 import type { LoopIO } from '../../src/loop/conversationLoop.js';
@@ -40,8 +40,14 @@ vi.mock('node:child_process', async (importOriginal) => {
   };
 });
 
+// Mock generateDynamicScaffold
+vi.mock('../../src/develop/dynamicScaffolder.js', () => ({
+  generateDynamicScaffold: vi.fn(),
+}));
+
 const require = createRequire(import.meta.url);
-const fixtureSession: WorkshopSession = require('../fixtures/completedSession.json') as WorkshopSession;
+const fixtureSession: WorkshopSession =
+  require('../fixtures/completedSession.json') as WorkshopSession;
 
 describe('E2E: failure/recovery (T050)', () => {
   let tmpDir: string;
@@ -65,8 +71,12 @@ describe('E2E: failure/recovery (T050)', () => {
     return {
       writtenLines,
       activityLines,
-      write: vi.fn((text: string) => { writtenLines.push(text); }),
-      writeActivity: vi.fn((text: string) => { activityLines.push(text); }),
+      write: vi.fn((text: string) => {
+        writtenLines.push(text);
+      }),
+      writeActivity: vi.fn((text: string) => {
+        activityLines.push(text);
+      }),
       writeToolSummary: vi.fn(),
       readInput: vi.fn().mockResolvedValue(null),
       showDecisionGate: vi.fn(),
@@ -75,34 +85,26 @@ describe('E2E: failure/recovery (T050)', () => {
     };
   }
 
-  function makeFakeScaffolder(outputDir: string): PocScaffolder {
-    return {
-      scaffold: vi.fn().mockImplementation(async () => {
-        const { writeFile, mkdir } = await import('node:fs/promises');
-        await mkdir(join(outputDir, 'src'), { recursive: true });
-        await writeFile(join(outputDir, 'package.json'), JSON.stringify({
+  function setupDynamicScaffoldMock(outputDir: string): void {
+    vi.mocked(generateDynamicScaffold).mockImplementation(async () => {
+      const { writeFile, mkdir } = await import('node:fs/promises');
+      await mkdir(join(outputDir, 'src'), { recursive: true });
+      await writeFile(
+        join(outputDir, 'package.json'),
+        JSON.stringify({
           name: 'test-poc',
           scripts: { test: 'vitest run' },
           dependencies: {},
           devDependencies: {},
-        }), 'utf-8');
-        await writeFile(join(outputDir, 'src', 'index.ts'), 'export function main() {}', 'utf-8');
-        return {
-          createdFiles: ['package.json', 'src/index.ts'],
-          skippedFiles: [],
-          context: {
-            projectName: 'test-poc',
-            ideaTitle: 'Test',
-            ideaDescription: 'Test',
-            techStack: { language: 'TypeScript', runtime: 'Node.js 20', testRunner: 'npm test' },
-            planSummary: 'Test',
-            sessionId: fixtureSession.sessionId,
-            outputDir,
-          },
-        };
-      }),
-      getTemplateFiles: () => [],
-    } as unknown as PocScaffolder;
+        }),
+        'utf-8',
+      );
+      await writeFile(join(outputDir, 'src', 'index.ts'), 'export function main() {}', 'utf-8');
+      return {
+        createdFiles: ['package.json', 'src/index.ts'],
+        techStack: { language: 'TypeScript', runtime: 'Node.js 20', testRunner: 'npm test' },
+      };
+    });
   }
 
   function makeAlwaysFailingClient(): CopilotClient {
@@ -134,7 +136,7 @@ describe('E2E: failure/recovery (T050)', () => {
 
   it('terminates with max-iterations when all tests keep failing', async () => {
     const io = makeIo();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
     const client = makeAlwaysFailingClient();
     const testRunner = makeAlwaysFailingTestRunner();
 
@@ -145,7 +147,6 @@ describe('E2E: failure/recovery (T050)', () => {
       outputDir: tmpDir,
       maxIterations: 2,
       testRunner,
-      scaffolder,
     });
 
     const result = await ralph.run();
@@ -156,7 +157,7 @@ describe('E2E: failure/recovery (T050)', () => {
 
   it('verifies terminationReason=max-iterations in session state', async () => {
     const io = makeIo();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
     const client = makeAlwaysFailingClient();
     const testRunner = makeAlwaysFailingTestRunner();
 
@@ -167,7 +168,6 @@ describe('E2E: failure/recovery (T050)', () => {
       outputDir: tmpDir,
       maxIterations: 2,
       testRunner,
-      scaffolder,
     });
 
     const result = await ralph.run();
@@ -177,7 +177,7 @@ describe('E2E: failure/recovery (T050)', () => {
 
   it('session has iteration history after failed loop', async () => {
     const io = makeIo();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
     const client = makeAlwaysFailingClient();
     const testRunner = makeAlwaysFailingTestRunner();
 
@@ -188,7 +188,6 @@ describe('E2E: failure/recovery (T050)', () => {
       outputDir: tmpDir,
       maxIterations: 2,
       testRunner,
-      scaffolder,
     });
 
     const result = await ralph.run();
@@ -276,10 +275,7 @@ describe('E2E: failure/recovery (T050)', () => {
     });
 
     try {
-      await developCommand(
-        { session: fixtureSession.sessionId },
-        { store, io: devIo, client },
-      );
+      await developCommand({ session: fixtureSession.sessionId }, { store, io: devIo, client });
     } finally {
       RalphLoop.prototype.run = originalRun;
     }

package/tests/integration/pocGithubMcp.spec.ts

@@ -13,7 +13,7 @@ import { createRequire } from 'node:module';
 
 import { RalphLoop } from '../../src/develop/ralphLoop.js';
 import { GitHubMcpAdapter } from '../../src/develop/githubMcpAdapter.js';
-import { PocScaffolder } from '../../src/develop/pocScaffolder.js';
+import { generateDynamicScaffold } from '../../src/develop/dynamicScaffolder.js';
 import { TestRunner } from '../../src/develop/testRunner.js';
 import type { WorkshopSession } from '../../src/shared/schemas/session.js';
 import type { LoopIO } from '../../src/loop/conversationLoop.js';
@@ -42,6 +42,11 @@ vi.mock('node:child_process', async (importOriginal) => {
   };
 });
 
+// Mock generateDynamicScaffold
+vi.mock('../../src/develop/dynamicScaffolder.js', () => ({
+  generateDynamicScaffold: vi.fn(),
+}));
+
 const require = createRequire(import.meta.url);
 const fixtureSession: WorkshopSession =
   require('../fixtures/completedSession.json') as WorkshopSession;
@@ -58,38 +63,26 @@ function makeIo(): LoopIO {
   };
 }
 
-function makeFakeScaffolder(outputDir: string): PocScaffolder {
-  return {
-    scaffold: vi.fn().mockImplementation(async () => {
-      const { writeFile, mkdir } = await import('node:fs/promises');
-      await mkdir(join(outputDir, 'src'), { recursive: true });
-      await writeFile(
-        join(outputDir, 'package.json'),
-        JSON.stringify({
-          name: 'test',
-          scripts: { test: 'vitest run' },
-          dependencies: {},
-          devDependencies: {},
-        }),
-        'utf-8',
-      );
-      await writeFile(join(outputDir, 'src', 'index.ts'), 'export function main() {}', 'utf-8');
-      return {
-        createdFiles: ['package.json', 'src/index.ts'],
-        skippedFiles: [],
-        context: {
-          projectName: 'ai-powered-route-optimizer',
-          ideaTitle: 'AI Route Optimizer',
-          ideaDescription: 'Optimize routes',
-          techStack: { language: 'TypeScript', runtime: 'Node.js 20', testRunner: 'npm test' },
-          planSummary: 'Route optimization',
-          sessionId: fixtureSession.sessionId,
-          outputDir,
-        },
-      };
-    }),
-    getTemplateFiles: () => [],
-  } as unknown as PocScaffolder;
+function setupDynamicScaffoldMock(outputDir: string): void {
+  vi.mocked(generateDynamicScaffold).mockImplementation(async () => {
+    const { writeFile, mkdir } = await import('node:fs/promises');
+    await mkdir(join(outputDir, 'src'), { recursive: true });
+    await writeFile(
+      join(outputDir, 'package.json'),
+      JSON.stringify({
+        name: 'test',
+        scripts: { test: 'vitest run' },
+        dependencies: {},
+        devDependencies: {},
+      }),
+      'utf-8',
+    );
+    await writeFile(join(outputDir, 'src', 'index.ts'), 'export function main() {}', 'utf-8');
+    return {
+      createdFiles: ['package.json', 'src/index.ts'],
+      techStack: { language: 'TypeScript', runtime: 'Node.js 20', testRunner: 'npm test' },
+    };
+  });
 }
 
 function makePassingClient(): CopilotClient {
@@ -137,7 +130,7 @@ describe.skip('RalphLoop — GitHub MCP flow (T034)', () => {
     const io = makeIo();
     const client = makePassingClient();
     const testRunner = makePassingTestRunner();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
 
     // Available GitHub MCP
     const availableMcpManager: McpManager = {
@@ -152,7 +145,6 @@ describe.skip('RalphLoop — GitHub MCP flow (T034)', () => {
       outputDir: tmpDir,
       maxIterations: 3,
       testRunner,
-      scaffolder,
     });
 
     const result = await ralph.run();
@@ -164,7 +156,7 @@ describe.skip('RalphLoop — GitHub MCP flow (T034)', () => {
     const io = makeIo();
     const client = makePassingClient();
     const testRunner = makePassingTestRunner();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
 
     const availableMcpManager: McpManager = {
       isAvailable: (name: string) => name === 'github',
@@ -180,7 +172,6 @@ describe.skip('RalphLoop — GitHub MCP flow (T034)', () => {
       outputDir: tmpDir,
       maxIterations: 3,
       testRunner,
-      scaffolder,
     });
 
     const result = await ralph.run();
@@ -196,7 +187,7 @@ describe.skip('RalphLoop — GitHub MCP flow (T034)', () => {
     const io = makeIo();
     const client = makePassingClient();
     const testRunner = makePassingTestRunner();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
 
     const availableMcpManager: McpManager = {
       isAvailable: (name: string) => name === 'github',
@@ -211,7 +202,6 @@ describe.skip('RalphLoop — GitHub MCP flow (T034)', () => {
       outputDir: tmpDir,
       maxIterations: 3,
       testRunner,
-      scaffolder,
     });
 
     await ralph.run();

package/tests/integration/pocLocalFallback.spec.ts

@@ -12,7 +12,7 @@ import { tmpdir } from 'node:os';
 import { createRequire } from 'node:module';
 
 import { RalphLoop } from '../../src/develop/ralphLoop.js';
-import { PocScaffolder } from '../../src/develop/pocScaffolder.js';
+import { generateDynamicScaffold } from '../../src/develop/dynamicScaffolder.js';
 import { TestRunner } from '../../src/develop/testRunner.js';
 import type { WorkshopSession } from '../../src/shared/schemas/session.js';
 import type { LoopIO } from '../../src/loop/conversationLoop.js';
@@ -40,6 +40,11 @@ vi.mock('node:child_process', async (importOriginal) => {
   };
 });
 
+// Mock generateDynamicScaffold
+vi.mock('../../src/develop/dynamicScaffolder.js', () => ({
+  generateDynamicScaffold: vi.fn(),
+}));
+
 const require = createRequire(import.meta.url);
 const fixtureSession: WorkshopSession =
   require('../fixtures/completedSession.json') as WorkshopSession;
@@ -60,38 +65,26 @@ function makeIo(): LoopIO & { activityMessages: string[] } {
   };
 }
 
-function makeFakeScaffolder(outputDir: string): PocScaffolder {
-  return {
-    scaffold: vi.fn().mockImplementation(async () => {
-      const { writeFile, mkdir } = await import('node:fs/promises');
-      await mkdir(join(outputDir, 'src'), { recursive: true });
-      await writeFile(
-        join(outputDir, 'package.json'),
-        JSON.stringify({
-          name: 'test',
-          scripts: { test: 'vitest run' },
-          dependencies: {},
-          devDependencies: {},
-        }),
-        'utf-8',
-      );
-      await writeFile(join(outputDir, 'src', 'index.ts'), 'export function main() {}', 'utf-8');
-      return {
-        createdFiles: ['package.json', 'src/index.ts'],
-        skippedFiles: [],
-        context: {
-          projectName: 'test',
-          ideaTitle: 'Test',
-          ideaDescription: 'Test',
-          techStack: { language: 'TypeScript', runtime: 'Node.js 20', testRunner: 'npm test' },
-          planSummary: 'Test',
-          sessionId: fixtureSession.sessionId,
-          outputDir,
-        },
-      };
-    }),
-    getTemplateFiles: () => [],
-  } as unknown as PocScaffolder;
+function setupDynamicScaffoldMock(outputDir: string): void {
+  vi.mocked(generateDynamicScaffold).mockImplementation(async () => {
+    const { writeFile, mkdir } = await import('node:fs/promises');
+    await mkdir(join(outputDir, 'src'), { recursive: true });
+    await writeFile(
+      join(outputDir, 'package.json'),
+      JSON.stringify({
+        name: 'test',
+        scripts: { test: 'vitest run' },
+        dependencies: {},
+        devDependencies: {},
+      }),
+      'utf-8',
+    );
+    await writeFile(join(outputDir, 'src', 'index.ts'), 'export function main() {}', 'utf-8');
+    return {
+      createdFiles: ['package.json', 'src/index.ts'],
+      techStack: { language: 'TypeScript', runtime: 'Node.js 20', testRunner: 'npm test' },
+    };
+  });
 }
 
 function makePassingClient(): CopilotClient {
@@ -137,7 +130,7 @@ describe('RalphLoop — local fallback (T033)', () => {
     const io = makeIo();
     const client = makePassingClient();
     const testRunner = makePassingTestRunner();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
 
     const ralph = new RalphLoop({
       client,
@@ -146,7 +139,6 @@ describe('RalphLoop — local fallback (T033)', () => {
       outputDir: tmpDir,
       maxIterations: 3,
       testRunner,
-      scaffolder,
     });
 
     const result = await ralph.run();
@@ -160,7 +152,7 @@ describe('RalphLoop — local fallback (T033)', () => {
     const io = makeIo();
     const client = makePassingClient();
     const testRunner = makePassingTestRunner();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
 
     const ralph = new RalphLoop({
       client,
@@ -169,7 +161,6 @@ describe('RalphLoop — local fallback (T033)', () => {
       outputDir: tmpDir,
       maxIterations: 3,
       testRunner,
-      scaffolder,
     });
 
     const result = await ralph.run();
@@ -181,7 +172,7 @@ describe('RalphLoop — local fallback (T033)', () => {
     const io = makeIo();
     const client = makePassingClient();
     const testRunner = makePassingTestRunner();
-    const scaffolder = makeFakeScaffolder(tmpDir);
+    setupDynamicScaffoldMock(tmpDir);
 
     const ralph = new RalphLoop({
       client,
@@ -190,7 +181,6 @@ describe('RalphLoop — local fallback (T033)', () => {
       outputDir: tmpDir,
       maxIterations: 3,
       testRunner,
-      scaffolder,
     });
 
     await ralph.run();