social-autoposter 1.6.69 → 1.6.70

package/mcp/dist/index.js

@@ -5,7 +5,6 @@
 //   draft_cycle  - scan + draft, return all drafts as a numbered table for the
 //                  user to review in chat (posts nothing).
 //   post_drafts  - post the drafts the user chose by number from a batch.
-//   autopilot    - one tool, action = enable | disable | status (launchd job).
 //   get_stats    - read-only post + engagement stats.
 //
 // THIN wrapper. The pipeline brain (scan, score, drafting prompts, posting)
@@ -18,9 +17,9 @@ import os from "node:os";
 import path from "node:path";
 import fs from "node:fs";
 import { repoDir, runPython, run, readPlan, writePlan, planPath, } from "./repo.js";
-import { applySetup, resolveProject, hasReadyProject, listManagedProjectStatus, REQUIRED_FIELDS, RECOMMENDED_FIELDS, configPath, } from "./setup.js";
+import { applySetup, resolveProject, listManagedProjectStatus, REQUIRED_FIELDS, RECOMMENDED_FIELDS, configPath, } from "./setup.js";
 import { xStatus, xConnect, xDetectSources, xScanProfile, summarizeXAuth } from "./twitterAuth.js";
-import { startProvisioning, isProvisioning, readProgress, runtimeReady, readRuntime, resolvePython, resolveChrome, } from "./runtime.js";
+import { startProvisioning, isProvisioning, readProgress, runtimeReady, readRuntime, resolvePython, resolveChrome, ensureMenubar, } from "./runtime.js";
 import { blockOnboardingMilestone, completeOnboardingMilestone, ensureDoctorPhase, onboardingLedger, onboardingSnapshot, recordOnboardingAttempt, runDoctorPhase, } from "./onboarding.js";
 import { VERSION, versionStatus, latestPublishedVersion } from "./version.js";
 import { initSentry, sendHeartbeat, captureError, flushSentry } from "./telemetry.js";
@@ -177,12 +176,11 @@ const server = new McpServer({
         "surfaces `update_available` and an `update_hint`.\n\n" +
         "TYPICAL FLOW: `project_config` (configure OR edit the project, and connect X) -> `draft_cycle` " +
         "(scan + review a batch; the user approves / edits / skips every draft in a single form) -> " +
-        "`autopilot` (enable to also turn on hands-free background posting AND daily auto-updates) -> " +
         "`get_stats` (see performance). Run `project_config` first; the other tools refuse until a " +
         "project is fully configured. To change anything about a project later, call `project_config` " +
         "again with the project's name and just the changed fields — there is no separate config editor.\n\n" +
         "RENDER THE DASHBOARD AFTER ACTIONS. After any state-changing or results-producing tool call " +
-        "(`draft_cycle`, `post_drafts`, `autopilot` enable/disable, `get_stats`), end your turn by " +
+        "(`draft_cycle`, `post_drafts`, `get_stats`), end your turn by " +
         "calling the `dashboard` tool so the user sees the updated state visually. Do NOT call " +
         "`dashboard` after pure Q&A, config explanations, or status-only checks that changed nothing.",
 });
@@ -502,6 +500,19 @@ async function postApproved(batchId, plan) {
     catch {
         /* keep raw */
     }
+    // On a successful run, mark the posted candidates in the ORIGINAL plan so the
+    // other review surface (chat vs menu-bar pop-ups) skips them — cross-surface
+    // de-dup. Best-effort; the pipeline's own already-posted check is the backstop.
+    if (res.code === 0) {
+        for (const c of approved)
+            c.posted = true;
+        try {
+            writePlan(batchId, plan);
+        }
+        catch {
+            /* best effort */
+        }
+    }
     return {
         attempted: approved.length,
         exit_code: res.code,
@@ -604,7 +615,7 @@ tool("project_config", {
         "Call with status:true (or no name) to list every configured project, its remaining fields, AND " +
         "whether X is connected. Use config, conversation context, profile_scan, and website research " +
         "before asking for fields. Ask only if no product can be identified or an interactive login is " +
-        "unavoidable. The draft_cycle, autopilot, and get_stats tools refuse to run until a project is " +
+        "unavoidable. The draft_cycle and get_stats tools refuse to run until a project is " +
         "fully set up.",
     inputSchema: {
         status: z.boolean().optional(),
@@ -1071,6 +1082,15 @@ tool("draft_cycle", {
         outcome: "review_batch",
         draft_count: count,
     });
+    // Fire the menu-bar pop-up review (default). The chat-table review below is
+    // unchanged; both surfaces can approve, de-duped by the plan `posted` flag.
+    writeReviewRequest({
+        batch_id: drafted.batchId,
+        project: proj,
+        count,
+        plan_path: planPath(drafted.batchId),
+        created_at: new Date().toISOString(),
+    });
     const table = renderDraftsTable(plan);
     const message = `Drafted ${count} ${count === 1 ? "reply" : "replies"} for "${proj}" ` +
         `(batch ${drafted.batchId}). NOTHING has been posted yet.\n\n` +
@@ -1175,6 +1195,18 @@ tool("post_drafts", {
         else
             warnings.push(`ignored #${n}: out of range (1-${total})`);
     });
+    // Cross-surface de-dup: chat and the menu-bar pop-ups can both approve, so
+    // never re-post a candidate the other surface already posted.
+    const alreadyPosted = [];
+    for (const n of Array.from(approve)) {
+        if (candidates[n - 1]?.posted === true) {
+            approve.delete(n);
+            alreadyPosted.push(n);
+        }
+    }
+    if (alreadyPosted.length) {
+        warnings.push(`already posted (skipped): ${alreadyPosted.sort((a, b) => a - b).join(", ")}`);
+    }
     candidates.forEach((c, i) => (c.approved = approve.has(i + 1)));
     writePlan(batch_id, plan);
     if (approve.size === 0) {
@@ -1199,92 +1231,16 @@ tool("post_drafts", {
         warnings,
     });
 });
-// ---- autopilot: one tool, three actions -----------------------------------
-tool("autopilot", {
-    title: "X autopilot",
-    description: "Control background X/Twitter posting. action=enable loads the launchd job so the " +
-        "cycle fires automatically; action=disable unloads it (manual draft_cycle still works); " +
-        "action=status reports whether it is loaded. After enable/disable, call the `dashboard` " +
-        "tool so the user sees the updated autopilot state.",
-    inputSchema: {
-        action: z.enum(["enable", "disable", "status"]),
-    },
-}, async ({ action }) => {
-    if (action !== "status" && !hasReadyProject()) {
-        return textContent("No project is fully set up yet, so autopilot has nothing to post. Run the `project_config` tool " +
-            "first. Note: autopilot runs the background cycle across all configured projects; it is " +
-            "not scoped to one project.");
-    }
-    const uid = process.getuid ? process.getuid() : 0;
-    const logDir = path.join(repoDir(), "skill", "logs");
-    if (action === "status") {
-        const res = await run("launchctl", ["list"], { timeoutMs: 10_000 });
-        const lines = res.stdout.split("\n");
-        const loaded = lines.some((l) => l.includes(TWITTER_AUTOPILOT_LABEL));
-        const updaterLoaded = lines.some((l) => l.includes(UPDATER_LABEL));
-        return jsonContent({
-            label: TWITTER_AUTOPILOT_LABEL,
-            loaded,
-            auto_update_label: UPDATER_LABEL,
-            auto_update_loaded: updaterLoaded,
-        });
-    }
-    if (action === "enable") {
-        // Bring up the on-screen overlay watcher so background autopilot cycles
-        // still paint the harness status/sidebar. Idempotent + detached.
-        await ensureOverlayWatch();
-        // 1) Cycle plist. Write one pointing at the self-update guard ONLY if no
-        //    plist exists yet; never overwrite a hand-tuned/dev plist.
-        const createdCycle = ensurePlist(TWITTER_AUTOPILOT_PLIST, plistXml({
-            label: TWITTER_AUTOPILOT_LABEL,
-            programArgs: ["/bin/bash", path.join(repoDir(), "skill", "run-cycle-update-guard.sh")],
-            intervalSecs: 60,
-            runAtLoad: false,
-            stdoutLog: path.join(logDir, "launchd-twitter-cycle-stdout.log"),
-            stderrLog: path.join(logDir, "launchd-twitter-cycle-stderr.log"),
-        }));
-        const cycleRes = await loadPlist(TWITTER_AUTOPILOT_LABEL, TWITTER_AUTOPILOT_PLIST, uid);
-        // 2) Daily self-updater. Keeps a headless install current with no human
-        //    in the loop. RunAtLoad so it also checks shortly after enable.
-        const createdUpdater = ensurePlist(UPDATER_PLIST, plistXml({
-            label: UPDATER_LABEL,
-            programArgs: ["/bin/bash", path.join(repoDir(), "skill", "social-autoposter-update.sh")],
-            intervalSecs: 86_400,
-            runAtLoad: true,
-            stdoutLog: path.join(logDir, "launchd-self-update-stdout.log"),
-            stderrLog: path.join(logDir, "launchd-self-update-stderr.log"),
-        }));
-        const updaterRes = await loadPlist(UPDATER_LABEL, UPDATER_PLIST, uid);
-        return jsonContent({
-            action: "enable",
-            autopilot: {
-                loaded: cycleRes.code === 0,
-                plist: TWITTER_AUTOPILOT_PLIST,
-                created: createdCycle,
-                error: cycleRes.code === 0 ? null : (cycleRes.stderr || cycleRes.stdout).trim(),
-            },
-            auto_update: {
-                loaded: updaterRes.code === 0,
-                plist: UPDATER_PLIST,
-                created: createdUpdater,
-                note: "Daily updater enabled. It self-updates real npm installs and is a no-op on dev/source " +
-                    "checkouts (refuses to clobber a .git working tree).",
-                error: updaterRes.code === 0 ? null : (updaterRes.stderr || updaterRes.stdout).trim(),
-            },
-        });
-    }
-    // disable — unload both jobs (leave the plist files in place for re-enable)
-    const cycleOff = await unloadPlist(TWITTER_AUTOPILOT_LABEL, TWITTER_AUTOPILOT_PLIST, uid);
-    const updaterOff = await unloadPlist(UPDATER_LABEL, UPDATER_PLIST, uid);
-    return jsonContent({
-        action: "disable",
-        autopilot_unloaded: cycleOff.code === 0,
-        auto_update_unloaded: updaterOff.code === 0,
-        note: cycleOff.code === 0
-            ? "Autopilot and daily auto-update unloaded. Manual draft_cycle still works."
-            : `Autopilot disable reported exit ${cycleOff.code}: ${(cycleOff.stderr || cycleOff.stdout).trim()}`,
-    });
-});
+// ---- autopilot: MCP tool removed ------------------------------------------
+// The `autopilot` MCP tool (enable/disable/status) was intentionally removed:
+// hands-free background posting is no longer toggled from the agent/tool surface.
+// The underlying launchd cycle job + plist (com.m13v.social-twitter-cycle) and
+// the daily self-updater are NOT touched here — an already-loaded job keeps
+// running, and the plist files stay on disk. The plist helpers above
+// (ensurePlist / plistXml / loadPlist / unloadPlist) and the constants are kept
+// as the underlying source for that job; the `dashboard` snapshot still reports
+// the job's loaded state via autopilotLoaded(). To enable/disable the job now,
+// use launchctl directly or re-add a tool here.
 // ---- get_stats: read-only -------------------------------------------------
 tool("get_stats", {
     title: "Get X/Twitter stats",
@@ -1452,7 +1408,7 @@ function runtimeSnapshot() {
 // ---- panel: MCP Apps control surface --------------------------------------
 // A self-contained HTML view rendered by hosts that support MCP Apps (Claude
 // desktop/web, etc.). It duplicates NO pipeline logic: each button calls one of
-// the tools above (draft_cycle / autopilot / project_config / get_stats) through the host
+// the tools above (draft_cycle / project_config / get_stats) through the host
 // and re-reads status. The tool itself returns the first-paint snapshot so the
 // view has data the instant it loads.
 // Is either launchd job (cycle / daily updater) currently loaded?
@@ -1624,19 +1580,44 @@ function startLocalPanel() {
         });
     });
 }
-// Publish the loopback URL to a stable file so an out-of-process reader (the
-// Claude Code side-panel reverse proxy) can find the ephemeral port without
-// scraping `lsof`. Best-effort: a write failure never blocks the panel.
+// Publish the loopback URL to stable files so out-of-process readers can find
+// the ephemeral port without scraping `lsof`:
+//   - panel-url            plain text, for the Claude Code side-panel reverse proxy.
+//   - panel-endpoint.json  richer (url + version + pid), for the menu bar app,
+//                          which POSTs /tool/<name> here for live data.
+// Best-effort: a write failure never blocks the panel (readers re-check /health).
 function writePanelUrl(url) {
     try {
         const dir = path.join(process.env.HOME || os.homedir(), ".social-autoposter-mcp");
         fs.mkdirSync(dir, { recursive: true });
         fs.writeFileSync(path.join(dir, "panel-url"), url, "utf-8");
+        fs.writeFileSync(path.join(dir, "panel-endpoint.json"), JSON.stringify({ url, pid: process.pid, version: VERSION, started_at: new Date().toISOString() }, null, 2) + "\n", "utf-8");
     }
     catch (e) {
         console.error("[social-autoposter-mcp] writePanelUrl failed:", e?.message || e);
     }
 }
+// The owned state dir, honoring SAPS_STATE_DIR (matches menubar/s4l_state.py).
+function sapsStateDir() {
+    return (process.env.SAPS_STATE_DIR ||
+        path.join(process.env.HOME || os.homedir(), ".social-autoposter-mcp"));
+}
+// Signal the menu bar that a fresh draft batch is ready for pop-up review. The
+// chat-table review path is unchanged and still works; this just ALSO lets the
+// corner cards drive review (both surfaces de-dup via the plan's `posted` flag).
+// The menu bar reads review-request.json, presents the cards, posts via the
+// loopback post_drafts tool, then clears the file. Best-effort: a write failure
+// just means no pop-ups this batch (chat review still works).
+function writeReviewRequest(req) {
+    try {
+        const dir = sapsStateDir();
+        fs.mkdirSync(dir, { recursive: true });
+        fs.writeFileSync(path.join(dir, "review-request.json"), JSON.stringify(req, null, 2) + "\n", "utf-8");
+    }
+    catch (e) {
+        console.error("[social-autoposter-mcp] writeReviewRequest failed:", e?.message || e);
+    }
+}
 // Open a URL in the user's default browser, cross-platform. Opening is OPT-IN:
 // by default we do NOT pop a browser tab. The dashboard already surfaces in-host
 // (MCP Apps inline) or via the Claude Code side panel / returned loopback URL, so
@@ -1658,10 +1639,10 @@ async function openInBrowser(url) {
 appTool("dashboard", {
     title: "Social Autoposter dashboard",
     description: "Render the Social Autoposter dashboard in chat: a visual surface showing project setup, X " +
-        "connection, autopilot state, and 7-day stats, with buttons to run a draft cycle, toggle " +
-        "autopilot, connect X, and refresh. Use when the user asks to see the dashboard, panel, " +
+        "connection, autopilot state, and 7-day stats, with buttons to run a draft cycle, connect X, " +
+        "and refresh. Use when the user asks to see the dashboard, panel, " +
         "status, or controls. ALSO call this at the end of any state-changing or results-producing " +
-        "action (draft_cycle, post_drafts, autopilot enable/disable, get_stats) so the user sees the " +
+        "action (draft_cycle, post_drafts, get_stats) so the user sees the " +
         "updated dashboard. Hosts without UI support get the same data as text.",
     inputSchema: {},
     // fallback_url is set only when the host can't render the ui:// resource and
@@ -1802,6 +1783,12 @@ async function main() {
     void startLocalPanel()
         .then((url) => console.error(`[social-autoposter-mcp] panel loopback ready at ${url}`))
         .catch((e) => console.error("[social-autoposter-mcp] panel loopback start failed:", e?.message || e));
+    // Ensure the macOS menu bar mini-dashboard is installed + running. Idempotent
+    // and cheap when already present, so existing installs pick it up on the next
+    // Claude restart without re-provisioning. Best-effort: never blocks boot.
+    void ensureMenubar()
+        .then((r) => console.error(`[social-autoposter-mcp] menubar: ${r.skipped ? "skip" : r.ok ? "ok" : "fail"} (${r.detail})`))
+        .catch((e) => console.error("[social-autoposter-mcp] menubar ensure failed:", e?.message || e));
     // Phone home so this .mcpb install is visible in the install-lane digest
     // (parity with the npx launchd heartbeat). Once on startup, then every 15m
     // while the desktop app keeps the server alive. unref() so it never holds the