social-autoposter 1.6.35 → 1.6.36

package/bin/cli.js

@@ -214,6 +214,30 @@ function isAppMakerVm() {
   return probe.status === 0;
 }
 
+// VM / AppMaker support is strictly opt-in. A normal `init`/`update` (the
+// macOS user path) installs none of it — no apt-get, no :9222 CDP env file, no
+// AppMaker MCP port overrides. It activates only when explicitly requested:
+//   - env  SA_VM=1  (or SOCIAL_AUTOPOSTER_VM=1)
+//   - flag --vm     on the command line
+//   - a persisted marker written by `bootstrap-vm` (so later `update`s on the
+//     same VM stay in VM mode without re-passing the flag)
+//   - a genuine AppMaker VM (linux + /opt/startup.sh + live :9222) — kept as a
+//     fallback so the existing mk0r bootstrap keeps working untouched. This can
+//     never be true on a user's Mac.
+const VM_MARKER = path.join(HOME, '.social-autoposter', 'vm-mode');
+function vmModeEnabled() {
+  if (process.env.SA_VM === '1' || process.env.SOCIAL_AUTOPOSTER_VM === '1') return true;
+  if (process.argv.includes('--vm')) return true;
+  try { if (fs.existsSync(VM_MARKER)) return true; } catch { /* ignore */ }
+  return isAppMakerVm();
+}
+function enableVmMode() {
+  try {
+    fs.mkdirSync(path.dirname(VM_MARKER), { recursive: true });
+    fs.writeFileSync(VM_MARKER, 'enabled\n');
+  } catch { /* best-effort; vmModeEnabled() still honors env/flag/probe */ }
+}
+
 // Write ~/.social-autoposter-env so skill/lib/twitter-backend.sh picks up the
 // AppMaker-specific TWITTER_CDP_URL before its `${VAR:-default}` fallback hits.
 // Idempotent: rewrites the file every invocation so a config edit on the VM
@@ -375,6 +399,9 @@ function bootstrapVm() {
     console.error('bootstrap-vm: not an AppMaker VM (no /opt/startup.sh + CDP :9222). Use `init` or `update` on dev boxes.');
     process.exit(2);
   }
+  // Persist VM mode so subsequent `update` runs on this sandbox keep the
+  // AppMaker tweaks without re-passing --vm/SA_VM.
+  enableVmMode();
   console.log('  AppMaker VM bootstrap: resolving identity from DB by sessionKey...');
 
   let sessionKey;
@@ -471,7 +498,7 @@ function bootstrapVm() {
 }
 
 function installBrowserHarness() {
-  const onAppMaker = isAppMakerVm();
+  const onAppMaker = vmModeEnabled();
   if (onAppMaker) {
     console.log('  AppMaker VM detected -> installing harness toolchain (deps); MCP will be pointed at port 9222');
     writeAppMakerEnvFile();
@@ -803,7 +830,7 @@ function init() {
   installBrowserAgentConfigs();
   // On AppMaker VMs, patch the twitter-harness MCP config so its server.py
   // drives port 9222 (AppMaker Chromium) instead of the default 9555.
-  if (isAppMakerVm()) applyAppMakerMcpConfigOverrides();
+  if (vmModeEnabled()) applyAppMakerMcpConfigOverrides();
   // Register those MCP servers with Claude so they show up in `claude mcp list`.
   registerBrowserAgentMcpServers();
 
@@ -891,7 +918,7 @@ function update() {
   installBrowserAgentConfigs();
   // On AppMaker VMs, patch the twitter-harness MCP config so its server.py
   // drives port 9222 (AppMaker Chromium) instead of the default 9555.
-  if (isAppMakerVm()) applyAppMakerMcpConfigOverrides();
+  if (vmModeEnabled()) applyAppMakerMcpConfigOverrides();
   // Register any newly added MCP servers with Claude (idempotent).
   registerBrowserAgentMcpServers();
 

package/mcp/dist/index.js

@@ -131,6 +131,34 @@ function jsonContent(obj) {
 function textContent(text) {
     return { content: [{ type: "text", text }] };
 }
+// Map a pipeline failure-reason key (from scripts/classify_run_error.py, emitted
+// by run-twitter-cycle.sh as `DRAFT_ONLY_BLOCKED=<reason>`) to a clear,
+// actionable message. The most common one on a fresh machine is
+// claude_not_logged_in: the background `claude` CLI the pipeline shells out to
+// has its OWN login, separate from Claude Desktop, so it can be logged out even
+// though this MCP host is signed in. Without this, an auth failure was silently
+// reported as a benign empty cycle ("all threads already engaged").
+function blockedReasonMessage(reason) {
+    switch (reason) {
+        case "claude_not_logged_in":
+            return ("The background Claude CLI on this machine isn't logged in, so the drafting step " +
+                "couldn't run. (It DID find and rank threads, it just couldn't draft replies.) This " +
+                "CLI uses its own login, separate from Claude Desktop. To fix it, open a terminal and run:\n\n" +
+                "    claude\n\n" +
+                "then `/login` inside it (or run `claude setup-token`). Once it's logged in, run draft_cycle again.");
+        case "monthly_limit":
+        case "daily_limit":
+        case "rate_limit_5h":
+            return (`The drafting step hit an Anthropic usage limit (${reason}), so no replies were drafted. ` +
+                "Wait for the limit to reset, then run draft_cycle again.");
+        case "credit_balance":
+            return ("The drafting step failed because the Anthropic account is out of credits. " +
+                "Add credits, then run draft_cycle again.");
+        default:
+            return (`The drafting step failed (${reason}) and produced no drafts. ` +
+                "Check skill/logs/twitter-cycle-*.log on this machine for details, then run draft_cycle again.");
+    }
+}
 async function produceDrafts(project) {
     // Run the real pipeline in DRAFT_ONLY mode: scan -> score -> draft -> link-gen,
     // then STOP before posting. The script prints `DRAFT_ONLY_PLAN=<path>` and
@@ -150,6 +178,13 @@ async function produceDrafts(project) {
     const marker = /DRAFT_ONLY_PLAN=\/tmp\/twitter_cycle_plan_(.+)\.json/.exec(res.stdout + "\n" + res.stderr);
     if (marker && marker[1])
         return { batchId: marker[1] };
+    // A real prep-step failure (e.g. the background claude CLI isn't logged in)
+    // emits DRAFT_ONLY_BLOCKED=<reason>. Surface that instead of silently falling
+    // back to a stale/empty batch and mis-reporting "no fresh candidates".
+    const blockedMarker = /DRAFT_ONLY_BLOCKED=([a-z0-9_]+)/.exec(res.stdout + "\n" + res.stderr);
+    if (blockedMarker && blockedMarker[1]) {
+        return { batchId: null, blocked: blockedReasonMessage(blockedMarker[1]) };
+    }
     const existing = latestBatchId();
     if (existing)
         return { batchId: existing };