social-autoposter 1.6.31 → 1.6.32

package/mcp/manifest.json

@@ -50,7 +50,8 @@
       "type": "directory",
       "title": "Social Autoposter repo path",
       "description": "Absolute path to your social-autoposter repo clone (the folder that contains config.json, scripts/, skill/). The MCP shells out to the pipeline scripts in this folder.",
-      "required": true
+      "required": true,
+      "default": "${HOME}/social-autoposter"
     },
     "saps_python": {
       "type": "string",

package/mcp-servers/browser-harness/server.py

@@ -309,31 +309,93 @@ def _terminate(pid: int, grace: float = 5.0) -> None:
         pass
 
 
+def _cdp_browser_close() -> bool:
+    """Ask Chrome to quit via CDP Browser.close. This is Chrome's own
+    graceful-shutdown RPC: it tears down renderers in order and flushes the
+    cookie store before exiting, which signal-based termination does not
+    reliably guarantee. Returns True if the RPC was issued; False if the
+    browser-harness CLI was missing, CDP was unreachable, or the call errored.
+    Issuing the RPC does NOT mean Chrome has exited yet — poll the pid."""
+    if not shutil.which(BROWSER_HARNESS_BIN) and not Path(BROWSER_HARNESS_BIN).exists():
+        return False
+    env = os.environ.copy()
+    env["BU_CDP_URL"] = CDP_URL
+    env["PATH"] = f"{Path.home()}/.local/bin:" + env.get("PATH", "")
+    try:
+        proc = subprocess.run(
+            [BROWSER_HARNESS_BIN],
+            input="cdp('Browser.close')\n",
+            env=env,
+            capture_output=True,
+            text=True,
+            timeout=10,
+        )
+    except (subprocess.TimeoutExpired, OSError):
+        return False
+    return proc.returncode == 0
+
+
 def stop_chrome() -> dict:
     """Gracefully stop the managed Chrome — the tracked process AND any orphan
     still LISTENing on the debug port — so connect_x-launched Chromes can't
-    strand the port. SIGTERM-with-grace lets Chrome persist cookies to disk."""
-    targets: list[int] = []
-    pid = _read_pid()
-    if pid and _pid_alive(pid):
-        targets.append(pid)
-    for owner in _port_owner_pids():
-        if owner not in targets and _pid_alive(owner):
-            targets.append(owner)
-
-    for t in targets:
-        _terminate(t)
-
-    try:
-        PID_FILE.unlink()
-    except FileNotFoundError:
-        pass
-    for stale in ("/tmp/bu-default.sock", "/tmp/bu-default.pid"):
+    strand the port.
+
+    Two-stage shutdown: first ask Chrome to quit itself via CDP `Browser.close`
+    (its own graceful-quit RPC, which flushes the cookie SQLite synchronously
+    before exit). If the process exits within `CDP_QUIT_DEADLINE_SEC`, we're
+    done — cookies are durable. Only if CDP refuses or the process doesn't
+    exit in time do we fall back to SIGTERM-with-grace, then SIGKILL. The old
+    SIGTERM+5s+SIGKILL path lost cookies because Chrome's shutdown sequence
+    sometimes outlasts the 5s window; CDP-first removes that race."""
+    CDP_QUIT_DEADLINE_SEC = 20.0
+    POLL_INTERVAL_SEC = 0.5
+
+    tracked_pid = _read_pid()
+    initial_owners = _port_owner_pids()
+    initial_targets: list[int] = []
+    if tracked_pid and _pid_alive(tracked_pid):
+        initial_targets.append(tracked_pid)
+    for owner in initial_owners:
+        if owner not in initial_targets and _pid_alive(owner):
+            initial_targets.append(owner)
+
+    cdp_attempted = False
+    cdp_issued = False
+    if initial_targets and _cdp_alive():
+        cdp_attempted = True
+        cdp_issued = _cdp_browser_close()
+        if cdp_issued:
+            deadline = time.time() + CDP_QUIT_DEADLINE_SEC
+            while time.time() < deadline:
+                still_alive = [p for p in initial_targets if _pid_alive(p)]
+                if not still_alive:
+                    break
+                time.sleep(POLL_INTERVAL_SEC)
+
+    reaped: list[int] = []
+    survivors = [p for p in initial_targets if _pid_alive(p)]
+    for p in survivors:
+        _terminate(p, grace=15.0)
+        reaped.append(p)
+
+    for stale in (PID_FILE, Path("/tmp/bu-default.sock"), Path("/tmp/bu-default.pid")):
         try:
-            os.unlink(stale)
+            stale.unlink()
         except FileNotFoundError:
             pass
-    return {"status": "stopped", "reaped": targets, "tracked_pid": pid}
+
+    via = "cdp_browser_close" if (cdp_issued and not survivors) else (
+        "sigterm_fallback" if cdp_attempted else "sigterm"
+    )
+    return {
+        "status": "stopped",
+        "via": via,
+        "tracked_pid": tracked_pid,
+        "initial_targets": initial_targets,
+        "cdp_attempted": cdp_attempted,
+        "cdp_issued": cdp_issued,
+        "sigterm_reaped": reaped,
+    }
 
 
 # --- browser-harness exec wrapper ---

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "social-autoposter",
-  "version": "1.6.31",
+  "version": "1.6.32",
   "description": "Automated social posting pipeline for Reddit, X/Twitter, LinkedIn, and Moltbook. Install as a Claude Code agent skill.",
   "bin": {
     "social-autoposter": "bin/cli.js"
@@ -106,6 +106,7 @@
     "!scripts/test_own_reply_dedup.py",
     "!scripts/twitter_compose_dm.py",
     "scripts/*.sh",
+    "!scripts/_dm_icp_batch.sh",
     "config.example.json",
     "requirements.txt",
     "SKILL.md",
@@ -117,7 +118,9 @@
     "mcp/dist/",
     "mcp/package.json",
     "mcp/manifest.json",
-    "mcp/install.mjs"
+    "mcp/install.mjs",
+    "!**/__pycache__/**",
+    "!**/*.pyc"
   ],
   "keywords": [
     "social-media",

package/skill/invent-supply-test.sh

@@ -65,13 +65,14 @@ echo "[invent-supply-test] twitter-browser lock held (pid=$$)" >&2
 
 # One harness invocation handles every query so we pay the CLI startup once.
 # Each scan() call appends a JSONL record to SCAN_TWEETS_FILE=$SCAN_OUT.
-# Upstream browser-harness dropped `-c <script>` for stdin-heredoc; pipe via
-# an unquoted heredoc so $REPO_DIR / $QUERIES_JSON still expand.
+# Installed browser-harness (v0.1.0) only accepts `-c "<script>"`; it does NOT
+# read from stdin (a heredoc just prints usage and exits with 0 tweets). Use
+# double-quoted -c so $REPO_DIR / $QUERIES_JSON still expand.
 BU_NAME=twitter-harness BU_CDP_URL=http://127.0.0.1:9555 \
 SCAN_TWEETS_FILE="$SCAN_OUT" \
 BATCH_ID="${BATCH_ID:-}" \
 FRESHNESS_HOURS_DISCOVER="$FRESHNESS_HOURS" \
-  "$HARNESS_BIN" <<PY 2>&1
+  "$HARNESS_BIN" -c "
 import sys, json, os, time
 sys.path.insert(0, '$REPO_DIR/scripts')
 from twitter_scan import scan
@@ -90,7 +91,7 @@ for q in queries:
     except Exception as e:
         dt = time.time() - t0
         print(f'  err project={project!r}  q={query[:50]!r}  in {dt:.1f}s  {type(e).__name__}: {e}', flush=True)
-PY
+" 2>&1
 
 release_lock "twitter-browser"
 echo "[invent-supply-test] done; results in $SCAN_OUT" >&2

package/skill/run-twitter-cycle.sh

@@ -690,6 +690,49 @@ log "twitter-browser lock held (pid=$$) Phase 1"
 # refuses to clean if the lock PID is alive.
 ensure_twitter_browser_for_backend 2>&1 | tee -a "$LOG_FILE"
 
+# --- Pre-flight: live X session probe (added 2026-06-02) --------------------
+# Before drafting/scraping anything, confirm the harness Chrome actually has a
+# valid x.com session. One CDP Network.getCookies call (<1s) catches the
+# "import never ran, evaporated after a hard restart, or auth_token expired"
+# cases that previously surfaced as "Phase 1 returned 0 tweets" mysteries.
+# Failing fast here turns a wasted ~7-minute scan + Claude bill into a clear
+# "reconnect X" message in the log.
+log "Pre-flight: probing harness Chrome for a live x.com auth_token..."
+_PREFLIGHT_OUT=$(BU_NAME=twitter-harness BU_CDP_URL=http://127.0.0.1:9555 \
+    "$HOME/.local/bin/browser-harness" -c "
+import sys, time
+try:
+    raw = cdp('Network.getCookies', urls=['https://x.com/', 'https://twitter.com/'])
+except Exception as e:
+    print('PREFLIGHT_CDP_ERROR ' + type(e).__name__ + ': ' + str(e))
+    sys.exit(0)
+ck = raw.get('cookies', [])
+auth = [c for c in ck if c.get('name') == 'auth_token']
+if not auth:
+    print('PREFLIGHT_FAIL no_auth_token cookies_total=' + str(len(ck)))
+    sys.exit(0)
+exp = auth[0].get('expires')
+domain = auth[0].get('domain', '?')
+if exp in (None, -1, 0):
+    print('PREFLIGHT_OK session domain=' + domain)
+else:
+    now = time.time()
+    if exp < now:
+        print('PREFLIGHT_FAIL auth_token_expired exp=' + str(int(exp)) + ' now=' + str(int(now)))
+        sys.exit(0)
+    print('PREFLIGHT_OK exp=' + str(int(exp)) + ' domain=' + domain)
+" 2>&1)
+if printf '%s\n' "$_PREFLIGHT_OUT" | grep -q '^PREFLIGHT_OK'; then
+    log "  Pre-flight OK: $(printf '%s\n' "$_PREFLIGHT_OUT" | grep '^PREFLIGHT_OK' | head -1)"
+else
+    log "  Pre-flight FAILED. The harness Chrome has no live X session."
+    log "  Details: $(printf '%s\n' "$_PREFLIGHT_OUT" | tail -3 | tr '\n' '|')"
+    log "  Action: run \`python3 scripts/setup_twitter_auth.py connect\` (or call the connect_x MCP tool) to import a fresh X session from your everyday browser, then re-run the cycle. If the import fails with 'access denied', unlock the macOS keychain first: \`security unlock-keychain ~/Library/Keychains/login.keychain-db\`."
+    echo "twitter_batches: ended $BATCH_ID"
+    release_lock "twitter-browser" 2>/dev/null || true
+    exit 1
+fi
+
 # --- Phase 1 retry loop (2026-05-27) ----------------------------------------
 # When a single scan produces fewer than RETRY_TARGET candidates that survive
 # all Phase 1 filters (harness age gate, scorer stale_age cutoff, already-
@@ -996,15 +1039,17 @@ except Exception: print(0)
 # $SCAN_TWEETS_FILE, which the existing shell-side parse below consumes.
 if [ "$QUERIES_COUNT" -gt 0 ]; then
     log "Lean Phase 1: executing $QUERIES_COUNT queries via browser-harness CDP"
-    # Upstream browser-harness dropped `-c <script>` in favor of stdin-heredoc;
-    # pipe via an unquoted heredoc so $REPO_DIR / $QUERIES_TMP still expand.
+    # Installed browser-harness (v0.1.0) only accepts `-c "<script>"`; it does NOT
+    # read a script from stdin (a heredoc just makes it print its usage line and
+    # exit, producing 0 tweets). Use double-quoted -c so $REPO_DIR / $QUERIES_TMP
+    # still expand; the Python body uses single quotes internally so it nests fine.
     BU_NAME=twitter-harness BU_CDP_URL=http://127.0.0.1:9555 \
     SCAN_TWEETS_FILE="$SCAN_TWEETS_FILE" \
     BATCH_ID="$BATCH_ID" \
     TWITTER_CYCLE_VARIANT="$TWITTER_CYCLE_VARIANT" \
     FRESHNESS_HOURS_DISCOVER="$FRESHNESS_HOURS_DISCOVER" \
     ENGAGED_TWEET_IDS="$ENGAGED_TWEET_IDS" \
-        "$HOME/.local/bin/browser-harness" <<PY 2>&1 | tee -a "$LOG_FILE"
+        "$HOME/.local/bin/browser-harness" -c "
 import sys, json, os, time
 sys.path.insert(0, '$REPO_DIR/scripts')
 from twitter_scan import scan
@@ -1029,7 +1074,7 @@ for q in queries:
     except Exception as e:
         dt = time.time() - t0
         print(f'  err project={project!r}  q={query[:50]!r}  in {dt:.1f}s  {type(e).__name__}: {e}', flush=True)
-PY
+" 2>&1 | tee -a "$LOG_FILE"
 fi
 rm -f "$QUERIES_TMP"
 

package/scripts/_dm_icp_batch.sh

@@ -1,32 +0,0 @@
-#!/bin/bash
-# Usage: _dm_icp_batch.sh DM_ID DEFAULT_LABEL DEFAULT_NOTES [override:project=label:notes ...]
-# Sets default label/notes on all 19 projects, then applies overrides
-set -e
-DM_ID=$1
-DEFAULT_LABEL=$2
-DEFAULT_NOTES=$3
-shift 3
-
-declare -A LABELS NOTES
-PROJECTS=(fazm Terminator "macOS MCP" Vipassana S4L "AI Browser Profile" "WhatsApp MCP" "macOS Session Replay" Cyrano Assrt PieLine Clone mk0r fde10x claude-meter c0nsl tenxats paperback-expert studyly)
-for p in "${PROJECTS[@]}"; do
-  LABELS["$p"]="$DEFAULT_LABEL"
-  NOTES["$p"]="$DEFAULT_NOTES"
-done
-
-for arg in "$@"; do
-  proj="${arg%%=*}"
-  rest="${arg#*=}"
-  lbl="${rest%%:*}"
-  note="${rest#*:}"
-  LABELS["$proj"]="$lbl"
-  NOTES["$proj"]="$note"
-done
-
-cd /Users/matthewdi/social-autoposter
-for p in "${PROJECTS[@]}"; do
-  python3 scripts/dm_conversation.py set-icp-precheck \
-    --dm-id "$DM_ID" --project "$p" \
-    --label "${LABELS[$p]}" --notes "${NOTES[$p]}" >/dev/null
-done
-echo "ICP prechecks set for DM $DM_ID (default=$DEFAULT_LABEL, ${#@} overrides)"