snow-flow 4.3.8 → 4.3.10

package/dist/mcp/servicenow-knowledge-catalog-mcp.js

@@ -798,7 +798,7 @@ ${args.recurring_price && args.recurring_price !== '0' ? `🔄 Recurring: $${arg
                 this.logger.error('❌ Variable creation failed:', {
                     error: response.error,
                     payload: variableData,
-                    status: response.status
+                    success: response.success
                 });
                 throw new Error(`Failed to create catalog variable: ${response.error}`);
             }
@@ -843,435 +843,434 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
         this.logger.info('🎯 SIMPLIFIED: Creating catalog UI policy with working approach...');
         // Simplified approach - focus on what actually works in ServiceNow
         try {
+            this.logger.info('Creating comprehensive catalog UI policy...');
+            // First, let's fetch ALL variables for this catalog item for debugging
+            this.logger.info(`📋 Fetching all variables for catalog item ${args.cat_item} for debugging...`);
             try {
-                this.logger.info('Creating comprehensive catalog UI policy...');
-                // First, let's fetch ALL variables for this catalog item for debugging
-                this.logger.info(`📋 Fetching all variables for catalog item ${args.cat_item} for debugging...`);
-                try {
-                    const allVarsResponse = await this.client.searchRecords('sc_cat_item_option', `cat_item=${args.cat_item}`, 100);
-                    if (allVarsResponse.success && allVarsResponse.data.result.length > 0) {
-                        this.logger.info(`📊 Found ${allVarsResponse.data.result.length} variables for this catalog item:`);
-                        allVarsResponse.data.result.forEach((v) => {
-                            this.logger.info(`  - Variable: name='${v.name}', sys_id='${v.sys_id}', question='${v.question_text}'`);
-                        });
-                    }
-                    else {
-                        this.logger.warn(`⚠️ No variables found for catalog item ${args.cat_item} - this might be a problem!`);
-                    }
+                const allVarsResponse = await this.client.searchRecords('sc_cat_item_option', `cat_item=${args.cat_item}`, 100);
+                if (allVarsResponse.success && allVarsResponse.data.result.length > 0) {
+                    this.logger.info(`📊 Found ${allVarsResponse.data.result.length} variables for this catalog item:`);
+                    allVarsResponse.data.result.forEach((v) => {
+                        this.logger.info(`  - Variable: name='${v.name}', sys_id='${v.sys_id}', question='${v.question_text}'`);
+                    });
                 }
-                catch (error) {
-                    this.logger.error(`❌ Failed to fetch variables for debugging:`, error);
+                else {
+                    this.logger.warn(`⚠️ No variables found for catalog item ${args.cat_item} - this might be a problem!`);
                 }
-                // Helper function to resolve variable names to sys_ids with MULTIPLE FALLBACKS
-                const resolveVariableId = async (variableName, catalogItem) => {
-                    // If already a sys_id, return as-is
-                    if (variableName && variableName.match(/^[a-f0-9]{32}$/)) {
-                        this.logger.info(`✅ Using sys_id directly: ${variableName}`);
-                        return variableName;
+            }
+            catch (error) {
+                this.logger.error(`❌ Failed to fetch variables for debugging:`, error);
+            }
+            // Helper function to resolve variable names to sys_ids with MULTIPLE FALLBACKS
+            const resolveVariableId = async (variableName, catalogItem) => {
+                // If already a sys_id, return as-is
+                if (variableName && variableName.match(/^[a-f0-9]{32}$/)) {
+                    this.logger.info(`✅ Using sys_id directly: ${variableName}`);
+                    return variableName;
+                }
+                this.logger.info(`🔍 Resolving variable name '${variableName}' to sys_id for catalog item ${catalogItem}...`);
+                // Try multiple search strategies for maximum compatibility
+                const searchStrategies = [
+                    // Strategy 1: Search by name field
+                    {
+                        query: `cat_item=${catalogItem}^name=${variableName}`,
+                        description: 'by name field'
+                    },
+                    // Strategy 2: Search by name with LIKE operator
+                    {
+                        query: `cat_item=${catalogItem}^nameLIKE${variableName}`,
+                        description: 'by name with LIKE'
+                    },
+                    // Strategy 3: Search by question_text
+                    {
+                        query: `cat_item=${catalogItem}^question_text=${variableName}`,
+                        description: 'by question_text field'
+                    },
+                    // Strategy 4: Search all variables for this item and match manually
+                    {
+                        query: `cat_item=${catalogItem}`,
+                        description: 'all variables for manual matching'
                     }
-                    this.logger.info(`🔍 Resolving variable name '${variableName}' to sys_id for catalog item ${catalogItem}...`);
-                    // Try multiple search strategies for maximum compatibility
-                    const searchStrategies = [
-                        // Strategy 1: Search by name field
-                        {
-                            query: `cat_item=${catalogItem}^name=${variableName}`,
-                            description: 'by name field'
-                        },
-                        // Strategy 2: Search by name with LIKE operator
-                        {
-                            query: `cat_item=${catalogItem}^nameLIKE${variableName}`,
-                            description: 'by name with LIKE'
-                        },
-                        // Strategy 3: Search by question_text
-                        {
-                            query: `cat_item=${catalogItem}^question_text=${variableName}`,
-                            description: 'by question_text field'
-                        },
-                        // Strategy 4: Search all variables for this item and match manually
-                        {
-                            query: `cat_item=${catalogItem}`,
-                            description: 'all variables for manual matching'
-                        }
-                    ];
-                    for (const strategy of searchStrategies) {
-                        this.logger.info(`🔍 Trying strategy: ${strategy.description}`);
-                        try {
-                            const varResponse = await this.client.searchRecords('sc_cat_item_option', strategy.query, 50 // Get more results for manual matching
-                            );
-                            if (varResponse.success && varResponse.data.result.length > 0) {
-                                // For the "all variables" strategy, try to match manually
-                                if (strategy.description === 'all variables for manual matching') {
-                                    const match = varResponse.data.result.find((v) => v.name === variableName ||
-                                        v.question_text === variableName ||
-                                        v.name?.toLowerCase() === variableName.toLowerCase());
-                                    if (match) {
-                                        this.logger.info(`✅ Found variable through manual matching: ${match.sys_id}`);
-                                        return match.sys_id;
-                                    }
-                                }
-                                else {
-                                    // Direct match found
-                                    const sysId = varResponse.data.result[0].sys_id;
-                                    this.logger.info(`✅ Resolved '${variableName}' to sys_id: ${sysId} (${strategy.description})`);
-                                    return sysId;
+                ];
+                for (const strategy of searchStrategies) {
+                    this.logger.info(`🔍 Trying strategy: ${strategy.description}`);
+                    try {
+                        const varResponse = await this.client.searchRecords('sc_cat_item_option', strategy.query, 50 // Get more results for manual matching
+                        );
+                        if (varResponse.success && varResponse.data.result.length > 0) {
+                            // For the "all variables" strategy, try to match manually
+                            if (strategy.description === 'all variables for manual matching') {
+                                const match = varResponse.data.result.find((v) => v.name === variableName ||
+                                    v.question_text === variableName ||
+                                    v.name?.toLowerCase() === variableName.toLowerCase());
+                                if (match) {
+                                    this.logger.info(`✅ Found variable through manual matching: ${match.sys_id}`);
+                                    return match.sys_id;
                                 }
                             }
-                        }
-                        catch (error) {
-                            this.logger.warn(`⚠️ Strategy failed: ${strategy.description}`, error);
-                        }
-                    }
-                    // If all strategies fail, try alternate table names (just in case)
-                    const alternateTables = ['item_option_new', 'io_set_item_option'];
-                    for (const table of alternateTables) {
-                        this.logger.info(`🔍 Trying alternate table: ${table}`);
-                        try {
-                            const varResponse = await this.client.searchRecords(table, `cat_item=${catalogItem}^name=${variableName}`, 1);
-                            if (varResponse.success && varResponse.data.result.length > 0) {
+                            else {
+                                // Direct match found
                                 const sysId = varResponse.data.result[0].sys_id;
-                                this.logger.info(`✅ Found in alternate table ${table}: ${sysId}`);
+                                this.logger.info(`✅ Resolved '${variableName}' to sys_id: ${sysId} (${strategy.description})`);
                                 return sysId;
                             }
                         }
-                        catch (error) {
-                            this.logger.warn(`⚠️ Alternate table ${table} failed:`, error);
-                        }
                     }
-                    this.logger.error(`❌ CRITICAL: Variable '${variableName}' not found in any table for catalog item ${catalogItem}`);
-                    this.logger.error(`❌ This will cause the action to fail! Please use the sys_id directly instead of the name.`);
-                    // Return the name but log a warning that this will fail
-                    return variableName;
-                };
-                // Helper function to map operations to correct ServiceNow format
-                const mapOperatorToServiceNow = (operator) => {
-                    const opMap = {
-                        'is': '=',
-                        'equals': '=',
-                        'is_not': '!=',
-                        'is not': '!=',
-                        'not equals': '!=',
-                        'contains': 'LIKE',
-                        'does_not_contain': 'NOT LIKE',
-                        'does not contain': 'NOT LIKE',
-                        'greater_than': '>',
-                        'greater than': '>',
-                        'less_than': '<',
-                        'less than': '<',
-                        'is_empty': 'ISEMPTY',
-                        'is empty': 'ISEMPTY',
-                        'is_not_empty': 'ISNOTEMPTY', // ✅ CRITICAL FIX: was missing!
-                        'is not empty': 'ISNOTEMPTY'
-                    };
-                    const normalizedOp = operator.toLowerCase().trim();
-                    const mapped = opMap[normalizedOp] || operator;
-                    this.logger.info(`🎯 Mapped operator '${operator}' -> '${mapped}'`);
-                    return mapped;
-                };
-                // Build condition string from conditions array
-                let conditionString = '';
-                this.logger.info('Checking conditions parameter:', {
-                    hasConditions: !!args.conditions,
-                    isArray: Array.isArray(args.conditions),
-                    length: args.conditions ? args.conditions.length : 0,
-                    conditionsData: args.conditions
-                });
-                if (args.conditions && Array.isArray(args.conditions)) {
-                    this.logger.info(`🎯 Building conditions string from ${args.conditions.length} conditions...`);
-                    const conditionParts = [];
-                    for (const condition of args.conditions) {
-                        // Resolve variable name to sys_id
-                        const variableId = await resolveVariableId(condition.catalog_variable, args.cat_item);
-                        // Get the correct ServiceNow operator
-                        const originalOperator = condition.operation || 'is';
-                        const serviceNowOperator = mapOperatorToServiceNow(originalOperator);
-                        // Safely get condition value (avoid undefined concatenation)
-                        const conditionValue = condition.value || '';
-                        // Build the condition part based on operator type
-                        // ✅ CRITICAL: Conditions must use IO:sys_id format for catalog variables!
-                        // BUT only if we successfully resolved the variable to a sys_id
-                        const isValidSysId = variableId && variableId.match(/^[a-f0-9]{32}$/);
-                        const variableWithIOPrefix = isValidSysId ? `IO:${variableId}` : variableId;
-                        if (!isValidSysId) {
-                            this.logger.warn(`⚠️ Variable '${condition.catalog_variable}' could not be resolved to sys_id - condition may fail!`);
-                        }
-                        let conditionPart = '';
-                        if (serviceNowOperator === 'ISEMPTY' || serviceNowOperator === 'ISNOTEMPTY') {
-                            // For empty/not empty checks, no value needed
-                            conditionPart = `${variableWithIOPrefix}${serviceNowOperator}`;
-                        }
-                        else if (serviceNowOperator === 'LIKE' || serviceNowOperator === 'NOT LIKE') {
-                            // For LIKE operations, ensure value is wrapped properly
-                            conditionPart = `${variableWithIOPrefix}${serviceNowOperator}${conditionValue}`;
-                        }
-                        else {
-                            // Standard operations (=, !=, >, <, etc.)
-                            conditionPart = `${variableWithIOPrefix}${serviceNowOperator}${conditionValue}`;
+                    catch (error) {
+                        this.logger.warn(`⚠️ Strategy failed: ${strategy.description}`, error);
+                    }
+                }
+                // If all strategies fail, try alternate table names (just in case)
+                const alternateTables = ['item_option_new', 'io_set_item_option'];
+                for (const table of alternateTables) {
+                    this.logger.info(`🔍 Trying alternate table: ${table}`);
+                    try {
+                        const varResponse = await this.client.searchRecords(table, `cat_item=${catalogItem}^name=${variableName}`, 1);
+                        if (varResponse.success && varResponse.data.result.length > 0) {
+                            const sysId = varResponse.data.result[0].sys_id;
+                            this.logger.info(`✅ Found in alternate table ${table}: ${sysId}`);
+                            return sysId;
                         }
-                        this.logger.info(`🏗️ Built condition part: ${conditionPart} (from ${originalOperator}: '${conditionValue}')`);
-                        conditionParts.push(conditionPart);
                     }
-                    // Join all conditions with ^ separator (ServiceNow query format)
-                    conditionString = conditionParts.join('^');
-                    this.logger.info(`✅ Built conditions string: "${conditionString}"`);
+                    catch (error) {
+                        this.logger.warn(`⚠️ Alternate table ${table} failed:`, error);
+                    }
                 }
-                // ✅ CRITICAL FIX: Create in catalog_ui_policy table!
-                // The actions reference catalog_ui_policy, NOT sys_ui_policy!
-                const policyData = {
-                    // catalog_ui_policy fields
-                    short_description: args.short_description,
-                    catalog_item: args.cat_item, // Reference to the catalog item
-                    catalog_conditions: conditionString || args.condition || '', // Conditions as string
-                    applies_catalog: true, // This is a catalog policy
-                    active: args.active !== false,
-                    applies_on: args.applies_on || 'true', // When to apply: 'true', 'false', or 'both'
-                    reverse_if_false: args.reverse_if_false !== false,
-                    // Optional script fields
-                    script_true: args.script_true || '',
-                    script_false: args.script_false || ''
+                this.logger.error(`❌ CRITICAL: Variable '${variableName}' not found in any table for catalog item ${catalogItem}`);
+                this.logger.error(`❌ This will cause the action to fail! Please use the sys_id directly instead of the name.`);
+                // Return the name but log a warning that this will fail
+                return variableName;
+            };
+            // Helper function to map operations to correct ServiceNow format
+            const mapOperatorToServiceNow = (operator) => {
+                const opMap = {
+                    'is': '=',
+                    'equals': '=',
+                    'is_not': '!=',
+                    'is not': '!=',
+                    'not equals': '!=',
+                    'contains': 'LIKE',
+                    'does_not_contain': 'NOT LIKE',
+                    'does not contain': 'NOT LIKE',
+                    'greater_than': '>',
+                    'greater than': '>',
+                    'less_than': '<',
+                    'less than': '<',
+                    'is_empty': 'ISEMPTY',
+                    'is empty': 'ISEMPTY',
+                    'is_not_empty': 'ISNOTEMPTY', // ✅ CRITICAL FIX: was missing!
+                    'is not empty': 'ISNOTEMPTY'
                 };
-                this.logger.info('🎯 Creating main policy in catalog_ui_policy table with data:', policyData);
-                const policyResponse = await this.client.createRecord('catalog_ui_policy', policyData);
-                if (!policyResponse.success) {
-                    this.logger.error('❌ Policy creation failed:', policyResponse.error);
-                    throw new Error(`Failed to create catalog UI policy: ${policyResponse.error}`);
+                const normalizedOp = operator.toLowerCase().trim();
+                const mapped = opMap[normalizedOp] || operator;
+                this.logger.info(`🎯 Mapped operator '${operator}' -> '${mapped}'`);
+                return mapped;
+            };
+            // Build condition string from conditions array
+            let conditionString = '';
+            this.logger.info('Checking conditions parameter:', {
+                hasConditions: !!args.conditions,
+                isArray: Array.isArray(args.conditions),
+                length: args.conditions ? args.conditions.length : 0,
+                conditionsData: args.conditions
+            });
+            if (args.conditions && Array.isArray(args.conditions)) {
+                this.logger.info(`🎯 Building conditions string from ${args.conditions.length} conditions...`);
+                const conditionParts = [];
+                for (const condition of args.conditions) {
+                    // Resolve variable name to sys_id
+                    const variableId = await resolveVariableId(condition.catalog_variable, args.cat_item);
+                    // Get the correct ServiceNow operator
+                    const originalOperator = condition.operation || 'is';
+                    const serviceNowOperator = mapOperatorToServiceNow(originalOperator);
+                    // Safely get condition value (avoid undefined concatenation)
+                    const conditionValue = condition.value || '';
+                    // Build the condition part based on operator type
+                    // ✅ CRITICAL: Conditions must use IO:sys_id format for catalog variables!
+                    // BUT only if we successfully resolved the variable to a sys_id
+                    const isValidSysId = variableId && variableId.match(/^[a-f0-9]{32}$/);
+                    const variableWithIOPrefix = isValidSysId ? `IO:${variableId}` : variableId;
+                    if (!isValidSysId) {
+                        this.logger.warn(`⚠️ Variable '${condition.catalog_variable}' could not be resolved to sys_id - condition may fail!`);
+                    }
+                    let conditionPart = '';
+                    if (serviceNowOperator === 'ISEMPTY' || serviceNowOperator === 'ISNOTEMPTY') {
+                        // For empty/not empty checks, no value needed
+                        conditionPart = `${variableWithIOPrefix}${serviceNowOperator}`;
+                    }
+                    else if (serviceNowOperator === 'LIKE' || serviceNowOperator === 'NOT LIKE') {
+                        // For LIKE operations, ensure value is wrapped properly
+                        conditionPart = `${variableWithIOPrefix}${serviceNowOperator}${conditionValue}`;
+                    }
+                    else {
+                        // Standard operations (=, !=, >, <, etc.)
+                        conditionPart = `${variableWithIOPrefix}${serviceNowOperator}${conditionValue}`;
+                    }
+                    this.logger.info(`🏗️ Built condition part: ${conditionPart} (from ${originalOperator}: '${conditionValue}')`);
+                    conditionParts.push(conditionPart);
                 }
-                const policyId = policyResponse.data.sys_id;
-                this.logger.info(`✅ Created main policy with sys_id: ${policyId}`);
-                const createdActions = [];
-                // Step 2: Create action records (dit werkt wel met aparte tabel)
-                this.logger.info('Checking actions parameter:', {
-                    hasActions: !!args.actions,
-                    isArray: Array.isArray(args.actions),
-                    length: args.actions ? args.actions.length : 0,
-                    actionsData: args.actions
-                });
-                if (args.actions && Array.isArray(args.actions)) {
-                    this.logger.info(`🎯 Starting to create ${args.actions.length} action records...`);
-                    for (let i = 0; i < args.actions.length; i++) {
-                        const action = args.actions[i];
-                        // Resolve variable name to sys_id
-                        this.logger.info(`🔍 Resolving variable: ${action.catalog_variable} for catalog item: ${args.cat_item}`);
-                        const variableId = await resolveVariableId(action.catalog_variable, args.cat_item);
-                        // Check if resolution actually worked (should be a sys_id now)
-                        const isValidSysId = variableId && variableId.match(/^[a-f0-9]{32}$/);
-                        if (!isValidSysId) {
-                            this.logger.error(`❌ CRITICAL: Failed to resolve variable '${action.catalog_variable}' to sys_id!`);
-                            this.logger.error(`❌ Got: ${variableId} (this is not a valid sys_id)`);
-                            // Continue anyway but it will likely fail
-                        }
-                        else {
-                            this.logger.info(`✅ Resolved to variable sys_id: ${variableId}`);
-                        }
-                        // ✅ CRITICAL FIX: Add "IO:" prefix as required by ServiceNow
-                        // BUT ONLY if we have a valid sys_id!
-                        const catalogVariableWithPrefix = isValidSysId ? `IO:${variableId}` : variableId;
-                        this.logger.info(`🎯 Using catalog_variable value: ${catalogVariableWithPrefix}`);
-                        // Actions structure in ServiceNow:
-                        // - catalog_ui_policy_action.catalog_variable -> "IO:" + variable_sys_id (required format)
-                        // - catalog_ui_policy_action.ui_policy -> catalog_ui_policy.sys_id
-                        // ✅ CRITICAL: Build action data according to ServiceNow's exact structure
-                        // catalog_ui_policy_action inherits from sys_ui_policy_action
-                        // We must set fields in the correct way for ServiceNow to accept them
-                        const actionData = {};
-                        // STEP 1: ENHANCED VERIFICATION - Verify policy exists before creating actions
-                        this.logger.info(`🔍 ENHANCED DEBUG: Verifying policy ${policyId} exists before creating action...`);
-                        if (!policyId) {
-                            this.logger.error(`❌ CRITICAL: No policyId available for action ${i + 1}!`);
-                            throw new Error(`Cannot create action without valid policy ID`);
-                        }
-                        // ✅ NEW: Test policy existence before action creation
-                        const policyExists = await this.client.searchRecords('catalog_ui_policy', `sys_id=${policyId}`, 1);
-                        if (!policyExists.success || policyExists.data.result.length === 0) {
-                            this.logger.error(`❌ CRITICAL: Policy ${policyId} does not exist in catalog_ui_policy table!`);
-                            throw new Error(`Policy verification failed - cannot create action without valid policy`);
-                        }
-                        const existingPolicy = policyExists.data.result[0];
-                        this.logger.info(`✅ Policy verification successful:`);
-                        this.logger.info(`   - Policy sys_id: ${existingPolicy.sys_id}`);
-                        this.logger.info(`   - Policy name: ${existingPolicy.short_description || 'N/A'}`);
-                        this.logger.info(`   - Policy active: ${existingPolicy.active}`);
-                        // STEP 2: Set reference fields with enhanced validation
-                        // ✅ ui_policy is a reference to catalog_ui_policy - test multiple formats
-                        this.logger.info(`📝 Setting ui_policy reference to: ${policyId}`);
-                        // Try setting the reference in the most explicit way possible
-                        actionData.ui_policy = policyId;
-                        // ✅ catalog_item is a reference to sc_cat_item - use sys_id directly  
-                        if (!args.cat_item) {
-                            this.logger.error(`❌ CRITICAL: No catalog item ID provided!`);
-                            throw new Error(`Cannot create action without catalog item ID`);
+                // Join all conditions with ^ separator (ServiceNow query format)
+                conditionString = conditionParts.join('^');
+                this.logger.info(`✅ Built conditions string: "${conditionString}"`);
+            }
+            // ✅ CRITICAL FIX: Create in catalog_ui_policy table!
+            // The actions reference catalog_ui_policy, NOT sys_ui_policy!
+            const policyData = {
+                // catalog_ui_policy fields
+                short_description: args.short_description,
+                catalog_item: args.cat_item, // Reference to the catalog item
+                catalog_conditions: conditionString || args.condition || '', // Conditions as string
+                applies_catalog: true, // This is a catalog policy
+                active: args.active !== false,
+                applies_on: args.applies_on || 'true', // When to apply: 'true', 'false', or 'both'
+                reverse_if_false: args.reverse_if_false !== false,
+                // Optional script fields
+                script_true: args.script_true || '',
+                script_false: args.script_false || ''
+            };
+            this.logger.info('🎯 Creating main policy in catalog_ui_policy table with data:', policyData);
+            const policyResponse = await this.client.createRecord('catalog_ui_policy', policyData);
+            if (!policyResponse.success) {
+                this.logger.error('❌ Policy creation failed:', policyResponse.error);
+                throw new Error(`Failed to create catalog UI policy: ${policyResponse.error}`);
+            }
+            const policyId = policyResponse.data.sys_id;
+            this.logger.info(`✅ Created main policy with sys_id: ${policyId}`);
+            const createdActions = [];
+            // Step 2: Create action records (dit werkt wel met aparte tabel)
+            this.logger.info('Checking actions parameter:', {
+                hasActions: !!args.actions,
+                isArray: Array.isArray(args.actions),
+                length: args.actions ? args.actions.length : 0,
+                actionsData: args.actions
+            });
+            if (args.actions && Array.isArray(args.actions)) {
+                this.logger.info(`🎯 Starting to create ${args.actions.length} action records...`);
+                for (let i = 0; i < args.actions.length; i++) {
+                    const action = args.actions[i];
+                    // Resolve variable name to sys_id
+                    this.logger.info(`🔍 Resolving variable: ${action.catalog_variable} for catalog item: ${args.cat_item}`);
+                    const variableId = await resolveVariableId(action.catalog_variable, args.cat_item);
+                    // Check if resolution actually worked (should be a sys_id now)
+                    const isValidSysId = variableId && variableId.match(/^[a-f0-9]{32}$/);
+                    if (!isValidSysId) {
+                        this.logger.error(`❌ CRITICAL: Failed to resolve variable '${action.catalog_variable}' to sys_id!`);
+                        this.logger.error(`❌ Got: ${variableId} (this is not a valid sys_id)`);
+                        // Continue anyway but it will likely fail
+                    }
+                    else {
+                        this.logger.info(`✅ Resolved to variable sys_id: ${variableId}`);
+                    }
+                    // ✅ CRITICAL FIX: Add "IO:" prefix as required by ServiceNow
+                    // BUT ONLY if we have a valid sys_id!
+                    const catalogVariableWithPrefix = isValidSysId ? `IO:${variableId}` : variableId;
+                    this.logger.info(`🎯 Using catalog_variable value: ${catalogVariableWithPrefix}`);
+                    // Actions structure in ServiceNow:
+                    // - catalog_ui_policy_action.catalog_variable -> "IO:" + variable_sys_id (required format)
+                    // - catalog_ui_policy_action.ui_policy -> catalog_ui_policy.sys_id
+                    // ✅ CRITICAL: Build action data according to ServiceNow's exact structure
+                    // catalog_ui_policy_action inherits from sys_ui_policy_action
+                    // We must set fields in the correct way for ServiceNow to accept them
+                    const actionData = {};
+                    // STEP 1: ENHANCED VERIFICATION - Verify policy exists before creating actions
+                    this.logger.info(`🔍 ENHANCED DEBUG: Verifying policy ${policyId} exists before creating action...`);
+                    if (!policyId) {
+                        this.logger.error(`❌ CRITICAL: No policyId available for action ${i + 1}!`);
+                        throw new Error(`Cannot create action without valid policy ID`);
+                    }
+                    // ✅ NEW: Test policy existence before action creation
+                    const policyExists = await this.client.searchRecords('catalog_ui_policy', `sys_id=${policyId}`, 1);
+                    if (!policyExists.success || policyExists.data.result.length === 0) {
+                        this.logger.error(`❌ CRITICAL: Policy ${policyId} does not exist in catalog_ui_policy table!`);
+                        throw new Error(`Policy verification failed - cannot create action without valid policy`);
+                    }
+                    const existingPolicy = policyExists.data.result[0];
+                    this.logger.info(`✅ Policy verification successful:`);
+                    this.logger.info(`   - Policy sys_id: ${existingPolicy.sys_id}`);
+                    this.logger.info(`   - Policy name: ${existingPolicy.short_description || 'N/A'}`);
+                    this.logger.info(`   - Policy active: ${existingPolicy.active}`);
+                    // STEP 2: Set reference fields with enhanced validation
+                    // ✅ ui_policy is a reference to catalog_ui_policy - test multiple formats
+                    this.logger.info(`📝 Setting ui_policy reference to: ${policyId}`);
+                    // Try setting the reference in the most explicit way possible
+                    actionData.ui_policy = policyId;
+                    // ✅ catalog_item is a reference to sc_cat_item - use sys_id directly  
+                    if (!args.cat_item) {
+                        this.logger.error(`❌ CRITICAL: No catalog item ID provided!`);
+                        throw new Error(`Cannot create action without catalog item ID`);
+                    }
+                    this.logger.info(`📝 Setting catalog_item reference to: ${args.cat_item}`);
+                    actionData.catalog_item = args.cat_item;
+                    // STEP 3: Set the catalog_variable with IO: prefix (STRING field, not reference)
+                    this.logger.info(`📝 Setting catalog_variable to: ${catalogVariableWithPrefix}`);
+                    actionData.catalog_variable = catalogVariableWithPrefix;
+                    // STEP 4: Set action properties with correct values
+                    // ✅ CRITICAL: Use "ignore" instead of not setting or using false
+                    // This is how ServiceNow differentiates between "don't change" and "set to false"
+                    if (action.visible !== undefined) {
+                        actionData.visible = action.visible === true ? 'true' :
+                            action.visible === false ? 'false' : 'ignore';
+                    }
+                    else {
+                        actionData.visible = 'ignore'; // Default to ignore if not specified
+                    }
+                    if (action.mandatory !== undefined) {
+                        actionData.mandatory = action.mandatory === true ? 'true' :
+                            action.mandatory === false ? 'false' : 'ignore';
+                    }
+                    else {
+                        actionData.mandatory = 'ignore'; // Default to ignore if not specified
+                    }
+                    if (action.readonly !== undefined) {
+                        actionData.disabled = action.readonly === true ? 'true' :
+                            action.readonly === false ? 'false' : 'ignore';
+                    }
+                    else {
+                        actionData.disabled = 'ignore'; // Default to ignore if not specified
+                    }
+                    // STEP 5: Set optional value field
+                    if (action.value !== undefined && action.value !== null && action.value !== '') {
+                        actionData.value = String(action.value);
+                    }
+                    // STEP 6: Set other metadata
+                    actionData.order = (i + 1) * 100;
+                    actionData.active = true;
+                    this.logger.info(`🔗 Creating action with VALIDATED structure:`);
+                    this.logger.info(`  - ui_policy (ref): ${policyId} [VERIFIED EXISTS]`);
+                    this.logger.info(`  - catalog_item (ref): ${args.cat_item}`);
+                    this.logger.info(`  - catalog_variable: ${catalogVariableWithPrefix}`);
+                    this.logger.info(`  - visible: ${actionData.visible}`);
+                    this.logger.info(`  - mandatory: ${actionData.mandatory}`);
+                    this.logger.info(`  - disabled: ${actionData.disabled}`);
+                    // ✅ ENHANCED DEBUG: Log complete action data being sent
+                    this.logger.info(`📋 Complete action data being sent to ServiceNow:`, JSON.stringify(actionData, null, 2));
+                    this.logger.info(`🎯 Attempting to create action ${i + 1} in catalog_ui_policy_action table...`);
+                    const actionResponse = await this.client.createRecord('catalog_ui_policy_action', actionData);
+                    if (actionResponse.success) {
+                        const createdActionId = actionResponse.data.sys_id;
+                        this.logger.info(`✅ Created action with sys_id: ${createdActionId}`);
+                        // 🔍 VERIFICATION: Check if action was actually created AND fields are populated
+                        this.logger.info(`🔍 Verifying action ${i + 1} creation and field population...`);
+                        const actionVerification = await this.client.searchRecords('catalog_ui_policy_action', `sys_id=${createdActionId}`, 1);
+                        if (!actionVerification.success || actionVerification.data.result.length === 0) {
+                            this.logger.error('❌ ACTION VERIFICATION FAILED: Action not found after creation!');
+                            throw new Error(`Action creation verification failed - action ${i + 1} not found in database`);
                         }
-                        this.logger.info(`📝 Setting catalog_item reference to: ${args.cat_item}`);
-                        actionData.catalog_item = args.cat_item;
-                        // STEP 3: Set the catalog_variable with IO: prefix (STRING field, not reference)
-                        this.logger.info(`📝 Setting catalog_variable to: ${catalogVariableWithPrefix}`);
-                        actionData.catalog_variable = catalogVariableWithPrefix;
-                        // STEP 4: Set action properties with correct values
-                        // ✅ CRITICAL: Use "ignore" instead of not setting or using false
-                        // This is how ServiceNow differentiates between "don't change" and "set to false"
-                        if (action.visible !== undefined) {
-                            actionData.visible = action.visible === true ? 'true' :
-                                action.visible === false ? 'false' : 'ignore';
+                        // ✅ NEW: Verify that critical fields are actually populated
+                        const createdAction = actionVerification.data.result[0];
+                        this.logger.info(`📋 Created action data:`, {
+                            sys_id: createdAction.sys_id,
+                            ui_policy: createdAction.ui_policy || '❌ EMPTY',
+                            catalog_variable: createdAction.catalog_variable || '❌ EMPTY',
+                            catalog_item: createdAction.catalog_item || '❌ EMPTY',
+                            visible: createdAction.visible,
+                            mandatory: createdAction.mandatory,
+                            disabled: createdAction.disabled
+                        });
+                        // ✅ ENHANCED VERIFICATION: Check if critical fields are populated correctly
+                        const uiPolicyValue = createdAction.ui_policy;
+                        const catalogVariableValue = createdAction.catalog_variable;
+                        const catalogItemValue = createdAction.catalog_item;
+                        // Log the raw response to understand what ServiceNow returns
+                        this.logger.info(`📋 Raw action verification response:`, JSON.stringify(createdAction, null, 2));
+                        // Check ui_policy reference - ServiceNow might return it as an object
+                        let actualUiPolicyId = uiPolicyValue;
+                        if (typeof uiPolicyValue === 'object' && uiPolicyValue !== null) {
+                            actualUiPolicyId = uiPolicyValue.value || uiPolicyValue.sys_id || '';
+                            this.logger.info(`📝 ui_policy returned as object: ${JSON.stringify(uiPolicyValue)}`);
                         }
-                        else {
-                            actionData.visible = 'ignore'; // Default to ignore if not specified
+                        if (!actualUiPolicyId || actualUiPolicyId === '' || actualUiPolicyId === '{}') {
+                            this.logger.error(`❌ CRITICAL: ui_policy field is EMPTY for action ${i + 1}!`);
+                            this.logger.error(`❌ Expected policy ID: ${policyId}`);
+                            this.logger.error(`❌ Raw ui_policy value: ${JSON.stringify(uiPolicyValue)}`);
+                            this.logger.error(`❌ Parsed ui_policy value: ${actualUiPolicyId}`);
+                            this.logger.error(`❌ Action data sent:`, JSON.stringify(actionData, null, 2));
+                            this.logger.error(`❌ Full action verification response:`, JSON.stringify(createdAction, null, 2));
+                            // ✅ ENHANCED ERROR: Try to understand ServiceNow's response pattern
+                            this.logger.error(`ℹ️ DIAGNOSTIC INFO:`);
+                            this.logger.error(`   - Policy verified to exist: YES (${policyId})`);
+                            this.logger.error(`   - Action created successfully: YES (${createdActionId})`);
+                            this.logger.error(`   - ui_policy field type: ${typeof uiPolicyValue}`);
+                            this.logger.error(`   - ui_policy field value length: ${String(uiPolicyValue || '').length}`);
+                            this.logger.error(`   - All action fields:`, Object.keys(createdAction));
+                            // Check if it's a ServiceNow API timing issue
+                            this.logger.warn(`🔄 ATTEMPTING SECONDARY VERIFICATION (possible timing issue)...`);
+                            // Wait a moment and try again
+                            await new Promise(resolve => setTimeout(resolve, 1000));
+                            const secondVerification = await this.client.searchRecords('catalog_ui_policy_action', `sys_id=${createdActionId}`, 1);
+                            if (secondVerification.success && secondVerification.data.result.length > 0) {
+                                const reCheckedAction = secondVerification.data.result[0];
+                                const reCheckedUiPolicy = reCheckedAction.ui_policy;
+                                this.logger.error(`🔄 Secondary verification ui_policy: ${JSON.stringify(reCheckedUiPolicy)}`);
+                                if (reCheckedUiPolicy && reCheckedUiPolicy !== '' && reCheckedUiPolicy !== '{}') {
+                                    this.logger.warn(`⚠️ This was a timing issue - ui_policy populated after delay`);
+                                    // Continue with the re-checked value
+                                    return; // Skip the error throwing
+                                }
+                            }
+                            throw new Error(`Action ${i + 1} created but ui_policy field is empty - action will not work! This may be a ServiceNow API or table structure issue.`);
                         }
-                        if (action.mandatory !== undefined) {
-                            actionData.mandatory = action.mandatory === true ? 'true' :
-                                action.mandatory === false ? 'false' : 'ignore';
+                        // For reference fields, ServiceNow might return an object - extract the value
+                        const uiPolicySysId = typeof uiPolicyValue === 'object' && uiPolicyValue.value ?
+                            uiPolicyValue.value : uiPolicyValue;
+                        this.logger.info(`✅ ui_policy field populated successfully: ${actualUiPolicyId}`);
+                        if (uiPolicySysId !== policyId) {
+                            this.logger.warn(`⚠️ ui_policy mismatch - Expected: ${policyId}, Got: ${uiPolicySysId}`);
                         }
                         else {
-                            actionData.mandatory = 'ignore'; // Default to ignore if not specified
+                            this.logger.info(`✅ ui_policy reference matches expected value`);
                         }
-                        if (action.readonly !== undefined) {
-                            actionData.disabled = action.readonly === true ? 'true' :
-                                action.readonly === false ? 'false' : 'ignore';
+                        // Check catalog_variable (should have IO: prefix)
+                        if (!catalogVariableValue || catalogVariableValue === '') {
+                            this.logger.error(`❌ CRITICAL: catalog_variable field is EMPTY for action ${i + 1}!`);
+                            this.logger.error(`❌ Expected: ${catalogVariableWithPrefix}, Got: ${catalogVariableValue}`);
+                            throw new Error(`Action ${i + 1} created but catalog_variable field is empty - action will not work!`);
                         }
-                        else {
-                            actionData.disabled = 'ignore'; // Default to ignore if not specified
-                        }
-                        // STEP 5: Set optional value field
-                        if (action.value !== undefined && action.value !== null && action.value !== '') {
-                            actionData.value = String(action.value);
+                        if (!catalogVariableValue.startsWith('IO:')) {
+                            this.logger.warn(`⚠️ catalog_variable missing IO: prefix - Got: ${catalogVariableValue}`);
                         }
-                        // STEP 6: Set other metadata
-                        actionData.order = (i + 1) * 100;
-                        actionData.active = true;
-                        this.logger.info(`🔗 Creating action with VALIDATED structure:`);
-                        this.logger.info(`  - ui_policy (ref): ${policyId} [VERIFIED EXISTS]`);
-                        this.logger.info(`  - catalog_item (ref): ${args.cat_item}`);
-                        this.logger.info(`  - catalog_variable: ${catalogVariableWithPrefix}`);
-                        this.logger.info(`  - visible: ${actionData.visible}`);
-                        this.logger.info(`  - mandatory: ${actionData.mandatory}`);
-                        this.logger.info(`  - disabled: ${actionData.disabled}`);
-                        // ✅ ENHANCED DEBUG: Log complete action data being sent
-                        this.logger.info(`📋 Complete action data being sent to ServiceNow:`, JSON.stringify(actionData, null, 2));
-                        this.logger.info(`🎯 Attempting to create action ${i + 1} in catalog_ui_policy_action table...`);
-                        const actionResponse = await this.client.createRecord('catalog_ui_policy_action', actionData);
-                        if (actionResponse.success) {
-                            const createdActionId = actionResponse.data.sys_id;
-                            this.logger.info(`✅ Created action with sys_id: ${createdActionId}`);
-                            // 🔍 VERIFICATION: Check if action was actually created AND fields are populated
-                            this.logger.info(`🔍 Verifying action ${i + 1} creation and field population...`);
-                            const actionVerification = await this.client.searchRecords('catalog_ui_policy_action', `sys_id=${createdActionId}`, 1);
-                            if (!actionVerification.success || actionVerification.data.result.length === 0) {
-                                this.logger.error('❌ ACTION VERIFICATION FAILED: Action not found after creation!');
-                                throw new Error(`Action creation verification failed - action ${i + 1} not found in database`);
-                            }
-                            // ✅ NEW: Verify that critical fields are actually populated
-                            const createdAction = actionVerification.data.result[0];
-                            this.logger.info(`📋 Created action data:`, {
-                                sys_id: createdAction.sys_id,
-                                ui_policy: createdAction.ui_policy || '❌ EMPTY',
-                                catalog_variable: createdAction.catalog_variable || '❌ EMPTY',
-                                catalog_item: createdAction.catalog_item || '❌ EMPTY',
-                                visible: createdAction.visible,
-                                mandatory: createdAction.mandatory,
-                                disabled: createdAction.disabled
-                            });
-                            // ✅ ENHANCED VERIFICATION: Check if critical fields are populated correctly
-                            const uiPolicyValue = createdAction.ui_policy;
-                            const catalogVariableValue = createdAction.catalog_variable;
-                            const catalogItemValue = createdAction.catalog_item;
-                            // Log the raw response to understand what ServiceNow returns
-                            this.logger.info(`📋 Raw action verification response:`, JSON.stringify(createdAction, null, 2));
-                            // Check ui_policy reference - ServiceNow might return it as an object
-                            let actualUiPolicyId = uiPolicyValue;
-                            if (typeof uiPolicyValue === 'object' && uiPolicyValue !== null) {
-                                actualUiPolicyId = uiPolicyValue.value || uiPolicyValue.sys_id || '';
-                                this.logger.info(`📝 ui_policy returned as object: ${JSON.stringify(uiPolicyValue)}`);
-                            }
-                            if (!actualUiPolicyId || actualUiPolicyId === '' || actualUiPolicyId === '{}') {
-                                this.logger.error(`❌ CRITICAL: ui_policy field is EMPTY for action ${i + 1}!`);
-                                this.logger.error(`❌ Expected policy ID: ${policyId}`);
-                                this.logger.error(`❌ Raw ui_policy value: ${JSON.stringify(uiPolicyValue)}`);
-                                this.logger.error(`❌ Parsed ui_policy value: ${actualUiPolicyId}`);
-                                this.logger.error(`❌ Action data sent:`, JSON.stringify(actionData, null, 2));
-                                this.logger.error(`❌ Full action verification response:`, JSON.stringify(createdAction, null, 2));
-                                // ✅ ENHANCED ERROR: Try to understand ServiceNow's response pattern
-                                this.logger.error(`ℹ️ DIAGNOSTIC INFO:`);
-                                this.logger.error(`   - Policy verified to exist: YES (${policyId})`);
-                                this.logger.error(`   - Action created successfully: YES (${createdActionId})`);
-                                this.logger.error(`   - ui_policy field type: ${typeof uiPolicyValue}`);
-                                this.logger.error(`   - ui_policy field value length: ${String(uiPolicyValue || '').length}`);
-                                this.logger.error(`   - All action fields:`, Object.keys(createdAction));
-                                // Check if it's a ServiceNow API timing issue
-                                this.logger.warn(`🔄 ATTEMPTING SECONDARY VERIFICATION (possible timing issue)...`);
-                                // Wait a moment and try again
-                                await new Promise(resolve => setTimeout(resolve, 1000));
-                                const secondVerification = await this.client.searchRecords('catalog_ui_policy_action', `sys_id=${createdActionId}`, 1);
-                                if (secondVerification.success && secondVerification.data.result.length > 0) {
-                                    const reCheckedAction = secondVerification.data.result[0];
-                                    const reCheckedUiPolicy = reCheckedAction.ui_policy;
-                                    this.logger.error(`🔄 Secondary verification ui_policy: ${JSON.stringify(reCheckedUiPolicy)}`);
-                                    if (reCheckedUiPolicy && reCheckedUiPolicy !== '' && reCheckedUiPolicy !== '{}') {
-                                        this.logger.warn(`⚠️ This was a timing issue - ui_policy populated after delay`);
-                                        // Continue with the re-checked value
-                                        return; // Skip the error throwing
-                                    }
-                                }
-                                throw new Error(`Action ${i + 1} created but ui_policy field is empty - action will not work! This may be a ServiceNow API or table structure issue.`);
-                            }
-                            // For reference fields, ServiceNow might return an object - extract the value
-                            const uiPolicySysId = typeof uiPolicyValue === 'object' && uiPolicyValue.value ?
-                                uiPolicyValue.value : uiPolicyValue;
-                            this.logger.info(`✅ ui_policy field populated successfully: ${actualUiPolicyId}`);
-                            if (uiPolicySysId !== policyId) {
-                                this.logger.warn(`⚠️ ui_policy mismatch - Expected: ${policyId}, Got: ${uiPolicySysId}`);
-                            }
-                            else {
-                                this.logger.info(`✅ ui_policy reference matches expected value`);
-                            }
-                            // Check catalog_variable (should have IO: prefix)
-                            if (!catalogVariableValue || catalogVariableValue === '') {
-                                this.logger.error(`❌ CRITICAL: catalog_variable field is EMPTY for action ${i + 1}!`);
-                                this.logger.error(`❌ Expected: ${catalogVariableWithPrefix}, Got: ${catalogVariableValue}`);
-                                throw new Error(`Action ${i + 1} created but catalog_variable field is empty - action will not work!`);
-                            }
-                            if (!catalogVariableValue.startsWith('IO:')) {
-                                this.logger.warn(`⚠️ catalog_variable missing IO: prefix - Got: ${catalogVariableValue}`);
-                            }
-                            // Check catalog_item reference
-                            if (!catalogItemValue || catalogItemValue === '' || catalogItemValue === '{}') {
-                                this.logger.error(`❌ CRITICAL: catalog_item field is EMPTY for action ${i + 1}!`);
-                                this.logger.error(`❌ Expected: ${args.cat_item}, Got: ${catalogItemValue}`);
-                                throw new Error(`Action ${i + 1} created but catalog_item field is empty - action will not work!`);
-                            }
-                            const catalogItemSysId = typeof catalogItemValue === 'object' && catalogItemValue.value ?
-                                catalogItemValue.value : catalogItemValue;
-                            if (catalogItemSysId !== args.cat_item) {
-                                this.logger.warn(`⚠️ catalog_item mismatch - Expected: ${args.cat_item}, Got: ${catalogItemSysId}`);
-                            }
-                            this.logger.info(`✅ Action ${i + 1} verified in database with all fields populated`);
-                            createdActions.push({
-                                sys_id: createdActionId,
-                                variable: action.catalog_variable,
-                                details: this.formatActionDetails(action)
-                            });
+                        // Check catalog_item reference
+                        if (!catalogItemValue || catalogItemValue === '' || catalogItemValue === '{}') {
+                            this.logger.error(`❌ CRITICAL: catalog_item field is EMPTY for action ${i + 1}!`);
+                            this.logger.error(`❌ Expected: ${args.cat_item}, Got: ${catalogItemValue}`);
+                            throw new Error(`Action ${i + 1} created but catalog_item field is empty - action will not work!`);
                         }
-                        else {
-                            const errorMsg = `❌ Failed to create action ${i + 1}: ${actionResponse.error || 'Unknown error'}`;
-                            this.logger.error(errorMsg);
-                            this.logger.error('❌ Action data was:', actionData);
-                            this.logger.error('❌ Response details:', {
-                                status: actionResponse.status,
-                                headers: actionResponse.headers,
-                                data: actionResponse.data
-                            });
-                            // BELANGRIJK: Gooi een error zodat de gebruiker weet dat het faalt!
-                            throw new Error(errorMsg);
+                        const catalogItemSysId = typeof catalogItemValue === 'object' && catalogItemValue.value ?
+                            catalogItemValue.value : catalogItemValue;
+                        if (catalogItemSysId !== args.cat_item) {
+                            this.logger.warn(`⚠️ catalog_item mismatch - Expected: ${args.cat_item}, Got: ${catalogItemSysId}`);
                         }
+                        this.logger.info(`✅ Action ${i + 1} verified in database with all fields populated`);
+                        createdActions.push({
+                            sys_id: createdActionId,
+                            variable: action.catalog_variable,
+                            details: this.formatActionDetails(action)
+                        });
+                    }
+                    else {
+                        const errorMsg = `❌ Failed to create action ${i + 1}: ${actionResponse.error || 'Unknown error'}`;
+                        this.logger.error(errorMsg);
+                        this.logger.error('❌ Action data was:', actionData);
+                        this.logger.error('❌ Response details:', {
+                            success: actionResponse.success,
+                            error: actionResponse.error,
+                            data: actionResponse.data
+                        });
+                        // BELANGRIJK: Gooi een error zodat de gebruiker weet dat het faalt!
+                        throw new Error(errorMsg);
                     }
                 }
-                // 🔍 FINAL VERIFICATION: Policy creation in catalog_ui_policy table
-                this.logger.info('🔍 Final verification: Checking policy in catalog_ui_policy table...');
-                const policyVerification = await this.client.searchRecords('catalog_ui_policy', `sys_id=${policyId}`, 1);
-                if (!policyVerification.success || policyVerification.data.result.length === 0) {
-                    this.logger.error('❌ POLICY VERIFICATION FAILED: Policy not found in catalog_ui_policy table!');
-                    throw new Error(`Policy creation verification failed - policy not found in catalog_ui_policy table`);
-                }
-                this.logger.info('✅ Policy verified in catalog_ui_policy table');
-                // Build comprehensive response
-                let responseText = `✅ Catalog UI Policy created successfully!
+            }
+            // 🔍 FINAL VERIFICATION: Policy creation in catalog_ui_policy table
+            this.logger.info('🔍 Final verification: Checking policy in catalog_ui_policy table...');
+            const policyVerification = await this.client.searchRecords('catalog_ui_policy', `sys_id=${policyId}`, 1);
+            if (!policyVerification.success || policyVerification.data.result.length === 0) {
+                this.logger.error('❌ POLICY VERIFICATION FAILED: Policy not found in catalog_ui_policy table!');
+                throw new Error(`Policy creation verification failed - policy not found in catalog_ui_policy table`);
+            }
+            this.logger.info('✅ Policy verified in catalog_ui_policy table');
+            // Build comprehensive response
+            let responseText = `✅ Catalog UI Policy created successfully!
 
 📋 **${args.short_description}**
 🆔 Policy sys_id: ${policyId}
@@ -1284,81 +1283,71 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
 🔍 **Verification Results:**
 ✅ Policy record created in catalog_ui_policy table
 ✅ ${createdActions.length} actions created in catalog_ui_policy_action table`;
-                if (conditionString) {
-                    responseText += `\n\n📝 **Conditions:**\n${conditionString}`;
-                }
-                if (createdActions.length > 0) {
-                    responseText += `\n\n⚡ **Actions Created (${createdActions.length}):**\n`;
-                    createdActions.forEach((action, i) => {
-                        responseText += `   ${i + 1}. ${action.details} on ${action.variable}\n`;
-                    });
-                }
-                responseText += `\n\n✨ UI policy configured successfully with ${createdActions.length} actions!`;
-                return {
-                    content: [{
-                            type: 'text',
-                            text: responseText
-                        }]
-                };
+            if (conditionString) {
+                responseText += `\n\n📝 **Conditions:**\n${conditionString}`;
             }
-            catch (error) {
-                this.logger.error('Failed to create catalog UI policy:', error);
-                throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to create catalog UI policy: ${error}`);
+            if (createdActions.length > 0) {
+                responseText += `\n\n⚡ **Actions Created (${createdActions.length}):**\n`;
+                createdActions.forEach((action, i) => {
+                    responseText += `   ${i + 1}. ${action.details} on ${action.variable}\n`;
+                });
             }
+            responseText += `\n\n✨ UI policy configured successfully with ${createdActions.length} actions!`;
+            return {
+                content: [{
+                        type: 'text',
+                        text: responseText
+                    }]
+            };
         }
-        /**
-         * Helper function to format action details for display
-         */
-        finally {
+        catch (error) {
+            this.logger.error('Failed to create catalog UI policy:', error);
+            throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to create catalog UI policy: ${error}`);
         }
-        /**
-         * Helper function to format action details for display
-         */
-    }
-    catch(error) { n; this.logger.error('Failed to create catalog UI policy:', error); n; return { content: [{ type: 'text', text: `❌ Failed to create catalog UI policy: ${error.message || error}` }] }; n; }
-}
-n;
-n;
-formatActionDetails(action, any);
-string;
-{
-    const details = [];
-    if (action.mandatory !== undefined) {
-        details.push(`Mandatory: ${action.mandatory}`);
-    }
-    if (action.visible !== undefined) {
-        details.push(`Visible: ${action.visible}`);
     }
-    if (action.readonly !== undefined) {
-        details.push(`Read-only: ${action.readonly}`);
-    }
-    if (action.value !== undefined && action.value !== '') {
-        details.push(`Value: "${action.value}"`);
-    }
-    return details.length > 0 ? details.join(', ') : 'No specific action';
-}
-async;
-createCatalogClientScript(args, any);
-{
-    try {
-        this.logger.info('Creating catalog client script...');
-        const scriptData = {
-            cat_item: args.cat_item,
-            name: args.name,
-            script: args.script,
-            type: args.type,
-            applies_to: args.applies_to || 'item',
-            cat_variable: args.variable || '',
-            active: args.active !== false
-        };
-        const response = await this.client.createRecord('catalog_script_client', scriptData);
-        if (!response.success) {
-            throw new Error(`Failed to create catalog client script: ${response.error}`);
+    /**
+     * Helper function to format action details for display
+     */
+    formatActionDetails(action) {
+        const details = [];
+        if (action.mandatory !== undefined) {
+            details.push(`Mandatory: ${action.mandatory}`);
+        }
+        if (action.visible !== undefined) {
+            details.push(`Visible: ${action.visible}`);
+        }
+        if (action.readonly !== undefined) {
+            details.push(`Read-only: ${action.readonly}`);
         }
-        return {
-            content: [{
-                    type: 'text',
-                    text: `✅ Catalog Client Script created successfully!
+        if (action.value !== undefined && action.value !== '') {
+            details.push(`Value: "${action.value}"`);
+        }
+        return details.length > 0 ? details.join(', ') : 'No specific action';
+    }
+    /**
+     * Create Catalog Client Script
+     * Uses catalog_script_client table
+     */
+    async createCatalogClientScript(args) {
+        try {
+            this.logger.info('Creating catalog client script...');
+            const scriptData = {
+                cat_item: args.cat_item,
+                name: args.name,
+                script: args.script,
+                type: args.type,
+                applies_to: args.applies_to || 'item',
+                cat_variable: args.variable || '',
+                active: args.active !== false
+            };
+            const response = await this.client.createRecord('catalog_script_client', scriptData);
+            if (!response.success) {
+                throw new Error(`Failed to create catalog client script: ${response.error}`);
+            }
+            return {
+                content: [{
+                        type: 'text',
+                        text: `✅ Catalog Client Script created successfully!
 
 📜 **${args.name}**
 🆔 sys_id: ${response.data.sys_id}
@@ -1368,115 +1357,118 @@ ${args.variable ? `📝 Variable: ${args.variable}` : ''}
 🔄 Active: ${args.active !== false ? 'Yes' : 'No'}
 
 ✨ Client script added to catalog item!`
-                }]
-        };
-    }
-    catch (error) {
-        this.logger.error('Failed to create catalog client script:', error);
-        throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to create catalog client script: ${error}`);
-    }
-}
-async;
-searchCatalog(args, any);
-{
-    try {
-        this.logger.info('Searching service catalog...');
-        let query = args.query ? `nameLIKE${args.query}^ORshort_descriptionLIKE${args.query}` : '';
-        if (args.category) {
-            query += query ? '^' : '';
-            query += `category=${args.category}`;
-        }
-        if (args.catalog) {
-            query += query ? '^' : '';
-            query += `sc_catalogs=${args.catalog}`;
-        }
-        if (args.active_only) {
-            query += query ? '^' : '';
-            query += 'active=true';
-        }
-        const limit = args.limit || 20;
-        this.logger.trackAPICall('SEARCH', 'sc_cat_item', limit);
-        const response = await this.client.searchRecords('sc_cat_item', query, limit);
-        if (!response.success) {
-            throw new Error('Failed to search catalog');
-        }
-        const items = response.data.result;
-        if (!items.length) {
-            return {
-                content: [{
-                        type: 'text',
-                        text: `❌ No catalog items found${args.query ? ` matching "${args.query}"` : ''}`
                     }]
             };
         }
-        const itemList = items.map((item) => {
-            return `🛍️ **${item.name}**
+        catch (error) {
+            this.logger.error('Failed to create catalog client script:', error);
+            throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to create catalog client script: ${error}`);
+        }
+    }
+    /**
+     * Search Service Catalog
+     */
+    async searchCatalog(args) {
+        try {
+            this.logger.info('Searching service catalog...');
+            let query = args.query ? `nameLIKE${args.query}^ORshort_descriptionLIKE${args.query}` : '';
+            if (args.category) {
+                query += query ? '^' : '';
+                query += `category=${args.category}`;
+            }
+            if (args.catalog) {
+                query += query ? '^' : '';
+                query += `sc_catalogs=${args.catalog}`;
+            }
+            if (args.active_only) {
+                query += query ? '^' : '';
+                query += 'active=true';
+            }
+            const limit = args.limit || 20;
+            this.logger.trackAPICall('SEARCH', 'sc_cat_item', limit);
+            const response = await this.client.searchRecords('sc_cat_item', query, limit);
+            if (!response.success) {
+                throw new Error('Failed to search catalog');
+            }
+            const items = response.data.result;
+            if (!items.length) {
+                return {
+                    content: [{
+                            type: 'text',
+                            text: `❌ No catalog items found${args.query ? ` matching "${args.query}"` : ''}`
+                        }]
+                };
+            }
+            const itemList = items.map((item) => {
+                return `🛍️ **${item.name}**
 🆔 ${item.sys_id}
 📝 ${item.short_description}
 ${item.price && item.price !== '0' ? `💰 Price: $${item.price}` : ''}
 🔄 Active: ${item.active ? 'Yes' : 'No'}`;
-        }).join('\n\n');
-        return {
-            content: [{
-                    type: 'text',
-                    text: `🔍 Catalog Search Results${args.query ? ` for "${args.query}"` : ''}:
+            }).join('\n\n');
+            return {
+                content: [{
+                        type: 'text',
+                        text: `🔍 Catalog Search Results${args.query ? ` for "${args.query}"` : ''}:
 
 ${itemList}
 
 ✨ Found ${items.length} catalog item(s)`
-                }]
-        };
-    }
-    catch (error) {
-        this.logger.error('Failed to search catalog:', error);
-        throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to search catalog: ${error}`);
-    }
-}
-async;
-orderCatalogItem(args, any);
-{
-    try {
-        this.logger.info('Ordering catalog item...');
-        // Create service catalog request
-        const requestData = {
-            requested_for: args.requested_for,
-            opened_by: args.requested_for,
-            special_instructions: args.special_instructions || ''
-        };
-        const requestResponse = await this.client.createRecord('sc_request', requestData);
-        if (!requestResponse.success) {
-            throw new Error(`Failed to create request: ${requestResponse.error}`);
+                    }]
+            };
         }
-        const requestId = requestResponse.data.sys_id;
-        // Create requested item (RITM)
-        const ritmData = {
-            request: requestId,
-            cat_item: args.cat_item,
-            requested_for: args.requested_for,
-            quantity: args.quantity || 1,
-            delivery_address: args.delivery_address || ''
-        };
-        const ritmResponse = await this.client.createRecord('sc_req_item', ritmData);
-        if (!ritmResponse.success) {
-            throw new Error(`Failed to create requested item: ${ritmResponse.error}`);
+        catch (error) {
+            this.logger.error('Failed to search catalog:', error);
+            throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to search catalog: ${error}`);
         }
-        const ritmId = ritmResponse.data.sys_id;
-        const ritmNumber = ritmResponse.data.number;
-        // Set variable values if provided
-        if (args.variables) {
-            for (const [varName, varValue] of Object.entries(args.variables)) {
-                const varData = {
-                    request_item: ritmId,
-                    name: varName,
-                    value: varValue
-                };
-                await this.client.createRecord('sc_item_option_mtom', varData);
+    }
+    /**
+     * Order Catalog Item
+     * Creates sc_request and sc_req_item records
+     */
+    async orderCatalogItem(args) {
+        try {
+            this.logger.info('Ordering catalog item...');
+            // Create service catalog request
+            const requestData = {
+                requested_for: args.requested_for,
+                opened_by: args.requested_for,
+                special_instructions: args.special_instructions || ''
+            };
+            const requestResponse = await this.client.createRecord('sc_request', requestData);
+            if (!requestResponse.success) {
+                throw new Error(`Failed to create request: ${requestResponse.error}`);
             }
-        }
-        return {
-            content: [{
-                    type: 'text',
-                    text: `✅ Catalog Item ordered successfully!
+            const requestId = requestResponse.data.sys_id;
+            // Create requested item (RITM)
+            const ritmData = {
+                request: requestId,
+                cat_item: args.cat_item,
+                requested_for: args.requested_for,
+                quantity: args.quantity || 1,
+                delivery_address: args.delivery_address || ''
+            };
+            const ritmResponse = await this.client.createRecord('sc_req_item', ritmData);
+            if (!ritmResponse.success) {
+                throw new Error(`Failed to create requested item: ${ritmResponse.error}`);
+            }
+            const ritmId = ritmResponse.data.sys_id;
+            const ritmNumber = ritmResponse.data.number;
+            // Set variable values if provided
+            if (args.variables) {
+                for (const [varName, varValue] of Object.entries(args.variables)) {
+                    const varData = {
+                        request_item: ritmId,
+                        name: varName,
+                        value: varValue
+                    };
+                    await this.client.createRecord('sc_item_option_mtom', varData);
+                }
+            }
+            return {
+                content: [{
+                        type: 'text',
+                        text: `✅ Catalog Item ordered successfully!
 
 🛍️ **Order Placed**
 🆔 Request: ${requestId}
@@ -1487,51 +1479,52 @@ ${args.delivery_address ? `📍 Delivery: ${args.delivery_address}` : ''}
 ${args.special_instructions ? `📝 Instructions: ${args.special_instructions}` : ''}
 
 ✨ Order submitted for fulfillment!`
-                }]
-        };
-    }
-    catch (error) {
-        this.logger.error('Failed to order catalog item:', error);
-        throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to order catalog item: ${error}`);
+                    }]
+            };
+        }
+        catch (error) {
+            this.logger.error('Failed to order catalog item:', error);
+            throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to order catalog item: ${error}`);
+        }
     }
-}
-async;
-getCatalogItemDetails(args, any);
-{
-    try {
-        this.logger.info('Getting catalog item details...', { sys_id: args.sys_id });
-        // 🔍 DEBUGGING: Try different methods to find the item
-        this.logger.info('🔍 Step 1: Trying getRecord method...');
-        let itemResponse = await this.client.getRecord('sc_cat_item', args.sys_id);
-        if (!itemResponse.success) {
-            this.logger.warn('❌ getRecord failed, trying searchRecords as fallback...');
-            this.logger.warn('getRecord error:', itemResponse.error);
-            // Fallback: try searchRecords method
-            itemResponse = await this.client.searchRecords('sc_cat_item', `sys_id=${args.sys_id}`, 1);
-            if (!itemResponse.success || itemResponse.data.result.length === 0) {
-                this.logger.error('❌ Both getRecord and searchRecords failed');
-                this.logger.error('searchRecords error:', itemResponse.error);
-                // Final fallback: try to query with different parameters
-                const queryResponse = await this.client.queryTable('sc_cat_item', `sys_id=${args.sys_id}`, 1);
-                if (queryResponse.success && queryResponse.data.result.length > 0) {
-                    this.logger.info('✅ Found item using queryTable fallback');
-                    itemResponse = { success: true, data: queryResponse.data.result[0] };
+    /**
+     * Get Catalog Item Details
+     */
+    async getCatalogItemDetails(args) {
+        try {
+            this.logger.info('Getting catalog item details...', { sys_id: args.sys_id });
+            // 🔍 DEBUGGING: Try different methods to find the item
+            this.logger.info('🔍 Step 1: Trying getRecord method...');
+            let itemResponse = await this.client.getRecord('sc_cat_item', args.sys_id);
+            if (!itemResponse.success) {
+                this.logger.warn('❌ getRecord failed, trying searchRecords as fallback...');
+                this.logger.warn('getRecord error:', itemResponse.error);
+                // Fallback: try searchRecords method
+                itemResponse = await this.client.searchRecords('sc_cat_item', `sys_id=${args.sys_id}`, 1);
+                if (!itemResponse.success || itemResponse.data.result.length === 0) {
+                    this.logger.error('❌ Both getRecord and searchRecords failed');
+                    this.logger.error('searchRecords error:', itemResponse.error);
+                    // Final fallback: try to query with different parameters
+                    const queryResponse = await this.client.searchRecords('sc_cat_item', `sys_id=${args.sys_id}`, 1);
+                    if (queryResponse.success && queryResponse.data.result.length > 0) {
+                        this.logger.info('✅ Found item using queryTable fallback');
+                        itemResponse = { success: true, data: queryResponse.data.result[0] };
+                    }
+                    else {
+                        this.logger.error('❌ All methods failed to find catalog item');
+                        throw new Error(`Catalog item not found with sys_id: ${args.sys_id}. Tried getRecord, searchRecords, and queryTable.`);
+                    }
                 }
                 else {
-                    this.logger.error('❌ All methods failed to find catalog item');
-                    throw new Error(`Catalog item not found with sys_id: ${args.sys_id}. Tried getRecord, searchRecords, and queryTable.`);
+                    this.logger.info('✅ Found item using searchRecords fallback');
+                    itemResponse = { success: true, data: itemResponse.data.result[0] };
                 }
             }
             else {
-                this.logger.info('✅ Found item using searchRecords fallback');
-                itemResponse = { success: true, data: itemResponse.data.result[0] };
+                this.logger.info('✅ Found item using getRecord');
             }
-        }
-        else {
-            this.logger.info('✅ Found item using getRecord');
-        }
-        const item = itemResponse.data;
-        let details = `🛍️ **${item.name}**
+            const item = itemResponse.data;
+            let details = `🛍️ **${item.name}**
 🆔 sys_id: ${item.sys_id}
 📝 ${item.short_description}
 📄 ${item.description || 'No detailed description'}
@@ -1539,82 +1532,82 @@ ${item.price && item.price !== '0' ? `💰 Price: $${item.price}` : ''}
 ${item.recurring_price && item.recurring_price !== '0' ? `🔄 Recurring: $${item.recurring_price}` : ''}
 📦 Delivery: ${item.delivery_time || '3 business days'}
 🔄 Active: ${item.active ? 'Yes' : 'No'}`;
-        // Get variables if requested
-        if (args.include_variables) {
-            const varResponse = await this.client.searchRecords('sc_cat_item_option', `cat_item=${args.sys_id}`, 50);
-            if (varResponse.success && varResponse.data.result.length) {
-                const variables = varResponse.data.result.map((v) => `  - ${v.question_text} (${v.type})${v.mandatory ? ' *Required' : ''}`).join('\n');
-                details += `\n\n📋 **Variables:**\n${variables}`;
+            // Get variables if requested
+            if (args.include_variables) {
+                const varResponse = await this.client.searchRecords('sc_cat_item_option', `cat_item=${args.sys_id}`, 50);
+                if (varResponse.success && varResponse.data.result.length) {
+                    const variables = varResponse.data.result.map((v) => `  - ${v.question_text} (${v.type})${v.mandatory ? ' *Required' : ''}`).join('\n');
+                    details += `\n\n📋 **Variables:**\n${variables}`;
+                }
             }
+            return {
+                content: [{
+                        type: 'text',
+                        text: details + '\n\n✨ Catalog item details retrieved!'
+                    }]
+            };
         }
-        return {
-            content: [{
-                    type: 'text',
-                    text: details + '\n\n✨ Catalog item details retrieved!'
-                }]
-        };
-    }
-    catch (error) {
-        this.logger.error('Failed to get catalog item details:', error);
-        throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to get catalog item details: ${error}`);
-    }
-}
-async;
-discoverCatalogs(args, any);
-{
-    try {
-        this.logger.info('Discovering service catalogs...');
-        let query = '';
-        if (args.active_only) {
-            query = 'active=true';
-        }
-        const catalogResponse = await this.client.searchRecords('sc_catalog', query, 50);
-        if (!catalogResponse.success) {
-            throw new Error('Failed to discover catalogs');
+        catch (error) {
+            this.logger.error('Failed to get catalog item details:', error);
+            throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to get catalog item details: ${error}`);
         }
-        const catalogs = catalogResponse.data.result;
-        // Get categories if requested
-        const catalogsWithDetails = await Promise.all(catalogs.map(async (catalog) => {
-            if (args.include_categories) {
-                const catResponse = await this.client.searchRecords('sc_category', `sc_catalog=${catalog.sys_id}`, 20);
-                const categories = catResponse.success ? catResponse.data.result : [];
-                return { ...catalog, categories };
+    }
+    /**
+     * Discover Service Catalogs
+     */
+    async discoverCatalogs(args) {
+        try {
+            this.logger.info('Discovering service catalogs...');
+            let query = '';
+            if (args.active_only) {
+                query = 'active=true';
             }
-            return catalog;
-        }));
-        const catalogText = catalogsWithDetails.map((catalog) => {
-            let text = `🛍️ **${catalog.title}** ${catalog.active ? '✅' : '❌'}
+            const catalogResponse = await this.client.searchRecords('sc_catalog', query, 50);
+            if (!catalogResponse.success) {
+                throw new Error('Failed to discover catalogs');
+            }
+            const catalogs = catalogResponse.data.result;
+            // Get categories if requested
+            const catalogsWithDetails = await Promise.all(catalogs.map(async (catalog) => {
+                if (args.include_categories) {
+                    const catResponse = await this.client.searchRecords('sc_category', `sc_catalog=${catalog.sys_id}`, 20);
+                    const categories = catResponse.success ? catResponse.data.result : [];
+                    return { ...catalog, categories };
+                }
+                return catalog;
+            }));
+            const catalogText = catalogsWithDetails.map((catalog) => {
+                let text = `🛍️ **${catalog.title}** ${catalog.active ? '✅' : '❌'}
 🆔 ${catalog.sys_id}
 📝 ${catalog.description || 'No description'}`;
-            if (catalog.categories) {
-                const categoryList = catalog.categories.map((cat) => `  - ${cat.title}`).join('\n');
-                text += `\n📂 Categories:\n${categoryList || '  No categories'}`;
-            }
-            return text;
-        }).join('\n\n');
-        return {
-            content: [{
-                    type: 'text',
-                    text: `🔍 Discovered Service Catalogs:
+                if (catalog.categories) {
+                    const categoryList = catalog.categories.map((cat) => `  - ${cat.title}`).join('\n');
+                    text += `\n📂 Categories:\n${categoryList || '  No categories'}`;
+                }
+                return text;
+            }).join('\n\n');
+            return {
+                content: [{
+                        type: 'text',
+                        text: `🔍 Discovered Service Catalogs:
 
 ${catalogText}
 
 ✨ Found ${catalogs.length} catalog(s)`
-                }]
-        };
+                    }]
+            };
+        }
+        catch (error) {
+            this.logger.error('Failed to discover catalogs:', error);
+            throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to discover catalogs: ${error}`);
+        }
     }
-    catch (error) {
-        this.logger.error('Failed to discover catalogs:', error);
-        throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to discover catalogs: ${error}`);
+    async run() {
+        const transport = new stdio_js_1.StdioServerTransport();
+        await this.server.connect(transport);
+        this.logger.info('ServiceNow Knowledge & Catalog MCP Server running on stdio');
     }
 }
-async;
-run();
-{
-    const transport = new stdio_js_1.StdioServerTransport();
-    await this.server.connect(transport);
-    this.logger.info('ServiceNow Knowledge & Catalog MCP Server running on stdio');
-}
 const server = new ServiceNowKnowledgeCatalogMCP();
 server.run().catch(console.error);
 //# sourceMappingURL=servicenow-knowledge-catalog-mcp.js.map