snow-flow 3.6.20 → 3.6.21

package/dist/mcp/servicenow-knowledge-catalog-mcp.js

@@ -797,16 +797,16 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
     }
     /**
      * Create Catalog UI Policy with Actions
-     * Creates records in 2 tables: sys_ui_policy and catalog_ui_policy_action
+     * Creates records in 2 tables: catalog_ui_policy and catalog_ui_policy_action
      *
-     * ✅ FINAL CORRECT STRUCTURE (v3.6.20):
-     * - Main policy goes in sys_ui_policy table (NOT catalog_ui_policy!)
+     * ✅ CORRECTED STRUCTURE (v3.6.21):
+     * - Main policy goes in catalog_ui_policy table (NOT sys_ui_policy!)
      * - Actions go in catalog_ui_policy_action table (inherits from sys_ui_policy_action)
-     * - Actions reference sys_ui_policy via ui_policy field (using policy sys_id directly)
+     * - Actions reference catalog_ui_policy via ui_policy field (using policy sys_id directly)
      * - Conditions use IO:sys_id format for catalog variables
      * - catalog_ui_policy_action.catalog_variable uses IO:sys_id format
      * - visible/mandatory/disabled use "ignore" as default, not false or empty
-     * - Reference fields are set directly, not via setValue() for reliability
+     * - Reference fields are set directly for reliability
      * - Enhanced verification ensures all critical fields are populated
      */
     async createCatalogUIPolicy(args) {
@@ -981,24 +981,23 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                 conditionString = conditionParts.join('^');
                 this.logger.info(`✅ Built conditions string: "${conditionString}"`);
             }
-            // ✅ CRITICAL FIX: Create in sys_ui_policy table, NOT catalog_ui_policy!
-            // The actions reference sys_ui_policy, not catalog_ui_policy
+            // ✅ CRITICAL FIX: Create in catalog_ui_policy table!
+            // The actions reference catalog_ui_policy, NOT sys_ui_policy!
             const policyData = {
-                // sys_ui_policy fields are different from catalog_ui_policy!
-                name: args.short_description, // sys_ui_policy uses 'name' not 'short_description'
-                table: 'sc_cat_item', // The table this policy applies to
-                conditions: conditionString || args.condition || '', // Condition string
+                // catalog_ui_policy fields
+                short_description: args.short_description,
+                catalog_item: args.cat_item, // Reference to the catalog item
+                catalog_conditions: conditionString || args.condition || '', // Conditions as string
+                applies_catalog: true, // This is a catalog policy
                 active: args.active !== false,
-                on_load: args.on_load !== false, // Different field name in sys_ui_policy
+                applies_on: args.applies_on || 'true', // When to apply: 'true', 'false', or 'both'
                 reverse_if_false: args.reverse_if_false !== false,
-                // Link to the catalog item via a different field
-                catalog_item: args.cat_item,
                 // Optional script fields
                 script_true: args.script_true || '',
                 script_false: args.script_false || ''
             };
-            this.logger.info('🎯 Creating main policy in sys_ui_policy table with data:', policyData);
-            const policyResponse = await this.client.createRecord('sys_ui_policy', policyData);
+            this.logger.info('🎯 Creating main policy in catalog_ui_policy table with data:', policyData);
+            const policyResponse = await this.client.createRecord('catalog_ui_policy', policyData);
             if (!policyResponse.success) {
                 this.logger.error('❌ Policy creation failed:', policyResponse.error);
                 throw new Error(`Failed to create catalog UI policy: ${policyResponse.error}`);
@@ -1166,27 +1165,27 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     }
                 }
             }
-            // 🔍 FINAL VERIFICATION: Policy creation in sys_ui_policy table
-            this.logger.info('🔍 Final verification: Checking policy in sys_ui_policy table...');
-            const policyVerification = await this.client.searchRecords('sys_ui_policy', `sys_id=${policyId}`, 1);
+            // 🔍 FINAL VERIFICATION: Policy creation in catalog_ui_policy table
+            this.logger.info('🔍 Final verification: Checking policy in catalog_ui_policy table...');
+            const policyVerification = await this.client.searchRecords('catalog_ui_policy', `sys_id=${policyId}`, 1);
             if (!policyVerification.success || policyVerification.data.result.length === 0) {
-                this.logger.error('❌ POLICY VERIFICATION FAILED: Policy not found in sys_ui_policy table!');
-                throw new Error(`Policy creation verification failed - policy not found in sys_ui_policy table`);
+                this.logger.error('❌ POLICY VERIFICATION FAILED: Policy not found in catalog_ui_policy table!');
+                throw new Error(`Policy creation verification failed - policy not found in catalog_ui_policy table`);
             }
-            this.logger.info('✅ Policy verified in sys_ui_policy table');
+            this.logger.info('✅ Policy verified in catalog_ui_policy table');
             // Build comprehensive response
-            let responseText = `✅ UI Policy created successfully in sys_ui_policy table!
+            let responseText = `✅ Catalog UI Policy created successfully!
 
 📋 **${args.short_description}**
 🆔 Policy sys_id: ${policyId}
-📊 Table: sys_ui_policy (correct table for catalog UI policy actions)
-🎯 Target Table: sc_cat_item
+📊 Table: catalog_ui_policy (correct table for catalog actions)
+🎯 Catalog Item: ${args.cat_item}
 🔄 Active: ${args.active !== false ? 'Yes' : 'No'}
-⚡ On Load: ${args.on_load !== false ? 'Yes' : 'No'}
+⚡ Applies On: ${args.applies_on || 'true'}
 🔁 Reverse if False: ${args.reverse_if_false !== false ? 'Yes' : 'No'}
 
 🔍 **Verification Results:**
-✅ Policy record created in sys_ui_policy table
+✅ Policy record created in catalog_ui_policy table
 ✅ ${createdActions.length} actions created in catalog_ui_policy_action table`;
             if (conditionString) {
                 responseText += `\n\n📝 **Conditions:**\n${conditionString}`;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "snow-flow",
-  "version": "3.6.20",
-  "description": "COMPLETE CATALOG UI POLICY FIX - v3.6.20 implements Snow-Flow's complete analysis: proper parent-child table inheritance (sys_ui_policy_action → catalog_ui_policy_action), direct assignment for references, 'ignore' values for visible/mandatory/disabled, enhanced verification, IO: prefix validation. Based on extensive ServiceNow structure analysis.",
+  "version": "3.6.21",
+  "description": "CRITICAL TABLE FIX - v3.6.21 fixes fundamental issue: policies now created in catalog_ui_policy table (NOT sys_ui_policy!). Actions correctly reference catalog_ui_policy records. This matches ServiceNow's actual structure where catalog_ui_policy_action.ui_policy references catalog_ui_policy table, not sys_ui_policy.",
   "main": "dist/index.js",
   "type": "commonjs",
   "bin": {