snow-flow 3.6.18 → 3.6.19

package/dist/mcp/servicenow-knowledge-catalog-mcp.js

@@ -1034,21 +1034,22 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     // Actions structure in ServiceNow:
                     // - catalog_ui_policy_action.catalog_variable -> "IO:" + variable_sys_id (required format)
                     // - catalog_ui_policy_action.ui_policy -> catalog_ui_policy.sys_id
+                    // ✅ CRITICAL FIX: Reference fields MUST be objects or sys_ids, not names!
+                    // ServiceNow reference fields expect either:
+                    // 1. Just the sys_id as a string
+                    // 2. An object with { value: sys_id, link: url }
                     const actionData = {
-                        // ✅ Main connection: to the variable with required IO: prefix (if valid sys_id)
-                        catalog_variable: catalogVariableWithPrefix
+                        // ✅ catalog_variable uses IO:sys_id format (this is a STRING field, not a reference)
+                        catalog_variable: catalogVariableWithPrefix,
+                        // ✅ ui_policy is a REFERENCE field - use the sys_id directly!
+                        ui_policy: policyId, // Use the policy sys_id from sys_ui_policy
+                        // ✅ catalog_item is also a REFERENCE field - use the sys_id
+                        catalog_item: args.cat_item // The catalog item sys_id
                     };
-                    // ✅ CRITICAL FIX: ui_policy field expects the NAME (short_description), NOT the sys_id!
-                    // ServiceNow uses the policy name as the reference value
-                    if (args.short_description) {
-                        actionData.ui_policy = args.short_description; // ✅ Use the policy NAME, not sys_id!
-                        this.logger.info(`🔗 Linking action to policy by NAME: "${args.short_description}"`);
-                    }
-                    else {
-                        // Fallback if somehow we don't have the name
-                        this.logger.error(`❌ CRITICAL: No policy name (short_description) available for linking!`);
-                        actionData.ui_policy = policyId; // Use sys_id as last resort
-                    }
+                    this.logger.info(`🔗 Linking action to:`);
+                    this.logger.info(`  - Policy: ${policyId} (sys_ui_policy sys_id)`);
+                    this.logger.info(`  - Variable: ${catalogVariableWithPrefix} (with IO: prefix)`);
+                    this.logger.info(`  - Catalog Item: ${args.cat_item}`);
                     // Voeg alleen GEDEFINIEERDE action properties toe 
                     if (action.mandatory !== undefined) {
                         actionData.mandatory = action.mandatory === true ? 'true' : action.mandatory === false ? 'false' : 'ignore';
@@ -1070,14 +1071,38 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     if (actionResponse.success) {
                         const createdActionId = actionResponse.data.sys_id;
                         this.logger.info(`✅ Created action with sys_id: ${createdActionId}`);
-                        // 🔍 VERIFICATION: Check if action was actually created
-                        this.logger.info(`🔍 Verifying action ${i + 1} creation...`);
+                        // 🔍 VERIFICATION: Check if action was actually created AND fields are populated
+                        this.logger.info(`🔍 Verifying action ${i + 1} creation and field population...`);
                         const actionVerification = await this.client.searchRecords('catalog_ui_policy_action', `sys_id=${createdActionId}`, 1);
                         if (!actionVerification.success || actionVerification.data.result.length === 0) {
                             this.logger.error('❌ ACTION VERIFICATION FAILED: Action not found after creation!');
                             throw new Error(`Action creation verification failed - action ${i + 1} not found in database`);
                         }
-                        this.logger.info(`✅ Action ${i + 1} verified in database`);
+                        // ✅ NEW: Verify that critical fields are actually populated
+                        const createdAction = actionVerification.data.result[0];
+                        this.logger.info(`📋 Created action data:`, {
+                            sys_id: createdAction.sys_id,
+                            ui_policy: createdAction.ui_policy || '❌ EMPTY',
+                            catalog_variable: createdAction.catalog_variable || '❌ EMPTY',
+                            catalog_item: createdAction.catalog_item || '❌ EMPTY',
+                            visible: createdAction.visible,
+                            mandatory: createdAction.mandatory,
+                            disabled: createdAction.disabled
+                        });
+                        // Check if critical fields are populated
+                        if (!createdAction.ui_policy || createdAction.ui_policy === '') {
+                            this.logger.error(`❌ CRITICAL: ui_policy field is EMPTY for action ${i + 1}!`);
+                            throw new Error(`Action ${i + 1} created but ui_policy field is empty - action will not work!`);
+                        }
+                        if (!createdAction.catalog_variable || createdAction.catalog_variable === '') {
+                            this.logger.error(`❌ CRITICAL: catalog_variable field is EMPTY for action ${i + 1}!`);
+                            throw new Error(`Action ${i + 1} created but catalog_variable field is empty - action will not work!`);
+                        }
+                        if (!createdAction.catalog_item || createdAction.catalog_item === '') {
+                            this.logger.error(`❌ CRITICAL: catalog_item field is EMPTY for action ${i + 1}!`);
+                            throw new Error(`Action ${i + 1} created but catalog_item field is empty - action will not work!`);
+                        }
+                        this.logger.info(`✅ Action ${i + 1} verified in database with all fields populated`);
                         createdActions.push({
                             sys_id: createdActionId,
                             variable: action.catalog_variable,

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "snow-flow",
-  "version": "3.6.18",
-  "description": "FUNDAMENTAL TABLE FIX - v3.6.18 corrects critical table structure: policies now created in sys_ui_policy (NOT catalog_ui_policy), conditions use IO:sys_id format, actions properly link to sys_ui_policy. This matches ServiceNow's actual catalog UI policy structure where catalog_ui_policy_action references sys_ui_policy, not catalog_ui_policy.",
+  "version": "3.6.19",
+  "description": "CRITICAL REFERENCE FIELD FIX - v3.6.19 fixes empty action fields by using sys_ids directly for reference fields (ui_policy, catalog_item) instead of names/objects. Added comprehensive verification to ensure all critical fields are populated. Actions now correctly link to sys_ui_policy with actual sys_id values, not empty strings.",
   "main": "dist/index.js",
   "type": "commonjs",
   "bin": {