snow-flow 3.6.17 → 3.6.19

package/dist/mcp/servicenow-knowledge-catalog-mcp.js

@@ -797,12 +797,14 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
     }
     /**
      * Create Catalog UI Policy with Actions
-     * Creates records in 2 tables: catalog_ui_policy and catalog_ui_policy_action
+     * Creates records in 2 tables: sys_ui_policy and catalog_ui_policy_action
      *
-     * BELANGRIJKE WIJZIGINGEN:
-     * - Conditions worden NIET in een aparte tabel opgeslagen
-     * - Conditions worden als string/script in catalog_conditions veld gezet
-     * - catalog_ui_policy_condition tabel bestaat niet in ServiceNow
+     * ✅ CORRECTED STRUCTURE (v3.6.18):
+     * - Main policy goes in sys_ui_policy table (NOT catalog_ui_policy!)
+     * - Actions go in catalog_ui_policy_action table
+     * - Actions reference sys_ui_policy via ui_policy field (using policy name)
+     * - Conditions use IO:sys_id format for catalog variables
+     * - catalog_ui_policy_action.catalog_variable uses IO:sys_id format
      */
     async createCatalogUIPolicy(args) {
         try {
@@ -949,18 +951,25 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     // Safely get condition value (avoid undefined concatenation)
                     const conditionValue = condition.value || '';
                     // Build the condition part based on operator type
+                    // ✅ CRITICAL: Conditions must use IO:sys_id format for catalog variables!
+                    // BUT only if we successfully resolved the variable to a sys_id
+                    const isValidSysId = variableId && variableId.match(/^[a-f0-9]{32}$/);
+                    const variableWithIOPrefix = isValidSysId ? `IO:${variableId}` : variableId;
+                    if (!isValidSysId) {
+                        this.logger.warn(`⚠️ Variable '${condition.catalog_variable}' could not be resolved to sys_id - condition may fail!`);
+                    }
                     let conditionPart = '';
                     if (serviceNowOperator === 'ISEMPTY' || serviceNowOperator === 'ISNOTEMPTY') {
                         // For empty/not empty checks, no value needed
-                        conditionPart = `${variableId}${serviceNowOperator}`;
+                        conditionPart = `${variableWithIOPrefix}${serviceNowOperator}`;
                     }
                     else if (serviceNowOperator === 'LIKE' || serviceNowOperator === 'NOT LIKE') {
                         // For LIKE operations, ensure value is wrapped properly
-                        conditionPart = `${variableId}${serviceNowOperator}${conditionValue}`;
+                        conditionPart = `${variableWithIOPrefix}${serviceNowOperator}${conditionValue}`;
                     }
                     else {
                         // Standard operations (=, !=, >, <, etc.)
-                        conditionPart = `${variableId}${serviceNowOperator}${conditionValue}`;
+                        conditionPart = `${variableWithIOPrefix}${serviceNowOperator}${conditionValue}`;
                     }
                     this.logger.info(`🏗️ Built condition part: ${conditionPart} (from ${originalOperator}: '${conditionValue}')`);
                     conditionParts.push(conditionPart);
@@ -969,21 +978,24 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                 conditionString = conditionParts.join('^');
                 this.logger.info(`✅ Built conditions string: "${conditionString}"`);
             }
-            // Step 1: Create main catalog UI policy record with embedded conditions
+            // ✅ CRITICAL FIX: Create in sys_ui_policy table, NOT catalog_ui_policy!
+            // The actions reference sys_ui_policy, not catalog_ui_policy
             const policyData = {
-                catalog_item: args.cat_item, // ✅ Link naar het catalog item
-                short_description: args.short_description,
-                catalog_conditions: conditionString || args.condition || '', // Conditions as string
-                applies_to: args.applies_to || 'item', // ✅ Correct veld: 'item', 'req_item', or 'task'
+                // sys_ui_policy fields are different from catalog_ui_policy!
+                name: args.short_description, // sys_ui_policy uses 'name' not 'short_description'
+                table: 'sc_cat_item', // The table this policy applies to
+                conditions: conditionString || args.condition || '', // Condition string
                 active: args.active !== false,
-                applies_on_load: args.on_load !== false,
+                on_load: args.on_load !== false, // Different field name in sys_ui_policy
                 reverse_if_false: args.reverse_if_false !== false,
-                // Optional script fields if needed
+                // Link to the catalog item via a different field
+                catalog_item: args.cat_item,
+                // Optional script fields
                 script_true: args.script_true || '',
                 script_false: args.script_false || ''
             };
-            this.logger.info('🎯 Creating main policy with data:', policyData);
-            const policyResponse = await this.client.createRecord('catalog_ui_policy', policyData);
+            this.logger.info('🎯 Creating main policy in sys_ui_policy table with data:', policyData);
+            const policyResponse = await this.client.createRecord('sys_ui_policy', policyData);
             if (!policyResponse.success) {
                 this.logger.error('❌ Policy creation failed:', policyResponse.error);
                 throw new Error(`Failed to create catalog UI policy: ${policyResponse.error}`);
@@ -1022,21 +1034,22 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     // Actions structure in ServiceNow:
                     // - catalog_ui_policy_action.catalog_variable -> "IO:" + variable_sys_id (required format)
                     // - catalog_ui_policy_action.ui_policy -> catalog_ui_policy.sys_id
+                    // ✅ CRITICAL FIX: Reference fields MUST be objects or sys_ids, not names!
+                    // ServiceNow reference fields expect either:
+                    // 1. Just the sys_id as a string
+                    // 2. An object with { value: sys_id, link: url }
                     const actionData = {
-                        // ✅ Main connection: to the variable with required IO: prefix (if valid sys_id)
-                        catalog_variable: catalogVariableWithPrefix
+                        // ✅ catalog_variable uses IO:sys_id format (this is a STRING field, not a reference)
+                        catalog_variable: catalogVariableWithPrefix,
+                        // ✅ ui_policy is a REFERENCE field - use the sys_id directly!
+                        ui_policy: policyId, // Use the policy sys_id from sys_ui_policy
+                        // ✅ catalog_item is also a REFERENCE field - use the sys_id
+                        catalog_item: args.cat_item // The catalog item sys_id
                     };
-                    // ✅ CRITICAL FIX: ui_policy field expects the NAME (short_description), NOT the sys_id!
-                    // ServiceNow uses the policy name as the reference value
-                    if (args.short_description) {
-                        actionData.ui_policy = args.short_description; // ✅ Use the policy NAME, not sys_id!
-                        this.logger.info(`🔗 Linking action to policy by NAME: "${args.short_description}"`);
-                    }
-                    else {
-                        // Fallback if somehow we don't have the name
-                        this.logger.error(`❌ CRITICAL: No policy name (short_description) available for linking!`);
-                        actionData.ui_policy = policyId; // Use sys_id as last resort
-                    }
+                    this.logger.info(`🔗 Linking action to:`);
+                    this.logger.info(`  - Policy: ${policyId} (sys_ui_policy sys_id)`);
+                    this.logger.info(`  - Variable: ${catalogVariableWithPrefix} (with IO: prefix)`);
+                    this.logger.info(`  - Catalog Item: ${args.cat_item}`);
                     // Voeg alleen GEDEFINIEERDE action properties toe 
                     if (action.mandatory !== undefined) {
                         actionData.mandatory = action.mandatory === true ? 'true' : action.mandatory === false ? 'false' : 'ignore';
@@ -1058,14 +1071,38 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     if (actionResponse.success) {
                         const createdActionId = actionResponse.data.sys_id;
                         this.logger.info(`✅ Created action with sys_id: ${createdActionId}`);
-                        // 🔍 VERIFICATION: Check if action was actually created
-                        this.logger.info(`🔍 Verifying action ${i + 1} creation...`);
+                        // 🔍 VERIFICATION: Check if action was actually created AND fields are populated
+                        this.logger.info(`🔍 Verifying action ${i + 1} creation and field population...`);
                         const actionVerification = await this.client.searchRecords('catalog_ui_policy_action', `sys_id=${createdActionId}`, 1);
                         if (!actionVerification.success || actionVerification.data.result.length === 0) {
                             this.logger.error('❌ ACTION VERIFICATION FAILED: Action not found after creation!');
                             throw new Error(`Action creation verification failed - action ${i + 1} not found in database`);
                         }
-                        this.logger.info(`✅ Action ${i + 1} verified in database`);
+                        // ✅ NEW: Verify that critical fields are actually populated
+                        const createdAction = actionVerification.data.result[0];
+                        this.logger.info(`📋 Created action data:`, {
+                            sys_id: createdAction.sys_id,
+                            ui_policy: createdAction.ui_policy || '❌ EMPTY',
+                            catalog_variable: createdAction.catalog_variable || '❌ EMPTY',
+                            catalog_item: createdAction.catalog_item || '❌ EMPTY',
+                            visible: createdAction.visible,
+                            mandatory: createdAction.mandatory,
+                            disabled: createdAction.disabled
+                        });
+                        // Check if critical fields are populated
+                        if (!createdAction.ui_policy || createdAction.ui_policy === '') {
+                            this.logger.error(`❌ CRITICAL: ui_policy field is EMPTY for action ${i + 1}!`);
+                            throw new Error(`Action ${i + 1} created but ui_policy field is empty - action will not work!`);
+                        }
+                        if (!createdAction.catalog_variable || createdAction.catalog_variable === '') {
+                            this.logger.error(`❌ CRITICAL: catalog_variable field is EMPTY for action ${i + 1}!`);
+                            throw new Error(`Action ${i + 1} created but catalog_variable field is empty - action will not work!`);
+                        }
+                        if (!createdAction.catalog_item || createdAction.catalog_item === '') {
+                            this.logger.error(`❌ CRITICAL: catalog_item field is EMPTY for action ${i + 1}!`);
+                            throw new Error(`Action ${i + 1} created but catalog_item field is empty - action will not work!`);
+                        }
+                        this.logger.info(`✅ Action ${i + 1} verified in database with all fields populated`);
                         createdActions.push({
                             sys_id: createdActionId,
                             variable: action.catalog_variable,
@@ -1086,27 +1123,28 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     }
                 }
             }
-            // 🔍 FINAL VERIFICATION: Policy creation
-            this.logger.info('🔍 Final verification: Checking policy in database...');
-            const policyVerification = await this.client.searchRecords('catalog_ui_policy', `sys_id=${policyId}`, 1);
+            // 🔍 FINAL VERIFICATION: Policy creation in sys_ui_policy table
+            this.logger.info('🔍 Final verification: Checking policy in sys_ui_policy table...');
+            const policyVerification = await this.client.searchRecords('sys_ui_policy', `sys_id=${policyId}`, 1);
             if (!policyVerification.success || policyVerification.data.result.length === 0) {
-                this.logger.error('❌ POLICY VERIFICATION FAILED: Policy not found after creation!');
-                throw new Error(`Policy creation verification failed - policy not found in database`);
+                this.logger.error('❌ POLICY VERIFICATION FAILED: Policy not found in sys_ui_policy table!');
+                throw new Error(`Policy creation verification failed - policy not found in sys_ui_policy table`);
             }
-            this.logger.info('✅ Policy verified in database');
+            this.logger.info('✅ Policy verified in sys_ui_policy table');
             // Build comprehensive response
-            let responseText = `✅ Catalog UI Policy created successfully!
+            let responseText = `✅ UI Policy created successfully in sys_ui_policy table!
 
 📋 **${args.short_description}**
 🆔 Policy sys_id: ${policyId}
-🎯 Applies to: ${args.applies_to || 'item'}
+📊 Table: sys_ui_policy (correct table for catalog UI policy actions)
+🎯 Target Table: sc_cat_item
 🔄 Active: ${args.active !== false ? 'Yes' : 'No'}
 ⚡ On Load: ${args.on_load !== false ? 'Yes' : 'No'}
 🔁 Reverse if False: ${args.reverse_if_false !== false ? 'Yes' : 'No'}
 
 🔍 **Verification Results:**
-✅ Policy record created and verified
-✅ ${createdActions.length} actions created and verified`;
+✅ Policy record created in sys_ui_policy table
+✅ ${createdActions.length} actions created in catalog_ui_policy_action table`;
             if (conditionString) {
                 responseText += `\n\n📝 **Conditions:**\n${conditionString}`;
             }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "snow-flow",
-  "version": "3.6.17",
-  "description": "UI POLICY NAME FIX - v3.6.17 fixes critical issue where ui_policy field in catalog_ui_policy_action table expects the policy NAME (short_description) instead of sys_id. Actions will now properly link to policies using the policy name as the reference value, which is what ServiceNow actually expects.",
+  "version": "3.6.19",
+  "description": "CRITICAL REFERENCE FIELD FIX - v3.6.19 fixes empty action fields by using sys_ids directly for reference fields (ui_policy, catalog_item) instead of names/objects. Added comprehensive verification to ensure all critical fields are populated. Actions now correctly link to sys_ui_policy with actual sys_id values, not empty strings.",
   "main": "dist/index.js",
   "type": "commonjs",
   "bin": {