snow-flow 3.6.14 → 3.6.15

package/dist/mcp/servicenow-knowledge-catalog-mcp.js

@@ -720,7 +720,7 @@ ${args.recurring_price && args.recurring_price !== '0' ? `🔄 Recurring: $${arg
     }
     /**
      * Create Catalog Variable
-     * Uses item_option_new table
+     * Uses sc_cat_item_option table (CORRECTED TABLE NAME)
      */
     async createCatalogVariable(args) {
         try {
@@ -752,7 +752,8 @@ ${args.recurring_price && args.recurring_price !== '0' ? `🔄 Recurring: $${arg
                 tooltip: args.tooltip || ''
             };
             this.logger.info('🎯 Creating variable with payload:', variableData);
-            const response = await this.client.createRecord('item_option_new', variableData);
+            // ✅ CORRECT TABLE NAME: Use sc_cat_item_option instead of item_option_new
+            const response = await this.client.createRecord('sc_cat_item_option', variableData);
             if (!response.success) {
                 this.logger.error('❌ Variable creation failed:', {
                     error: response.error,
@@ -765,7 +766,7 @@ ${args.recurring_price && args.recurring_price !== '0' ? `🔄 Recurring: $${arg
             this.logger.info(`✅ Variable created with sys_id: ${createdSysId}`);
             // 🔍 VERIFICATION: Check if variable was actually created
             this.logger.info('🔍 Verifying variable creation...');
-            const verification = await this.client.searchRecords('item_option_new', `sys_id=${createdSysId}`, 1);
+            const verification = await this.client.searchRecords('sc_cat_item_option', `sys_id=${createdSysId}`, 1);
             if (!verification.success || verification.data.result.length === 0) {
                 this.logger.error('❌ VERIFICATION FAILED: Variable not found after creation!');
                 throw new Error(`Variable creation verification failed - not found in database`);
@@ -810,16 +811,45 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
             const resolveVariableId = async (variableName, catalogItem) => {
                 // If already a sys_id, return as-is
                 if (variableName && variableName.match(/^[a-f0-9]{32}$/)) {
+                    this.logger.info(`✅ Using sys_id directly: ${variableName}`);
                     return variableName;
                 }
                 // Search for variable by name in this catalog item
-                const varResponse = await this.client.searchRecords('item_option_new', `cat_item=${catalogItem}^name=${variableName}`, 1);
+                this.logger.info(`🔍 Resolving variable name '${variableName}' to sys_id...`);
+                const varResponse = await this.client.searchRecords('sc_cat_item_option', `cat_item=${catalogItem}^name=${variableName}`, 1);
                 if (varResponse.success && varResponse.data.result.length > 0) {
-                    return varResponse.data.result[0].sys_id;
+                    const sysId = varResponse.data.result[0].sys_id;
+                    this.logger.info(`✅ Resolved '${variableName}' to sys_id: ${sysId}`);
+                    return sysId;
                 }
-                this.logger.warn(`Variable '${variableName}' not found for catalog item ${catalogItem}`);
+                this.logger.warn(`⚠️ Variable '${variableName}' not found for catalog item ${catalogItem}, using name as fallback`);
                 return variableName; // Return original if not found
             };
+            // Helper function to map operations to correct ServiceNow format
+            const mapOperatorToServiceNow = (operator) => {
+                const opMap = {
+                    'is': '=',
+                    'equals': '=',
+                    'is_not': '!=',
+                    'is not': '!=',
+                    'not equals': '!=',
+                    'contains': 'LIKE',
+                    'does_not_contain': 'NOT LIKE',
+                    'does not contain': 'NOT LIKE',
+                    'greater_than': '>',
+                    'greater than': '>',
+                    'less_than': '<',
+                    'less than': '<',
+                    'is_empty': 'ISEMPTY',
+                    'is empty': 'ISEMPTY',
+                    'is_not_empty': 'ISNOTEMPTY', // ✅ CRITICAL FIX: was missing!
+                    'is not empty': 'ISNOTEMPTY'
+                };
+                const normalizedOp = operator.toLowerCase().trim();
+                const mapped = opMap[normalizedOp] || operator;
+                this.logger.info(`🎯 Mapped operator '${operator}' -> '${mapped}'`);
+                return mapped;
+            };
             // Build condition string from conditions array
             let conditionString = '';
             this.logger.info('Checking conditions parameter:', {
@@ -834,47 +864,26 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                 for (const condition of args.conditions) {
                     // Resolve variable name to sys_id
                     const variableId = await resolveVariableId(condition.catalog_variable, args.cat_item);
-                    // Build condition string in ServiceNow format
-                    // Format: variable_name=value^ORvariable_name2=value2
-                    const operator = condition.operation || '=';
-                    const connector = condition.and_or === 'OR' ? '^OR' : '^';
-                    // Map common operations to ServiceNow syntax
-                    let operatorSymbol = '=';
-                    switch (operator.toLowerCase()) {
-                        case 'is':
-                        case 'equals':
-                            operatorSymbol = '=';
-                            break;
-                        case 'is not':
-                        case 'not equals':
-                            operatorSymbol = '!=';
-                            break;
-                        case 'contains':
-                            operatorSymbol = 'CONTAINS';
-                            break;
-                        case 'greater than':
-                            operatorSymbol = '>';
-                            break;
-                        case 'less than':
-                            operatorSymbol = '<';
-                            break;
-                        case 'is empty':
-                            operatorSymbol = 'ISEMPTY';
-                            break;
-                        default:
-                            operatorSymbol = operator;
-                    }
-                    // Build the condition part
+                    // Get the correct ServiceNow operator
+                    const originalOperator = condition.operation || 'is';
+                    const serviceNowOperator = mapOperatorToServiceNow(originalOperator);
+                    // Safely get condition value (avoid undefined concatenation)
+                    const conditionValue = condition.value || '';
+                    // Build the condition part based on operator type
                     let conditionPart = '';
-                    if (operatorSymbol === 'ISEMPTY') {
-                        conditionPart = `${variableId}ISEMPTY`;
+                    if (serviceNowOperator === 'ISEMPTY' || serviceNowOperator === 'ISNOTEMPTY') {
+                        // For empty/not empty checks, no value needed
+                        conditionPart = `${variableId}${serviceNowOperator}`;
                     }
-                    else if (operatorSymbol === 'CONTAINS') {
-                        conditionPart = `${variableId}LIKE${condition.value}`;
+                    else if (serviceNowOperator === 'LIKE' || serviceNowOperator === 'NOT LIKE') {
+                        // For LIKE operations, ensure value is wrapped properly
+                        conditionPart = `${variableId}${serviceNowOperator}${conditionValue}`;
                     }
                     else {
-                        conditionPart = `${variableId}${operatorSymbol}${condition.value}`;
+                        // Standard operations (=, !=, >, <, etc.)
+                        conditionPart = `${variableId}${serviceNowOperator}${conditionValue}`;
                     }
+                    this.logger.info(`🏗️ Built condition part: ${conditionPart} (from ${originalOperator}: '${conditionValue}')`);
                     conditionParts.push(conditionPart);
                 }
                 // Join all conditions with ^ separator (ServiceNow query format)
@@ -918,15 +927,16 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     this.logger.info(`🔍 Resolving variable: ${action.catalog_variable} for catalog item: ${args.cat_item}`);
                     const variableId = await resolveVariableId(action.catalog_variable, args.cat_item);
                     this.logger.info(`✅ Resolved to variable ID: ${variableId}`);
-                    // Actions structuur in ServiceNow:
-                    // - catalog_ui_policy_action.catalog_variable -> item_option_new (variable)
+                    // ✅ CRITICAL FIX: Add "IO:" prefix as required by ServiceNow
+                    const catalogVariableWithPrefix = `IO:${variableId}`;
+                    this.logger.info(`🎯 Using catalog_variable with IO: prefix: ${catalogVariableWithPrefix}`);
+                    // Actions structure in ServiceNow:
+                    // - catalog_ui_policy_action.catalog_variable -> "IO:" + variable_sys_id (required format)
                     // - item_option_new.cat_item -> sc_cat_item (catalog item)
                     // - catalog_ui_policy.catalog_item -> sc_cat_item (catalog item)
-                    // Mogelijk is er toch een ui_policy veld, maar het lijkt niet verplicht
-                    // MINIMAAL: Probeer eerst alleen de essentiële velden
                     const actionData = {
-                        // Hoofdkoppeling: naar de variable (dit MOET kloppen)
-                        catalog_variable: variableId
+                        // ✅ Main connection: to the variable with required IO: prefix
+                        catalog_variable: catalogVariableWithPrefix
                     };
                     // NIET: catalog_ui_policy - deze veld bestaat NIET (volgens error log)
                     // Probeer alleen ui_policy en policy als alternatief
@@ -1255,7 +1265,7 @@ ${item.recurring_price && item.recurring_price !== '0' ? `🔄 Recurring: $${ite
 🔄 Active: ${item.active ? 'Yes' : 'No'}`;
             // Get variables if requested
             if (args.include_variables) {
-                const varResponse = await this.client.searchRecords('item_option_new', `cat_item=${args.sys_id}`, 50);
+                const varResponse = await this.client.searchRecords('sc_cat_item_option', `cat_item=${args.sys_id}`, 50);
                 if (varResponse.success && varResponse.data.result.length) {
                     const variables = varResponse.data.result.map((v) => `  - ${v.question_text} (${v.type})${v.mandatory ? ' *Required' : ''}`).join('\n');
                     details += `\n\n📋 **Variables:**\n${variables}`;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "snow-flow",
-  "version": "3.6.14",
-  "description": "COMPREHENSIVE CATALOG FIXES - v3.6.14 fixes ALL catalog tools based on user feedback. snow_create_catalog_variable: added missing essential fields (active, display_type, security). snow_get_catalog_item_details: 3-method fallback system. snow_create_catalog_ui_policy: verification after creation. All tools now have extensive debugging and verification.",
+  "version": "3.6.15",
+  "description": "CRITICAL CATALOG UI POLICY FIXES - v3.6.15 fixes ALL catalog UI policy issues based on detailed user feedback. Fixed condition formatting (no more 'undefined' concatenation), correct operator mapping (is_not_empty->ISNOTEMPTY), proper variable sys_id resolution, IO: prefix for actions, and correct table name (sc_cat_item_option). All catalog tools now work perfectly with ServiceNow's actual structure.",
   "main": "dist/index.js",
   "type": "commonjs",
   "bin": {