snow-flow 3.6.12 → 3.6.13

package/dist/mcp/servicenow-knowledge-catalog-mcp.js

@@ -792,7 +792,14 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
             };
             // Build condition string from conditions array
             let conditionString = '';
+            this.logger.info('Checking conditions parameter:', {
+                hasConditions: !!args.conditions,
+                isArray: Array.isArray(args.conditions),
+                length: args.conditions ? args.conditions.length : 0,
+                conditionsData: args.conditions
+            });
             if (args.conditions && Array.isArray(args.conditions)) {
+                this.logger.info(`🎯 Building conditions string from ${args.conditions.length} conditions...`);
                 const conditionParts = [];
                 for (const condition of args.conditions) {
                     // Resolve variable name to sys_id
@@ -840,8 +847,9 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                     }
                     conditionParts.push(conditionPart);
                 }
-                // Join all conditions
-                conditionString = conditionParts.join('');
+                // Join all conditions with ^ separator (ServiceNow query format)
+                conditionString = conditionParts.join('^');
+                this.logger.info(`✅ Built conditions string: "${conditionString}"`);
             }
             // Step 1: Create main catalog UI policy record with embedded conditions
             const policyData = {
@@ -856,40 +864,62 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
                 script_true: args.script_true || '',
                 script_false: args.script_false || ''
             };
+            this.logger.info('🎯 Creating main policy with data:', policyData);
             const policyResponse = await this.client.createRecord('catalog_ui_policy', policyData);
             if (!policyResponse.success) {
+                this.logger.error('❌ Policy creation failed:', policyResponse.error);
                 throw new Error(`Failed to create catalog UI policy: ${policyResponse.error}`);
             }
             const policyId = policyResponse.data.sys_id;
-            this.logger.info(`Created main policy with sys_id: ${policyId}`);
+            this.logger.info(`✅ Created main policy with sys_id: ${policyId}`);
             const createdActions = [];
             // Step 2: Create action records (dit werkt wel met aparte tabel)
+            this.logger.info('Checking actions parameter:', {
+                hasActions: !!args.actions,
+                isArray: Array.isArray(args.actions),
+                length: args.actions ? args.actions.length : 0,
+                actionsData: args.actions
+            });
             if (args.actions && Array.isArray(args.actions)) {
-                this.logger.info(`Creating ${args.actions.length} action records...`);
+                this.logger.info(`🎯 Starting to create ${args.actions.length} action records...`);
                 for (let i = 0; i < args.actions.length; i++) {
                     const action = args.actions[i];
                     // Resolve variable name to sys_id
+                    this.logger.info(`🔍 Resolving variable: ${action.catalog_variable} for catalog item: ${args.cat_item}`);
                     const variableId = await resolveVariableId(action.catalog_variable, args.cat_item);
+                    this.logger.info(`✅ Resolved to variable ID: ${variableId}`);
                     // Actions structuur in ServiceNow:
                     // - catalog_ui_policy_action.catalog_variable -> item_option_new (variable)
                     // - item_option_new.cat_item -> sc_cat_item (catalog item)
                     // - catalog_ui_policy.catalog_item -> sc_cat_item (catalog item)
                     // Mogelijk is er toch een ui_policy veld, maar het lijkt niet verplicht
+                    // MINIMAAL: Probeer eerst alleen de essentiële velden
                     const actionData = {
-                        // Primaire koppeling: naar de variable
-                        catalog_variable: variableId, // Verplicht: koppeling naar variable
-                        // Mogelijk ook een policy koppeling (als het veld bestaat)
-                        ui_policy: policyId, // Probeer dit ook, kan optioneel zijn
-                        // Action settings - gebruik strings zoals ServiceNow verwacht
-                        mandatory: action.mandatory === true ? 'true' : action.mandatory === false ? 'false' : 'ignore',
-                        visible: action.visible === false ? 'false' : action.visible === true ? 'true' : 'ignore',
-                        disabled: action.readonly === true ? 'true' : action.readonly === false ? 'false' : 'ignore',
-                        // Waarde velden (voor set_value acties)
-                        value: action.value || '',
-                        // Metadata
-                        order: (i + 1) * 100,
-                        active: true
+                        // Hoofdkoppeling: naar de variable (dit MOET kloppen)
+                        catalog_variable: variableId
                     };
+                    // NIET: catalog_ui_policy - deze veld bestaat NIET (volgens error log)
+                    // Probeer alleen ui_policy en policy als alternatief
+                    if (policyId) {
+                        // Probeer ui_policy (dit is waarschijnlijk correct)
+                        actionData.ui_policy = policyId;
+                    }
+                    // Voeg alleen GEDEFINIEERDE action properties toe 
+                    if (action.mandatory !== undefined) {
+                        actionData.mandatory = action.mandatory === true ? 'true' : action.mandatory === false ? 'false' : 'ignore';
+                    }
+                    if (action.visible !== undefined) {
+                        actionData.visible = action.visible === false ? 'false' : action.visible === true ? 'true' : 'ignore';
+                    }
+                    if (action.readonly !== undefined) {
+                        actionData.disabled = action.readonly === true ? 'true' : action.readonly === false ? 'false' : 'ignore';
+                    }
+                    if (action.value) {
+                        actionData.value = action.value;
+                    }
+                    // Basis metadata
+                    actionData.order = (i + 1) * 100;
+                    actionData.active = true;
                     this.logger.info(`Attempting to create action ${i + 1}:`, actionData);
                     const actionResponse = await this.client.createRecord('catalog_ui_policy_action', actionData);
                     if (actionResponse.success) {
@@ -940,27 +970,6 @@ ${args.help_text ? `❓ Help: ${args.help_text}` : ''}
             throw new types_js_1.McpError(types_js_1.ErrorCode.InternalError, `Failed to create catalog UI policy: ${error}`);
         }
     }
-    /**
-     * Helper function to determine action type based on provided fields
-     * Note: ServiceNow might not use 'type' field, actions are determined by field values
-     */
-    determineActionType(action) {
-        // ServiceNow bepaalt het type waarschijnlijk op basis van de velden zelf
-        // Dit is alleen voor logging/display
-        if (action.value !== undefined && action.value !== '') {
-            return 'set_value';
-        }
-        if (action.mandatory === true) {
-            return 'set_mandatory';
-        }
-        if (action.visible === false) {
-            return 'set_hidden';
-        }
-        if (action.readonly === true) {
-            return 'set_readonly';
-        }
-        return 'default';
-    }
     /**
      * Helper function to format action details for display
      */

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "snow-flow",
-  "version": "3.6.12",
-  "description": "COMPLETE UI POLICY FIX - v3.6.12 fixes both policy and actions. Policy uses catalog_item + applies_to fields. Actions link to catalog_variable. Conditions stored as query string. Based on actual ServiceNow table structure.",
+  "version": "3.6.13",
+  "description": "DEBUG UI POLICY - v3.6.13 adds extensive debugging to find why actions/conditions fail. Fixed condition string joining with ^ separator. Removed catalog_ui_policy field (doesn't exist). Added detailed logging for troubleshooting.",
   "main": "dist/index.js",
   "type": "commonjs",
   "bin": {