snow-flow 3.5.14 → 3.5.15

package/dist/utils/artifact-local-sync.d.ts

@@ -31,6 +31,8 @@ export interface LocalFile {
     currentContent?: string;
     isModified: boolean;
     fieldMapping?: FieldMapping;
+    existedBefore?: boolean;
+    previousContent?: string;
 }
 export declare class ArtifactLocalSync {
     private baseDir;
@@ -84,9 +86,21 @@ export declare class ArtifactLocalSync {
      */
     private validateES5;
     /**
-     * Strip headers/footers we added - now uses field mapping for accuracy
+     * Strip headers/footers we added - FIXED to use actual fieldMapping wrappers
      */
     private stripAddedWrappers;
+    /**
+     * Create regex pattern from wrapper text, handling placeholders
+     */
+    private escapeRegexAndCreatePattern;
+    /**
+     * Fallback: Strip generic comments when no fieldMapping available
+     */
+    private stripGenericComments;
+    /**
+     * INTELLIGENT WRAPPER DETECTION: Check if content actually needs wrappers
+     */
+    private needsWrappers;
     /**
      * Sanitize filename for filesystem
      */

package/dist/utils/artifact-local-sync.js

@@ -127,6 +127,7 @@ class ArtifactLocalSync {
             throw new Error(`Unsupported artifact type: ${tableName}. Supported types: ${Object.keys(artifact_registry_1.ARTIFACT_REGISTRY).join(', ')}`);
         }
         console.log(`\n🔄 Pulling ${config.displayName} (${sys_id}) to local files...`);
+        console.log(`📋 Snow-Flow v3.5.15 - Intelligent Wrapper System Active`);
         // Get timeout configuration
         const timeoutConfig = (0, mcp_timeout_config_js_1.getMCPTimeoutConfig)();
         // Use smart fetcher for known types, otherwise direct query
@@ -186,9 +187,17 @@ class ArtifactLocalSync {
                 .replace('{name}', sanitizedName)
                 .replace('{api_name}', artifactData.api_name || sanitizedName)
                 .replace('{short_description}', artifactData.short_description || sanitizedName);
-            // Generate header/footer with replacements
-            const header = this.replacePlaceholders(mapping.wrapperHeader || '', artifactData);
-            const footer = this.replacePlaceholders(mapping.wrapperFooter || '', artifactData);
+            // INTELLIGENT WRAPPER SYSTEM: Only add wrappers if actually needed
+            let header = '';
+            let footer = '';
+            if (mapping.wrapperHeader && mapping.wrapperFooter && this.needsWrappers(processedContent, mapping)) {
+                header = this.replacePlaceholders(mapping.wrapperHeader, artifactData);
+                footer = this.replacePlaceholders(mapping.wrapperFooter, artifactData);
+                console.log(`   🔧 Adding wrappers for ${filename} (content needs them)`);
+            }
+            else if (mapping.wrapperHeader && mapping.wrapperFooter) {
+                console.log(`   ✅ Skipping wrappers for ${filename} (content is already wrapped)`);
+            }
             const file = this.createLocalFile(artifactPath, `${filename}.${mapping.fileExtension}`, processedContent, mapping.serviceNowField, mapping.fileExtension, header, footer);
             file.fieldMapping = mapping;
             files.push(file);
@@ -370,6 +379,31 @@ class ArtifactLocalSync {
     createLocalFile(dirPath, filename, content, field, type, header = '', footer = '') {
         const filePath = path.join(dirPath, filename);
         const fullContent = header + content + footer;
+        // CRITICAL FIX: Check if file exists and handle overwrites intelligently
+        let fileExists = false;
+        let existingContent = '';
+        if (fs.existsSync(filePath)) {
+            fileExists = true;
+            existingContent = fs.readFileSync(filePath, 'utf8');
+            // Check if existing content is the same (avoid unnecessary writes)
+            if (existingContent === fullContent) {
+                console.log(`   📄 Unchanged: ${filename} (identical content, skipping write)`);
+                return {
+                    filename,
+                    path: filePath,
+                    field,
+                    type: type,
+                    originalContent: content,
+                    isModified: false
+                };
+            }
+            console.log(`   🔄 Overwriting: ${filename}`);
+            console.log(`   ℹ️ File size: ${existingContent.length} → ${fullContent.length} chars`);
+        }
+        else {
+            console.log(`   📝 Creating: ${filename}`);
+        }
+        // Write the file
         fs.writeFileSync(filePath, fullContent, 'utf8');
         return {
             filename,
@@ -377,7 +411,9 @@ class ArtifactLocalSync {
             field,
             type: type,
             originalContent: content,
-            isModified: false
+            isModified: fileExists, // Mark as modified if we overwrote existing file
+            existedBefore: fileExists,
+            previousContent: existingContent
         };
     }
     /**
@@ -544,29 +580,105 @@ snow-flow sync status ${widget.sys_id}
         return issues;
     }
     /**
-     * Strip headers/footers we added - now uses field mapping for accuracy
+     * Strip headers/footers we added - FIXED to use actual fieldMapping wrappers
      */
     stripAddedWrappers(content, type, fieldMapping) {
-        // Remove our added comments and wrappers
+        if (!fieldMapping || !fieldMapping.wrapperHeader || !fieldMapping.wrapperFooter) {
+            // No wrappers defined, just remove generic comments
+            return this.stripGenericComments(content, type);
+        }
+        let cleaned = content;
+        // Get the actual wrappers that were added (without placeholders)
+        const header = fieldMapping.wrapperHeader;
+        const footer = fieldMapping.wrapperFooter;
+        // CRITICAL FIX: Use the EXACT wrappers from fieldMapping
+        if (header && footer) {
+            // Create regex patterns from the actual wrappers
+            const headerPattern = this.escapeRegexAndCreatePattern(header);
+            const footerPattern = this.escapeRegexAndCreatePattern(footer);
+            // Remove footer first (from end)
+            if (footerPattern) {
+                cleaned = cleaned.replace(new RegExp(footerPattern + '$'), '');
+            }
+            // Remove header (from start)
+            if (headerPattern) {
+                cleaned = cleaned.replace(new RegExp('^' + headerPattern), '');
+            }
+        }
+        return cleaned.trim();
+    }
+    /**
+     * Create regex pattern from wrapper text, handling placeholders
+     */
+    escapeRegexAndCreatePattern(wrapper) {
+        // Replace placeholders with generic patterns
+        let pattern = wrapper
+            .replace(/\{name\}/g, '[^}]*') // Replace {name} with pattern to match any name
+            .replace(/\{[^}]+\}/g, '[^}]*'); // Replace any other {placeholder}
+        // Escape special regex characters
+        pattern = pattern.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+        // Convert \n back to actual newlines in pattern
+        pattern = pattern.replace(/\\n/g, '\\s*\\n\\s*');
+        return pattern;
+    }
+    /**
+     * Fallback: Strip generic comments when no fieldMapping available
+     */
+    stripGenericComments(content, type) {
         let cleaned = content;
         if (type === 'js') {
-            // Remove wrapper function if we added it
-            cleaned = cleaned.replace(/^\(function\(\) \{\n/, '');
-            cleaned = cleaned.replace(/\n\}\)\(\);$/, '');
-            // Remove our header comments
-            cleaned = cleaned.replace(/^\/\*\*[\s\S]*?\*\/\n\n/, '');
-            cleaned = cleaned.replace(/^function\(/, 'function(');
+            // Remove generic comment blocks at start
+            cleaned = cleaned.replace(/^\/\*\*[\s\S]*?\*\/\s*\n?/, '');
+            // Remove simple function wrappers (conservative approach)
+            cleaned = cleaned.replace(/^\(function\(\) \{\s*\n?/, '');
+            cleaned = cleaned.replace(/\s*\n?\}\)\(\);\s*$/, '');
+            cleaned = cleaned.replace(/^function\(\s*/, 'function(');
         }
         else if (type === 'html') {
-            // Remove our HTML comments
-            cleaned = cleaned.replace(/^<!-- ServiceNow Widget Template -->[\s\S]*?-->\n\n/, '');
+            // Remove HTML comments
+            cleaned = cleaned.replace(/^<!--[\s\S]*?-->\s*\n?/, '');
         }
         else if (type === 'css') {
-            // Remove our CSS comments
-            cleaned = cleaned.replace(/^\/\* ServiceNow Widget Styles \*\/[\s\S]*?\*\/\n\n/, '');
+            // Remove CSS comments
+            cleaned = cleaned.replace(/^\/\*[\s\S]*?\*\/\s*\n?/, '');
         }
         return cleaned.trim();
     }
+    /**
+     * INTELLIGENT WRAPPER DETECTION: Check if content actually needs wrappers
+     */
+    needsWrappers(content, mapping) {
+        if (!content || !content.trim()) {
+            return false; // Empty content doesn't need wrappers
+        }
+        // Check for server script wrappers
+        if (mapping.wrapperHeader?.includes('(function()') && mapping.wrapperFooter?.includes('})()')) {
+            // Check if content already has function wrapper
+            const trimmed = content.trim();
+            if (trimmed.match(/^\(function\s*\([^)]*\)\s*\{[\s\S]*\}\s*\)\s*\([^)]*\)\s*;?$/)) {
+                return false; // Already has function wrapper
+            }
+            if (trimmed.match(/^\(function\(\)\s*\{[\s\S]*\}\)\(\)\s*;?$/)) {
+                return false; // Already has our specific wrapper
+            }
+        }
+        // Check for client script wrappers
+        if (mapping.wrapperHeader?.includes('function(') && mapping.wrapperFooter?.includes(')')) {
+            const trimmed = content.trim();
+            if (trimmed.match(/^function\s*\([^)]*\)\s*\{[\s\S]*\}$/)) {
+                return false; // Already is a function
+            }
+        }
+        // Check if content already has comments that look like ours
+        if (mapping.wrapperHeader?.includes('/**')) {
+            if (content.includes('* Server Script for Widget:') ||
+                content.includes('* Client Controller for Widget:') ||
+                content.includes('* ES5 ONLY -')) {
+                return false; // Already has our comments
+            }
+        }
+        return true; // Content needs wrappers
+    }
     /**
      * Sanitize filename for filesystem
      */

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "snow-flow",
-  "version": "3.5.14",
-  "description": "ServiceNow development framework with comprehensive Claude Code integration. Enhanced 'snow-flow init' creates optimized settings.json with 18 MCP servers, extensive development permissions, intelligent hooks, and ServiceNow-specific commands. Fixed false positive success reporting in artifact push. Features intelligent timeout configuration for long operations while preventing Claude API timeouts. Executes background scripts using ES5 JavaScript only (ServiceNow Rhino engine requirement). Provides complete development workflow with local artifact sync, widget debugging, deployment validation, and comprehensive platform management.",
+  "version": "3.5.15",
+  "description": "ServiceNow development framework with FIXED local artifact sync system. CRITICAL BUG RESOLVED: Fixed cumulative wrapper problems in snow_pull_artifact where dynamic registry wrappers didn't match hardcoded strip patterns, causing dubbele function wrappers. Now features intelligent wrapper detection and proper content handling. Enhanced 'snow-flow init' creates optimized settings.json with 18 MCP servers, extensive development permissions, intelligent hooks, and ServiceNow-specific commands. Features intelligent timeout configuration and comprehensive ServiceNow development workflow.",
   "main": "dist/index.js",
   "type": "commonjs",
   "bin": {