snow-flow 3.5.11 → 3.5.13

package/dist/utils/artifact-local-sync.js

@@ -318,7 +318,14 @@ class ArtifactLocalSync {
         try {
             console.log(`\n📤 Updating ${config.displayName} in ServiceNow...`);
             const timeoutConfig = (0, mcp_timeout_config_js_1.getMCPTimeoutConfig)();
-            await (0, mcp_timeout_config_js_1.withMCPTimeout)(this.client.updateRecord(config.tableName, sys_id, updates), timeoutConfig.pushToolTimeout, `Update ${config.displayName} ${sys_id}`);
+            const updateResult = await (0, mcp_timeout_config_js_1.withMCPTimeout)(this.client.updateRecord(config.tableName, sys_id, updates), timeoutConfig.pushToolTimeout, `Update ${config.displayName} ${sys_id}`);
+            // CRITICAL FIX: Check if the API call was actually successful
+            if (!updateResult || !updateResult.success) {
+                const errorMsg = updateResult?.error || 'Unknown API error';
+                console.error(`❌ ServiceNow API returned failure: ${errorMsg}`);
+                artifact.syncStatus = 'pending_upload';
+                return false;
+            }
             artifact.syncStatus = 'synced';
             artifact.lastSyncedAt = new Date();
             console.log(`✅ ${config.displayName} successfully updated in ServiceNow!`);

package/dist/utils/mcp-timeout-config.js

@@ -16,21 +16,21 @@ exports.quickHealthCheck = quickHealthCheck;
 function getMCPTimeoutConfig() {
     const isDebug = process.env.DEBUG === 'true';
     const isProduction = process.env.NODE_ENV === 'production';
-    // Fast timeouts to prevent Claude from timing out
+    // Balanced timeouts - long enough for real work, short enough to prevent hanging
     const config = {
-        // Server should start quickly (3s max)
-        serverInitTimeout: parseInt(process.env.MCP_SERVER_INIT_TIMEOUT || '3000'),
-        // Tool timeouts - keep them short to fail fast
-        defaultToolTimeout: parseInt(process.env.MCP_DEFAULT_TOOL_TIMEOUT || '8000'), // 8s default
-        queryToolTimeout: parseInt(process.env.MCP_QUERY_TIMEOUT || '5000'), // 5s for queries
-        pullToolTimeout: parseInt(process.env.MCP_PULL_TIMEOUT || '10000'), // 10s for pulls
-        pushToolTimeout: parseInt(process.env.MCP_PUSH_TIMEOUT || '10000'), // 10s for pushes
-        debugToolTimeout: parseInt(process.env.MCP_DEBUG_TIMEOUT || '15000'), // 15s for debug
-        scriptToolTimeout: parseInt(process.env.MCP_SCRIPT_TIMEOUT || '20000'), // 20s for scripts
-        // API calls should be fast
-        apiCallTimeout: parseInt(process.env.MCP_API_TIMEOUT || '5000'), // 5s per API call
-        apiRetryDelay: parseInt(process.env.MCP_API_RETRY_DELAY || '1000'), // 1s between retries
-        apiMaxRetries: parseInt(process.env.MCP_API_MAX_RETRIES || '2'), // Only 2 retries
+        // Server should start reasonably quickly
+        serverInitTimeout: parseInt(process.env.MCP_SERVER_INIT_TIMEOUT || '10000'), // 10s for server init
+        // Tool timeouts - balanced for real operations
+        defaultToolTimeout: parseInt(process.env.MCP_DEFAULT_TOOL_TIMEOUT || '30000'), // 30s default
+        queryToolTimeout: parseInt(process.env.MCP_QUERY_TIMEOUT || '15000'), // 15s for queries
+        pullToolTimeout: parseInt(process.env.MCP_PULL_TIMEOUT || '60000'), // 60s for pulls (large widgets)
+        pushToolTimeout: parseInt(process.env.MCP_PUSH_TIMEOUT || '45000'), // 45s for pushes
+        debugToolTimeout: parseInt(process.env.MCP_DEBUG_TIMEOUT || '30000'), // 30s for debug
+        scriptToolTimeout: parseInt(process.env.MCP_SCRIPT_TIMEOUT || '120000'), // 2 min for scripts
+        // API calls get reasonable time
+        apiCallTimeout: parseInt(process.env.MCP_API_TIMEOUT || '15000'), // 15s per API call
+        apiRetryDelay: parseInt(process.env.MCP_API_RETRY_DELAY || '2000'), // 2s between retries
+        apiMaxRetries: parseInt(process.env.MCP_API_MAX_RETRIES || '3'), // 3 retries for resilience
         // Health checks
         healthCheckInterval: parseInt(process.env.MCP_HEALTH_INTERVAL || '30000'), // Every 30s
         healthCheckTimeout: parseInt(process.env.MCP_HEALTH_TIMEOUT || '2000'), // 2s timeout

package/dist/utils/servicenow-client.js

@@ -86,8 +86,6 @@ class ServiceNowClient {
         // 🔧 CRITICAL FIX: Add makeRequest method to Axios instance to fix phantom calls
         // Some code expects makeRequest to exist on this.client (the Axios instance)
         this.client.makeRequest = async (config) => {
-            this.logger.debug('🔧 AXIOS makeRequest called! Config:', config);
-            this.logger.debug('🔧 Routing to appropriate HTTP method...');
             // Route to the appropriate Axios method based on the request config
             const method = (config.method || 'GET').toLowerCase();
             const url = config.url || config.endpoint;
@@ -2888,17 +2886,13 @@ try {
      * This method provides compatibility for code that expects makeRequest
      */
     async makeRequest(config) {
-        this.logger.info('🔧 MAKEQUEST CALLED! Stack trace:', new Error().stack);
-        this.logger.info('🔧 TEMP FIX: makeRequest called with config:', config);
-        this.logger.info('🔧 This instance constructor:', this.constructor.name);
-        this.logger.info('🔧 This instance methods:', Object.getOwnPropertyNames(Object.getPrototypeOf(this)));
+        // Debug logging removed - was causing noise in production
         try {
             await this.ensureAuthenticated();
             // Route the request to the appropriate HTTP method
             const method = (config.method || 'GET').toLowerCase();
             const url = config.url || config.endpoint;
             const data = config.data || config.body;
-            this.logger.info(`🔧 Routing ${method.toUpperCase()} request to: ${url}`);
             switch (method) {
                 case 'get':
                     return await this.get(url, config.params);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "snow-flow",
-  "version": "3.5.11",
-  "description": "ServiceNow development framework with MCP server integration and fast response times. Features timeout-protected MCP operations to prevent Claude API timeouts. Executes background scripts using ES5 JavaScript only (ServiceNow Rhino engine requirement). Provides 18 MCP servers including local development sync for editing ServiceNow artifacts with Claude Code native tools, widget deployment with coherence validation, table operations, script execution, machine learning, advanced features, and comprehensive platform management.",
+  "version": "3.5.13",
+  "description": "ServiceNow development framework with MCP server integration and reliable push operations. Fixed false positive success reporting in artifact push - now properly validates API responses. Features intelligent timeout configuration for long operations while preventing Claude API timeouts. Debug logging cleaned up for production use. Executes background scripts using ES5 JavaScript only (ServiceNow Rhino engine requirement). Provides 18 MCP servers including local development sync for editing ServiceNow artifacts with Claude Code native tools, widget deployment with coherence validation, table operations, script execution, machine learning, advanced features, and comprehensive platform management.",
   "main": "dist/index.js",
   "type": "commonjs",
   "bin": {