snow-flow 3.0.19 → 3.0.21

package/dist/mcp/servicenow-deployment-mcp.js

@@ -487,6 +487,8 @@ class ServiceNowDeploymentMCP {
                 const refreshResult = await this.deploymentAuthManager.forceTokenRefresh();
                 if (!refreshResult.success) {
                     return {
+                        success: false,
+                        error: authResult.error || 'Unable to authenticate',
                         content: [
                             {
                                 type: 'text',
@@ -500,7 +502,77 @@ class ServiceNowDeploymentMCP {
             if (!authResult.hasWriteScope) {
                 this.logger.warn('⚠️ Token may lack write permissions, deployment might fail with 403');
             }
-            this.logger.info('Deploying widget to ServiceNow', { name: args.name });
+            this.logger.info('Deploying widget to ServiceNow', { name: args.name, sys_id: args.sys_id });
+            // CHECK: If sys_id is provided, this is an UPDATE not a CREATE
+            if (args.sys_id) {
+                this.logger.info('🔄 UPDATE mode detected - updating existing widget', { sys_id: args.sys_id });
+                try {
+                    // Update the existing widget
+                    const updateResult = await this.client.updateRecord('sp_widget', args.sys_id, {
+                        name: args.name || undefined,
+                        title: args.title || undefined,
+                        template: args.template || undefined,
+                        css: args.css || undefined,
+                        client_script: args.client_script || undefined,
+                        server_script: args.server_script || undefined,
+                        option_schema: args.option_schema || undefined,
+                        demo_data: args.demo_data || undefined,
+                        data: args.data || undefined,
+                        description: args.description || undefined
+                    });
+                    if (updateResult.success) {
+                        const credentials = await this.oauth.loadCredentials();
+                        const widgetUrl = credentials?.instance ?
+                            `https://${credentials.instance}/sp_config?id=widget_editor&sys_id=${args.sys_id}` :
+                            'ServiceNow instance URL not available';
+                        return {
+                            success: true,
+                            sys_id: args.sys_id,
+                            name: args.name,
+                            content: [
+                                {
+                                    type: 'text',
+                                    text: `✅ Widget updated successfully!
+                  
+🎯 Widget Details:
+- Sys ID: ${args.sys_id}
+- Name: ${args.name || 'Unchanged'}
+- Deployment Context: ${args.config?.deployment_context || args.deployment_context || 'Widget update'}
+- Method: Direct update via API
+
+🔗 Direct Links:
+- Widget Editor: ${widgetUrl}
+- Service Portal Designer: https://${credentials?.instance}/sp_config?id=designer
+
+⚡ **Widget Updated**
+Your changes have been applied to the existing widget.`
+                                }
+                            ]
+                        };
+                    }
+                    else {
+                        return {
+                            success: false,
+                            error: updateResult.error || 'Failed to update widget',
+                            content: [{
+                                    type: 'text',
+                                    text: `❌ Failed to update widget: ${updateResult.error || 'Unknown error'}`
+                                }]
+                        };
+                    }
+                }
+                catch (updateError) {
+                    this.logger.error('Widget update failed', updateError);
+                    return {
+                        success: false,
+                        error: updateError.message || 'Update failed',
+                        content: [{
+                                type: 'text',
+                                text: `❌ Widget update failed: ${updateError.message || 'Unknown error'}`
+                            }]
+                    };
+                }
+            }
             // ENHANCED: Mandatory Update Set management with auto-activation
             try {
                 // Force Update Set creation/activation for all deployments
@@ -554,6 +626,9 @@ class ServiceNowDeploymentMCP {
                     `https://${credentials.instance}/sp_config?id=widget_editor&sys_id=${existenceCheck.artifact.sys_id}` :
                     'ServiceNow instance URL not available';
                 return {
+                    success: true,
+                    sys_id: existenceCheck.artifact.sys_id,
+                    name: args.name,
                     content: [
                         {
                             type: 'text',
@@ -579,7 +654,14 @@ Your widget is deployed and ready for testing in Service Portal.`
             }
             // Validate widget structure
             if (!args.template || !args.name || !args.title) {
-                throw new Error('Widget must have name, title, and template');
+                return {
+                    success: false,
+                    error: 'Widget must have name, title, and template',
+                    content: [{
+                            type: 'text',
+                            text: '❌ Widget validation failed: Widget must have name, title, and template'
+                        }]
+                };
             }
             // IMPROVED: Softer Service Portal permissions check with graceful fallback
             let hasServicePortalAccess = false;
@@ -860,6 +942,8 @@ Your widget is deployed and ready for testing in Service Portal.`
 `;
                     }
                     return {
+                        success: false,
+                        error: directError?.message || tableError?.message || 'Deployment failed',
                         content: [
                             {
                                 type: 'text',
@@ -998,7 +1082,11 @@ Use \`snow_deployment_debug\` for more information about this session.`,
                 const inconsistencyWarning = inconsistencies.length > 0
                     ? `\n\n⚠️ Sys_ID Inconsistencies Detected:\n${inconsistencies.map(inc => `- ${inc.issue}`).join('\n')}`
                     : '';
+                // Return both MCP response format AND success properties for attemptDirectDeployment
                 return {
+                    success: true,
+                    sys_id: result.data.sys_id,
+                    name: args.name,
                     content: [
                         {
                             type: 'text',
@@ -1056,7 +1144,14 @@ Use \`snow_deployment_debug\` for more information about this session.`,
 • Check dependencies with check_dependencies: true
 
 📚 Documentation: See CLAUDE.md for Widget Deployment Guidelines`;
-                throw new Error(enhancedError);
+                return {
+                    success: false,
+                    error: result.error || 'Unknown deployment error',
+                    content: [{
+                            type: 'text',
+                            text: enhancedError
+                        }]
+                };
             }
         }
         catch (error) {
@@ -1082,6 +1177,9 @@ Use \`snow_deployment_debug\` for more information about this session.`,
                             `https://${credentials.instance}/sp_config?id=widget_editor&sys_id=${createdWidget.sys_id}` :
                             'ServiceNow instance URL not available';
                         return {
+                            success: true,
+                            sys_id: createdWidget.sys_id,
+                            name: args.name,
                             content: [{
                                     type: 'text',
                                     text: `✅ Widget deployed successfully! (Error Recovery)
@@ -1130,7 +1228,14 @@ ${is403Error ? '\n⚠️  **Possible False Negative**: Widget may have been crea
 • Use snow_widget_test() for validation
 
 📚 **Important**: If you see "403" or "Forbidden" errors, the widget may still have been created successfully. Check ServiceNow directly.`;
-            throw new Error(enhancedError);
+            return {
+                success: false,
+                error: error instanceof Error ? error.message : String(error),
+                content: [{
+                        type: 'text',
+                        text: enhancedError
+                    }]
+            };
         }
     }
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "snow-flow",
-  "version": "3.0.19",
+  "version": "3.0.21",
   "description": "Snow-Flow v3.0.18: DIRECT API VERIFICATION! 🚀 Replaced unreliable searchRecords with direct API calls (snow_query_table style) for widget verification. All null/403 error recovery now uses GET /api/now/table/sp_widget with precise queries. NO MORE FALSE NEGATIVES - verification works consistently every time!",
   "main": "dist/index.js",
   "type": "commonjs",