snow-flow 10.0.1-dev.488 → 10.0.1-dev.490

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-dev.488",
+  "version": "10.0.1-dev.490",
   "name": "snow-flow",
   "description": "Snow-Flow - ServiceNow Multi-Agent Development Framework powered by AI",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -110,6 +110,26 @@ async function executeFlowPatchMutation(
   return resp.data?.data?.global?.snFlowDesigner?.flow || resp.data;
 }
 
+/**
+ * Acquire the Flow Designer editing lock on a flow.
+ * The UI calls safeEdit(create: flowId) when opening the editor.
+ * This must be called before GraphQL mutations on existing flows.
+ */
+async function acquireFlowEditingLock(client: any, flowId: string): Promise<{ success: boolean; error?: string }> {
+  try {
+    var mutation = 'mutation { global { snFlowDesigner { safeEdit(safeEditInput: {create: "' + flowId + '"}) { createResult { canEdit id editingUserDisplayName __typename } __typename } __typename } __typename } }';
+    var resp = await client.post('/api/now/graphql', { variables: {}, query: mutation });
+    var result = resp.data?.data?.global?.snFlowDesigner?.safeEdit?.createResult;
+    if (result?.canEdit === true || result?.canEdit === 'true') {
+      return { success: true };
+    }
+    var editingUser = result?.editingUserDisplayName || 'another user';
+    return { success: false, error: 'Flow is locked by ' + editingUser };
+  } catch (e: any) {
+    return { success: false, error: e.message || 'unknown error' };
+  }
+}
+
 /**
  * Release the Flow Designer editing lock on a flow.
  * The UI calls safeEdit(delete: flowId) when closing the editor.
@@ -221,7 +241,12 @@ async function buildActionInputsForInsert(
     };
   });
 
-  return { inputs, resolvedInputs, actionParams };
+  // Check for mandatory fields that are missing a value
+  var missingMandatory = inputs
+    .filter(function (inp: any) { return inp.parameter?.mandatory && !inp.value?.value; })
+    .map(function (inp: any) { return inp.name + ' (' + (inp.parameter?.label || inp.name) + ')'; });
+
+  return { inputs, resolvedInputs, actionParams, missingMandatory };
 }
 
 /**
@@ -353,7 +378,12 @@ async function buildFlowLogicInputsForInsert(
     variables: '[]'
   };
 
-  return { inputs, flowLogicDefinition, resolvedInputs, inputQueryError: inputQueryError || undefined, defParamsCount: defParams.length };
+  // Check for mandatory fields that are missing a value
+  var missingMandatory = inputs
+    .filter(function (inp: any) { return inp.parameter?.mandatory && !inp.value?.value; })
+    .map(function (inp: any) { return inp.name + ' (' + (inp.parameter?.label || inp.name) + ')'; });
+
+  return { inputs, flowLogicDefinition, resolvedInputs, inputQueryError: inputQueryError || undefined, defParamsCount: defParams.length, missingMandatory };
 }
 
 // Note: reordering of existing elements is NOT possible via Table API because
@@ -1107,6 +1137,12 @@ async function addActionViaGraphQL(
   steps.available_inputs = inputResult.actionParams.map((p: any) => ({ element: p.element, label: p.label }));
   steps.resolved_inputs = inputResult.resolvedInputs;
 
+  // Validate mandatory fields
+  if (inputResult.missingMandatory && inputResult.missingMandatory.length > 0) {
+    steps.missing_mandatory = inputResult.missingMandatory;
+    return { success: false, error: 'Missing required inputs for ' + actionType + ': ' + inputResult.missingMandatory.join(', ') + '. These fields are mandatory in Flow Designer.', steps };
+  }
+
   // Calculate insertion order
   const resolvedOrder = await calculateInsertOrder(client, flowId, parentUiId, order);
   steps.insert_order = resolvedOrder;
@@ -1997,6 +2033,12 @@ async function addFlowLogicViaGraphQL(
   steps.resolved_inputs = inputResult.resolvedInputs;
   steps.input_query_stats = { defParamsFound: inputResult.defParamsCount, inputsBuilt: inputResult.inputs.length, error: inputResult.inputQueryError };
 
+  // Validate mandatory fields (e.g. condition for IF/ELSEIF)
+  if (inputResult.missingMandatory && inputResult.missingMandatory.length > 0) {
+    steps.missing_mandatory = inputResult.missingMandatory;
+    return { success: false, error: 'Missing required inputs for ' + logicType + ': ' + inputResult.missingMandatory.join(', ') + '. These fields are mandatory in Flow Designer.', steps };
+  }
+
   // ── Detect condition that needs data pill transformation ────────────
   // Flow Designer sets conditions via a SEPARATE UPDATE after the element is created.
   // Three paths:
@@ -3727,22 +3769,27 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
       }
 
       // ────────────────────────────────────────────────────────────────
-      // OPEN_FLOW — acquire Flow Designer editing lock (processflow GET)
+      // OPEN_FLOW — acquire Flow Designer editing lock (safeEdit create)
       // ────────────────────────────────────────────────────────────────
       case 'open_flow': {
         if (!args.flow_id) throw new SnowFlowError(ErrorType.VALIDATION_ERROR, 'flow_id is required for open_flow');
         var openFlowId = await resolveFlowId(client, args.flow_id);
         var openSummary = summary();
+
+        // Step 1: Load flow data via processflow GET (same as UI)
         try {
-          // The processflow GET is what the Flow Designer UI calls when opening a flow for editing.
-          // This acquires the editing lock so subsequent GraphQL mutations can work.
           await client.get('/api/now/processflow/flow/' + openFlowId);
-          openSummary.success('Flow opened for editing').field('Flow', openFlowId)
+        } catch (_) { /* best-effort — flow data load is not critical for lock acquisition */ }
+
+        // Step 2: Acquire editing lock via safeEdit create mutation (required for GraphQL mutations)
+        var lockResult = await acquireFlowEditingLock(client, openFlowId);
+        if (lockResult.success) {
+          openSummary.success('Flow opened for editing (lock acquired)').field('Flow', openFlowId)
             .line('You can now use add_action, add_flow_logic, etc. Call close_flow when done.');
           return createSuccessResult({ action: 'open_flow', flow_id: openFlowId, editing_session: true }, {}, openSummary.build());
-        } catch (e: any) {
-          openSummary.error('Failed to open flow for editing: ' + (e.message || 'unknown')).field('Flow', openFlowId);
-          return createErrorResult('Failed to open flow for editing: ' + (e.message || 'unknown'));
+        } else {
+          openSummary.error('Cannot open flow: ' + (lockResult.error || 'lock acquisition failed')).field('Flow', openFlowId);
+          return createErrorResult('Cannot open flow for editing: ' + (lockResult.error || 'lock acquisition failed'));
         }
       }