snow-flow 10.0.1-dev.487 → 10.0.1-dev.489

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-dev.487",
+  "version": "10.0.1-dev.489",
   "name": "snow-flow",
   "description": "Snow-Flow - ServiceNow Multi-Agent Development Framework powered by AI",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -110,6 +110,26 @@ async function executeFlowPatchMutation(
   return resp.data?.data?.global?.snFlowDesigner?.flow || resp.data;
 }
 
+/**
+ * Acquire the Flow Designer editing lock on a flow.
+ * The UI calls safeEdit(create: flowId) when opening the editor.
+ * This must be called before GraphQL mutations on existing flows.
+ */
+async function acquireFlowEditingLock(client: any, flowId: string): Promise<{ success: boolean; error?: string }> {
+  try {
+    var mutation = 'mutation { global { snFlowDesigner { safeEdit(safeEditInput: {create: "' + flowId + '"}) { createResult { canEdit id editingUserDisplayName __typename } __typename } __typename } __typename } }';
+    var resp = await client.post('/api/now/graphql', { variables: {}, query: mutation });
+    var result = resp.data?.data?.global?.snFlowDesigner?.safeEdit?.createResult;
+    if (result?.canEdit === true || result?.canEdit === 'true') {
+      return { success: true };
+    }
+    var editingUser = result?.editingUserDisplayName || 'another user';
+    return { success: false, error: 'Flow is locked by ' + editingUser };
+  } catch (e: any) {
+    return { success: false, error: e.message || 'unknown error' };
+  }
+}
+
 /**
  * Release the Flow Designer editing lock on a flow.
  * The UI calls safeEdit(delete: flowId) when closing the editor.
@@ -1917,6 +1937,27 @@ async function addFlowLogicViaGraphQL(
 ): Promise<{ success: boolean; logicId?: string; uiUniqueIdentifier?: string; steps?: any; error?: string }> {
   const steps: any = {};
 
+  // Normalize common aliases to actual ServiceNow flow logic type values
+  var LOGIC_TYPE_ALIASES: Record<string, string> = {
+    'FOR_EACH': 'FOREACH',
+    'DO_UNTIL': 'DOUNTIL',
+    'ELSE_IF': 'ELSEIF',
+    'SKIP_ITERATION': 'CONTINUE',
+    'EXIT_LOOP': 'BREAK',
+    'GO_BACK_TO': 'GOBACKTO',
+    'DYNAMIC_FLOW': 'DYNAMICFLOW',
+    'END_FLOW': 'END',
+    'GET_FLOW_OUTPUT': 'GETFLOWOUTPUT',
+    'GET_FLOW_OUTPUTS': 'GETFLOWOUTPUT',
+    'SET_FLOW_VARIABLES': 'SETFLOWVARIABLES',
+    'APPEND_FLOW_VARIABLES': 'APPENDFLOWVARIABLES',
+  };
+  var normalizedType = LOGIC_TYPE_ALIASES[logicType.toUpperCase()] || logicType;
+  if (normalizedType !== logicType) {
+    steps.type_normalized = { from: logicType, to: normalizedType };
+    logicType = normalizedType;
+  }
+
   // Dynamically look up flow logic definition in sys_hub_flow_logic_definition
   // Fetch extra fields needed for the flowLogicDefinition object in the mutation
   const defFields = 'sys_id,type,name,description,order,attributes,compilation_class,quiescence,visible,category,connected_to';
@@ -1924,7 +1965,7 @@ async function addFlowLogicViaGraphQL(
   let defName = '';
   let defType = logicType;
   let defRecord: any = {};
-  // Try exact match on type (IF, ELSE, FOR_EACH, DO_UNTIL, SWITCH), then name
+  // Try exact match on type (IF, ELSE, FOREACH, DOUNTIL, etc.), then name
   for (const field of ['type', 'name']) {
     if (defId) break;
     try {
@@ -2597,17 +2638,18 @@ export const toolDefinition: MCPToolDefinition = {
       },
       logic_type: {
         type: 'string',
-        description: 'Flow logic type for add_flow_logic. Looked up dynamically in sys_hub_flow_logic_definition. Available types: ' +
+        description: 'Flow logic type for add_flow_logic. Looked up dynamically in sys_hub_flow_logic_definition. ' +
+          'Common aliases (FOR_EACH, DO_UNTIL, etc.) are auto-normalized to ServiceNow types. Available types: ' +
           'IF, ELSEIF, ELSE — conditional branching. Use ELSEIF (not nested ELSE+IF) for else-if branches. ELSE and ELSEIF require connected_to set to the If block\'s uiUniqueIdentifier. ' +
-          'FOR_EACH, DO_UNTIL — loops. SKIP_ITERATION and EXIT_LOOP can be used inside loops. ' +
+          'FOREACH (or FOR_EACH), DOUNTIL (or DO_UNTIL) — loops. CONTINUE (skip iteration) and BREAK (exit loop) can be used inside loops. ' +
           'PARALLEL — execute branches in parallel. ' +
           'DECISION — switch/decision table. ' +
           'TRY — error handling (try/catch). ' +
           'END — End Flow (stops execution). Always add END as the last element when the flow should terminate cleanly. ' +
           'TIMER — Wait for a duration of time. ' +
-          'GO_BACK_TO — jump back to a previous step. ' +
-          'SET_FLOW_VARIABLES, APPEND_FLOW_VARIABLES, GET_FLOW_OUTPUT — flow variable management. ' +
-          'WORKFLOW — call a legacy workflow. DYNAMIC_FLOW — dynamically invoke a flow. ' +
+          'GOBACKTO (or GO_BACK_TO) — jump back to a previous step. ' +
+          'SETFLOWVARIABLES, APPENDFLOWVARIABLES, GETFLOWOUTPUT — flow variable management. ' +
+          'WORKFLOW — call a legacy workflow. DYNAMICFLOW — dynamically invoke a flow. ' +
           'Best practice: add an END element at the end of your flow for clean termination.'
       },
       logic_inputs: {
@@ -3705,22 +3747,27 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
       }
 
       // ────────────────────────────────────────────────────────────────
-      // OPEN_FLOW — acquire Flow Designer editing lock (processflow GET)
+      // OPEN_FLOW — acquire Flow Designer editing lock (safeEdit create)
       // ────────────────────────────────────────────────────────────────
       case 'open_flow': {
         if (!args.flow_id) throw new SnowFlowError(ErrorType.VALIDATION_ERROR, 'flow_id is required for open_flow');
         var openFlowId = await resolveFlowId(client, args.flow_id);
         var openSummary = summary();
+
+        // Step 1: Load flow data via processflow GET (same as UI)
         try {
-          // The processflow GET is what the Flow Designer UI calls when opening a flow for editing.
-          // This acquires the editing lock so subsequent GraphQL mutations can work.
           await client.get('/api/now/processflow/flow/' + openFlowId);
-          openSummary.success('Flow opened for editing').field('Flow', openFlowId)
+        } catch (_) { /* best-effort — flow data load is not critical for lock acquisition */ }
+
+        // Step 2: Acquire editing lock via safeEdit create mutation (required for GraphQL mutations)
+        var lockResult = await acquireFlowEditingLock(client, openFlowId);
+        if (lockResult.success) {
+          openSummary.success('Flow opened for editing (lock acquired)').field('Flow', openFlowId)
             .line('You can now use add_action, add_flow_logic, etc. Call close_flow when done.');
           return createSuccessResult({ action: 'open_flow', flow_id: openFlowId, editing_session: true }, {}, openSummary.build());
-        } catch (e: any) {
-          openSummary.error('Failed to open flow for editing: ' + (e.message || 'unknown')).field('Flow', openFlowId);
-          return createErrorResult('Failed to open flow for editing: ' + (e.message || 'unknown'));
+        } else {
+          openSummary.error('Cannot open flow: ' + (lockResult.error || 'lock acquisition failed')).field('Flow', openFlowId);
+          return createErrorResult('Cannot open flow for editing: ' + (lockResult.error || 'lock acquisition failed'));
         }
       }