snow-flow 10.0.1-dev.486 → 10.0.1-dev.488

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-dev.486",
+  "version": "10.0.1-dev.488",
   "name": "snow-flow",
   "description": "Snow-Flow - ServiceNow Multi-Agent Development Framework powered by AI",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -1917,6 +1917,27 @@ async function addFlowLogicViaGraphQL(
 ): Promise<{ success: boolean; logicId?: string; uiUniqueIdentifier?: string; steps?: any; error?: string }> {
   const steps: any = {};
 
+  // Normalize common aliases to actual ServiceNow flow logic type values
+  var LOGIC_TYPE_ALIASES: Record<string, string> = {
+    'FOR_EACH': 'FOREACH',
+    'DO_UNTIL': 'DOUNTIL',
+    'ELSE_IF': 'ELSEIF',
+    'SKIP_ITERATION': 'CONTINUE',
+    'EXIT_LOOP': 'BREAK',
+    'GO_BACK_TO': 'GOBACKTO',
+    'DYNAMIC_FLOW': 'DYNAMICFLOW',
+    'END_FLOW': 'END',
+    'GET_FLOW_OUTPUT': 'GETFLOWOUTPUT',
+    'GET_FLOW_OUTPUTS': 'GETFLOWOUTPUT',
+    'SET_FLOW_VARIABLES': 'SETFLOWVARIABLES',
+    'APPEND_FLOW_VARIABLES': 'APPENDFLOWVARIABLES',
+  };
+  var normalizedType = LOGIC_TYPE_ALIASES[logicType.toUpperCase()] || logicType;
+  if (normalizedType !== logicType) {
+    steps.type_normalized = { from: logicType, to: normalizedType };
+    logicType = normalizedType;
+  }
+
   // Dynamically look up flow logic definition in sys_hub_flow_logic_definition
   // Fetch extra fields needed for the flowLogicDefinition object in the mutation
   const defFields = 'sys_id,type,name,description,order,attributes,compilation_class,quiescence,visible,category,connected_to';
@@ -1924,7 +1945,7 @@ async function addFlowLogicViaGraphQL(
   let defName = '';
   let defType = logicType;
   let defRecord: any = {};
-  // Try exact match on type (IF, ELSE, FOR_EACH, DO_UNTIL, SWITCH), then name
+  // Try exact match on type (IF, ELSE, FOREACH, DOUNTIL, etc.), then name
   for (const field of ['type', 'name']) {
     if (defId) break;
     try {
@@ -2506,9 +2527,10 @@ export const toolDefinition: MCPToolDefinition = {
           'add_action', 'update_action', 'delete_action',
           'add_flow_logic', 'update_flow_logic', 'delete_flow_logic',
           'add_subflow', 'update_subflow', 'delete_subflow',
-          'close_flow'
+          'open_flow', 'close_flow'
         ],
-        description: 'Action to perform. add_*/update_*/delete_* for triggers, actions, flow_logic, subflows. update_trigger replaces the trigger type. update_action/update_flow_logic/update_subflow change input values. delete_* removes elements by element_id. IMPORTANT: When making multiple edits to a flow (add_action, add_flow_logic, etc.), call close_flow as the LAST step to release the editing lock. Without close_flow, the flow stays locked and cannot be edited in the UI. create_flow auto-releases the lock.'
+        description: 'Action to perform. EDITING WORKFLOW: create_flow keeps the editing lock open — you can immediately call add_action, add_flow_logic, etc. without open_flow. For editing EXISTING flows: call open_flow first to acquire the lock. Always call close_flow as the LAST step to release the lock so users can edit in the UI. ' +
+          'add_*/update_*/delete_* for triggers, actions, flow_logic, subflows. update_trigger replaces the trigger type. delete_* removes elements by element_id.'
       },
 
       flow_id: {
@@ -2596,17 +2618,18 @@ export const toolDefinition: MCPToolDefinition = {
       },
       logic_type: {
         type: 'string',
-        description: 'Flow logic type for add_flow_logic. Looked up dynamically in sys_hub_flow_logic_definition. Available types: ' +
+        description: 'Flow logic type for add_flow_logic. Looked up dynamically in sys_hub_flow_logic_definition. ' +
+          'Common aliases (FOR_EACH, DO_UNTIL, etc.) are auto-normalized to ServiceNow types. Available types: ' +
           'IF, ELSEIF, ELSE — conditional branching. Use ELSEIF (not nested ELSE+IF) for else-if branches. ELSE and ELSEIF require connected_to set to the If block\'s uiUniqueIdentifier. ' +
-          'FOR_EACH, DO_UNTIL — loops. SKIP_ITERATION and EXIT_LOOP can be used inside loops. ' +
+          'FOREACH (or FOR_EACH), DOUNTIL (or DO_UNTIL) — loops. CONTINUE (skip iteration) and BREAK (exit loop) can be used inside loops. ' +
           'PARALLEL — execute branches in parallel. ' +
           'DECISION — switch/decision table. ' +
           'TRY — error handling (try/catch). ' +
           'END — End Flow (stops execution). Always add END as the last element when the flow should terminate cleanly. ' +
           'TIMER — Wait for a duration of time. ' +
-          'GO_BACK_TO — jump back to a previous step. ' +
-          'SET_FLOW_VARIABLES, APPEND_FLOW_VARIABLES, GET_FLOW_OUTPUT — flow variable management. ' +
-          'WORKFLOW — call a legacy workflow. DYNAMIC_FLOW — dynamically invoke a flow. ' +
+          'GOBACKTO (or GO_BACK_TO) — jump back to a previous step. ' +
+          'SETFLOWVARIABLES, APPENDFLOWVARIABLES, GETFLOWOUTPUT — flow variable management. ' +
+          'WORKFLOW — call a legacy workflow. DYNAMICFLOW — dynamically invoke a flow. ' +
           'Best practice: add an END element at the end of your flow for clean termination.'
       },
       logic_inputs: {
@@ -3094,11 +3117,8 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
           }
         }
 
-        // Release Flow Designer editing lock (safeEdit delete) so users can edit the flow in the UI
-        if (flowSysId) {
-          var lockReleased = await releaseFlowEditingLock(client, flowSysId);
-          diagnostics.editing_lock_released = lockReleased;
-        }
+        // NOTE: Do NOT release the editing lock here. The agent may need to add more elements
+        // (flow logic, actions, etc.) after creation. The agent must call close_flow when done.
 
         return createSuccessResult({
           created: true,
@@ -3706,6 +3726,26 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
           : createErrorResult(delResult.error || 'Failed to delete element');
       }
 
+      // ────────────────────────────────────────────────────────────────
+      // OPEN_FLOW — acquire Flow Designer editing lock (processflow GET)
+      // ────────────────────────────────────────────────────────────────
+      case 'open_flow': {
+        if (!args.flow_id) throw new SnowFlowError(ErrorType.VALIDATION_ERROR, 'flow_id is required for open_flow');
+        var openFlowId = await resolveFlowId(client, args.flow_id);
+        var openSummary = summary();
+        try {
+          // The processflow GET is what the Flow Designer UI calls when opening a flow for editing.
+          // This acquires the editing lock so subsequent GraphQL mutations can work.
+          await client.get('/api/now/processflow/flow/' + openFlowId);
+          openSummary.success('Flow opened for editing').field('Flow', openFlowId)
+            .line('You can now use add_action, add_flow_logic, etc. Call close_flow when done.');
+          return createSuccessResult({ action: 'open_flow', flow_id: openFlowId, editing_session: true }, {}, openSummary.build());
+        } catch (e: any) {
+          openSummary.error('Failed to open flow for editing: ' + (e.message || 'unknown')).field('Flow', openFlowId);
+          return createErrorResult('Failed to open flow for editing: ' + (e.message || 'unknown'));
+        }
+      }
+
       // ────────────────────────────────────────────────────────────────
       // CLOSE_FLOW — release Flow Designer editing lock (safeEdit)
       // ────────────────────────────────────────────────────────────────