snow-flow 10.0.1-dev.478 → 10.0.1-dev.480

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-dev.478",
+  "version": "10.0.1-dev.480",
   "name": "snow-flow",
   "description": "Snow-Flow - ServiceNow Multi-Agent Development Framework powered by AI",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -1512,17 +1512,16 @@ async function buildConditionLabelCache(
   tableLabel: string,
   logicUiId: string,
   explicitFields?: string[]
-): Promise<{ inserts: any[]; updates: any[] }> {
-  var empty = { inserts: [], updates: [] };
-  if (!dataPillBase) return empty;
+): Promise<any[]> {
+  if (!dataPillBase) return [];
 
   // Collect unique field names — either from explicit list or by parsing encoded query
   if (!explicitFields) {
     var clauses = parseEncodedQuery(conditionValue);
-    if (clauses.length === 0) return empty;
+    if (clauses.length === 0) return [];
     explicitFields = clauses.map(function (c) { return c.field; }).filter(function (f) { return !!f; });
   }
-  if (explicitFields.length === 0) return empty;
+  if (explicitFields.length === 0) return [];
 
   // De-duplicate field names
   var uniqueFields: string[] = [];
@@ -1536,51 +1535,16 @@ async function buildConditionLabelCache(
   }
   if (uniqueFields.length === 0) return [];
 
-  // Batch-query sys_dictionary for field metadata (type, label)
-  var fieldMeta: Record<string, { type: string; label: string }> = {};
-  try {
-    var dictResp = await client.get('/api/now/table/sys_dictionary', {
-      params: {
-        sysparm_query: 'name=' + table + '^elementIN' + uniqueFields.join(','),
-        sysparm_fields: 'element,column_label,internal_type',
-        sysparm_display_value: 'false',
-        sysparm_limit: uniqueFields.length + 5
-      }
-    });
-    var dictResults = dictResp.data.result || [];
-    for (var d = 0; d < dictResults.length; d++) {
-      var rec = dictResults[d];
-      var elName = str(rec.element);
-      var intType = str(rec.internal_type?.value || rec.internal_type || 'string');
-      var colLabel = str(rec.column_label);
-      if (elName) fieldMeta[elName] = { type: intType, label: colLabel };
-    }
-  } catch (_) {
-    // Fallback: use "string" type and generated labels if dictionary lookup fails
-  }
-
-  // Build labelCache entries for condition pills, split into INSERT and UPDATE:
-  // - INSERT: record-level pill (must exist for actions; format from processflow XML)
-  // - UPDATE: field-level pills (minimal: name + usedInstances — matching the UI's exact mutation format)
+  // Build labelCache UPDATE entries for condition pills.
+  // Matches the UI's exact mutation format (from if-statement-update.txt):
+  //   labelCache: { update: [{ name: "Created or Updated_1.current.category", usedInstances: [...] }] }
   //
-  // The UI uses labelCache.update for condition pills (captured mutation shows only name + usedInstances).
-  // The record-level pill is INSERTed to ensure it exists (our trigger is created via code, not UI).
-  var inserts: any[] = [];
+  // The record-level pill (e.g. "Created or Updated_1.current") is NOT included here because:
+  // - The ServiceNow backend automatically creates it when the trigger is saved (INSERT → UPDATE)
+  // - Sending a duplicate labelCache.insert for it can cause the entire labelCache block to fail
+  // - The UI's condition mutation never sends a record-level pill insert (confirmed via network capture)
   var updates: any[] = [];
 
-  // Record-level pill entry → INSERT with full metadata (processflow XML format)
-  inserts.push({
-    name: dataPillBase,
-    label: 'Trigger - Record ' + triggerName + '\u279b' + tableLabel + ' Record',
-    reference: table,
-    reference_display: tableLabel,
-    type: 'reference',
-    base_type: 'reference',
-    attributes: {},
-    usedInstances: []
-  });
-
-  // Field-level pill entries → UPDATE with minimal fields (matching UI mutation)
   for (var j = 0; j < uniqueFields.length; j++) {
     var f = uniqueFields[j];
     var pillName = dataPillBase + '.' + f;
@@ -1591,7 +1555,7 @@ async function buildConditionLabelCache(
     });
   }
 
-  return { inserts, updates };
+  return updates;
 }
 
 // ── DATA PILL SUPPORT FOR RECORD ACTIONS (Update/Create Record) ──────
@@ -1922,6 +1886,29 @@ async function addFlowLogicViaGraphQL(
   var needsConditionUpdate = false;
   var conditionTriggerInfo: any = null;
 
+  // Pre-process: detect JS-style dot notation conditions and convert to shorthand pill format.
+  // Users may write conditions like:
+  //   "trigger.current.category = software"      (single =)
+  //   "trigger.current.category == 'software'"   (JS equality)
+  //   "current.priority = 1"                     (short prefix)
+  // These are converted to pill shorthand format that the existing logic can handle:
+  //   "{{trigger.current.category}}=software"
+  var DOT_NOTATION_RE = /((?:trigger\.)?current)\.(\w+)\s*(===?|!==?|>=|<=|>|<|=)\s*(?:'([^']*)'|"([^"]*)"|(\S+))/g;
+  if (DOT_NOTATION_RE.test(rawCondition)) {
+    DOT_NOTATION_RE.lastIndex = 0;
+    var dotOriginal = rawCondition;
+    rawCondition = rawCondition.replace(DOT_NOTATION_RE, function (_m: string, prefix: string, field: string, op: string, qv1: string, qv2: string, uv: string) {
+      var snOp = op;
+      if (op === '==' || op === '===') snOp = '=';
+      else if (op === '!=' || op === '!==') snOp = '!=';
+      var val = qv1 !== undefined ? qv1 : (qv2 !== undefined ? qv2 : uv);
+      return '{{' + prefix + '.' + field + '}}' + snOp + val;
+    });
+    // Replace JS && with ServiceNow ^ (AND separator)
+    rawCondition = rawCondition.replace(/\s*&&\s*/g, '^');
+    steps.dot_notation_rewrite = { original: dotOriginal, rewritten: rawCondition };
+  }
+
   // Shorthand patterns that need rewriting to the real data pill base
   // e.g. {{trigger.current.category}} → {{Created or Updated_1.current.category}}
   var PILL_SHORTHANDS = ['trigger.current', 'current', 'trigger_record', 'trigger.record'];
@@ -2042,19 +2029,15 @@ async function addFlowLogicViaGraphQL(
       }
 
       steps.condition_transform = { original: rawCondition, transformed: transformedCondition };
-      steps.label_cache = {
-        inserts: labelCacheResult.inserts.map(function (e: any) { return e.name; }),
-        updates: labelCacheResult.updates.map(function (e: any) { return e.name; })
-      };
+      steps.label_cache = labelCacheResult.map(function (e: any) { return e.name; });
 
       try {
-        // Match the UI's exact format for condition UPDATE (from captured network tab mutation):
+        // Match the UI's exact format for condition UPDATE (from if-statement-update.txt):
+        // - labelCache.update: field-level pills with minimal name + usedInstances
+        // - NO labelCache.insert (record-level pill is auto-created by backend during trigger save)
         // - condition input: only name + value (NO displayValue, NO flowLogicDefinition)
-        // - labelCache.insert: record-level pill with full metadata (ensures it exists)
-        // - labelCache.update: field-level pills with minimal name + usedInstances (matching UI)
         var updatePatch: any = {
           flowId: flowId,
-          labelCache: {} as any,
           flowLogics: {
             update: [{
               uiUniqueIdentifier: returnedUuid,
@@ -2066,11 +2049,8 @@ async function addFlowLogicViaGraphQL(
             }]
           }
         };
-        if (labelCacheResult.inserts.length > 0) {
-          updatePatch.labelCache.insert = labelCacheResult.inserts;
-        }
-        if (labelCacheResult.updates.length > 0) {
-          updatePatch.labelCache.update = labelCacheResult.updates;
+        if (labelCacheResult.length > 0) {
+          updatePatch.labelCache = { update: labelCacheResult };
         }
         // Log the exact GraphQL mutation for debugging
         steps.condition_update_mutation = jsToGraphQL(updatePatch);