snow-flow 10.0.1-dev.464 → 10.0.1-dev.466

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-dev.464",
+  "version": "10.0.1-dev.466",
   "name": "snow-flow",
   "description": "Snow-Flow - ServiceNow Multi-Agent Development Framework powered by AI",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -141,7 +141,7 @@ async function buildActionInputsForInsert(
       }
       var match = actionParams.find(function (p: any) {
         var el = str(p.element);
-        return el.endsWith('_' + key) || el === key || str(p.label).toLowerCase() === key.toLowerCase();
+        return el.endsWith('_' + key) || el.startsWith(key + '_') || el === key || str(p.label).toLowerCase() === key.toLowerCase();
       });
       if (match) resolvedInputs[str(match.element)] = value;
       else resolvedInputs[key] = value;
@@ -1001,6 +1001,15 @@ async function addActionViaGraphQL(
   steps.insert_order = resolvedOrder;
 
   const uuid = generateUUID();
+
+  // ── Data pill transformation for record actions (Update/Create Record) ──
+  // These actions need: record → data pill, table_name → displayValue, field values → packed into values string
+  var recordActionResult = await transformActionInputsForRecordAction(
+    client, flowId, inputResult.inputs, inputResult.resolvedInputs,
+    inputResult.actionParams, uuid
+  );
+  steps.record_action = recordActionResult.steps;
+
   const actionResponseFields = 'actions { inserts { sysId uiUniqueIdentifier __typename } updates deletes __typename }' +
     ' flowLogics { inserts { sysId uiUniqueIdentifier __typename } updates deletes __typename }' +
     ' subflows { inserts { sysId uiUniqueIdentifier __typename } updates deletes __typename }';
@@ -1019,11 +1028,16 @@ async function addActionViaGraphQL(
         uiUniqueIdentifier: uuid,
         type: 'action',
         parentUiId: parentUiId || '',
-        inputs: inputResult.inputs
+        inputs: recordActionResult.inputs
       }]
     }
   };
 
+  // Add labelCache entries for data pill references in record actions
+  if (recordActionResult.labelCacheEntries.length > 0) {
+    flowPatch.labelCache = { insert: recordActionResult.labelCacheEntries };
+  }
+
   // Add parent flow logic update signal (tells GraphQL the parent was modified)
   if (parentUiId) {
     flowPatch.flowLogics = { update: [{ uiUniqueIdentifier: parentUiId, type: 'flowlogic' }] };
@@ -1196,94 +1210,251 @@ function parseEncodedQuery(query: string): { prefix: string; field: string; oper
 }
 
 /**
- * Transform an encoded query condition value to use data pill references.
- * Replaces field names with {{dataPillBase.fieldName}} syntax.
+ * Check if a condition value looks like a standard ServiceNow encoded query.
+ * Standard encoded queries use: field_name=value^field_name2!=value2
+ *
+ * Returns false for JavaScript expressions, scripts, fd_data references, etc.
+ * which should be passed through as-is without data pill transformation.
+ */
+function isStandardEncodedQuery(condition: string): boolean {
+  if (!condition) return false;
+  // Parentheses indicate function calls or grouping expressions
+  if (/[()]/.test(condition)) return false;
+  // Method calls like .toString(, .replace(, .match(
+  if (/\.\w+\(/.test(condition)) return false;
+  // Regex patterns like /[
+  if (/\/\[/.test(condition)) return false;
+  // JS equality operators == or ===
+  if (/===?/.test(condition)) return false;
+  // JS modulo, logical AND/OR
+  if (/%/.test(condition)) return false;
+  if (/&&|\|\|/.test(condition)) return false;
+  // Flow Designer internal variable references
+  if (condition.startsWith('fd_data.')) return false;
+  // Already contains data pill references (already transformed)
+  if (condition.includes('{{')) return false;
+  return true;
+}
+
+/**
+ * Transform an encoded query condition into Flow Designer data pill format.
  *
- * Example: "category=inquiry" → "{{Created or Updated_1.current.category}}=inquiry"
+ * The UI format uses a record-level data pill prepended to the encoded query:
+ *   "category=inquiry" → "{{Created or Updated_1.current}}category=inquiry"
+ *
+ * The record pill tells Flow Designer which record/table the condition applies to.
+ * The encoded query after the pill is the actual filter.
  */
 function transformConditionToDataPills(conditionValue: string, dataPillBase: string): string {
   if (!conditionValue || !dataPillBase) return conditionValue;
-
-  var clauses = parseEncodedQuery(conditionValue);
-  if (clauses.length === 0) return conditionValue;
-
-  var result = '';
-  for (var i = 0; i < clauses.length; i++) {
-    var clause = clauses[i];
-    result += clause.prefix;
-    result += '{{' + dataPillBase + '.' + clause.field + '}}';
-    result += clause.operator;
-    result += clause.value;
-  }
-
-  return result;
+  // Prepend the record-level data pill to the encoded query
+  return '{{' + dataPillBase + '}}' + conditionValue;
 }
 
 /**
- * Build labelCache entries for data pills used in flow logic conditions.
- * Each unique data pill reference needs a labelCache entry so the Flow Designer UI
- * can display the data pill label correctly.
+ * Build a single record-level labelCache entry for the data pill used in a condition.
+ * The UI registers the record pill with the condition input, matching the captured format:
  *
- * The entry format matches the captured UI mutation format.
+ * { name: "Created or Updated_1.current",
+ *   label: "Trigger - Record Created or Updated➛Incident Record",
+ *   reference: "incident", type: "reference", base_type: "reference",
+ *   usedInstances: [{ uiUniqueIdentifier, inputName: "condition" }] }
  */
 function buildConditionLabelCache(
-  conditionValue: string,
   dataPillBase: string,
   triggerName: string,
   table: string,
   tableLabel: string,
   logicUiId: string
 ): any[] {
-  if (!conditionValue || !dataPillBase) return [];
+  if (!dataPillBase) return [];
+
+  return [{
+    name: dataPillBase,
+    label: 'Trigger - Record ' + triggerName + '\u27a1' + tableLabel + ' Record',
+    reference: table,
+    reference_display: tableLabel,
+    type: 'reference',
+    base_type: 'reference',
+    attributes: '',
+    usedInstances: [{ uiUniqueIdentifier: logicUiId, inputName: 'condition' }],
+    choices: {}
+  }];
+}
 
-  var clauses = parseEncodedQuery(conditionValue);
-  if (clauses.length === 0) return [];
+// ── DATA PILL SUPPORT FOR RECORD ACTIONS (Update/Create Record) ──────
 
-  // Build a label cache entry for each unique field-level data pill
-  var seen: Record<string, boolean> = {};
-  var entries: any[] = [];
+/** Shorthands that users can pass for `record` to mean "the trigger's current record". */
+const RECORD_PILL_SHORTHANDS = ['current', 'trigger.current', 'trigger_record', 'trigger record'];
 
-  // Also register the record-level data pill (the base: TriggerName_1.current)
-  // This is needed for the condition builder to understand the context
-  if (!seen[dataPillBase]) {
-    seen[dataPillBase] = true;
-    entries.push({
+/**
+ * Post-process action inputs for record-modifying actions (Update Record, Create Record).
+ *
+ * These actions have 3 key inputs:
+ * - `record`: reference to the record → needs data pill format {{TriggerName_1.current}}
+ * - `table_name`: target table → needs displayValue (e.g. "Incident")
+ * - `values`: packed field=value pairs → e.g. "priority=2^state=3"
+ *
+ * User-provided field-value pairs that don't match defined action parameters are
+ * automatically packed into the `values` string.
+ *
+ * Returns the transformed inputs and labelCache entries.
+ */
+async function transformActionInputsForRecordAction(
+  client: any,
+  flowId: string,
+  actionInputs: any[],
+  resolvedInputs: Record<string, string>,
+  actionParams: any[],
+  uuid: string
+): Promise<{ inputs: any[]; labelCacheEntries: any[]; steps: any }> {
+  var steps: any = {};
+
+  // Detect if this is a record action: must have both `record` and `table_name` parameters
+  var definedParamNames = actionParams.map(function (p: any) { return str(p.element); });
+  var hasRecord = definedParamNames.includes('record');
+  var hasTableName = definedParamNames.includes('table_name');
+  var hasValues = definedParamNames.includes('values');
+
+  if (!hasRecord || !hasTableName) {
+    steps.record_action = false;
+    return { inputs: actionInputs, labelCacheEntries: [], steps };
+  }
+  steps.record_action = true;
+
+  // Get trigger info for data pill construction
+  var triggerInfo = await getFlowTriggerInfo(client, flowId);
+  steps.trigger_info = {
+    dataPillBase: triggerInfo.dataPillBase,
+    triggerName: triggerInfo.triggerName,
+    table: triggerInfo.table,
+    tableLabel: triggerInfo.tableLabel,
+    error: triggerInfo.error
+  };
+
+  var dataPillBase = triggerInfo.dataPillBase; // e.g. "Created or Updated_1.current"
+  var labelCacheEntries: any[] = [];
+  var usedInstances: { uiUniqueIdentifier: string; inputName: string }[] = [];
+
+  // ── 1. Transform `record` input to data pill ──────────────────────
+  var recordInput = actionInputs.find(function (inp: any) { return inp.name === 'record'; });
+  if (recordInput && dataPillBase) {
+    var recordVal = recordInput.value?.value || '';
+    var isShorthand = RECORD_PILL_SHORTHANDS.includes(recordVal.toLowerCase());
+    var isAlreadyPill = recordVal.startsWith('{{');
+
+    if (isShorthand || !recordVal) {
+      // Auto-fill with trigger's current record data pill
+      recordInput.value = { schemaless: false, schemalessValue: '', value: '{{' + dataPillBase + '}}' };
+      usedInstances.push({ uiUniqueIdentifier: uuid, inputName: 'record' });
+      steps.record_transform = { original: recordVal, pill: '{{' + dataPillBase + '}}' };
+    } else if (isAlreadyPill) {
+      usedInstances.push({ uiUniqueIdentifier: uuid, inputName: 'record' });
+    }
+  }
+
+  // ── 2. Transform `table_name` input with displayValue ─────────────
+  var tableNameInput = actionInputs.find(function (inp: any) { return inp.name === 'table_name'; });
+  if (tableNameInput) {
+    var tableVal = tableNameInput.value?.value || '';
+    // Also accept `table` as user key (maps to table_name)
+    if (!tableVal && resolvedInputs['table']) {
+      tableVal = resolvedInputs['table'];
+    }
+    // If still empty, use trigger's table
+    if (!tableVal && triggerInfo.table) {
+      tableVal = triggerInfo.table;
+    }
+    if (tableVal) {
+      // Look up display name for the table
+      var tableDisplayName = triggerInfo.tableLabel || '';
+      if (tableVal !== triggerInfo.table || !tableDisplayName) {
+        // Different table than trigger — look up its label
+        try {
+          var tblResp = await client.get('/api/now/table/sys_db_object', {
+            params: { sysparm_query: 'name=' + tableVal, sysparm_fields: 'label', sysparm_display_value: 'true', sysparm_limit: 1 }
+          });
+          tableDisplayName = str(tblResp.data.result?.[0]?.label) || tableVal.charAt(0).toUpperCase() + tableVal.slice(1).replace(/_/g, ' ');
+        } catch (_) {
+          tableDisplayName = tableVal.charAt(0).toUpperCase() + tableVal.slice(1).replace(/_/g, ' ');
+        }
+      }
+      tableNameInput.value = { schemaless: false, schemalessValue: '', value: tableVal };
+      tableNameInput.displayValue = { schemaless: false, schemalessValue: '', value: tableDisplayName };
+      steps.table_name_transform = { value: tableVal, displayValue: tableDisplayName };
+    }
+  }
+
+  // ── 3. Pack non-parameter field values into `values` string ───────
+  // Any user-provided key that is NOT a defined action parameter goes into the values string
+  var valuesInput = actionInputs.find(function (inp: any) { return inp.name === 'values'; });
+  if (valuesInput) {
+    var fieldPairs: string[] = [];
+    var existingValues = valuesInput.value?.value || '';
+
+    // If user already passed a pre-built values string, use it
+    if (existingValues && existingValues.includes('=')) {
+      fieldPairs.push(existingValues);
+    }
+
+    // Find user-provided keys that are not defined action parameters
+    for (var key of Object.keys(resolvedInputs)) {
+      if (definedParamNames.includes(key)) continue;
+      // Also skip table (alias for table_name) and record
+      if (key === 'table' || key === 'record') continue;
+
+      var val = resolvedInputs[key];
+
+      // Check if value should be a data pill reference
+      if (val && dataPillBase) {
+        var valLower = val.toLowerCase();
+        if (RECORD_PILL_SHORTHANDS.includes(valLower)) {
+          // Shorthand → record-level data pill
+          val = '{{' + dataPillBase + '}}';
+          usedInstances.push({ uiUniqueIdentifier: uuid, inputName: key });
+        } else if (valLower.startsWith('trigger.current.') || valLower.startsWith('current.')) {
+          // Field-level data pill: "trigger.current.assigned_to" → {{dataPillBase.assigned_to}}
+          var fieldName = valLower.startsWith('trigger.current.') ? val.substring(16) : val.substring(8);
+          val = '{{' + dataPillBase + '.' + fieldName + '}}';
+          usedInstances.push({ uiUniqueIdentifier: uuid, inputName: key });
+        } else if (val.startsWith('{{')) {
+          // Already a data pill
+          usedInstances.push({ uiUniqueIdentifier: uuid, inputName: key });
+        }
+      }
+
+      fieldPairs.push(key + '=' + val);
+    }
+
+    if (fieldPairs.length > 0) {
+      var packedValues = fieldPairs.join('^');
+      valuesInput.value = { schemaless: false, schemalessValue: '', value: packedValues };
+      steps.values_transform = { packed: packedValues, fieldCount: fieldPairs.length };
+    }
+  }
+
+  // ── 4. Build labelCache entries for data pills ────────────────────
+  if (dataPillBase && usedInstances.length > 0) {
+    var tableRef = triggerInfo.tableRef || triggerInfo.table || '';
+    var tableLabel = triggerInfo.tableLabel || '';
+
+    // Record-level data pill entry
+    labelCacheEntries.push({
       name: dataPillBase,
-      label: 'Trigger - Record ' + triggerName + '\u27a1' + tableLabel + ' Record',
-      reference: table,
+      label: 'Trigger - Record ' + triggerInfo.triggerName + '\u27a1' + tableLabel + ' Record',
+      reference: tableRef,
       reference_display: tableLabel,
       type: 'reference',
       base_type: 'reference',
       attributes: '',
-      usedInstances: [{ uiUniqueIdentifier: logicUiId, inputName: 'condition' }],
+      usedInstances: usedInstances,
       choices: {}
     });
-  }
 
-  for (var i = 0; i < clauses.length; i++) {
-    var field = clauses[i].field;
-    if (!field) continue;
-    var pillName = dataPillBase + '.' + field;
-    if (seen[pillName]) continue;
-    seen[pillName] = true;
-
-    // Capitalize field name for label
-    var fieldLabel = field.replace(/_/g, ' ').replace(/\b\w/g, function (c: string) { return c.toUpperCase(); });
-
-    entries.push({
-      name: pillName,
-      label: 'Trigger - Record ' + triggerName + '\u27a1' + tableLabel + ' Record\u27a1' + fieldLabel,
-      reference: '',
-      reference_display: '',
-      type: 'string',
-      base_type: 'string',
-      attributes: '',
-      usedInstances: [{ uiUniqueIdentifier: logicUiId, inputName: 'condition' }],
-      choices: {}
-    });
+    steps.label_cache = { count: labelCacheEntries.length, pills: [dataPillBase], usedInstances: usedInstances.length };
   }
 
-  return entries;
+  return { inputs: actionInputs, labelCacheEntries, steps };
 }
 
 // ── FLOW LOGIC (If/Else, For Each, etc.) ─────────────────────────────
@@ -1358,31 +1529,32 @@ async function addFlowLogicViaGraphQL(
   steps.resolved_inputs = inputResult.resolvedInputs;
   steps.input_query_stats = { defParamsFound: inputResult.defParamsCount, inputsBuilt: inputResult.inputs.length, error: inputResult.inputQueryError };
 
-  // ── Data pill transformation for condition inputs ───────────────────
-  // Flow Designer conditions require data pill references ({{TriggerName_1.current.field}})
-  // instead of bare field names. Transform encoded query conditions and build labelCache.
+  // ── Detect condition that needs data pill transformation ────────────
+  // Flow Designer sets conditions via a SEPARATE UPDATE after the element is created.
+  // The condition format uses record-level data pill: {{TriggerName_1.current}}encodedQuery
+  // Non-standard conditions (JS expressions, fd_data refs) are passed through as-is.
   const uuid = generateUUID();
-  var labelCacheEntries: any[] = [];
-
   var conditionInput = inputResult.inputs.find(function (inp: any) { return inp.name === 'condition'; });
   var rawCondition = conditionInput?.value?.value || '';
-  if (rawCondition && rawCondition !== '^EQ') {
-    var triggerInfo = await getFlowTriggerInfo(client, flowId);
-    steps.trigger_info = { dataPillBase: triggerInfo.dataPillBase, triggerName: triggerInfo.triggerName, table: triggerInfo.table, tableLabel: triggerInfo.tableLabel, error: triggerInfo.error };
-
-    if (triggerInfo.dataPillBase) {
-      // Transform condition value: "category=inquiry" → "{{Created or Updated_1.current.category}}=inquiry"
-      var transformedCondition = transformConditionToDataPills(rawCondition, triggerInfo.dataPillBase);
-      conditionInput.value = { schemaless: false, schemalessValue: '', value: transformedCondition };
-      steps.condition_transform = { original: rawCondition, transformed: transformedCondition };
-
-      // Build labelCache entries for each data pill used in the condition
-      labelCacheEntries = buildConditionLabelCache(
-        rawCondition, triggerInfo.dataPillBase, triggerInfo.triggerName,
-        triggerInfo.tableRef, triggerInfo.tableLabel, uuid
-      );
-      steps.label_cache = { count: labelCacheEntries.length, pills: labelCacheEntries.map(function (e: any) { return e.name; }) };
+  var needsConditionUpdate = false;
+  var conditionTriggerInfo: any = null;
+
+  if (rawCondition && rawCondition !== '^EQ' && isStandardEncodedQuery(rawCondition)) {
+    conditionTriggerInfo = await getFlowTriggerInfo(client, flowId);
+    steps.trigger_info = {
+      dataPillBase: conditionTriggerInfo.dataPillBase, triggerName: conditionTriggerInfo.triggerName,
+      table: conditionTriggerInfo.table, tableLabel: conditionTriggerInfo.tableLabel, error: conditionTriggerInfo.error
+    };
+    if (conditionTriggerInfo.dataPillBase) {
+      needsConditionUpdate = true;
+      // Clear condition in INSERT — it will be set via separate UPDATE with labelCache
+      conditionInput.value = { schemaless: false, schemalessValue: '', value: '' };
+      steps.condition_strategy = 'two_step';
     }
+  } else if (rawCondition && rawCondition !== '^EQ') {
+    // Non-standard condition (JS expression, fd_data ref, etc.) — pass through as-is
+    steps.condition_strategy = 'passthrough';
+    steps.condition_not_encoded_query = true;
   }
 
   // Calculate insertion order
@@ -1419,23 +1591,55 @@ async function addFlowLogicViaGraphQL(
     }
   };
 
-  // Add labelCache entries for data pill references in conditions
-  if (labelCacheEntries.length > 0) {
-    flowPatch.labelCache = { insert: labelCacheEntries };
-  }
-
   // Add parent flow logic update signal (tells GraphQL the parent was modified)
   if (parentUiId) {
     flowPatch.flowLogics.update = [{ uiUniqueIdentifier: parentUiId, type: 'flowlogic' }];
   }
 
   try {
+    // Step 1: INSERT the flow logic element (with empty condition if data pill transform is needed)
     const result = await executeFlowPatchMutation(client, flowPatch, logicResponseFields);
     const logicId = result?.flowLogics?.inserts?.[0]?.sysId;
     const returnedUuid = result?.flowLogics?.inserts?.[0]?.uiUniqueIdentifier || uuid;
     steps.insert = { success: !!logicId, logicId, uuid: returnedUuid };
     if (!logicId) return { success: false, steps, error: 'GraphQL flow logic INSERT returned no ID' };
 
+    // Step 2: UPDATE condition with data pill + labelCache (separate mutation, matching UI behavior)
+    // The Flow Designer UI always sets conditions in a separate UPDATE after creating the element.
+    if (needsConditionUpdate && conditionTriggerInfo) {
+      var dataPillBase = conditionTriggerInfo.dataPillBase;
+      var transformedCondition = transformConditionToDataPills(rawCondition, dataPillBase);
+      var labelCacheEntries = buildConditionLabelCache(
+        dataPillBase, conditionTriggerInfo.triggerName,
+        conditionTriggerInfo.tableRef, conditionTriggerInfo.tableLabel, returnedUuid
+      );
+
+      steps.condition_transform = { original: rawCondition, transformed: transformedCondition };
+      steps.label_cache = { count: labelCacheEntries.length, pills: labelCacheEntries.map(function (e: any) { return e.name; }) };
+
+      try {
+        var updatePatch: any = {
+          flowId: flowId,
+          labelCache: { insert: labelCacheEntries },
+          flowLogics: {
+            update: [{
+              uiUniqueIdentifier: returnedUuid,
+              type: 'flowlogic',
+              inputs: [{
+                name: 'condition',
+                value: { schemaless: false, schemalessValue: '', value: transformedCondition }
+              }]
+            }]
+          }
+        };
+        await executeFlowPatchMutation(client, updatePatch, logicResponseFields);
+        steps.condition_update = { success: true };
+      } catch (ue: any) {
+        steps.condition_update = { success: false, error: ue.message };
+        // Element was created successfully — condition update failure is non-fatal
+      }
+    }
+
     return { success: true, logicId, uiUniqueIdentifier: returnedUuid, steps };
   } catch (e: any) {
     steps.insert = { success: false, error: e.message };