snow-flow 10.0.1-dev.412 → 10.0.1-dev.414

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-dev.412",
+  "version": "10.0.1-dev.414",
   "name": "snow-flow",
   "description": "Snow-Flow - ServiceNow Multi-Agent Development Framework powered by AI",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -124,11 +124,11 @@ async function createFlowViaScheduledJob(
     "    } catch(t1e) { r.steps.tier1 = { success: false, error: t1e.getMessage ? t1e.getMessage() : t1e + '' }; }",
     "",
     // ── TIER 2: GlideRecord ──
-    // Reference flow analysis shows:
-    //   - flow_definition on flow record = null (working flows don't have it)
-    //   - latest_snapshot = 32-char sys_id (reference, NOT JSON!)
-    //   - latest_version = null (normal on this instance)
-    // So: DON'T set flow_definition on flow, set latest_snapshot = version sys_id.
+    // Reference flow analysis:
+    //   - latest_snapshot points to sys_hub_flow_snapshot (NOT version, NOT JSON)
+    //   - flow_definition on flow record = null
+    //   - latest_version = null (normal)
+    // Pipeline: flow → version → snapshot → set latest_snapshot on flow
     "    if (!flowSysId) {",
     "      try {",
     "        var f = new GlideRecord('sys_hub_flow');",
@@ -138,11 +138,10 @@ async function createFlowViaScheduledJob(
     "        f.setValue('run_as', runAs); f.setValue('active', false);",
     "        f.setValue('status', 'draft'); f.setValue('validated', true);",
     "        f.setValue('type', isSubflow ? 'subflow' : 'flow');",
-    // Do NOT set flow_definition (null on working flows)
-    // Do NOT set latest_snapshot yet (set after version insert — it's a sys_id ref)
     "        flowSysId = f.insert();",
     "        r.steps.flow_insert = { success: !!flowSysId, sys_id: flowSysId + '' };",
     "        if (flowSysId) {",
+    // Version record
     "          var v = new GlideRecord('sys_hub_flow_version');",
     "          v.initialize();",
     "          v.setValue('flow', flowSysId); v.setValue('name', '1.0');",
@@ -153,16 +152,35 @@ async function createFlowViaScheduledJob(
     "          verSysId = v.insert();",
     "          r.steps.version_insert = { success: !!verSysId, sys_id: verSysId + '' };",
     "",
-    // Set latest_snapshot on flow record to version sys_id (reference field, not JSON)
-    "          if (verSysId) {",
+    // Create snapshot in sys_hub_flow_snapshot (this is what latest_snapshot points to!)
+    "          var snapId = null;",
+    "          try {",
+    "            var snap = new GlideRecord('sys_hub_flow_snapshot');",
+    "            if (snap.isValid()) {",
+    "              snap.initialize();",
+    "              snap.setValue('name', flowName);",
+    // Try setting common fields — some may not exist, that's OK
+    "              try { snap.setValue('flow', flowSysId); } catch(e) {}",
+    "              try { snap.setValue('version', verSysId); } catch(e) {}",
+    "              try { snap.setValue('state', 'draft'); } catch(e) {}",
+    "              try { snap.setValue('active', true); } catch(e) {}",
+    "              if (flowDefStr) { try { snap.setValue('flow_definition', flowDefStr); } catch(e) {} }",
+    "              snapId = snap.insert();",
+    "              r.steps.snapshot_insert = { success: !!snapId, sys_id: snapId + '' };",
+    "            } else { r.steps.snapshot_insert = { success: false, error: 'table not valid' }; }",
+    "          } catch(snapE) { r.steps.snapshot_insert = { success: false, error: snapE.getMessage ? snapE.getMessage() : snapE + '' }; }",
+    "",
+    // Set latest_snapshot on flow to point to the snapshot record
+    "          var snapshotRef = snapId || verSysId;",
+    "          if (snapshotRef) {",
     "            try {",
     "              var flowUpd = new GlideRecord('sys_hub_flow');",
     "              if (flowUpd.get(flowSysId)) {",
-    "                flowUpd.setValue('latest_snapshot', verSysId);",
+    "                flowUpd.setValue('latest_snapshot', snapshotRef);",
     "                flowUpd.update();",
-    "                r.steps.latest_snapshot_set = verSysId + '';",
+    "                r.steps.latest_snapshot_set = { value: snapshotRef + '', source: snapId ? 'snapshot' : 'version' };",
     "              }",
-    "            } catch(lsE) { r.steps.latest_snapshot_set = 'error:' + (lsE.getMessage ? lsE.getMessage() : lsE + ''); }",
+    "            } catch(lsE) { r.steps.latest_snapshot_set = { error: lsE.getMessage ? lsE.getMessage() : lsE + '' }; }",
     "          }",
     "          r.tier_used = 'gliderecord_scheduled'; r.success = true;",
     "        }",
@@ -273,7 +291,7 @@ async function createFlowViaScheduledJob(
     "      }",
     "      r.steps.variables = { success: true, created: varsCreated };",
     "",
-    // ── Reference: query an existing published flow to see what it looks like ──
+    // ── Reference: deep-inspect a published flow to find what latest_snapshot points to ──
     "      r.steps.reference_flow = null;",
     "      try {",
     "        var refGr = new GlideRecord('sys_hub_flow');",
@@ -282,83 +300,63 @@ async function createFlowViaScheduledJob(
     "        refGr.setLimit(1); refGr.query();",
     "        if (refGr.next()) {",
     "          var refId = refGr.getUniqueValue();",
-    "          var refFd = refGr.getValue('flow_definition') + '';",
     "          var refLs = refGr.getValue('latest_snapshot') + '';",
-    "          var refLv = refGr.getValue('latest_version') + '';",
     "          r.steps.reference_flow = {",
     "            sys_id: refId,",
     "            name: refGr.getValue('name'),",
-    "            has_flow_definition: refFd !== 'null' && refFd.length > 0,",
-    "            flow_definition_length: refFd.length,",
-    "            flow_definition_prefix: refFd.substring(0, 200),",
-    "            has_latest_snapshot: refLs !== 'null' && refLs.length > 0,",
-    "            latest_snapshot_length: refLs.length,",
-    "            latest_version: refLv,",
-    "            has_latest_version: refLv !== 'null' && refLv.length > 5",
+    "            latest_snapshot_value: refLs,",
+    "            latest_version: refGr.getValue('latest_version') + ''",
     "          };",
-    // Query version records for reference flow (by flow= since latest_version is null)
-    "          var refVer = new GlideRecord('sys_hub_flow_version');",
-    "          refVer.addQuery('flow', refId);",
-    "          refVer.orderByDesc('sys_created_on');",
-    "          refVer.setLimit(1); refVer.query();",
-    "          if (refVer.next()) {",
-    "            var refVFd = refVer.getValue('flow_definition') + '';",
-    "            r.steps.reference_flow.version_sys_id = refVer.getUniqueValue();",
-    "            r.steps.reference_flow.version_state = refVer.getValue('state');",
-    "            r.steps.reference_flow.version_compile_state = refVer.getValue('compile_state');",
-    "            r.steps.reference_flow.version_is_current = refVer.getValue('is_current');",
-    "            r.steps.reference_flow.version_active = refVer.getValue('active');",
-    "            r.steps.reference_flow.version_has_flow_def = refVFd !== 'null' && refVFd.length > 0;",
-    "            r.steps.reference_flow.version_flow_def_length = refVFd.length;",
-    "            r.steps.reference_flow.version_flow_def_prefix = refVFd.substring(0, 200);",
-    // Check if latest_snapshot matches this version sys_id
-    "            r.steps.reference_flow.snapshot_matches_version = (refLs === refVer.getUniqueValue());",
-    "          } else { r.steps.reference_flow.version_found = false; }",
+    // Read the reference snapshot record fields (sys_hub_flow_snapshot)
+    "          if (refLs !== 'null' && refLs.length === 32) {",
+    "            try {",
+    "              var refSnap = new GlideRecord('sys_hub_flow_snapshot');",
+    "              if (refSnap.get(refLs)) {",
+    "                r.steps.reference_flow.snapshot_table = 'sys_hub_flow_snapshot';",
+    // Read all non-null fields to learn the schema
+    "                var snapFields = {};",
+    "                var snapEl = refSnap.getFields();",
+    "                for (var si = 0; si < snapEl.size(); si++) {",
+    "                  var sField = snapEl.get(si);",
+    "                  var sName = sField.getName() + '';",
+    "                  var sVal = refSnap.getValue(sName);",
+    "                  if (sVal && sName.indexOf('sys_') !== 0) {",
+    "                    var sStr = sVal + '';",
+    "                    snapFields[sName] = sStr.length > 100 ? sStr.substring(0, 100) + '...(len:' + sStr.length + ')' : sStr;",
+    "                  }",
+    "                }",
+    "                r.steps.reference_flow.snapshot_fields = snapFields;",
+    "              }",
+    "            } catch(snapRefE) { r.steps.reference_flow.snapshot_error = snapRefE + ''; }",
+    "          }",
+    // Count trigger/action instances for reference flow
+    "          var refTrig = new GlideAggregate('sys_hub_trigger_instance');",
+    "          refTrig.addQuery('flow', refId); refTrig.addAggregate('COUNT'); refTrig.query();",
+    "          r.steps.reference_flow.trigger_count = refTrig.next() ? parseInt(refTrig.getAggregate('COUNT')) : 0;",
+    "          var refAct = new GlideAggregate('sys_hub_action_instance');",
+    "          refAct.addQuery('flow', refId); refAct.addAggregate('COUNT'); refAct.query();",
+    "          r.steps.reference_flow.action_count = refAct.next() ? parseInt(refAct.getAggregate('COUNT')) : 0;",
     "        }",
     "      } catch(refE) { r.steps.reference_flow = { error: refE + '' }; }",
     "",
-    // ── Engine: try FlowAPI.compile() now that flow_definition is set ──
-    // DO NOT try publish (StackOverflowError). Only compile.
-    "      r.steps.engine = { apis_found: [], mode: 'compile_with_flowdef' };",
+    // ── Engine: skip compile (returns error, doesn't help) ──
+    "      r.steps.engine = { mode: 'probe_only' };",
     "      try {",
     "        if (typeof sn_fd !== 'undefined') {",
     "          r.steps.engine.sn_fd = 'available';",
-    "          if (sn_fd.FlowAPI && typeof sn_fd.FlowAPI.compile === 'function') {",
-    "            r.steps.engine.apis_found.push('FlowAPI');",
-    "            try {",
-    "              var compileResult = sn_fd.FlowAPI.compile(flowSysId);",
-    "              r.steps.engine.compile = 'success';",
-    "              r.steps.engine.compile_result = (compileResult + '').substring(0, 200);",
-    "            } catch(ce) {",
-    "              r.steps.engine.compile = 'error:' + (ce.getMessage ? ce.getMessage() : ce + '');",
-    "            }",
-    // Check latest_version immediately after compile
-    "            var postCompile = new GlideRecord('sys_hub_flow');",
-    "            if (postCompile.get(flowSysId)) {",
-    "              r.steps.engine.latest_version_after_compile = postCompile.getValue('latest_version') + '';",
-    "            }",
-    "          }",
-    "        } else {",
-    "          r.steps.engine.sn_fd = 'unavailable';",
-    "        }",
-    "      } catch(engineErr) {",
-    "        r.steps.engine.error = engineErr.getMessage ? engineErr.getMessage() : engineErr + '';",
-    "      }",
+    "        } else { r.steps.engine.sn_fd = 'unavailable'; }",
+    "      } catch(engineErr) {}",
     "    }",
     "",
     "    r.flow_sys_id = flowSysId ? flowSysId + '' : null;",
     "    r.version_sys_id = verSysId ? verSysId + '' : null;",
-    // ── Final check: re-read latest_version + compare our flow to reference ──
+    // ── Final check: read back our flow's latest_snapshot to confirm ──
     "    if (flowSysId) {",
     "      var cf = new GlideRecord('sys_hub_flow');",
     "      if (cf.get(flowSysId)) {",
-    "        r.latest_version_set = !cf.latest_version.nil();",
     "        r.latest_version_value = cf.getValue('latest_version') + '';",
-    // Also read our flow_definition to verify it was stored
-    "        var ourFd = cf.getValue('flow_definition') + '';",
-    "        r.our_flow_definition_stored = ourFd !== 'null' && ourFd.length > 0;",
-    "        r.our_flow_definition_length = ourFd.length;",
-    "        r.our_flow_definition_prefix = ourFd.substring(0, 200);",
+    "        r.our_latest_snapshot = cf.getValue('latest_snapshot') + '';",
+    "        r.our_latest_snapshot_length = (cf.getValue('latest_snapshot') + '').length;",
     "      }",
     "    }",
     "  } catch(e) { r.success = false; r.error = e.getMessage ? e.getMessage() : e + ''; }",