snow-flow 10.0.1-dev.410 → 10.0.1-dev.412

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-dev.410",
+  "version": "10.0.1-dev.412",
   "name": "snow-flow",
   "description": "Snow-Flow - ServiceNow Multi-Agent Development Framework powered by AI",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -124,9 +124,11 @@ async function createFlowViaScheduledJob(
     "    } catch(t1e) { r.steps.tier1 = { success: false, error: t1e.getMessage ? t1e.getMessage() : t1e + '' }; }",
     "",
     // ── TIER 2: GlideRecord ──
-    // Set flow_definition + latest_snapshot on flow record.
-    // Set flow_definition on version record.
-    // Force-set latest_version with setWorkflow(false) to bypass BRs.
+    // Reference flow analysis shows:
+    //   - flow_definition on flow record = null (working flows don't have it)
+    //   - latest_snapshot = 32-char sys_id (reference, NOT JSON!)
+    //   - latest_version = null (normal on this instance)
+    // So: DON'T set flow_definition on flow, set latest_snapshot = version sys_id.
     "    if (!flowSysId) {",
     "      try {",
     "        var f = new GlideRecord('sys_hub_flow');",
@@ -136,9 +138,10 @@ async function createFlowViaScheduledJob(
     "        f.setValue('run_as', runAs); f.setValue('active', false);",
     "        f.setValue('status', 'draft'); f.setValue('validated', true);",
     "        f.setValue('type', isSubflow ? 'subflow' : 'flow');",
-    "        if (flowDefStr) { f.setValue('flow_definition', flowDefStr); f.setValue('latest_snapshot', flowDefStr); }",
+    // Do NOT set flow_definition (null on working flows)
+    // Do NOT set latest_snapshot yet (set after version insert — it's a sys_id ref)
     "        flowSysId = f.insert();",
-    "        r.steps.flow_insert = { success: !!flowSysId, sys_id: flowSysId + '', flow_def_set: !!flowDefStr };",
+    "        r.steps.flow_insert = { success: !!flowSysId, sys_id: flowSysId + '' };",
     "        if (flowSysId) {",
     "          var v = new GlideRecord('sys_hub_flow_version');",
     "          v.initialize();",
@@ -146,30 +149,20 @@ async function createFlowViaScheduledJob(
     "          v.setValue('version', '1.0'); v.setValue('state', 'draft');",
     "          v.setValue('active', true); v.setValue('compile_state', 'draft');",
     "          v.setValue('is_current', true);",
-    "          v.setValue('internal_name', intName + '_v1_0');",
     "          if (flowDefStr) { v.setValue('flow_definition', flowDefStr); }",
     "          verSysId = v.insert();",
-    "          r.steps.version_insert = { success: !!verSysId, sys_id: verSysId + '', has_flow_def: !!flowDefStr };",
+    "          r.steps.version_insert = { success: !!verSysId, sys_id: verSysId + '' };",
     "",
-    // Force-set latest_version — bypass BRs with setWorkflow(false)
+    // Set latest_snapshot on flow record to version sys_id (reference field, not JSON)
     "          if (verSysId) {",
     "            try {",
     "              var flowUpd = new GlideRecord('sys_hub_flow');",
-    "              flowUpd.setWorkflow(false);",
-    "              flowUpd.autoSysFields(false);",
     "              if (flowUpd.get(flowSysId)) {",
-    "                flowUpd.setValue('latest_version', verSysId);",
+    "                flowUpd.setValue('latest_snapshot', verSysId);",
     "                flowUpd.update();",
-    "                r.steps.latest_version_force = 'attempted';",
+    "                r.steps.latest_snapshot_set = verSysId + '';",
     "              }",
-    "            } catch(lvE) { r.steps.latest_version_force = 'error:' + (lvE.getMessage ? lvE.getMessage() : lvE + ''); }",
-    // Verify latest_version was set
-    "            var lvCheck = new GlideRecord('sys_hub_flow');",
-    "            if (lvCheck.get(flowSysId)) {",
-    "              var lvVal = lvCheck.getValue('latest_version');",
-    "              r.steps.latest_version_after_force = lvVal + '';",
-    "              r.steps.latest_version_success = (lvVal === verSysId + '');",
-    "            }",
+    "            } catch(lsE) { r.steps.latest_snapshot_set = 'error:' + (lsE.getMessage ? lsE.getMessage() : lsE + ''); }",
     "          }",
     "          r.tier_used = 'gliderecord_scheduled'; r.success = true;",
     "        }",
@@ -280,37 +273,74 @@ async function createFlowViaScheduledJob(
     "      }",
     "      r.steps.variables = { success: true, created: varsCreated };",
     "",
-    // ── Engine: PROBE ONLY — do NOT call compile or publish ──
-    // FlowAPI.publish() → StackOverflowError (corrupts flow)
-    // FlowAPI.compile() → "success" but doesn't set latest_version, may corrupt
-    // Just probe what APIs exist for diagnostics.
-    "      r.steps.engine = { apis_found: [], mode: 'probe_only' };",
+    // ── Reference: query an existing published flow to see what it looks like ──
+    "      r.steps.reference_flow = null;",
+    "      try {",
+    "        var refGr = new GlideRecord('sys_hub_flow');",
+    "        refGr.addQuery('status', 'published');",
+    "        refGr.addQuery('active', true);",
+    "        refGr.setLimit(1); refGr.query();",
+    "        if (refGr.next()) {",
+    "          var refId = refGr.getUniqueValue();",
+    "          var refFd = refGr.getValue('flow_definition') + '';",
+    "          var refLs = refGr.getValue('latest_snapshot') + '';",
+    "          var refLv = refGr.getValue('latest_version') + '';",
+    "          r.steps.reference_flow = {",
+    "            sys_id: refId,",
+    "            name: refGr.getValue('name'),",
+    "            has_flow_definition: refFd !== 'null' && refFd.length > 0,",
+    "            flow_definition_length: refFd.length,",
+    "            flow_definition_prefix: refFd.substring(0, 200),",
+    "            has_latest_snapshot: refLs !== 'null' && refLs.length > 0,",
+    "            latest_snapshot_length: refLs.length,",
+    "            latest_version: refLv,",
+    "            has_latest_version: refLv !== 'null' && refLv.length > 5",
+    "          };",
+    // Query version records for reference flow (by flow= since latest_version is null)
+    "          var refVer = new GlideRecord('sys_hub_flow_version');",
+    "          refVer.addQuery('flow', refId);",
+    "          refVer.orderByDesc('sys_created_on');",
+    "          refVer.setLimit(1); refVer.query();",
+    "          if (refVer.next()) {",
+    "            var refVFd = refVer.getValue('flow_definition') + '';",
+    "            r.steps.reference_flow.version_sys_id = refVer.getUniqueValue();",
+    "            r.steps.reference_flow.version_state = refVer.getValue('state');",
+    "            r.steps.reference_flow.version_compile_state = refVer.getValue('compile_state');",
+    "            r.steps.reference_flow.version_is_current = refVer.getValue('is_current');",
+    "            r.steps.reference_flow.version_active = refVer.getValue('active');",
+    "            r.steps.reference_flow.version_has_flow_def = refVFd !== 'null' && refVFd.length > 0;",
+    "            r.steps.reference_flow.version_flow_def_length = refVFd.length;",
+    "            r.steps.reference_flow.version_flow_def_prefix = refVFd.substring(0, 200);",
+    // Check if latest_snapshot matches this version sys_id
+    "            r.steps.reference_flow.snapshot_matches_version = (refLs === refVer.getUniqueValue());",
+    "          } else { r.steps.reference_flow.version_found = false; }",
+    "        }",
+    "      } catch(refE) { r.steps.reference_flow = { error: refE + '' }; }",
+    "",
+    // ── Engine: try FlowAPI.compile() now that flow_definition is set ──
+    // DO NOT try publish (StackOverflowError). Only compile.
+    "      r.steps.engine = { apis_found: [], mode: 'compile_with_flowdef' };",
     "      try {",
     "        if (typeof sn_fd !== 'undefined') {",
     "          r.steps.engine.sn_fd = 'available';",
-    "          var probeNames = ['FlowDesigner', 'FlowCompiler', 'FlowAPI', 'FlowPublisher'];",
-    "          for (var pn = 0; pn < probeNames.length; pn++) {",
+    "          if (sn_fd.FlowAPI && typeof sn_fd.FlowAPI.compile === 'function') {",
+    "            r.steps.engine.apis_found.push('FlowAPI');",
     "            try {",
-    "              if (sn_fd[probeNames[pn]]) {",
-    "                r.steps.engine.apis_found.push(probeNames[pn]);",
-    "                var methods = [];",
-    "                var pObj = sn_fd[probeNames[pn]];",
-    "                var checkMethods = ['createFlow','publishFlow','activateFlow','compileFlow','compile','publish','getFlow'];",
-    "                for (var cm = 0; cm < checkMethods.length; cm++) {",
-    "                  if (typeof pObj[checkMethods[cm]] === 'function') methods.push(checkMethods[cm]);",
-    "                }",
-    "                if (methods.length > 0) r.steps.engine[probeNames[pn] + '_methods'] = methods;",
-    "              }",
-    "            } catch(e) {}",
+    "              var compileResult = sn_fd.FlowAPI.compile(flowSysId);",
+    "              r.steps.engine.compile = 'success';",
+    "              r.steps.engine.compile_result = (compileResult + '').substring(0, 200);",
+    "            } catch(ce) {",
+    "              r.steps.engine.compile = 'error:' + (ce.getMessage ? ce.getMessage() : ce + '');",
+    "            }",
+    // Check latest_version immediately after compile
+    "            var postCompile = new GlideRecord('sys_hub_flow');",
+    "            if (postCompile.get(flowSysId)) {",
+    "              r.steps.engine.latest_version_after_compile = postCompile.getValue('latest_version') + '';",
+    "            }",
     "          }",
     "        } else {",
     "          r.steps.engine.sn_fd = 'unavailable';",
     "        }",
-    "        try {",
-    "          if (typeof GlideFlowDesigner !== 'undefined') {",
-    "            r.steps.engine.apis_found.push('GlideFlowDesigner');",
-    "          }",
-    "        } catch(e) {}",
     "      } catch(engineErr) {",
     "        r.steps.engine.error = engineErr.getMessage ? engineErr.getMessage() : engineErr + '';",
     "      }",
@@ -318,12 +348,17 @@ async function createFlowViaScheduledJob(
     "",
     "    r.flow_sys_id = flowSysId ? flowSysId + '' : null;",
     "    r.version_sys_id = verSysId ? verSysId + '' : null;",
-    // ── Post-engine check: re-read latest_version ──
+    // ── Final check: re-read latest_version + compare our flow to reference ──
     "    if (flowSysId) {",
     "      var cf = new GlideRecord('sys_hub_flow');",
     "      if (cf.get(flowSysId)) {",
     "        r.latest_version_set = !cf.latest_version.nil();",
     "        r.latest_version_value = cf.getValue('latest_version') + '';",
+    // Also read our flow_definition to verify it was stored
+    "        var ourFd = cf.getValue('flow_definition') + '';",
+    "        r.our_flow_definition_stored = ourFd !== 'null' && ourFd.length > 0;",
+    "        r.our_flow_definition_length = ourFd.length;",
+    "        r.our_flow_definition_prefix = ourFd.substring(0, 200);",
     "      }",
     "    }",
     "  } catch(e) { r.success = false; r.error = e.getMessage ? e.getMessage() : e + ''; }",
@@ -1429,9 +1464,9 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
             run_as: flowRunAs,
             status: shouldActivate ? 'published' : 'draft',
             validated: true,
-            type: isSubflow ? 'subflow' : 'flow',
-            flow_definition: JSON.stringify(flowDefinition),
-            latest_snapshot: JSON.stringify(flowDefinition)
+            type: isSubflow ? 'subflow' : 'flow'
+            // Do NOT set flow_definition or latest_snapshot on flow record
+            // Reference flow analysis: flow_definition=null, latest_snapshot=version sys_id
           };
 
           var flowResponse = await client.post('/api/now/table/sys_hub_flow', flowData);
@@ -1475,36 +1510,16 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
               versionCreated = true;
               diagnostics.version_created = true;
               diagnostics.version_method = 'table_api (draft→update)';
-              diagnostics.version_fields_set = ['flow', 'name', 'version', 'state', 'active', 'compile_state', 'is_current', 'published_flow', 'internal_name'];
 
-              // Step 3: Check if BRs auto-set latest_version on the flow
-              await new Promise(resolve => setTimeout(resolve, 1000));
+              // Set latest_snapshot on flow record to version sys_id (reference field)
               try {
-                var flowCheck = await client.get('/api/now/table/sys_hub_flow/' + flowSysId, {
-                  params: { sysparm_fields: 'latest_version', sysparm_display_value: 'false' }
+                await client.patch('/api/now/table/sys_hub_flow/' + flowSysId, {
+                  latest_snapshot: versionSysId
                 });
-                var autoLinked = !!(flowCheck.data.result?.latest_version);
-                diagnostics.latest_version_auto_set = autoLinked;
-
-                // Step 4: If BRs didn't set it, explicitly PATCH + verify
-                if (!autoLinked) {
-                  try {
-                    var linkResp = await client.patch('/api/now/table/sys_hub_flow/' + flowSysId, {
-                      latest_version: versionSysId,
-                      latest_published_version: shouldActivate ? versionSysId : undefined
-                    });
-                    diagnostics.latest_version_patch_status = linkResp.status;
-                    // Immediate readback
-                    var readback = await client.get('/api/now/table/sys_hub_flow/' + flowSysId, {
-                      params: { sysparm_fields: 'latest_version', sysparm_display_value: 'false' }
-                    });
-                    diagnostics.latest_version_after_patch = readback.data.result?.latest_version || 'null';
-                  } catch (linkError: any) {
-                    diagnostics.latest_version_patch_error = linkError.message || 'unknown';
-                    factoryWarnings.push('latest_version link failed: ' + (linkError.message || linkError));
-                  }
-                }
-              } catch (_) {}
+                diagnostics.latest_snapshot_set = versionSysId;
+              } catch (snapshotErr: any) {
+                diagnostics.latest_snapshot_error = snapshotErr.message || 'unknown';
+              }
             }
           } catch (verError: any) {
             factoryWarnings.push('sys_hub_flow_version creation failed: ' + (verError.message || verError));