snow-flow 10.0.1-dev.404 → 10.0.1-dev.405

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-dev.404",
+  "version": "10.0.1-dev.405",
   "name": "snow-flow",
   "description": "Snow-Flow - ServiceNow Multi-Agent Development Framework powered by AI",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -165,7 +165,7 @@ async function createFlowViaScheduledJob(
     "",
     // ── Trigger, action, variable creation (runs for any tier) ──
     "    if (flowSysId) {",
-    // Trigger — search broadly for trigger definition (internal_name varies per instance)
+    // Trigger — search broadly (no type filter, internal_name varies per instance)
     "      if (!isSubflow && trigType !== 'manual') {",
     "        try {",
     "          var trigSearchTerms = {",
@@ -177,21 +177,55 @@ async function createFlowViaScheduledJob(
     "          var trigDef = null;",
     "          var trigDefId = null;",
     "          var trigSearchLog = [];",
+    // Search 1: CONTAINS on internal_name (NO type filter — 'type' column values vary)
     "          for (var ts = 0; ts < terms.length; ts++) {",
     "            var tg = new GlideRecord('sys_hub_action_type_definition');",
     "            tg.addQuery('internal_name', 'CONTAINS', terms[ts]);",
-    "            tg.addQuery('type', 'trigger');",
-    "            tg.setLimit(1); tg.query();",
-    "            if (tg.next()) { trigDef = tg; trigDefId = tg.getUniqueValue(); trigSearchLog.push(terms[ts] + ':found'); break; }",
-    "            trigSearchLog.push(terms[ts] + ':not_found');",
+    "            tg.setLimit(5); tg.query();",
+    "            while (tg.next()) {",
+    "              var tgType = tg.getValue('type') + '';",
+    "              var tgName = tg.getValue('internal_name') + '';",
+    "              trigSearchLog.push(terms[ts] + ':' + tgName + '(type=' + tgType + ')');",
+    "              if (!trigDefId) { trigDef = tg; trigDefId = tg.getUniqueValue(); }",
+    "            }",
+    "            if (trigDefId) break;",
     "          }",
+    // Search 2: by display name (no type filter)
     "          if (!trigDefId) {",
     "            var tg2 = new GlideRecord('sys_hub_action_type_definition');",
     "            tg2.addQuery('name', 'CONTAINS', trigType.replace('_', ' '));",
-    "            tg2.addQuery('type', 'trigger');",
-    "            tg2.setLimit(1); tg2.query();",
-    "            if (tg2.next()) { trigDef = tg2; trigDefId = tg2.getUniqueValue(); trigSearchLog.push('name_search:found'); }",
-    "            else { trigSearchLog.push('name_search:not_found'); }",
+    "            tg2.setLimit(5); tg2.query();",
+    "            while (tg2.next()) {",
+    "              var tg2Type = tg2.getValue('type') + '';",
+    "              var tg2Name = tg2.getValue('internal_name') + '';",
+    "              trigSearchLog.push('name:' + tg2Name + '(type=' + tg2Type + ')');",
+    "              if (!trigDefId) { trigDef = tg2; trigDefId = tg2.getUniqueValue(); }",
+    "            }",
+    "          }",
+    // Search 3: sys_hub_trigger_definition table (alternative on some instances)
+    "          if (!trigDefId) {",
+    "            try {",
+    "              var tg3 = new GlideRecord('sys_hub_trigger_definition');",
+    "              if (tg3.isValid()) {",
+    "                tg3.addQuery('internal_name', 'CONTAINS', terms[0]);",
+    "                tg3.setLimit(3); tg3.query();",
+    "                while (tg3.next()) {",
+    "                  trigSearchLog.push('trig_def_table:' + tg3.getValue('internal_name'));",
+    "                  if (!trigDefId) { trigDef = tg3; trigDefId = tg3.getUniqueValue(); }",
+    "                }",
+    "              } else { trigSearchLog.push('trig_def_table:invalid'); }",
+    "            } catch(e3) { trigSearchLog.push('trig_def_table:error'); }",
+    "          }",
+    // Discovery: log what type values exist (helps debug trigger issues)
+    "          if (!trigDefId) {",
+    "            try {",
+    "              var disc = new GlideAggregate('sys_hub_action_type_definition');",
+    "              disc.addAggregate('COUNT', 'type');",
+    "              disc.groupBy('type'); disc.query();",
+    "              var typeValues = [];",
+    "              while (disc.next()) { typeValues.push(disc.getValue('type') + ':' + disc.getAggregate('COUNT', 'type')); }",
+    "              trigSearchLog.push('type_values:[' + typeValues.join(',') + ']');",
+    "            } catch(de) { trigSearchLog.push('discovery:error'); }",
     "          }",
     "          if (trigDefId) {",
     "            var trigInst = new GlideRecord('sys_hub_trigger_instance');",
@@ -201,9 +235,9 @@ async function createFlowViaScheduledJob(
     "            if (trigTable) trigInst.setValue('table', trigTable);",
     "            if (trigCondition) trigInst.setValue('condition', trigCondition);",
     "            var trigId = trigInst.insert();",
-    "            r.steps.trigger = { success: !!trigId, sys_id: trigId + '', def_name: trigDef.getValue('name'), search: trigSearchLog };",
+    "            r.steps.trigger = { success: !!trigId, sys_id: trigId + '', def_name: trigDef.getValue('name'), def_internal: trigDef.getValue('internal_name'), search: trigSearchLog };",
     "          } else {",
-    "            r.steps.trigger = { success: false, error: 'No trigger def found', search: trigSearchLog };",
+    "            r.steps.trigger = { success: false, error: 'No trigger def found after broad search', search: trigSearchLog };",
     "          }",
     "        } catch(te) { r.steps.trigger = { success: false, error: te.getMessage ? te.getMessage() : te + '' }; }",
     "      }",
@@ -245,11 +279,11 @@ async function createFlowViaScheduledJob(
     "      }",
     "      r.steps.variables = { success: true, created: varsCreated };",
     "",
-    // ── Engine probe (discovery only — do NOT call publish/compile) ──
-    // Previous versions called FlowAPI.publish() which caused StackOverflowError
-    // and corrupted the flow. Now we only probe which APIs exist for diagnostics.
-    // The flow is left as a clean draft; user publishes via Flow Designer UI.
-    "      r.steps.engine = { apis_found: [], mode: 'probe_only' };",
+    // ── Engine: probe APIs + try compile (NOT publish — that StackOverflowed) ──
+    // FlowAPI.publish() caused StackOverflowError and corrupted the flow.
+    // FlowAPI.compile() should be safer — it registers the flow with the
+    // engine and sets latest_version without the publish side effects.
+    "      r.steps.engine = { apis_found: [], mode: 'probe_and_compile' };",
     "      try {",
     "        if (typeof sn_fd !== 'undefined') {",
     "          r.steps.engine.sn_fd = 'available';",
@@ -268,6 +302,24 @@ async function createFlowViaScheduledJob(
     "              }",
     "            } catch(e) {}",
     "          }",
+    // Try compile (safe) — DO NOT try publish (StackOverflowError)
+    "          var compiled = false;",
+    // Priority 1: FlowDesigner.compileFlow (most specific)
+    "          if (!compiled && sn_fd.FlowDesigner && typeof sn_fd.FlowDesigner.compileFlow === 'function') {",
+    "            try { sn_fd.FlowDesigner.compileFlow(flowSysId); r.steps.engine.compile = 'FlowDesigner.compileFlow:success'; compiled = true; }",
+    "            catch(e) { r.steps.engine.compile = 'FlowDesigner.compileFlow:' + (e.getMessage ? e.getMessage() : e + ''); }",
+    "          }",
+    // Priority 2: FlowCompiler.compile
+    "          if (!compiled && sn_fd.FlowCompiler && typeof sn_fd.FlowCompiler.compile === 'function') {",
+    "            try { sn_fd.FlowCompiler.compile(flowSysId); r.steps.engine.compile = 'FlowCompiler.compile:success'; compiled = true; }",
+    "            catch(e) { r.steps.engine.compile = 'FlowCompiler.compile:' + (e.getMessage ? e.getMessage() : e + ''); }",
+    "          }",
+    // Priority 3: FlowAPI.compile (available on this instance per diagnostics)
+    "          if (!compiled && sn_fd.FlowAPI && typeof sn_fd.FlowAPI.compile === 'function') {",
+    "            try { sn_fd.FlowAPI.compile(flowSysId); r.steps.engine.compile = 'FlowAPI.compile:success'; compiled = true; }",
+    "            catch(e) { r.steps.engine.compile = 'FlowAPI.compile:' + (e.getMessage ? e.getMessage() : e + ''); }",
+    "          }",
+    "          r.steps.engine.compiled = compiled;",
     "        } else {",
     "          r.steps.engine.sn_fd = 'unavailable';",
     "        }",