snow-flow-test 10.0.1-test.200 → 10.0.1-test.202

package/package.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
-  "version": "10.0.1-test.200",
+  "version": "10.0.1-test.202",
   "name": "snow-flow-test",
   "description": "Snow-Flow Test - ServiceNow Multi-Agent Development Framework",
   "license": "Elastic-2.0",

package/src/servicenow/servicenow-mcp-unified/tools/flow-designer/snow_manage_flow.ts

@@ -2505,9 +2505,11 @@ export const toolDefinition: MCPToolDefinition = {
           'add_trigger', 'update_trigger', 'delete_trigger',
           'add_action', 'update_action', 'delete_action',
           'add_flow_logic', 'update_flow_logic', 'delete_flow_logic',
-          'add_subflow', 'update_subflow', 'delete_subflow'
+          'add_subflow', 'update_subflow', 'delete_subflow',
+          'open_flow', 'close_flow'
         ],
-        description: 'Action to perform. add_*/update_*/delete_* for triggers, actions, flow_logic, subflows. update_trigger replaces the trigger type. update_action/update_flow_logic/update_subflow change input values. delete_* removes elements by element_id.'
+        description: 'Action to perform. EDITING WORKFLOW: create_flow keeps the editing lock open — you can immediately call add_action, add_flow_logic, etc. without open_flow. For editing EXISTING flows: call open_flow first to acquire the lock. Always call close_flow as the LAST step to release the lock so users can edit in the UI. ' +
+          'add_*/update_*/delete_* for triggers, actions, flow_logic, subflows. update_trigger replaces the trigger type. delete_* removes elements by element_id.'
       },
 
       flow_id: {
@@ -3093,11 +3095,8 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
           }
         }
 
-        // Release Flow Designer editing lock (safeEdit delete) so users can edit the flow in the UI
-        if (flowSysId) {
-          var lockReleased = await releaseFlowEditingLock(client, flowSysId);
-          diagnostics.editing_lock_released = lockReleased;
-        }
+        // NOTE: Do NOT release the editing lock here. The agent may need to add more elements
+        // (flow logic, actions, etc.) after creation. The agent must call close_flow when done.
 
         return createSuccessResult({
           created: true,
@@ -3480,7 +3479,6 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
           addTrigSummary.error('Failed to add trigger: ' + (addTrigResult.error || 'unknown'));
         }
 
-        await releaseFlowEditingLock(client, addTrigFlowId);
         return addTrigResult.success
           ? createSuccessResult({ action: 'add_trigger', ...addTrigResult }, {}, addTrigSummary.build())
           : createErrorResult(addTrigResult.error || 'Failed to add trigger');
@@ -3544,7 +3542,6 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
           updTrigSummary.error('Failed to update trigger: ' + (updTrigResult.error || 'unknown'));
         }
 
-        await releaseFlowEditingLock(client, updTrigFlowId);
         return updTrigResult.success
           ? createSuccessResult({ action: 'update_trigger', steps: updTrigSteps }, {}, updTrigSummary.build())
           : createErrorResult(updTrigResult.error || 'Failed to update trigger');
@@ -3576,7 +3573,6 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
           addActSummary.error('Failed to add action: ' + (addActResult.error || 'unknown'));
         }
 
-        await releaseFlowEditingLock(client, addActFlowId);
         return addActResult.success
           ? createSuccessResult({ action: 'add_action', ...addActResult }, {}, addActSummary.build())
           : createErrorResult(addActResult.error || 'Failed to add action');
@@ -3613,7 +3609,6 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
           addLogicSummary.error('Failed to add flow logic: ' + (addLogicResult.error || 'unknown'));
         }
 
-        await releaseFlowEditingLock(client, addLogicFlowId);
         return addLogicResult.success
           ? createSuccessResult({ action: 'add_flow_logic', ...addLogicResult }, {}, addLogicSummary.build())
           : createErrorResult(addLogicResult.error || 'Failed to add flow logic');
@@ -3648,7 +3643,6 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
           addSubSummary.error('Failed to add subflow call: ' + (addSubResult.error || 'unknown'));
         }
 
-        await releaseFlowEditingLock(client, addSubFlowId);
         return addSubResult.success
           ? createSuccessResult({ action: 'add_subflow', ...addSubResult }, {}, addSubSummary.build())
           : createErrorResult(addSubResult.error || 'Failed to add subflow call');
@@ -3674,7 +3668,6 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
         } else {
           updElemSummary.error('Failed to update element: ' + (updElemResult.error || 'unknown'));
         }
-        await releaseFlowEditingLock(client, updElemFlowId);
         return updElemResult.success
           ? createSuccessResult({ action, ...updElemResult }, {}, updElemSummary.build())
           : createErrorResult(updElemResult.error || 'Failed to update element');
@@ -3706,12 +3699,47 @@ export async function execute(args: any, context: ServiceNowContext): Promise<To
         } else {
           delSummary.error('Failed to delete element: ' + (delResult.error || 'unknown'));
         }
-        await releaseFlowEditingLock(client, delElemFlowId);
         return delResult.success
           ? createSuccessResult({ action, ...delResult }, {}, delSummary.build())
           : createErrorResult(delResult.error || 'Failed to delete element');
       }
 
+      // ────────────────────────────────────────────────────────────────
+      // OPEN_FLOW — acquire Flow Designer editing lock (processflow GET)
+      // ────────────────────────────────────────────────────────────────
+      case 'open_flow': {
+        if (!args.flow_id) throw new SnowFlowError(ErrorType.VALIDATION_ERROR, 'flow_id is required for open_flow');
+        var openFlowId = await resolveFlowId(client, args.flow_id);
+        var openSummary = summary();
+        try {
+          // The processflow GET is what the Flow Designer UI calls when opening a flow for editing.
+          // This acquires the editing lock so subsequent GraphQL mutations can work.
+          await client.get('/api/now/processflow/flow/' + openFlowId);
+          openSummary.success('Flow opened for editing').field('Flow', openFlowId)
+            .line('You can now use add_action, add_flow_logic, etc. Call close_flow when done.');
+          return createSuccessResult({ action: 'open_flow', flow_id: openFlowId, editing_session: true }, {}, openSummary.build());
+        } catch (e: any) {
+          openSummary.error('Failed to open flow for editing: ' + (e.message || 'unknown')).field('Flow', openFlowId);
+          return createErrorResult('Failed to open flow for editing: ' + (e.message || 'unknown'));
+        }
+      }
+
+      // ────────────────────────────────────────────────────────────────
+      // CLOSE_FLOW — release Flow Designer editing lock (safeEdit)
+      // ────────────────────────────────────────────────────────────────
+      case 'close_flow': {
+        if (!args.flow_id) throw new SnowFlowError(ErrorType.VALIDATION_ERROR, 'flow_id is required for close_flow');
+        var closeFlowId = await resolveFlowId(client, args.flow_id);
+        var closed = await releaseFlowEditingLock(client, closeFlowId);
+        var closeSummary = summary();
+        if (closed) {
+          closeSummary.success('Flow editing lock released').field('Flow', closeFlowId);
+        } else {
+          closeSummary.warning('Lock release returned false (flow may not have been locked)').field('Flow', closeFlowId);
+        }
+        return createSuccessResult({ action: 'close_flow', flow_id: closeFlowId, lock_released: closed }, {}, closeSummary.build());
+      }
+
       default:
         throw new SnowFlowError(ErrorType.VALIDATION_ERROR, 'Unknown action: ' + action);
     }