sneakoscope 6.7.0 → 7.0.0

package/dist/native/sks-menubar/Sources/SettingsViewController.swift

@@ -1,6 +1,6 @@
 import Cocoa
 
-final class SettingsViewController: NSViewController {
+final class SettingsViewController: NSViewController, ControlCenterPage {
     private let notifications: NotificationCoordinator
     private let quitWithCodex = NSButton(checkboxWithTitle: "Quit SKS Menu when Codex quits (otherwise hide)", target: nil, action: nil)
     private let status = NativeView.detail("Settings use the native app configuration file.")
@@ -10,26 +10,60 @@ final class SettingsViewController: NSViewController {
     override func loadView() {
         quitWithCodex.target = self; quitWithCodex.action = #selector(save)
         quitWithCodex.state = readConfig()["quit_with_codex"] as? Bool == true ? .on : .off
+        quitWithCodex.setAccessibilityLabel("Quit SKS Menu when Codex quits")
         let authorize = NativeView.button("Enable Notifications", target: self, action: #selector(enableNotifications))
         view = NativeView.stack([
             NativeView.title("Settings"),
-            NativeView.detail("Use system typography, focus behavior, notification authorization, and explicit consequential changes."),
+            NativeView.detail("These options stay on this Mac. Notification permission and Codex lifecycle behavior never leave the machine."),
             quitWithCodex, authorize, status
         ])
+        refreshOnAppear()
     }
 
-    @objc private func enableNotifications() { notifications.requestAuthorizationFromSettings(); status.stringValue = "Notification authorization was requested from macOS." }
+    func refreshOnAppear() {
+        quitWithCodex.state = readConfig()["quit_with_codex"] as? Bool == true ? .on : .off
+        if notifications.authorizationDenied {
+            status.stringValue = "Notifications are denied in macOS Settings. Operation results still appear in Control Center."
+        } else if FileManager.default.fileExists(atPath: AppRuntime.configPath) {
+            status.stringValue = "Settings loaded from the native app configuration file."
+        } else {
+            status.stringValue = "No settings file yet. Changing an option creates one with owner-only permissions."
+        }
+    }
+
+    @objc private func enableNotifications() {
+        notifications.requestAuthorizationFromSettings()
+        status.stringValue = "Notification authorization was requested from macOS."
+    }
 
     @objc private func save() {
         var config = readConfig()
         config["schema"] = "sks.sks-menubar-config.v1"
         config["codex_bundle_id"] = AppRuntime.codexBundleId as Any
         config["quit_with_codex"] = quitWithCodex.state == .on
-        guard JSONSerialization.isValidJSONObject(config), let data = try? JSONSerialization.data(withJSONObject: config, options: [.prettyPrinted]) else { return }
+        guard JSONSerialization.isValidJSONObject(config), let data = try? JSONSerialization.data(withJSONObject: config, options: [.prettyPrinted]) else {
+            status.stringValue = "Settings could not be encoded."
+            return
+        }
         let target = URL(fileURLWithPath: AppRuntime.configPath)
-        let temporary = target.deletingLastPathComponent().appendingPathComponent(".config.\(UUID().uuidString).tmp")
-        do { try data.write(to: temporary, options: .atomic); _ = try FileManager.default.replaceItemAt(target, withItemAt: temporary); status.stringValue = "Settings saved." }
-        catch { status.stringValue = "Settings could not be saved." }
+        let directory = target.deletingLastPathComponent()
+        let temporary = directory.appendingPathComponent(".config.\(UUID().uuidString).tmp")
+        do {
+            try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true)
+            try data.write(to: temporary, options: .atomic)
+            if FileManager.default.fileExists(atPath: target.path) {
+                _ = try FileManager.default.replaceItemAt(target, withItemAt: temporary)
+            } else {
+                try FileManager.default.moveItem(at: temporary, to: target)
+            }
+            try FileManager.default.setAttributes([.posixPermissions: 0o600], ofItemAtPath: target.path)
+            status.stringValue = quitWithCodex.state == .on
+                ? "Saved. SKS Menu will quit when Codex quits."
+                : "Saved. SKS Menu will hide when Codex quits."
+        } catch {
+            try? FileManager.default.removeItem(at: temporary)
+            status.stringValue = "Settings could not be saved. Confirm \(directory.path) is writable."
+        }
     }
 
     private func readConfig() -> [String: Any] {

package/dist/native/sks-menubar/Sources/StatusItemController.swift

@@ -93,6 +93,7 @@ final class StatusItemController: NSObject, NSMenuDelegate {
     }
 
     private func refreshLocalState() {
+        hydrateFromLatestOperation()
         let update = readJson(path: FileManager.default.homeDirectoryForCurrentUser
             .appendingPathComponent(".sneakoscope-global/cache/update-status.json").path)
         let sksUpdate = ((update?["sks"] as? [String: Any])?["update_available"] as? Bool) == true
@@ -101,18 +102,45 @@ final class StatusItemController: NSObject, NSMenuDelegate {
         let signatureBroken = menuBar?["signature_ok"] as? Bool == false
         let resourcesBroken = menuBar?["resources_ok"] as? Bool == false
         let integrityBroken = signatureBroken || resourcesBroken || !FileManager.default.fileExists(atPath: AppRuntime.buildStampPath)
+        let pendingCount = operations.latestSnapshot()?.state == .waitingForConfirmation ? 1 : 0
+        pendingLine.title = "Pending approvals (\(pendingCount))"
         let icon: SKSStatusIcon
         let summary: String
         if integrityBroken { icon = .warning; summary = "Needs attention — Menu Bar integrity" }
         else if operationFailed { icon = .warning; summary = "Needs attention — last operation failed" }
-        else if actionRequired || notificationAuthorizationDenied { icon = .attention; summary = notificationAuthorizationDenied ? "Notifications require attention" : "Input or approval required" }
+        else if actionRequired || notificationAuthorizationDenied || pendingCount > 0 {
+            icon = .attention
+            summary = notificationAuthorizationDenied ? "Notifications require attention" : pendingCount > 0 ? "Input or approval required" : "Input or approval required"
+        }
         else if sksUpdate || codexUpdate { icon = .updateAvailable; summary = "Update available" }
         else if operationRunning { icon = .working; summary = "Working" }
         else { icon = .healthy; summary = "Healthy" }
-        apply(icon)
+        apply(icon, summary: summary)
         statusLine.title = "Status: \(summary)"
     }
 
+    private func hydrateFromLatestOperation() {
+        guard let latest = operations.latestSnapshot() else { return }
+        switch latest.state {
+        case .queued, .running:
+            operationRunning = true
+            operationFailed = false
+            actionRequired = false
+        case .waitingForConfirmation:
+            operationRunning = false
+            operationFailed = false
+            actionRequired = true
+        case .failed, .terminalUncertain:
+            operationRunning = false
+            operationFailed = true
+            actionRequired = false
+        case .succeeded, .cancelled:
+            operationRunning = false
+            operationFailed = false
+            actionRequired = false
+        }
+    }
+
     private func refreshExpiredUpdateStatusIfNeeded() {
         let update = readJson(path: FileManager.default.homeDirectoryForCurrentUser
             .appendingPathComponent(".sneakoscope-global/cache/update-status.json").path)
@@ -190,7 +218,7 @@ final class StatusItemController: NSObject, NSMenuDelegate {
         return expiry <= now
     }
 
-    private func apply(_ state: SKSStatusIcon) {
+    private func apply(_ state: SKSStatusIcon, summary: String) {
         let pair: (String, String)
         switch state {
         case .healthy: pair = ("SKSStatusTemplate", "checkmark.circle")
@@ -201,6 +229,9 @@ final class StatusItemController: NSObject, NSMenuDelegate {
         }
         statusItem.button?.image = AppIdentity.statusImage(resource: pair.0, symbol: pair.1)
         statusItem.button?.imagePosition = .imageOnly
+        statusItem.button?.setAccessibilityLabel("SKS status")
+        statusItem.button?.setAccessibilityValue(summary)
+        statusItem.button?.toolTip = "SKS Control Center — \(summary)"
     }
 
     private func run(_ arguments: [String], kind: String, mutationGroup: String?, summary: String, completion: (() -> Void)? = nil) {

package/dist/native/sks-menubar/Sources/UpdatesViewController.swift

@@ -1,6 +1,6 @@
 import Cocoa
 
-final class UpdatesViewController: NSViewController {
+final class UpdatesViewController: NSViewController, ControlCenterPage {
     private static let controlCenterUpdateEnvironment = ["SKS_UPDATE_DEFER_MENUBAR_RESTART": "1"]
     private let processClient: ProcessClient
     private let operations: OperationCoordinator
@@ -11,6 +11,9 @@ final class UpdatesViewController: NSViewController {
     private let progress = NSProgressIndicator()
     private var receiptTimer: Timer?
     private var activeReceiptId: String?
+    private var checkButton: NSButton!
+    private var reviewButton: NSButton!
+    private var busy = false
 
     init(processClient: ProcessClient, operations: OperationCoordinator, notifications: NotificationCoordinator) {
         self.processClient = processClient; self.operations = operations; self.notifications = notifications
@@ -22,9 +25,9 @@ final class UpdatesViewController: NSViewController {
         progress.isIndeterminate = !NSWorkspace.shared.accessibilityDisplayShouldReduceMotion
         progress.controlSize = .small
         progress.isHidden = true
-        let check = NativeView.button("Check Now", target: self, action: #selector(checkNow))
-        let review = NativeView.button("Review and Update", target: self, action: #selector(reviewAndUpdate))
-        let buttons = NSStackView(views: [check, review, progress])
+        checkButton = NativeView.button("Check Now", target: self, action: #selector(checkNow))
+        reviewButton = NativeView.button("Review and Update", target: self, action: #selector(reviewAndUpdate))
+        let buttons = NSStackView(views: [checkButton, reviewButton, progress])
         buttons.orientation = .horizontal; buttons.spacing = 8
         view = NativeView.stack([
             NativeView.title("Updates"),
@@ -37,17 +40,36 @@ final class UpdatesViewController: NSViewController {
 
     deinit { receiptTimer?.invalidate() }
 
+    func refreshOnAppear() { reloadSnapshot() }
+
     private func loadCached() {
         reloadSnapshot()
     }
 
+    private func setBusy(_ value: Bool) {
+        busy = value
+        checkButton?.isEnabled = !value
+        reviewButton?.isEnabled = !value
+    }
+
     @objc private func checkNow() { run(["update", "status", "--refresh", "--json"], kind: "update-status", group: nil) }
 
     @objc private func reviewAndUpdate() {
         run(["update", "review", "--json"], kind: "update-review", group: nil) { [weak self] result in
-            guard result.code == 0, let self = self, let window = self.view.window else { return }
+            guard let self = self else { return }
+            guard result.code == 0, let window = self.view.window else {
+                self.status.stringValue = "Update review failed. Open Diagnostics for the redacted log."
+                return
+            }
+            let pending = self.operations.latestSnapshot()
             AlertFactory.confirmSheet(window: window, title: "Update SKS?", message: "Review completed. Continue with the verified staged update?", destructive: false) { approved in
-                if approved { self.run(["update", "now", "--json"], kind: "update", group: "update") }
+                if approved {
+                    self.run(["update", "now", "--json"], kind: "update", group: "update")
+                } else if let pending = pending, pending.kind == "update-review" {
+                    _ = self.operations.update(pending, state: .cancelled, stage: "confirmation", progress: 1, summary: "Update review cancelled")
+                    self.status.stringValue = "Update review cancelled. No staged update was applied."
+                    self.reloadSnapshot()
+                }
             }
         }
     }
@@ -62,6 +84,7 @@ final class UpdatesViewController: NSViewController {
             ))
             return
         }
+        setBusy(true)
         progress.isHidden = false
         if NSWorkspace.shared.accessibilityDisplayShouldReduceMotion {
             progress.isIndeterminate = false
@@ -76,10 +99,12 @@ final class UpdatesViewController: NSViewController {
         _ = operations.update(operation, state: .running, stage: "running", progress: nil, summary: status.stringValue)
         if kind == "update" { startReceiptPolling(for: operation) }
         let environment = kind == "update" ? Self.controlCenterUpdateEnvironment : [:]
-        processClient.run(args, environment: environment) { [weak self] result in
+        let timeout: TimeInterval? = kind == "update" ? nil : NativeView.mutationTimeout
+        processClient.run(args, environment: environment, timeout: timeout) { [weak self] result in
             guard let self = self else { return }
             self.stopReceiptPolling()
             self.progress.stopAnimation(nil); self.progress.isHidden = true
+            self.setBusy(false)
             var authoritativeState: OperationState?
             var restartMenuBarAfterCompletion = false
             if kind == "update" {
@@ -106,6 +131,11 @@ final class UpdatesViewController: NSViewController {
             } else {
                 let state: OperationState = kind == "update-review" && result.code == 0 ? .waitingForConfirmation : result.code == 0 ? .succeeded : .failed
                 _ = self.operations.update(operation, state: state, stage: state == .waitingForConfirmation ? "confirmation" : "complete", progress: 1, summary: state == .waitingForConfirmation ? "Update review is waiting for confirmation" : result.code == 0 ? "Update operation completed" : "Update operation failed")
+                if result.code != 0 {
+                    self.status.stringValue = "\(kind.replacingOccurrences(of: "-", with: " ").capitalized) failed · \(NativeView.redactPreview(result.output))"
+                } else if state == .waitingForConfirmation {
+                    self.status.stringValue = "Review ready. Confirm to continue, or cancel to leave the current install unchanged."
+                }
             }
             let updateOutput = kind == "update-status" ? result.output : nil
             let approvalRequired = kind == "update-review" && result.code == 0
@@ -162,7 +192,7 @@ final class UpdatesViewController: NSViewController {
     }
 
     private func reloadSnapshot() {
-        processClient.run(["update", "status", "--json"]) { [weak self] result in self?.render(statusResult: result) }
+        processClient.run(["update", "status", "--json"], timeout: NativeView.statusTimeout) { [weak self] result in self?.render(statusResult: result) }
     }
 
     private func render(statusResult result: ProcessResult) {

package/dist/scripts/docs-truthfulness-check.js

@@ -33,7 +33,7 @@ const required = {
     'docs/goal-to-loop-migration.md': ['only persisted goal owner', 'creates no SKS mission', '--legacy-goal-runtime', 'fail with an instruction'],
     'docs/known-gaps.md': ['No P0', 'P1'],
     'docs/release-readiness.md': [
-        'SKS 6.7.0 Release Readiness',
+        'SKS 7.0.0 Release Readiness',
         '$sks-naruto',
         '$sks-work',
         'sks doctor --fix',
@@ -46,7 +46,7 @@ const required = {
         'proof-aware fleet control',
         'npm stage publish',
         'npm stage approve <stage-id>',
-        '6.2.0 to 6.7.0 upgrade smoke'
+        '6.2.0 to 7.0.0 upgrade smoke'
     ]
 };
 const forbidden = [

package/dist/scripts/doctor-fixes-codex-app-fast-ui-check.js

@@ -38,15 +38,19 @@ const ok = plan.fast_selector === 'manual_action_required'
     && plan.provider_actions.includes('sks codex-lb setup --host <domain> --api-key-stdin --yes')
     && plan.safe_auto_apply === true
     && repaired.fast_selector === 'repaired'
-    && repaired.provider_selector === 'selected_provider_ready'
-    && repaired.selected_provider_blockers.length === 0
+    // Contract-valid codex-lb selection is preserved through Fast UI repair; without
+    // hermetic credentials/catalog the selected provider stays setup-required.
+    && repaired.provider_selector === 'manual_action_required'
+    && repaired.selected_provider_blockers.includes('codex_lb_api_key_missing')
+    && repaired.selected_provider_blockers.includes('codex_lb_base_url_missing')
+    && repaired.selected_provider_blockers.includes('codex_lb_model_catalog_json_unselected')
     && repaired.safe_auto_apply === true
     && backups.length >= 1
     && /^model\s*=\s*"future-codex-model"$/m.test(projectAfter.split(/\n\s*\[/)[0] || '')
     && /^model_reasoning_effort\s*=\s*"medium"$/m.test(projectAfter.split(/\n\s*\[/)[0] || '')
     && !/^model\s*=/m.test(homeTopLevel)
     && !/^model_reasoning_effort\s*=/m.test(homeTopLevel)
-    && !/^model_provider\s*=/m.test(homeTopLevel)
+    && /^model_provider\s*=\s*"codex-lb"$/m.test(homeTopLevel)
     && /model_provider\s*=\s*"codex-lb"/.test(projectAfter)
     && /^service_tier\s*=\s*"fast"$/m.test(homeTopLevel)
     && /fast_mode = false/.test(homeAfter)

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "sneakoscope",
   "displayName": "ㅅㅋㅅ",
-  "version": "6.7.0",
+  "version": "7.0.0",
   "description": "Proof-first Codex CLI and ChatGPT Desktop orchestration for AI coding agents, release verification, and macOS menu bar control.",
   "type": "module",
   "homepage": "https://github.com/mandarange/Sneakoscope-Codex#readme",