smol-symphony 0.1.0 → 0.2.0

package/dist/agent/vm-process-registry.js

@@ -0,0 +1,79 @@
+// VmProcessRegistry — tracks the backing host (qemu) process of every live
+// Gondolin VM the orchestrator created, so a forced shutdown can SIGKILL them
+// before `process.exit` (issue 152).
+//
+// WHY this exists. Symphony creates VMs *in-process* (`VM.create` runs in the
+// orchestrator), so each qemu instance is a DIRECT CHILD of the symphony
+// process. On `process.exit` those children are reparented to init and survive
+// as orphaned `qemu-system-x86_64`. The Gondolin session registry can't help
+// reap them on the forced path: it records the *creating* process's pid
+// (symphony's own — see session-registry.js `pid: process.pid`), so a
+// session-pid reaper either skips them (self-pid guard) or, worse, would target
+// the orchestrator. The only reliable handle on the backing qemu is each VM's
+// `getHostPid()` (the qemu `child.pid`), which is what this registry signals.
+//
+// Adapter-layer module: no domain imports. The minimal `KillableVm` shape is
+// satisfied structurally by Gondolin's `VM`, so this stays free of the heavy
+// Gondolin import and is unit-testable in isolation.
+export class VmProcessRegistry {
+    live = new Set();
+    kill;
+    selfPid;
+    constructor(opts = {}) {
+        this.kill = opts.kill ?? ((pid, signal) => process.kill(pid, signal));
+        this.selfPid = opts.selfPid ?? process.pid;
+    }
+    /**
+     * Register a live VM. Returns a deregister callback to invoke after a clean
+     * `close()` so the set stays bounded across many dispatches. Correctness does
+     * NOT depend on deregistration: once a VM's runner exits, `getHostPid()`
+     * returns null and {@link killAll} skips it, so a leaked entry can never
+     * signal a (possibly pid-reused) dead process.
+     */
+    track(vm) {
+        this.live.add(vm);
+        return () => {
+            this.live.delete(vm);
+        };
+    }
+    /**
+     * SIGKILL the backing host process of every tracked VM that still has a live
+     * runner pid. Synchronous and bounded (one signal per tracked VM, no IO), so
+     * the forced-shutdown path can call it and `process.exit` immediately without
+     * risking a hang. Best-effort: a VM with no live runner (`getHostPid → null`)
+     * is skipped, and ESRCH / any other signal failure is swallowed — a stuck pid
+     * must not wedge the forced exit. Returns the number of host pids targeted.
+     */
+    killAll() {
+        const pids = safeKillTargets([...this.live].map((vm) => vm.getHostPid()), this.selfPid);
+        for (const pid of pids) {
+            try {
+                this.kill(pid, 'SIGKILL');
+            }
+            catch {
+                // ESRCH (already gone) / EPERM / etc. — best-effort on the way out.
+            }
+        }
+        return pids.length;
+    }
+}
+/**
+ * Pure: reduce candidate VM host pids (some unknown/null) to the distinct, safe
+ * set to SIGKILL — positive safe integers, never the caller's own pid (which
+ * `process.kill` would aim at the orchestrator) and never `<= 0` (which would
+ * signal a whole process group). Exported for direct testing.
+ */
+export function safeKillTargets(hostPids, selfPid) {
+    const out = new Set();
+    for (const pid of hostPids) {
+        if (pid === null || pid === undefined)
+            continue;
+        if (!Number.isSafeInteger(pid) || pid <= 0)
+            continue;
+        if (pid === selfPid)
+            continue;
+        out.add(pid);
+    }
+    return [...out];
+}
+//# sourceMappingURL=vm-process-registry.js.map

package/dist/agent/vm-process-registry.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"vm-process-registry.js","sourceRoot":"","sources":["../../src/agent/vm-process-registry.ts"],"names":[],"mappings":"AAAA,2EAA2E;AAC3E,8EAA8E;AAC9E,qCAAqC;AACrC,EAAE;AACF,8EAA8E;AAC9E,yEAAyE;AACzE,+EAA+E;AAC/E,6EAA6E;AAC7E,wEAAwE;AACxE,sEAAsE;AACtE,gFAAgF;AAChF,8EAA8E;AAC9E,8EAA8E;AAC9E,EAAE;AACF,6EAA6E;AAC7E,6EAA6E;AAC7E,qDAAqD;AAmBrD,MAAM,OAAO,iBAAiB;IACX,IAAI,GAAG,IAAI,GAAG,EAAc,CAAC;IAC7B,IAAI,CAAoD;IACxD,OAAO,CAAS;IAEjC,YAAY,OAAiC,EAAE;QAC7C,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC,IAAI,IAAI,CAAC,CAAC,GAAG,EAAE,MAAM,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC,CAAC;QACtE,IAAI,CAAC,OAAO,GAAG,IAAI,CAAC,OAAO,IAAI,OAAO,CAAC,GAAG,CAAC;IAC7C,CAAC;IAED;;;;;;OAMG;IACH,KAAK,CAAC,EAAc;QAClB,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,GAAG,EAAE;YACV,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QACvB,CAAC,CAAC;IACJ,CAAC;IAED;;;;;;;OAOG;IACH,OAAO;QACL,MAAM,IAAI,GAAG,eAAe,CAAC,CAAC,GAAG,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,EAAE,CAAC,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;QACxF,KAAK,MAAM,GAAG,IAAI,IAAI,EAAE,CAAC;YACvB,IAAI,CAAC;gBACH,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;YAC5B,CAAC;YAAC,MAAM,CAAC;gBACP,oEAAoE;YACtE,CAAC;QACH,CAAC;QACD,OAAO,IAAI,CAAC,MAAM,CAAC;IACrB,CAAC;CACF;AAED;;;;;GAKG;AACH,MAAM,UAAU,eAAe,CAC7B,QAA0C,EAC1C,OAAe;IAEf,MAAM,GAAG,GAAG,IAAI,GAAG,EAAU,CAAC;IAC9B,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC3B,IAAI,GAAG,KAAK,IAAI,IAAI,GAAG,KAAK,SAAS;YAAE,SAAS;QAChD,IAAI,CAAC,MAAM,CAAC,aAAa,CAAC,GAAG,CAAC,IAAI,GAAG,IAAI,CAAC;YAAE,SAAS;QACrD,IAAI,GAAG,KAAK,OAAO;YAAE,SAAS;QAC9B,GAAG,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;IACf,CAAC;IACD,OAAO,CAAC,GAAG,GAAG,CAAC,CAAC;AAClB,CAAC"}

package/dist/bin/cli-args.js

@@ -0,0 +1,105 @@
+// CLI argument parsing for the `symphony` binary. Lives in its own module so
+// tests can import `parseCli` without triggering the `main()` side effects of
+// `src/bin/symphony.ts` (HTTP/ACP listeners, tracker init, etc.) at import
+// time.
+import path from 'node:path';
+import process from 'node:process';
+export function parseCli(argv) {
+    // Detect subcommands. `reconcile` and `rerun` share the parsed-args
+    // skeleton with the default `serve` mode; the subcommand is what differs
+    // at the action layer (main() dispatches accordingly). Preserve the
+    // subcommand verbatim in the return value — collapsing `reconcile` back to
+    // `serve` would let the missing-workflow scaffold prompt fire on a
+    // `symphony reconcile` invocation, which has nothing to scaffold against.
+    let subcommand = 'serve';
+    let rest = argv;
+    if (argv[0] === 'reconcile') {
+        subcommand = 'reconcile';
+        rest = argv.slice(1);
+    }
+    else if (argv[0] === 'rerun') {
+        subcommand = 'rerun';
+        rest = argv.slice(1);
+    }
+    let workflow = null;
+    let port = null;
+    let reconcileForce = false;
+    let rerunCheck = null;
+    let verbose = false;
+    for (let i = 0; i < rest.length; i++) {
+        const a = rest[i];
+        if (a === '--port' || a === '-p') {
+            const v = rest[++i];
+            if (!v) {
+                process.stderr.write(`error: --port requires a value\n`);
+                process.exit(2);
+            }
+            const n = parseInt(v, 10);
+            if (!Number.isFinite(n) || n < 0) {
+                process.stderr.write(`error: invalid --port value: ${v}\n`);
+                process.exit(2);
+            }
+            port = n;
+        }
+        else if (a.startsWith('--port=')) {
+            const n = parseInt(a.slice('--port='.length), 10);
+            if (!Number.isFinite(n) || n < 0) {
+                process.stderr.write(`error: invalid --port value: ${a}\n`);
+                process.exit(2);
+            }
+            port = n;
+        }
+        else if (subcommand === 'reconcile' && a === '--force') {
+            reconcileForce = true;
+        }
+        else if (a === '--reconcile-force') {
+            // Top-level alias for `reconcile --force`. Kept so existing invocations and
+            // process-manager unit files don't need rewriting; the new canonical shape is
+            // `symphony reconcile --force [path]`.
+            reconcileForce = true;
+        }
+        else if (subcommand === 'rerun' && (a === '--check' || a === '-c')) {
+            const v = rest[++i];
+            if (!v) {
+                process.stderr.write(`error: --check requires a value\n`);
+                process.exit(2);
+            }
+            rerunCheck = v;
+        }
+        else if (subcommand === 'rerun' && a.startsWith('--check=')) {
+            rerunCheck = a.slice('--check='.length);
+        }
+        else if (a === '--verbose' || a === '-v' || a === '--foreground') {
+            verbose = true;
+        }
+        else if (a === '-h' || a === '--help') {
+            process.stdout.write(`symphony [path-to-WORKFLOW.md] [--port PORT] [--reconcile-force] [--verbose]\n` +
+                `symphony reconcile [path-to-WORKFLOW.md] [--force] [--port PORT]\n` +
+                `symphony rerun --check=<name> [path-to-WORKFLOW.md]\n\n` +
+                `If path is omitted, ./WORKFLOW.md is used.\n` +
+                `\`reconcile --force\` (or the alias \`--reconcile-force\`) requests an\n` +
+                `immediate reconcile pass (VM / workspace / PR janitors) at startup.\n` +
+                `\`rerun --check=<name>\` invalidates the named run_in_vm action's content-hash\n` +
+                `cache entry so the next dispatch into its state re-executes it.\n` +
+                `\`--verbose\` (alias \`--foreground\`, \`-v\`) mirrors structured logs to the\n` +
+                `console; by default they go to the log file only so the console stays clean.\n`);
+            process.exit(0);
+        }
+        else if (!workflow) {
+            workflow = a;
+        }
+        else {
+            process.stderr.write(`error: unexpected argument: ${a}\n`);
+            process.exit(2);
+        }
+    }
+    return {
+        subcommand,
+        workflow: workflow ?? path.resolve(process.cwd(), 'WORKFLOW.md'),
+        port,
+        reconcileForce,
+        rerunCheck,
+        verbose,
+    };
+}
+//# sourceMappingURL=cli-args.js.map

package/dist/bin/cli-args.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"cli-args.js","sourceRoot":"","sources":["../../src/bin/cli-args.ts"],"names":[],"mappings":"AAAA,6EAA6E;AAC7E,8EAA8E;AAC9E,2EAA2E;AAC3E,QAAQ;AAER,OAAO,IAAI,MAAM,WAAW,CAAC;AAC7B,OAAO,OAAO,MAAM,cAAc,CAAC;AAenC,MAAM,UAAU,QAAQ,CAAC,IAAc;IACrC,oEAAoE;IACpE,yEAAyE;IACzE,oEAAoE;IACpE,2EAA2E;IAC3E,mEAAmE;IACnE,0EAA0E;IAC1E,IAAI,UAAU,GAAoC,OAAO,CAAC;IAC1D,IAAI,IAAI,GAAG,IAAI,CAAC;IAChB,IAAI,IAAI,CAAC,CAAC,CAAC,KAAK,WAAW,EAAE,CAAC;QAC5B,UAAU,GAAG,WAAW,CAAC;QACzB,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACvB,CAAC;SAAM,IAAI,IAAI,CAAC,CAAC,CAAC,KAAK,OAAO,EAAE,CAAC;QAC/B,UAAU,GAAG,OAAO,CAAC;QACrB,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACvB,CAAC;IACD,IAAI,QAAQ,GAAkB,IAAI,CAAC;IACnC,IAAI,IAAI,GAAkB,IAAI,CAAC;IAC/B,IAAI,cAAc,GAAG,KAAK,CAAC;IAC3B,IAAI,UAAU,GAAkB,IAAI,CAAC;IACrC,IAAI,OAAO,GAAG,KAAK,CAAC;IACpB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACrC,MAAM,CAAC,GAAG,IAAI,CAAC,CAAC,CAAE,CAAC;QACnB,IAAI,CAAC,KAAK,QAAQ,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;YACjC,MAAM,CAAC,GAAG,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC;YACpB,IAAI,CAAC,CAAC,EAAE,CAAC;gBACP,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,kCAAkC,CAAC,CAAC;gBACzD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;YAClB,CAAC;YACD,MAAM,CAAC,GAAG,QAAQ,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAC1B,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;gBACjC,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,gCAAgC,CAAC,IAAI,CAAC,CAAC;gBAC5D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;YAClB,CAAC;YACD,IAAI,GAAG,CAAC,CAAC;QACX,CAAC;aAAM,IAAI,CAAC,CAAC,UAAU,CAAC,SAAS,CAAC,EAAE,CAAC;YACnC,MAAM,CAAC,GAAG,QAAQ,CAAC,CAAC,CAAC,KAAK,CAAC,SAAS,CAAC,MAAM,CAAC,EAAE,EAAE,CAAC,CAAC;YAClD,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;gBACjC,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,gCAAgC,CAAC,IAAI,CAAC,CAAC;gBAC5D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;YAClB,CAAC;YACD,IAAI,GAAG,CAAC,CAAC;QACX,CAAC;aAAM,IAAI,UAAU,KAAK,WAAW,IAAI,CAAC,KAAK,SAAS,EAAE,CAAC;YACzD,cAAc,GAAG,IAAI,CAAC;QACxB,CAAC;aAAM,IAAI,CAAC,KAAK,mBAAmB,EAAE,CAAC;YACrC,4EAA4E;YAC5E,8EAA8E;YAC9E,uCAAuC;YACvC,cAAc,GAAG,IAAI,CAAC;QACxB,CAAC;aAAM,IAAI,UAAU,KAAK,OAAO,IAAI,CAAC,CAAC,KAAK,SAAS,IAAI,CAAC,KAAK,IAAI,CAAC,EAAE,CAAC;YACrE,MAAM,CAAC,GAAG,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC;YACpB,IAAI,CAAC,CAAC,EAAE,CAAC;gBACP,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,mCAAmC,CAAC,CAAC;gBAC1D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;YAClB,CAAC;YACD,UAAU,GAAG,CAAC,CAAC;QACjB,CAAC;aAAM,IAAI,UAAU,KAAK,OAAO,IAAI,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,EAAE,CAAC;YAC9D,UAAU,GAAG,CAAC,CAAC,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;QAC1C,CAAC;aAAM,IAAI,CAAC,KAAK,WAAW,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,cAAc,EAAE,CAAC;YACnE,OAAO,GAAG,IAAI,CAAC;QACjB,CAAC;aAAM,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,QAAQ,EAAE,CAAC;YACxC,OAAO,CAAC,MAAM,CAAC,KAAK,CAClB,gFAAgF;gBAC9E,oEAAoE;gBACpE,yDAAyD;gBACzD,8CAA8C;gBAC9C,0EAA0E;gBAC1E,uEAAuE;gBACvE,kFAAkF;gBAClF,mEAAmE;gBACnE,iFAAiF;gBACjF,gFAAgF,CACnF,CAAC;YACF,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAClB,CAAC;aAAM,IAAI,CAAC,QAAQ,EAAE,CAAC;YACrB,QAAQ,GAAG,CAAC,CAAC;QACf,CAAC;aAAM,CAAC;YACN,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,+BAA+B,CAAC,IAAI,CAAC,CAAC;YAC3D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAClB,CAAC;IACH,CAAC;IACD,OAAO;QACL,UAAU;QACV,QAAQ,EAAE,QAAQ,IAAI,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,aAAa,CAAC;QAChE,IAAI;QACJ,cAAc;QACd,UAAU;QACV,OAAO;KACR,CAAC;AACJ,CAAC"}