smartrte-core 1.0.0-beta.6 → 1.0.0-beta.8

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 1.0.0-beta.8
+
+- Fix Blockquote (and unwrap) throwing an uncaught error ("replaceNode before payload does not match document node.") and applying nothing, for a selection spanning a list item's own text and a nested sub-list item's text — two selected blocks resolving to two different, nested "list" ancestors were treated as independent (and mutually conflicting) wrap targets instead of recognizing the inner one is already covered by the outer one. Also fixed the identical latent issue for unwrapping nested blockquotes (the schema allows blockquote nesting), even though no live report had surfaced it yet. See `docs/bugs/blockquote-crashes-on-selection-spanning-outer-and-nested-list.md`.
+
+## 1.0.0-beta.7
+
+- Fix copy, cut, and native drag throwing an uncaught error ("Clipboard copy is clamped to one structural parent.") for any selection whose two endpoints weren't immediate siblings — e.g. starting in a plain paragraph and dragging into a nested list item, or spanning two list items at different nesting depths. This was not an exotic shape: any selection reaching into a list, table, or blockquote from outside it hit this, and the failure was a silent no-op (nothing copied) with a console error, not a graceful fallback. See `docs/bugs/clipboard-copy-cut-throws-across-differently-nested-endpoints.md`.
+
 ## 1.0.0-beta.6
 
 - Fix pasting a long, list-free document (many short paragraphs, no images) being slow enough to look broken — the Office/Google Docs list normalizers recursed into every paragraph hunting for nested lists a `<p>` can never structurally contain. Pasting a few thousand blocks now completes in well under a second instead of multiple seconds to tens of seconds. See `docs/bugs/clipboard-paste-slow-on-large-list-free-documents.md` for the full investigation, including a known remaining limitation for very large (10,000+ block) pastes.

package/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2025 Smart RTE Contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/README.md

@@ -1,28 +1,65 @@
-# Smart RTE Core
+# smartrte-core
 
-Framework-agnostic document model, selection, transaction, history, and
-normalization primitives. This package is not yet wired into the published
-React editor; it establishes the compatibility-safe migration boundary.
+[![npm version](https://img.shields.io/npm/v/smartrte-core.svg)](https://www.npmjs.com/package/smartrte-core)
+[![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](https://opensource.org/licenses/MIT)
 
-## Foundation contract
+Framework-agnostic document model, selection, transaction, and editing primitives that power [`smartrte-react`](https://www.npmjs.com/package/smartrte-react). Everything here is plain TypeScript with no DOM/React dependency in its core data structures — schema, operations, and history all operate on a plain JSON document tree.
 
-The frozen Phase 1/C0 kernel is available from the dedicated subpath:
+**If you're building a React app, install `smartrte-react` instead** — it depends on this package and re-exports everything you're likely to need. Install `smartrte-core` directly only if you're building a custom editing surface (a different UI framework, a headless document pipeline, a server-side format converter) on top of the same document model.
+
+## Install
+
+```bash
+npm install smartrte-core
+```
+
+## What's in here
 
 ```ts
 import {
   createFoundationEditor,
   foundationSchema,
-  resolveScope,
-  type ResolvedPos,
-  type SmartTransaction,
+  createPluginRegistry,
+  builtInPlugins,
 } from "smartrte-core/foundation";
 ```
 
-The package root remains the compatibility API for the current React adapter.
-New kernel and Phase 2 resolver work must use `smartrte-core/foundation`; do not
-extend the legacy raw-path contracts. `pnpm run lint:foundation-boundary`
-enforces that boundary. Root promotion is an explicit Phase 3 list-migration
-exit criterion. See `docs/FOUNDATION_CONTRACT.md` in the repository for the
-locked decisions and `docs/SEMANTIC_SELECTION_CONTRACT.md` for Phase 2.
-The persistent apply, incremental index, renderer, and browser-input contracts
-are recorded in `docs/CANONICAL_EDITING_SURFACE.md`.
+- **Document model & schema** (`types`, `schema`, `identity`) — a plain JSON tree of typed nodes (paragraph, heading, list, table, image, formula, ...), each with a stable id that survives edits.
+- **Editing engine** (`editor`, `transactions`, `operations`, `history`) — `createFoundationEditor` builds a stateful editor: dispatch a transaction, get back an updated document plus mapped selection, with full undo/redo.
+- **Selection & scope resolution** (`scope/`) — resolves "what does the current selection actually touch" (a text range, a set of list items, a table-cell rectangle, a mix) so commands can act on the right thing regardless of how deeply nested it is.
+- **Browser input surface** (`surface/`) — the `beforeinput`/paste/cut/drop/composition handling layer a real contentEditable-backed UI wires up to; this is what `smartrte-react` builds its editing surface on.
+- **Format adapters** (`formats/`) — HTML, Markdown, DOCX (via `mammoth`/`@xmldom`), and PDF (`pdfjs-dist`) import/export, each declaring an explicit fidelity contract (`builtInFormatFidelity`) for exactly what's lossless vs. lossy per format/feature pair.
+- **Diff, versioning, comments, suggestions, plugin system** (`diff/`, `versioning/`, `comments/`, `suggestions/`, `plugin/`) — the primitives `smartrte-react`'s version history, comment threads, and track-changes UI are built on. A `PluginRegistry` (`createPluginRegistry`, `builtInPlugins`) is how new commands, keyboard shortcuts, toolbar contributions, and renderer behavior are added — see [`docs/PLUGIN_ARCHITECTURE.md`](https://github.com/ayush1852017/smart-rte/blob/master/docs/PLUGIN_ARCHITECTURE.md) in the repository.
+- **Collab contract** (`collab/`) — the operation-transform machinery (`mapOperation`) a real-time transport would rebase concurrent edits through. A contract for hosts building multi-writer collaboration against; no transport implementation ships here.
+
+## Subpath exports
+
+```json
+{
+  ".": "compatibility root (legacy pre-foundation API)",
+  "./foundation": "the current, actively-developed API - use this",
+  "./legacy": "retired raw-path contracts, kept only for migration"
+}
+```
+
+New code should import from `smartrte-core/foundation` exclusively. The package root is a compatibility surface for older integrations; it is not where new capability lands.
+
+## Security
+
+Format importers (HTML, DOCX, PDF) sanitize what they parse (DOMPurify for HTML), but this package holds no storage credentials and performs no network I/O itself — persistence, uploads, and real-time transport are all host-owned boundaries (see `smartrte-react`'s `MediaProvider`/`VersionProvider`/`CommentProvider`/`SuggestionProvider`/`CollabTransport`).
+
+## Development
+
+This package lives in a pnpm workspace monorepo alongside `smartrte-react`.
+
+```bash
+git clone https://github.com/ayush1852017/smart-rte.git
+cd smart-rte
+pnpm install
+pnpm --filter smartrte-core build
+pnpm --filter smartrte-core test
+```
+
+## License
+
+MIT — see [LICENSE](https://github.com/ayush1852017/smart-rte/blob/master/LICENSE).

package/dist/foundation/block/commands.js

@@ -29,6 +29,31 @@ const ancestorWithRole = (nodeId, role, ctx) => {
     }
     return null;
 };
+/**
+ * Two different selected blocks can resolve to two different target
+ * ancestors (both matching `role`) where one target is itself nested inside
+ * the other - e.g. a selection spanning a top-level list item and a
+ * sub-item of its own nested list has one selected block whose nearest
+ * "list" ancestor is the outer list, and another whose nearest "list"
+ * ancestor is the inner one. Both are real, valid `role` ancestors, but
+ * treating them as two independent wrap/unwrap targets is wrong: the outer
+ * target's own subtree already contains the inner one, so replacing both
+ * separately means the second operation's `before` snapshot (captured
+ * against the pre-edit document) no longer matches the document by the time
+ * it runs, since the first operation already mutated a node inside it -
+ * `applyOperations` throws "replaceNode before payload does not match
+ * document node." Kept only the outermost target per such chain - wrapping/
+ * unwrapping it already covers everything nested inside it.
+ */
+const dropNestedTargets = (targets, ctx) => {
+    const idsToDrop = [];
+    targets.forEach((_target, id) => {
+        const resolved = ctx.positions.positionOf(id);
+        if (resolved?.ancestors.some((ancestor) => ancestor.id !== id && targets.has(ancestor.id)))
+            idsToDrop.push(id);
+    });
+    idsToDrop.forEach((id) => targets.delete(id));
+};
 const ancestorTargets = (scope, role, ctx) => {
     const targets = new Map();
     selectedBlockIds(scope).forEach((nodeId) => {
@@ -37,6 +62,7 @@ const ancestorTargets = (scope, role, ctx) => {
             return;
         targets.set(ancestor.id, locate(ancestor.id, ctx));
     });
+    dropNestedTargets(targets, ctx);
     return [...targets.values()].sort((left, right) => right.pos.path.length - left.pos.path.length || right.pos.offset - left.pos.offset);
 };
 const typeAttrs = (node, type, attrs) => {
@@ -145,6 +171,7 @@ export const unwrapBlocks = (_document, scope, params, ctx) => {
             return;
         wrappers.set(target.id, locate(target.id, ctx));
     });
+    dropNestedTargets(wrappers, ctx);
     return [...wrappers.values()].sort((left, right) => right.pos.path.length - left.pos.path.length || right.pos.offset - left.pos.offset).flatMap(({ node, pos }) => {
         if (node.type !== wrapperType)
             return [];

package/dist/foundation/clipboard/transfer.js

@@ -1,6 +1,12 @@
 import { isTextNode } from "../identity.js";
 import { comparePos, nodeAtPath } from "../positions.js";
 const samePath = (left, right) => left.length === right.length && left.every((part, index) => part === right[index]);
+const commonPrefixLength = (left, right) => {
+    let index = 0;
+    while (index < left.length && index < right.length && left[index] === right[index])
+        index += 1;
+    return index;
+};
 const size = (node) => isTextNode(node) ? node.text.length : 1;
 const split = (children, offset) => {
     const before = [];
@@ -31,6 +37,42 @@ const element = (document, pos) => {
         throw new Error("Clipboard selection owner is invalid.");
     return node;
 };
+/**
+ * `node`'s content, keeping only what lies at-or-after (path, offset) within it -
+ * fully-included later siblings at every level, and a recursively-trimmed branch
+ * for the one that actually contains the position. Used for the tail (or "from")
+ * endpoint of a selection that crosses into a different structural ancestor than
+ * its other endpoint (e.g. from a plain paragraph into a nested list item) - a
+ * selection shape that isn't naturally isTextNode/same-parent, but is still a
+ * perfectly ordinary drag-selection a user can make.
+ */
+const afterSlice = (node, path, offset) => {
+    const children = node.children || [];
+    if (path.length === 0) {
+        const [, tail] = split(children, offset);
+        return { ...node, children: tail };
+    }
+    const index = path[0];
+    const child = children[index];
+    if (!child || isTextNode(child))
+        throw new Error("Clipboard selection path is malformed.");
+    const rest = children.slice(index + 1).map((sibling) => structuredClone(sibling));
+    return { ...node, children: [afterSlice(child, path.slice(1), offset), ...rest] };
+};
+/** Mirror of {@link afterSlice}: keeps only what lies strictly before (path, offset). */
+const beforeSlice = (node, path, offset) => {
+    const children = node.children || [];
+    if (path.length === 0) {
+        const [before] = split(children, offset);
+        return { ...node, children: before };
+    }
+    const index = path[0];
+    const child = children[index];
+    if (!child || isTextNode(child))
+        throw new Error("Clipboard selection path is malformed.");
+    const rest = children.slice(0, index).map((sibling) => structuredClone(sibling));
+    return { ...node, children: [...rest, beforeSlice(child, path.slice(1), offset)] };
+};
 export const sliceClipboardSelection = (document, selection) => {
     const selected = range(selection);
     if (selection.type === "node" || selection.type === "cell") {
@@ -45,24 +87,27 @@ export const sliceClipboardSelection = (document, selection) => {
         const [content] = split(tail, selected.to.offset - selected.from.offset);
         return { type: "doc", id: document.id, children: [{ ...fromOwner, children: content }] };
     }
-    const parentPath = selected.from.path.slice(0, -1);
-    if (!samePath(parentPath, selected.to.path.slice(0, -1)))
-        throw new Error("Clipboard copy is clamped to one structural parent.");
-    const parent = nodeAtPath(document, parentPath);
-    const toOwner = element(document, selected.to);
-    if (!parent || isTextNode(parent) || !parent.children)
-        throw new Error("Clipboard selection parent is invalid.");
-    const fromIndex = selected.from.path[selected.from.path.length - 1];
-    const toIndex = selected.to.path[selected.to.path.length - 1];
-    const [, first] = split(fromOwner.children || [], selected.from.offset);
-    const [last] = split(toOwner.children || [], selected.to.offset);
+    // The two endpoints don't share an immediate parent - they may still share a
+    // deeper common ancestor (e.g. one endpoint is a plain paragraph and the other
+    // is nested inside a list item or table cell several levels down, an entirely
+    // ordinary drag-selection). Slice each endpoint's own top-level branch under
+    // that ancestor recursively, rather than assuming a flat sibling relationship.
+    const commonLength = commonPrefixLength(selected.from.path, selected.to.path);
+    const ancestorPath = selected.from.path.slice(0, commonLength);
+    const ancestor = nodeAtPath(document, ancestorPath);
+    if (!ancestor || isTextNode(ancestor) || !ancestor.children)
+        throw new Error("Clipboard selection ancestor is invalid.");
+    const fromIndex = selected.from.path[commonLength];
+    const toIndex = selected.to.path[commonLength];
+    const fromBranch = ancestor.children[fromIndex];
+    const toBranch = ancestor.children[toIndex];
+    if (!fromBranch || !toBranch || isTextNode(fromBranch) || isTextNode(toBranch))
+        throw new Error("Clipboard selection endpoint is invalid.");
+    const first = afterSlice(fromBranch, selected.from.path.slice(commonLength + 1), selected.from.offset);
+    const last = beforeSlice(toBranch, selected.to.path.slice(commonLength + 1), selected.to.offset);
     return {
         type: "doc", id: document.id,
-        children: [
-            { ...fromOwner, children: first },
-            ...parent.children.slice(fromIndex + 1, toIndex).map((node) => structuredClone(node)),
-            { ...toOwner, children: last },
-        ],
+        children: [first, ...ancestor.children.slice(fromIndex + 1, toIndex).map((node) => structuredClone(node)), last],
     };
 };
 export const deleteClipboardSelection = (document, selection, positions) => {
@@ -91,18 +136,45 @@ export const deleteClipboardSelection = (document, selection, positions) => {
         };
     }
     const parentPath = selected.from.path.slice(0, -1);
-    const parent = nodeAtPath(document, parentPath);
     const toOwner = element(document, selected.to);
-    if (!samePath(parentPath, selected.to.path.slice(0, -1)) || !parent || isTextNode(parent) || !parent.children) {
-        throw new Error("Clipboard deletion is clamped to one structural parent.");
+    if (samePath(parentPath, selected.to.path.slice(0, -1))) {
+        const parent = nodeAtPath(document, parentPath);
+        if (!parent || isTextNode(parent) || !parent.children)
+            throw new Error("Clipboard deletion parent is invalid.");
+        const fromIndex = selected.from.path[selected.from.path.length - 1];
+        const toIndex = selected.to.path[selected.to.path.length - 1];
+        const [before] = split(owner.children || [], selected.from.offset);
+        const [, after] = split(toOwner.children || [], selected.to.offset);
+        const operations = [];
+        for (let index = toIndex; index > fromIndex; index -= 1)
+            operations.push({ type: "removeNode", pos: { path: [...parentPath], offset: index }, node: parent.children[index] });
+        operations.push({ type: "replaceNode", pos: ownerPosition.pos, before: owner, after: { ...owner, children: [...before, ...after] } });
+        return { operations, selectionTarget: { ownerId: owner.id, offset: selected.from.offset } };
+    }
+    // Endpoints live under different immediate parents (e.g. cutting from a plain
+    // paragraph into a nested list item) - too structurally different to merge
+    // into one owner the way same-parent siblings do above, but still coherent:
+    // trim each endpoint's own top-level branch down to what's unselected, remove
+    // any branch fully between them, and leave both trimmed branches in place.
+    const commonLength = commonPrefixLength(selected.from.path, selected.to.path);
+    const ancestorPath = selected.from.path.slice(0, commonLength);
+    const ancestor = nodeAtPath(document, ancestorPath);
+    if (!ancestor || isTextNode(ancestor) || !ancestor.children)
+        throw new Error("Clipboard deletion ancestor is invalid.");
+    const fromIndex = selected.from.path[commonLength];
+    const toIndex = selected.to.path[commonLength];
+    const fromBranch = ancestor.children[fromIndex];
+    const toBranch = ancestor.children[toIndex];
+    if (!fromBranch || !toBranch || isTextNode(fromBranch) || isTextNode(toBranch))
+        throw new Error("Clipboard deletion endpoint is invalid.");
+    const trimmedFrom = beforeSlice(fromBranch, selected.from.path.slice(commonLength + 1), selected.from.offset);
+    const trimmedTo = afterSlice(toBranch, selected.to.path.slice(commonLength + 1), selected.to.offset);
+    const operations = [
+        { type: "replaceNode", pos: { path: [...ancestorPath], offset: toIndex }, before: toBranch, after: trimmedTo },
+    ];
+    for (let index = toIndex - 1; index > fromIndex; index -= 1) {
+        operations.push({ type: "removeNode", pos: { path: [...ancestorPath], offset: index }, node: ancestor.children[index] });
     }
-    const fromIndex = selected.from.path[selected.from.path.length - 1];
-    const toIndex = selected.to.path[selected.to.path.length - 1];
-    const [before] = split(owner.children || [], selected.from.offset);
-    const [, after] = split(toOwner.children || [], selected.to.offset);
-    const operations = [];
-    for (let index = toIndex; index > fromIndex; index -= 1)
-        operations.push({ type: "removeNode", pos: { path: [...parentPath], offset: index }, node: parent.children[index] });
-    operations.push({ type: "replaceNode", pos: ownerPosition.pos, before: owner, after: { ...owner, children: [...before, ...after] } });
+    operations.push({ type: "replaceNode", pos: { path: [...ancestorPath], offset: fromIndex }, before: fromBranch, after: trimmedFrom });
     return { operations, selectionTarget: { ownerId: owner.id, offset: selected.from.offset } };
 };

package/dist/foundation/surface/input.js

@@ -601,15 +601,25 @@ export class FoundationInputPipeline {
         if (!event.clipboardData || collapsed(this.editor.selection))
             return;
         event.preventDefault();
-        this.writeTransfer(event.clipboardData, sliceClipboardSelection(this.editor.document, this.editor.selection));
+        try {
+            this.writeTransfer(event.clipboardData, sliceClipboardSelection(this.editor.document, this.editor.selection));
+        }
+        catch {
+            this.unhandled.push("copy-rejected");
+        }
     }
     handleCut(event) {
         if (!event.clipboardData || collapsed(this.editor.selection))
             return;
         event.preventDefault();
-        this.writeTransfer(event.clipboardData, sliceClipboardSelection(this.editor.document, this.editor.selection));
-        const deletion = deleteClipboardSelection(this.editor.document, this.editor.selection, this.editor.positions);
-        this.commitClipboard({ ...deletion, definingAncestorId: null }, "cut");
+        try {
+            this.writeTransfer(event.clipboardData, sliceClipboardSelection(this.editor.document, this.editor.selection));
+            const deletion = deleteClipboardSelection(this.editor.document, this.editor.selection, this.editor.positions);
+            this.commitClipboard({ ...deletion, definingAncestorId: null }, "cut");
+        }
+        catch {
+            this.unhandled.push("cut-rejected");
+        }
     }
     handlePaste(event) {
         event.preventDefault();
@@ -635,10 +645,15 @@ export class FoundationInputPipeline {
     handleDragStart(event) {
         if (!event.dataTransfer || collapsed(this.editor.selection))
             return;
-        const fragment = sliceClipboardSelection(this.editor.document, this.editor.selection);
-        this.internalDrag = { selection: this.editor.selection, fragment };
-        this.writeTransfer(event.dataTransfer, fragment);
-        event.dataTransfer.effectAllowed = "move";
+        try {
+            const fragment = sliceClipboardSelection(this.editor.document, this.editor.selection);
+            this.internalDrag = { selection: this.editor.selection, fragment };
+            this.writeTransfer(event.dataTransfer, fragment);
+            event.dataTransfer.effectAllowed = "move";
+        }
+        catch {
+            this.unhandled.push("dragstart-rejected");
+        }
     }
     handleDrop(event) {
         event.preventDefault();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "smartrte-core",
-  "version": "1.0.0-beta.6",
+  "version": "1.0.0-beta.8",
   "description": "Framework-agnostic document model and editing primitives for Smart RTE",
   "repository": {
     "type": "git",