smartledger-bsv 3.0.1 → 3.0.2

package/utilities/working-signature-demo.js

@@ -0,0 +1,181 @@
+#!/usr/bin/env node
+
+/**
+ * 🔧 BSV Working Script Validation Example
+ * 
+ * Creates a transaction with properly signed inputs that will pass
+ * the BSV script interpreter validation.
+ */
+
+const bsv = require('../index.js');
+const { acceptTransaction } = require('./miner-simulator');
+const { loadConfig } = require('./utxo-manager');
+
+/**
+ * Create a properly signed transaction that should pass script validation
+ */
+function createValidTransaction() {
+  console.log('🔧 Creating Valid BSV Transaction');
+  console.log('═'.repeat(80));
+  
+  try {
+    // Load wallet config
+    const config = loadConfig();
+    const wallet = config.wallet;
+    const utxo = config.utxo;
+    
+    // Create recipient
+    const recipientKey = new bsv.PrivateKey();
+    const recipientAddress = recipientKey.toAddress();
+    
+    console.log('📋 Transaction Details:');
+    console.log(`👛 From: ${wallet.address}`);
+    console.log(`🎯 To: ${recipientAddress}`);
+    console.log(`💰 Amount: 20,000 satoshis`);
+    console.log(`💳 UTXO: ${utxo.txid}:${utxo.vout} (${utxo.satoshis} sats)`);
+    
+    // Create the transaction step by step
+    const tx = new bsv.Transaction();
+    
+    // Add input
+    tx.from({
+      txid: utxo.txid,
+      vout: utxo.vout,
+      scriptPubKey: utxo.script,
+      satoshis: utxo.satoshis
+    });
+    
+    // Add outputs
+    tx.to(recipientAddress, 20000);
+    tx.change(wallet.address);
+    tx.fee(1000);
+    
+    console.log('\n🔐 Signing transaction...');
+    console.log(`Private Key: ${wallet.privateKeyWIF}`);
+    console.log(`Input Script (before): ${tx.inputs[0].script ? tx.inputs[0].script.toHex() : 'empty'}`);
+    
+    // Sign with the correct private key and signature type
+    const privateKey = bsv.PrivateKey.fromWIF(wallet.privateKeyWIF);
+    
+    // Sign with SIGHASH_ALL | SIGHASH_FORKID
+    const sigType = bsv.crypto.Signature.SIGHASH_ALL | bsv.crypto.Signature.SIGHASH_FORKID;
+    tx.sign(privateKey, sigType);
+    
+    console.log(`Input Script (after): ${tx.inputs[0].script.toHex()}`);
+    console.log(`Script ASM: ${tx.inputs[0].script.toASM()}`);
+    
+    console.log('\n✅ Transaction signed successfully');
+    console.log(`🆔 Transaction ID: ${tx.id}`);
+    console.log(`📦 Raw Hex: ${tx.toString()}`);
+    
+    // Verify the signature locally first
+    console.log('\n🔍 Local signature verification:');
+    try {
+      const verified = tx.verify();
+      console.log(`Local verification: ${verified ? '✅ VALID' : '❌ INVALID'}`);
+    } catch (error) {
+      console.log(`Local verification error: ${error.message}`);
+    }
+    
+    return tx;
+    
+  } catch (error) {
+    console.error('❌ Error creating transaction:', error.message);
+    return null;
+  }
+}
+
+/**
+ * Test the transaction with our miner
+ */
+function testWithMiner() {
+  console.log('\n' + '═'.repeat(80));
+  console.log('🎯 Testing with BSV Script Interpreter Miner');
+  console.log('═'.repeat(80));
+  
+  const tx = createValidTransaction();
+  
+  if (!tx) {
+    console.log('❌ Failed to create transaction');
+    return;
+  }
+  
+  // Test with full script validation
+  console.log('\n📡 Sending to miner with full BSV script validation...');
+  const result = acceptTransaction(tx);
+  
+  if (result.accepted) {
+    console.log('\n🎉 SUCCESS! Transaction accepted by BSV script interpreter!');
+    console.log(`✅ TXID: ${result.txid}`);
+  } else {
+    console.log('\n❌ Transaction rejected');
+    console.log('Errors:', result.errors);
+  }
+  
+  return result;
+}
+
+/**
+ * Debug signature creation process
+ */
+function debugSignatureCreation() {
+  console.log('\n' + '═'.repeat(80));
+  console.log('🔍 Debugging Signature Creation');
+  console.log('═'.repeat(80));
+  
+  try {
+    const config = loadConfig();
+    const wallet = config.wallet;
+    const utxo = config.utxo;
+    
+    console.log('🔑 Wallet Info:');
+    console.log(`Address: ${wallet.address}`);
+    console.log(`Private Key: ${wallet.privateKeyWIF}`);
+    console.log(`Public Key: ${wallet.publicKey}`);
+    
+    console.log('\n💰 UTXO Info:');
+    console.log(`TXID: ${utxo.txid}`);
+    console.log(`Vout: ${utxo.vout}`);
+    console.log(`Value: ${utxo.satoshis} satoshis`);
+    console.log(`Script: ${utxo.script}`);
+    
+    // Parse the script
+    const script = bsv.Script.fromHex(utxo.script);
+    console.log(`Script ASM: ${script.toASM()}`);
+    
+    // Verify the address matches
+    const scriptAddress = script.toAddress();
+    console.log(`Script Address: ${scriptAddress}`);
+    console.log(`Wallet Address: ${wallet.address}`);
+    console.log(`Addresses match: ${scriptAddress.toString() === wallet.address ? '✅' : '❌'}`);
+    
+  } catch (error) {
+    console.error('❌ Debug error:', error.message);
+  }
+}
+
+/**
+ * Run all tests
+ */
+function runTests() {
+  debugSignatureCreation();
+  const result = testWithMiner();
+  
+  if (result && result.accepted) {
+    console.log('\n🎯 Perfect! The BSV script interpreter accepted our transaction!');
+  } else {
+    console.log('\n🔧 Need to fix signature creation for script interpreter...');
+  }
+}
+
+// Run tests if called directly
+if (require.main === module) {
+  runTests();
+}
+
+module.exports = {
+  createValidTransaction,
+  testWithMiner,
+  debugSignatureCreation,
+  runTests
+};

package/validation_test.js

@@ -0,0 +1,97 @@
+#!/usr/bin/env node
+
+/**
+ * SmartLedger-BSV Signature Verification Fix Validation
+ * 
+ * This script validates that the signature verification bug has been fixed
+ */
+
+const bsv = require('./index.js');
+
+console.log('🎯 SmartLedger-BSV Signature Verification Fix Validation');
+console.log('=======================================================\n');
+
+// Test with multiple different signatures
+const testCases = [
+  {
+    name: 'Test Case 1: hello world',
+    privateKey: 'L1aW4aubDFB7yfras2S1mN3bqg9nwySY8nkoLmJebSLD5BWv3ENZ',
+    message: 'hello world'
+  },
+  {
+    name: 'Test Case 2: BSV transaction',  
+    privateKey: 'KzsjKq2FVqVuQv2ueHVFuB65A9uEZ6S1E6hrhGCi5LAFS9kBf7Nm',
+    message: 'BSV blockchain transaction data'
+  },
+  {
+    name: 'Test Case 3: empty message',
+    privateKey: 'L4rK1yDtCWekvXuE6oXD9jCYfFNV2cWRpVuPLBcCU2z8TrisoyY1', 
+    message: ''
+  }
+];
+
+let passedTests = 0;
+let totalTests = 0;
+
+for (const testCase of testCases) {
+  console.log(`\n📝 ${testCase.name}:`);
+  console.log('='.repeat(testCase.name.length + 4));
+  
+  try {
+    const privateKey = new bsv.PrivateKey(testCase.privateKey);
+    const publicKey = privateKey.publicKey;
+    const message = Buffer.from(testCase.message, 'utf8');
+    const hash = bsv.crypto.Hash.sha256(message);
+
+    // Create signature
+    const signature = bsv.crypto.ECDSA.sign(hash, privateKey);
+    const derSig = signature.toDER();
+    const canonicalSig = signature.toCanonical();
+    const canonicalDer = canonicalSig.toDER();
+    
+    console.log(`Private Key: ${testCase.privateKey}`);
+    console.log(`Message: "${testCase.message}"`);
+    console.log(`Signature canonical: ${signature.isCanonical()}`);
+    
+    // Test all verification methods
+    const tests = [
+      { name: 'ECDSA.verify(hash, derSig, publicKey)', result: bsv.crypto.ECDSA.verify(hash, derSig, publicKey) },
+      { name: 'ECDSA.verify(hash, canonicalDer, publicKey)', result: bsv.crypto.ECDSA.verify(hash, canonicalDer, publicKey) },
+      { name: 'ECDSA.verify(hash, signature, publicKey)', result: bsv.crypto.ECDSA.verify(hash, signature, publicKey) },
+      { name: 'SmartVerify.smartVerify(hash, derSig, publicKey)', result: bsv.SmartVerify.smartVerify(hash, derSig, publicKey) },
+      { name: 'SmartVerify.smartVerify(hash, canonicalDer, publicKey)', result: bsv.SmartVerify.smartVerify(hash, canonicalDer, publicKey) },
+      { name: 'SmartVerify.isCanonical(derSig)', result: bsv.SmartVerify.isCanonical(derSig) },
+      { name: 'SmartVerify.isCanonical(canonicalDer)', result: bsv.SmartVerify.isCanonical(canonicalDer) }
+    ];
+    
+    for (const test of tests) {
+      totalTests++;
+      const status = test.result ? '✅ PASS' : '❌ FAIL';
+      console.log(`${status} ${test.name}: ${test.result}`);
+      if (test.result) passedTests++;
+    }
+    
+  } catch (error) {
+    console.log(`❌ Test failed with error: ${error.message}`);
+  }
+}
+
+console.log('\n🏆 Summary:');
+console.log('===========');
+console.log(`Passed: ${passedTests}/${totalTests} tests`);
+console.log(`Success rate: ${((passedTests / totalTests) * 100).toFixed(1)}%`);
+
+if (passedTests === totalTests) {
+  console.log('\n🎉 ALL TESTS PASSED! Signature verification is now working correctly.');
+  console.log('✅ The SmartLedger-BSV v3.0.1 signature verification bug has been FIXED!');
+} else {
+  console.log('\n⚠️  Some tests failed. The fix may not be complete.');
+}
+
+console.log('\n📋 Fix Summary:');
+console.log('===============');
+console.log('1. Fixed ECDSA.set() to auto-parse DER buffers to Signature objects');
+console.log('2. Fixed ECDSA.sigError() to handle canonical signature verification properly');
+console.log('3. Fixed SmartVerify.smartVerify() to accept both DER buffers and Signature objects');
+console.log('4. Fixed SmartVerify.isCanonical() to parse DER buffers correctly');
+console.log('5. Enhanced compatibility with both canonical and non-canonical signature inputs');